- 30 Oct, 2019 40 commits
-
-
Alice Boxhall authored
This reverts commit 04962c50. Reason for revert: Unfortunately this seems to have caused a build failure: https://ci.chromium.org/p/chromium/builders/ci/Android%20CFI/6760 Original change's description: > [Android][Signin] Fix bookmark signin promo dismiss tests > > This CL fixes the bookmark signin promo tests when the promo is > dismissed in different scenarios. > > Bug: 789531 > Change-Id: I852e60cb3e56f9db737cb0e03073d36373908f68 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883628 > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Alice Wang <aliceywang@chromium.org> > Auto-Submit: Alice Wang <aliceywang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710784} TBR=twellington@chromium.org,bsazonov@chromium.org,aliceywang@chromium.org Change-Id: I40ad228bbccd446455106c5278392cbde11834b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890456Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#710992}
-
Michael Giuffrida authored
Adds a pref for Supervised Users to determine whether the user is allowed to grant permissions to extensions (and, by extension, whether the user is allowed to install extensions with parental approval). The pref is controlled by Sync settings for the supervised user, ultimately determined by the custodian checking the "Allow sites and apps to ask for permissions" checkbox in the Chrome family dashboard. For now, we will rely on the fact that this checkbox also sets the GeolocationDisabled setting. In the future, the Kids Management server should send a separate setting for extension permissions; that will give us flexibility in the future to break the checkbox into multiple settings. Bug: 1018956 Change-Id: Ifda14018dc7f4a018b493159c6e80b00c2e18b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885216Reviewed-by:
Dan S <danan@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#710991}
-
Xianzhu Wang authored
Now we support physical tests under virtual directories after crrev.com/c/1873504, and no longer need PhysicalTestSuites. The only two PhysicalTestSuites are converted to VirtualTestSuites: - hdr -> virtual/hdr - fast/text -> virtual/text-antialias --enable-direct-write is removed because it's not a valid flag fast/text-autoresize is rebaselined. It was accidentally run with --enable-font-antialiasing because we matched the physical test suite base with startswith. Bug: 1014162 Change-Id: I3319268d8c53abf9cbda31a07794d8d56fd93d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888124 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#710990}
-
Hiroshige Hayashizaki authored
- Move generator-related sections from referrer-policy/README.md to common/security-features/README.md - Add mixed-content/README.md to mention about the generator. - Update some sections, namely how to remove generated tests, etc. Bug: 906850 Change-Id: I03f5483435dd9a59b923303d693d7a2cf4717e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785899 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#710989}
-
Kurt Horimoto authored
This required adding new API to ChromeEarlGrey to fetch the current fullscreen viewport insets. Bug: 987646 Change-Id: I18a897a558074025da81262b17429e09417fe61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889112Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#710988}
-
Patrick Monette authored
The ModuleBlacklistCacheUpdater currently doesn't support a module first loading into a process where injection is allowed then loading into one where it should be blocked. This DCHECK ensures this limitation will be addressed before adding another supported process type. Bug: 662084 Change-Id: Id49f323ee2e9a53bdafcd8f7391495e26d5d8cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879948 Auto-Submit: Patrick Monette <pmonette@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#710987}
-
Andrew Xu authored
This CL accomplishes the following things: (1) Designate the previous/next focusable widget for navigation widget, hotseat widget and status area widget. It prevents the accessibility ring from being trapped in one widget. (2) Ensures that the hotseat is shown when the shelf app icon gets the accessibility focus. (3) Implements the test api to facilitate browser tests to access the shelf widget code. Bug: 1010219 Change-Id: I86dd5cc464430f0a91c8c8a043fcb9fb437d58a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873386Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710986}
-
Jan Wilken Dörrie authored
Value::GetList() will soon stop returning references to the underlying vector. Instead it will return a thin wrapper that only allows iteration and member access. This change prepares //components/sync* for this switch. Bug: 646113 Change-Id: I65cfed19643ddebd1db2dfb159493ab0c039b4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887695 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#710985}
-
Mario Sanchez Prada authored
Convert the remaining bits referencing the mojom::DeviceFactory mojo interface using the old APIs to the new mojo types. Bug: 955171 Change-Id: If7079f11822446582fffafabddfcea737da982c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879459 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#710984}
-
Donn Denman authored
Fixes the positioning of the open-in-tab icon in the new layout. BUG=1016976 Change-Id: I8d632200063ba35076af140321d8e14d9be53a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888400 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#710983}
-
Manas Verma authored
When the user toggles the switch for FIDO authentication, the pref is set to true and the offer dialog is shown. This CL ensures to reset the pref to false if the user declines the offer immediately. Bug: 949269 Change-Id: Idd5424f3972e7785eda672a82fa48753ec98c709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884312Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#710982}
-
Jasper Chapman-Black authored
Thanks to earlier refactoring work, this is super easy! Bug: 1011921 Change-Id: I67e8f68ef0b87092c36e1176b3e8d033e8597db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891133 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#710981}
-
Xiaohan Wang authored
The MockCdmFactory just creates the MockCdm and should not expect what calls will be made on the MockCdm. Hence, replace StrictMock with NiceMock. Test cases that expect calls on MockCdm should get the MockCdm via MockCdmFactory::GetCreatedCdm() and explicitly specify expectations using EXPECT_CALL. This is also consistent with googlemock guidelines [1]: """ Our general recommendation is to use nice mocks (not yet the default) most of the time, use naggy mocks (the current default) when developing or debugging tests, and use strict mocks only as the last resort. """ [1] https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#the-nice-the-strict-and-the-naggy-nicestrictnaggy Bug: 1018854 Test: Update test helper classes. No functionality change. Change-Id: I197f83b221296beccd05b82d2b6ae030381178e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890970 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#710980}
-
dpapad authored
Fixed: 1019798 Change-Id: Idfd2502fa32dfa44ad19b105f5d4bc9a54eb15e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891147Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#710979}
-
Alexander Gaponov authored
Currently, there is no way to set expectetions on SetDelegate function Replaces with MOCK_METHOD1 and moving current function body to ON_CALL().WillByDefault() Bug: internal b/132811177 Change-Id: I58ba51d5a0d3dcead895045009de2821271ccfd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885453Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Steven Zhu <jz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710978}
-
Natalie Chouinard authored
Migrate Supervised User preferences to use PrefServiceBridge generic methods, making use of the prefs.h enums. Replace duplicated Java constants for SupervisedUserURLFilter:: FilteringBehavior C++ enum with a generated Java enum. Bug: 1016957 Change-Id: Id0eb0b19464fb6bc487cb7924b68de6f753fba60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885505 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#710977}
-
Toni Barzic authored
Currently, OnOverviewModeWillStart is called both before and after ending any pending overview exit animations - we should call this only once, after existing animations have ended. Bug: None Change-Id: I87997a79693de59dbafb572d99799a4c3bb42513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891390Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#710976}
-
Hiroshige Hayashizaki authored
This CL moves `test_case_name` and `test_js` into test HTML templates, - To merge code from indiviual projects into common/, and - To prepare for merging multiple scenarios into a single HTML file. This CL keeps generated test files unchanged. Bug: 906850 Change-Id: Iad2dd874492b8824f4c97d76a78b09bf8e2ab94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889476 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#710975}
-
Dana Fried authored
ThumbnailTabHelper now captures the entire contents of a web page (within the bounds of the window) as the raw thumbnail instead of an image specifically cropped for tab hover cards. The image is scaled down to a size that can be used by both the touch- only tabstrip and hover cards, even when it must be cropped. Observers can now specify a size hint for uncompressed images; so that when the image is received by the observer it is pre-cropped appropriately. We use this new system to ensure that tab hover cards are still getting appropriately-sized thumbnails, but the touch-only tabstrip gets the entire compressed image of the webpage, at approximately the original aspect ratio. Bug: 1013646 Change-Id: If63dc7e13f8ddef09e991fcb20f5bef8cacad302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887734 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#710974}
-
Natalie Chouinard authored
Explicitly show soft input keypboard on omnibox focus for search. Fixes an issue with Duet, where the keyboard could be dismissed by the Back or keyboard Action buttons, after which re-clicking the Search button would focus the omnibox, but would not re-open the keyboard by default. Bug: 981682 Change-Id: I1fe14edae4493dd57afe79250ad7fdbc806adcc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869530Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#710973}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b29385ff. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: creis@chromium.org, lukasza@chromium.org: external/wpt/fetch/corb foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I355970b520a49141c9fc9ca40353ad7fb3f1ac5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891071Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710972}
-
Natalie Chouinard authored
Migrate Password Manager preferences to use PrefServiceBridge generic methods, making use of the prefs.h enums. Bug: 1016957 Change-Id: If35d6e14448dff0883bb66e836f67dbe631ae0f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885502Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#710971}
-
Vladimir Levin authored
This patch updates the code to simplify the if condition. This should a no-op change since the override is considered when getting the intrinsic content logical height. This also adds a test that fails if that if condition is not present, and passes otherwise. The test sizes the flex box based on the unstretched size when the item itself is stretched. R=cbiesinger@chromium.org, chrishtr@chromium.org Bug: 1018395 Change-Id: I16ff62d887110a9b93704160e93f2fbcc764c509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891012Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#710970}
-
Connie Wan authored
Includes a refactor of TabDragController and TabDragContext to allow dragging of TabSlotViews and not just Tabs. This required renaming many things, but thankfully not many functionality changes. Notable functionality changes: - in tab_strip: Logic is added in MaybeStartDrag() to handle selecting which views to drag. - in tab_strip: Logic is added in GetInsertionIndexFrom() for finding the right insertion index. - in tab_drag_controller: Logic is added in Attach() for dragging headers into new windows. - in tab_drag_controller: Logic is added in CompleteDrag() to deselect the dragged views. - in tab_drag_controller: Gates are added to prevent calling UpdateGroupForDraggedTabs(). Bug: 1004953 Change-Id: Ia334e5c424f9fbba704160239b19e4ca9f13eb9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866058Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#710969}
-
Josh Nohle authored
See analogous change to the device notifier at crrev/c/1888734/2..3. Bug: 951969 Change-Id: I771130dc97718c24b2ea5292086fd80e89ec45ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890001 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#710968}
-
Henry Jian authored
Previously, new splash webapks were not masking adaptive icon when it was used in splash screen. This CL fixes that. Bug: 977173 Change-Id: I6a38aec93369d6d7fda4fbba38f483c25b9b5960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891138Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Henry Jian <hzjian@google.com> Cr-Commit-Position: refs/heads/master@{#710967}
-
Josh Nohle authored
The Instance ID is the primary identifier for devices using v2 DeviceSync. This ID is not present in v1 DeviceSync, which used the device public key as the primary ID. The device public key is encrypted in v2 DeviceSync and might not be available during multi-device setup. Bug: 951969 Change-Id: I09c1ebd6016d651deabb7eca6356581c3c69c0fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882300 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#710966}
-
Brian Sheedy authored
Causes try-nougat-phone-tester, android-oreo-arm64-dbg, and android-pie-arm64-dbg to trigger on CLs that touch VR files since they run VR and AR tests that aren't handled by the Nexus 5Xs. Change-Id: I52599ba5c85a0066afd1e73f391d529f4ba8a06b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889170 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#710965}
-
Tobias Sargeant authored
If an AIDL file changes (comment and whitespace changes are ignored) then assert that the API version number is incremented by 1. Change-Id: Id7f3a17f9ab2244946d0cf12d7f0af48187172ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879462 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710964}
-
Kevin Bailey authored
We had a complicated test to see where to put the cursor, but it turns out that it was unnecessary, and wrong in one case. This CL restores its behavior. Bug: 1019631 Change-Id: I18ed14d12dc55b3ac63c76eb4ed62e3f5624e8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889999 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#710963}
-
dalyk authored
Bug: 10161646 Change-Id: I66061df5533dc00e8c07e354098f6735f366a3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870492 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#710962}
-
Brian Geffon authored
Adding features for ram_vs_swap_weight and extra_free kernel tunables. BUG=chromium:1019806 TESTED=Validated on an octopus device Change-Id: I681e09ba7cae3deeab69a8833fa068ed09f9eaf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890792Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#710961}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/61cd76748f7c..56981910bb85 git log 61cd76748f7c..56981910bb85 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 rharrison@google.com Rolling 5 dependencies & expectation files (#849) Created with: gclient setdep -r src/third_party/shaderc/src@56981910bb85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I261dd92770ed64850d503a9d5655c9fa7f8f1cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890845Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710960}
-
Yulun Wu authored
This is a reland of f2baca71 Original change's description: > Menu Model: fix bug where menu item title was greyed out because it is disabled. > > The old approach of adding title as a disabled item meant that this CL: > > https://chromium-review.googlesource.com/c/chromium/src/+/1788198 > > causes the menu title to be displayed in grey text instead of solid black text. This CL introduces a new menu type that, while still disabled and non-reactive, be displayed in solid black text. > > Bug: 1006203 > Change-Id: I9fa38132160228ebde5bd43d8db9c2f60d5f001c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841583 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Commit-Queue: Yulun Wu <yulunwu@chromium.org> > Auto-Submit: Yulun Wu <yulunwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707147} Bug: 1006203 Change-Id: I02ac38b96dea074f8e9c3e8c9a019a53db512513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869475 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#710959}
-
John Chen authored
NOTRY=true TBR=crouleau@chromium.org Bug: 1017244 Change-Id: Ib9c806e675cfe6727cf3e78a36af866b0f6bf2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891451Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#710958}
-
Mason Freed authored
Prior to this CL, a site could access the thumb of a range input and apply a 3D transform to it: input::-webkit-slider-thumb { transform: translateZ(20px); } That would previously cause a crash, as the code did not expect such a transform. This should work now. Fixed: 1018774 Change-Id: I8ccbbd532129752dd4e76fde4da064041e32a146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890499Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#710957}
-
Avery Musbach authored
When you are dragging a window to snap in a position for which the divider is not conducive to the window's minimum size, the snap preview shall be adjusted. Test: ash_unittests SplitViewOverviewSession*Test.SnappedWindowBoundsWithMinimumSizeTest/? Bug: 1017464 Change-Id: Iae51058747addd1f994dde62f2baeb123aae3621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880201 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#710956}
-
Michael Spang authored
The default configuration of TestScreen is to create one display and one WindowTreeHost with the same size. X11 is now incompatible with this requirement as of b14e13fd ("Reland "X11 and Ozone: DWTHPlatform handles Show/Hide/Max/Restore/Full""). Several aura tests are only passing currently due to another bug in DisplayList::UpdateDisplay, which prevents X11Window from seeing the current display size and enforcing the constraint. Other tests only work because TestScreen resizes the display to match the WindowTreeHost /after/ X11Window deletes the last row and column. i.e., X11Window tries to adjust the size to not match the display, and then TestScreen re-adjusts the display to match the window. This behavior is not convergent and causes small changes in initialization order to affect the dimensions of test windows. This hack should likely be removed altogether and the bug it's addressing fixed another way, but for now disable it in the test harness because it is blocking other changes such as a fix for the UpdateDisplay bug noted above. Bug: 1019015 Change-Id: I79e830b9c35df3df29dc8af50ac424076682d180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889294 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#710955}
-
Mario Sanchez Prada authored
Convert the remaining bits referencing the video_capture::mojom::Device mojo interface using the old APIs to the new mojo types. Bug: 955171 Change-Id: Ieafd706caa4d9454fc308f10cd109139376253e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879260 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#710954}
-
Toni Barzic authored
Updates how device transitions to home when home button is tapped and when user clicks in empty space in overview grid when kHomerviewGesture feature is enabled. When overview is active, it should use kFadeOutExit transition (instead of slide out) - this also fixes a bug where transform was not cleared on item windows when bounds were updated without animations (which was causing item window misplacement when the grid was updated while minimizing active window before exiting overview). FadeOutWindowsAndMaybeSlideOnExit is updated to take "slide" as an argument instead of deducing it depending on the animation type, as OVERVIEW_ANIMATION_EXIT_TO_HOME_LAUNCHER should slide if and only if using slide out overview exit transition (the animation can also be used by fade out exit). When clicking home with a window active, the top window is minimized using transform to home screen (the same used during drag from shelf), while the rest of the windows are minimized with no animations. To make this easier, WindowTransformToHomeScreenAnimation is moved to a separate file, and is updated to better handle windows whose origin is not in the screen origin (which is useful for transforming top windows in split view). Is split view, the top windows are transformed to home screen as the split view ends. If overview session is active together with split view, the overview session is ended immediately to avoid showing overview just after ending split view (during duration of the exit transition). BUG=1005366 Change-Id: Ic23893866700f5e5580f4445915d815f188e8c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885972 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#710953}
-