- 23 Sep, 2019 10 commits
-
-
Jeonghee Ahn authored
broken links. - ... [Running Web Tests Using the Content Shell](web_tests_in_content_shell.md) - ... [docs/web_tests_linux.md](./web_tests_linux.md). Change-Id: I5dd681d21e2f6e340f0907581d67f1fbfcd647fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817863Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#698808}
-
Alan Cutter authored
This reverts commit bf29e54a. Reason for revert: Broke Deterministic Linux (dbg) bot. https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/11261 Output: Unexpected files with diffs: nacl_test_data/extension_vcache_test/glibc/extension_validation_cache_libs/lib64/libppapi_cpp_lib.so nacl_test_data/glibc/pm_exit_status_test_libs/lib64/libppapi_cpp_lib.so nacl_test_data/glibc/simple_libs/lib64/libppapi_cpp_lib.so nacl_test_data/glibc/sysconf_nprocessors_onln_test_libs/lib64/libppapi_cpp_lib.so ppapi_nacl_tests_libs/lib64/glibc_x64/libppapi_cpp_lib.so Bug: 1006638 Original change's description: > Remove using directives ("using namespace x") from ppapi/. > > Bug: 82078 > Change-Id: I5acb5fde43a747f319709222a6cdbb7a414df070 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816293 > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698766} TBR=pkasting@chromium.org,bbudge@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 82078 Change-Id: I6d28134d3fbabac5e243123201af795692b9d8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817865Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#698807}
-
Julie Jeongeun Kim authored
This CL converts ProxyResolverRequestClient and ProxyResolverFactoryRequestClient from ProxyResolverFactoryMojoTest to new Mojo types. Bug: 955171 Change-Id: If23e54b4c2bdbc0ab43d84de7c5abb4fe268be3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812937 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#698806}
-
Jinsuk Kim authored
This CL replaces NavigationPopup with NavigationSheet for the history popup menu impl triggered by long press on back button. This allows the gesture navigation sheet and navigation popup to have same UI. The only difference between them is that, on long press on back, the sheet fully expands to show all the items. Now NavigationPopup class is used by back/forward button on tablet only. Bug: 999377 Change-Id: Ib68de11f0e5ac5357723ffbd1401c7859393a4ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792687 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#698805}
-
Trent Apted authored
E.g. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/6932 Test times out. Possibly related to recent change in r696987. TBR=yigu@chromium.org Bug: 1006635 Change-Id: I72f0a17f94932e7d197e4a90f99d81769e6299a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818878Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#698804}
-
Trent Apted authored
This reverts commit a42225db. Reason for revert: Test consistently fails on Linux Chromium OS ASan LSan Tests (1) e.g. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/35424 errors like [12262:12262:0922/152157.497151:FATAL:compositor_frame_sink_support.cc(336)] Check failed: result == SubmitResult::ACCEPTED (5 vs. 0) Details in BUG=1006633 Original change's description: > Portals: Add chrome/ browser test for activation > > Bug: 927056 > Change-Id: Ief5a22cf86cd6bdeeae4361e616f66487f589c9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809115 > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698129} TBR=avi@chromium.org,adithyas@chromium.org,lfg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 927056 Change-Id: Ib245b7d25b719d791ef6aeefa044200d90a64d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818877Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#698803}
-
Trent Apted authored
E.g. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/6929 [1756:1756:0922/124740.991289:ERROR:browser_context.cc(300)] Ignoring request for unknown per-browser-context service:multidevice_setup ../../chrome/browser/chromeos/login/session/chrome_session_manager_browsertest.cc:295: Failure Expected equality of these values: expected_brand Which is: "" google_brand::chromeos::GetBrand() Which is: "TEST" Stack trace: [1756:1756:0922/124741.053454:INFO:rlz_tracker.cc(306)] RLZ is disabled [ FAILED ] GuestSessionRlzTest/GuestSessionRlzTest.DeviceIsLocked/0, where GetParam() = false (664 ms) TBR=rogerta@chromium.org Bug: 997360 Change-Id: I020c643d74107e0ee811f829bfea3a8f75400d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817864Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#698802}
-
Trent Apted authored
Consistently failing since e.g. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/29406 Errors like [10182:10182:0919/233523.341151:ERROR:service.cc(373)] Failed to retrieve primary account info. ../../chrome/browser/ui/app_list/chrome_app_list_model_updater_browsertest.cc:82: Failure Value of: oem_app Actual: false Expected: true TBR=dominickn@chromium.org Bug: 1006522 Change-Id: I8c56ccdd0cdf82d671a9a3ef77c3b9641f178271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816255Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#698801}
-
Matt Giuca authored
(In addition to the existing same-origin check in the browser.) Bug: 1001404 Change-Id: Iac497980928da78458472cf3a6953e04b2ea8218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804707 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#698800}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9c9449e7331..4f789591c8f2 Created with: gclient setdep -r src-internal@4f789591c8f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7dc9c1e62d60381e012f420002db5f5430df6f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818120Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698799}
-
- 22 Sep, 2019 27 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8e4e504bae2e..8ab15bbab0fa git log 8e4e504bae2e..8ab15bbab0fa --date=short --no-merges --format='%ad %ae %s' 2019-09-22 vapier@chromium.org lint: fix a few redefined-argument-from-local warnings Created with: gclient setdep -r src/third_party/chromite@8ab15bbab0fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: If65284bfe94fadf764a312c1672dd6c3058d0b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817693Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698798}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic6884b8ca7d1fca2815ef496d97eb469837ac754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817694Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698797}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dfab53cb6dbb..c9c9449e7331 Created with: gclient setdep -r src-internal@c9c9449e7331 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7b8b6cf966abb8787252de100e2f7fe4190e0a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817691Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698796}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8b9de727666c..b4d60b5eda31 git log 8b9de727666c..b4d60b5eda31 --date=short --no-merges --format='%ad %ae %s' 2019-09-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@b4d60b5eda31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: Icf85707ea41635e25855ac05548e2ee26a10a1b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817692Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698795}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/82ae4b4b7d53..7cb60e812f16 git log 82ae4b4b7d53..7cb60e812f16 --date=short --no-merges --format='%ad %ae %s' 2019-09-22 tandrii@chromium.org git-cache: fix bug in prior CL. Created with: gclient setdep -r src/third_party/depot_tools@7cb60e812f16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ide6a67fb8dafdb50bd388d0ab2e0f63ad426de70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817690Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698794}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83de0881aaaa..dfab53cb6dbb Created with: gclient setdep -r src-internal@dfab53cb6dbb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9786f0f8a3971fb159971d3410c1908a3b6a5992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818376Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698793}
-
Elly Fong-Jones authored
In order to fully fix the linked bug, I need to change the color of this icon; doing that on a PNG is considerably painful. As such, this change first switches from using the PNG to using a vector icon. That allows cleaning up some bespoke image rendering code used with the old PNG icon. A followup CL will perform the actual color adjustment; this CL uses the exact colors the old PNG used to avoid unnecessary visual changes. The new Material icon does look slightly different from the old PNG, but that delta (the icon being different) has been approved by UX. TBR=oshima@chromium.org Bug: 957391 Change-Id: I3787b561dbe15bf00977ad54dd57ce183115bbec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815733 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#698792}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7b6b405503c1..8e4e504bae2e git log 7b6b405503c1..8e4e504bae2e --date=short --no-merges --format='%ad %ae %s' 2019-09-22 vapier@chromium.org cros_build_lib: replace PartialCmdMock.CmdResult with cros_build_lib.CommandResult Created with: gclient setdep -r src/third_party/chromite@8e4e504bae2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9276795d51903d9f084b2c94cd87bbd99a1dd3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817347Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698791}
-
David Grogan authored
It should only be definite if the element already had a definite main size or if the container has a definite main size. This is #2 from https://drafts.csswg.org/css-flexbox/#definite-sizes Bug: 845235 Change-Id: I0230080d22ada93ebc8bae09aeda629d87cf5b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797442Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#698790}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1848f3e9638d..8b9de727666c git log 1848f3e9638d..8b9de727666c --date=short --no-merges --format='%ad %ae %s' 2019-09-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@8b9de727666c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: I0eca82fdd5519f3bc6baa9edc3a2bb573facc1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818639Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698789}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2e00c9f853b8..1848f3e9638d git log 2e00c9f853b8..1848f3e9638d --date=short --no-merges --format='%ad %ae %s' 2019-09-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@1848f3e9638d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: I1d56dd2060d9627caf35b1538d04c23f75cd9861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818375Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698788}
-
Raul Tambre authored
Initial conversion performed using '2to3 -f print .'. Imports added and duplicate parentheses removed manually. Manually converted files, comments and inline code that 2to3 missed. Afterwards ran "git cl format --python" and cherry-picked the formatting changes. Fixed a syntax error in check_grd_for_unused_strings.py due to a missing comma (caught by pylint). There are no intended behavioural changes. Bug: 941669 Change-Id: Ie0c67e5e416f386830e95aa2469b18a98b5425a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818477 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#698787}
-
Raul Tambre authored
Initial conversion performed using '2to3 -f print .'. Imports added and duplicate parentheses removed manually. Manually converted files, comments and inline code that 2to3 missed. Afterwards ran "git cl format --python" and cherry-picked the formatting changes. There are no intended behavioural changes. Bug: 941669 Change-Id: I9d8cb5d770a3f68231d0dea664a12a10fb81ce9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814923 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#698786}
-
Henry Jian authored
This CL allows Chrome to request adaptive icons in WebAPK. Also, this CL makes Chrome check if a WebAPK's primary icon is maskable when determining if an update is needed. make chrome choose maskable icon of right size Previously, we prefer an icon with size 48dp when selecting an adaptive launcher icon. However, the adaptive icon design guide states that the size should be 108dp. This CL fix the bug. Bug: 977173 Change-Id: Ia067b2c3266298a2e1f9e0ce02148c30e9ed9cff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794242 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#698785}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/23b8230b5d84..2e00c9f853b8 git log 23b8230b5d84..2e00c9f853b8 --date=short --no-merges --format='%ad %ae %s' 2019-09-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@2e00c9f853b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: I6c2058a0277e874846341e4b87168e5f5f6adccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818597Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698784}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d23e51ff772..83de0881aaaa Created with: gclient setdep -r src-internal@83de0881aaaa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3417241f74ef805275badc7781baa15968a4a9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818577Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698783}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f2a09ddf6c6..4d23e51ff772 Created with: gclient setdep -r src-internal@4d23e51ff772 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I83868f9ef645407681edfc1f27182bbd4f76df6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818457Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698782}
-
Matt Falkenhagen authored
The project is moving toward documentation checked into the repository. This is a verbatim copy of https://www.chromium.org/developers/content-module/content-api Change-Id: I46fdbf8dc2696c3f09494dfda3cbf53eeae592ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815800Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#698781}
-
Callum May authored
This is a follow up to https://crrev.com/c/1789751 that removes the unused testing hooks for the fake WinWebAuthnApi since the fake is now injected via the FidoDiscoveryFactory Change-Id: Iadfc043d0836e7640e75981c4d49e59c2d079c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815880 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#698780}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f85be12f1b2f..7b6b405503c1 git log f85be12f1b2f..7b6b405503c1 --date=short --no-merges --format='%ad %ae %s' 2019-09-22 vapier@chromium.org filetype: avoid str.translate deletion Created with: gclient setdep -r src/third_party/chromite@7b6b405503c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2c758f89f6187cec64a4705b00b39cdf3105d3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818105Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698779}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b98887e6..510fd3c3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iec241c2d5d341565ce8c34313de45e345ed6308d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818246Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698778}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4f0c2ae9e2a8..7f2a09ddf6c6 Created with: gclient setdep -r src-internal@7f2a09ddf6c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ib8ba4d3f8b0cfdf1517d7a6b7f8f774f67004ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817849Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698777}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I1d704c20aa075b8393faed227602059b8321fa4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815955Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698776}
-
Wei-Yin Chen (陳威尹) authored
TBR=gilmanmh@google.com Bug: 979685 Change-Id: Ic516a4d159858e4a6d443dbb742d49a418d7b2a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817687Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#698775}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/383f6cf02d47..82ae4b4b7d53 git log 383f6cf02d47..82ae4b4b7d53 --date=short --no-merges --format='%ad %ae %s' 2019-09-22 tandrii@google.com git-cache: don't limit pack files to 2GiB. Created with: gclient setdep -r src/third_party/depot_tools@82ae4b4b7d53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I9944222e3d80460d1832d36e541682af11ef0bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817683Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698774}
-
Mirko Bonadei authored
RTC_* checks are intended to be used only inside WebRTC, Chromium should use the checks defined by base/logging.h. Bug: webrtc:9419 Change-Id: I98b52b1012c6cac49cc7ccd5bf22e30e471f4492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815125 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#698773}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/12be0fa268c2..4f0c2ae9e2a8 Created with: gclient setdep -r src-internal@4f0c2ae9e2a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ida5024074a2de94fc3f6223090f9de8aaea392e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818117Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698772}
-
- 21 Sep, 2019 3 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e4e5c3a98840..12be0fa268c2 Created with: gclient setdep -r src-internal@12be0fa268c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I86fdd0be12caa9c35eae4f5ee8cd2748df7b36dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818040Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698771}
-
Shuo-Peng Liao authored
V4L2ImageProcessor::TryOutputFormat() does not set input format before trying the given output format. We shall not assume that the validity of output format is unrelated to input format and size. BUG=1004727 TEST=Run VDA unittest on elm as it uses v4l2 VDA + v4l2 IP. Change-Id: I59bf75742d69e829f953f82e09fdfcb82ee2b6e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809125 Commit-Queue: Shuo-Peng Liao <deanliao@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#698770}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c04a8a196df5..e4e5c3a98840 Created with: gclient setdep -r src-internal@e4e5c3a98840 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iebc86a2f78f7d90161a1ef1e267dab5ac694402b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817938Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698769}
-