GitLab

For the default bookmark shortcut icon (document look), we had both
png image and overlay drawing java code for coloring. However, the seperated
logic caused an inconsistency for the Nexus 7.  It is possible to
fix it by simply correcting dimens.xml (https://codereview.chromium.org/15875019/),
However, a better solution would be combining the two seperated logics.
This CL replaces the java drawing code by png images.

Tested on Galaxy Nexus, Nexus 10, Nexus 7, and Motorola Xoom.

BUG=241380

Review URL: https://chromiumcodereview.appspot.com/15992008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204077 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=RectTest.Subtract

Review URL: https://chromiumcodereview.appspot.com/15706011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204076 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204075 0039d316-1c4b-4281-b951-d872f2087c98

1641: ninja: Enable deps mode on non-windows.
1642: revert 1641
1643: Make rule variables to work with generated sources.

BUG=none
TBR=bungeman

Review URL: https://codereview.chromium.org/16374008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204074 0039d316-1c4b-4281-b951-d872f2087c98

We're seeing Activity Log related memory leaks. This patch suppresses the leaks so that the tests can keep running while we investigate.

NOTRY=true
BUG=246825

Review URL: https://chromiumcodereview.appspot.com/16212010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204073 0039d316-1c4b-4281-b951-d872f2087c98

The master is throwing an exception.
BUG=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16123014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE

Review URL: https://chromiumcodereview.appspot.com/16093027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204071 0039d316-1c4b-4281-b951-d872f2087c98

It is disabled by default.

Also disabled D3D11 stats collection for all Vista machines and all machines with DisplayLink installed.

BUG=243125
Review URL: https://codereview.chromium.org/16270006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204070 0039d316-1c4b-4281-b951-d872f2087c98

The hash map is less convenient to use, but it promises much better
expected algorithmic complexity for the most common directory
operations. The indices converted with this patch almost never require
iteration, so it makes much more sense to use a hash_map (ie.
unordered_map) than a regular map.

This change also introduces a new index based on the server-assigned
unique tag. The server-assigned tag is set only on permanent items, so
there won't be many items in this index.

I ran some tests locally to confirm the new code does run faster.  On
certain model association tests I saw a speedup of ~10%.  I doubt we'll
see that much of a speedup in real world scenarios, but it could be a
noticeable improvement on some of our slower platforms.

BUG=238621, 115132, 241813

Review URL: https://chromiumcodereview.appspot.com/16231009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204069 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167037
R=kbr@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/16358011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204068 0039d316-1c4b-4281-b951-d872f2087c98

BUG=55316
TBR=mpcomplete@chromium.org

Review URL: https://codereview.chromium.org/16226004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204067 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245119

Review URL: https://chromiumcodereview.appspot.com/16063008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204066 0039d316-1c4b-4281-b951-d872f2087c98

BUG=234278
R=alecflett@chromium.org,dgrogan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16005006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204065 0039d316-1c4b-4281-b951-d872f2087c98

Previously this settings page assumes that there are multiple
displays, but now this page provides settings for a single display.
Better to focus on the first display rather than the secondary one.

BUG=246587
TEST=manually
R=xiyuan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15993017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204064 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245394
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15969022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204063 0039d316-1c4b-4281-b951-d872f2087c98

> Land Recent QUIC changes.
> 
> Merge internal change: 47341065
> 
> Fix to ensure the version matches before declaring that the public header
> flags exceed the max value. b/9190456
> 
> Merge internal change: 47324563
> 
> Fixing another backup bug (exposed by the last fix) that if we failed to
> write a standalone fin the stream would not be marked as write blocked.
> 
> Merge internal change: 47272116
> 
> Don't add QuicStreams to ActiveSessionList; Instead call DumpSession on
> alive streams via QuicSession.
> 
> Merge internal change: 47226512
> 
> Making the packet sequence number variable length to minimize bytes on the wire.
> 
> Merge internal change: 47220850
> 
> Fixing a bug in quic stream where we'd send rst stream packets for
> successful streams. The fin bit should be sufficient for both good
> request/response pairs and early response pairs.
> 
> Merge internal change: 47086343
> 
> Don't let FEC packets consume congestion window forever. If a FEC packet
> is not acked after a certain time, it is cleared from the congestion
> window. This timeout is higher than normal RTO.
> 
> Merge internal change: 47056082
> 
> Add QuicSession to ActiveSessionList.
> 
> Merge internal change: 47048300
> 
> Fixing a backup/resumption bug in QUIC.
> 
> It's possible to have a full congestion window worth of packets on the wire.
> 
> If we are in this state and a session tries to SendStreamData, the
> QuicPacketGenerator short-circuits without queuing packets because it checks
> to see if the connection CanWrite.
> 
> When we get an ack, we check to see if we have locally queued packets, but
> never call OnCanWrite on the session to clear any streams which write blocked
> without queueing packets.
> 
> Merge internal change: 47000173
> 
> QUIC: wire up the server-nonce parameters to the server config.
> 
> Merge internal change: 46985067
> 
> R=rch@chromium.org
> 
> Review URL: https://codereview.chromium.org/16256017

TBR=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/16374004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204062 0039d316-1c4b-4281-b951-d872f2087c98

SkColorSetA returns the modified value and doesn't change it in place.

R=danakj@chromium.org
BUG=none

Review URL: https://chromiumcodereview.appspot.com/16295025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204061 0039d316-1c4b-4281-b951-d872f2087c98

On some platforms such as Windows, IME APIs require
native window handle. With this patch set, IME API
wrappers are now able to obtain NativeWindow from
TextInputClient.

BUG=246516,246534

Review URL: https://chromiumcodereview.appspot.com/16154016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204060 0039d316-1c4b-4281-b951-d872f2087c98

It is failing on windows.
BUG=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16123012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204059 0039d316-1c4b-4281-b951-d872f2087c98

cc: Set resource->allocated to true within BindImage(). This mimicks the behaviour of BeginSetPixels() and fixes a DCHECK within LockForRead

BUG=175012

Review URL: https://chromiumcodereview.appspot.com/16055013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204058 0039d316-1c4b-4281-b951-d872f2087c98

objects that get passed in (canonically <input> elements apparently) which
recurse infinitely (as opposed to having a self-referential loop).

The previous solution to this problem (r150035) was to disable getters, which
apparently were the main cause, but this is no longer appropriate - we now use
this mechanism for all extension messaging, and this has become a problem (see
bug 246213).

TBR=jamesr@chromium.org, mpcomplete@chromium.org

BUG=246213,139933

Review URL: https://codereview.chromium.org/16295013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204057 0039d316-1c4b-4281-b951-d872f2087c98

This CL sets the user affiliation of enterprise-managed device-local
accounts to USER_AFFILIATION_MANAGED instead of USER_AFFILIATION_NONE.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/15792017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204055 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the AL used Extension objects when notifying the UI of new activity. If an extension were uninstalled in the middle of logging something, the Extension object would be deallocated before the UI tried to use the reference. Since we are replacing the old UI, I am switching to using IDs instead of Extension objects.

[[[ Reverted because it was causing heapcheck failures. Retrying a new version. ]]]

BUG=236395

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203218

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203618

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203950

Review URL: https://chromiumcodereview.appspot.com/15686007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204054 0039d316-1c4b-4281-b951-d872f2087c98

Review bug: http://b/8772053

Review URL: https://chromiumcodereview.appspot.com/14591005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204053 0039d316-1c4b-4281-b951-d872f2087c98

This was previously approved at https://codereview.chromium.org/15875020/

BUG=245318
TBR=cpu

Review URL: https://codereview.chromium.org/16380002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204052 0039d316-1c4b-4281-b951-d872f2087c98

Allowing for NULL damage buffers in low memory situations.

Ran 200 times on bots.

BUG=222618

Review URL: https://chromiumcodereview.appspot.com/13865008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204051 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=sreeram

Review URL: https://codereview.chromium.org/15981004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204050 0039d316-1c4b-4281-b951-d872f2087c98

The pile background color is what the pile gets cleared to to fill
partially rastered pixels.  If the layer is not opaque, clearing to an
opaque color leaves opaque artifacts.

Fix this by adding a function to return a safe color to clear the pile
to or to draw solid color quads from by requiring that this color be
opaque iff the contents of the layer are opaque.

R=danakj@chromium.org
BUG=245624

Review URL: https://chromiumcodereview.appspot.com/15995031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204048 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245011
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/16336017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204047 0039d316-1c4b-4281-b951-d872f2087c98

Merge internal change: 47341065

Fix to ensure the version matches before declaring that the public header
flags exceed the max value. b/9190456

Merge internal change: 47324563

Fixing another backup bug (exposed by the last fix) that if we failed to
write a standalone fin the stream would not be marked as write blocked.

Merge internal change: 47272116

Don't add QuicStreams to ActiveSessionList; Instead call DumpSession on
alive streams via QuicSession.

Merge internal change: 47226512

Making the packet sequence number variable length to minimize bytes on the wire.

Merge internal change: 47220850

Fixing a bug in quic stream where we'd send rst stream packets for
successful streams. The fin bit should be sufficient for both good
request/response pairs and early response pairs.

Merge internal change: 47086343

Don't let FEC packets consume congestion window forever. If a FEC packet
is not acked after a certain time, it is cleared from the congestion
window. This timeout is higher than normal RTO.

Merge internal change: 47056082

Add QuicSession to ActiveSessionList.

Merge internal change: 47048300

Fixing a backup/resumption bug in QUIC.

It's possible to have a full congestion window worth of packets on the wire.

If we are in this state and a session tries to SendStreamData, the
QuicPacketGenerator short-circuits without queuing packets because it checks
to see if the connection CanWrite.

When we get an ack, we check to see if we have locally queued packets, but
never call OnCanWrite on the session to clear any streams which write blocked
without queueing packets.

Merge internal change: 47000173

QUIC: wire up the server-nonce parameters to the server config.

Merge internal change: 46985067

R=rch@chromium.org

Review URL: https://codereview.chromium.org/16256017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204046 0039d316-1c4b-4281-b951-d872f2087c98

Remove miket@ and add dimich@ to chrome/browser/notifications
Add chrome/browser/extensions/api/notifications/OWNERS with dewittj@

r=miket@chromium.org,dimich@chromium.org
NOTRY=true
BUG=NONE

Review URL: https://chromiumcodereview.appspot.com/16214003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204045 0039d316-1c4b-4281-b951-d872f2087c98

Previously a single object MediaStreamUIController was used to control UI for
all streams. Replaced it with a per-stream MediaStreamUIProxy that simplifies
code in many places.
Also moved media request queueing logic from content layer to chrome. Now
different types of requests may be queued differently (e.g. there is no
reason to block screen capture requests on webcam infobar).

This change was previously landed in 197222 and reverted in 197242

TBR=vrk@chromium.org

Review URL: https://codereview.chromium.org/16342002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204044 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204043 0039d316-1c4b-4281-b951-d872f2087c98

R= siggi@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16357020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204041 0039d316-1c4b-4281-b951-d872f2087c98

This moves media_transfer_protocol targets into:
device/media_transfer_protocol/media_transfer_protocol.gyp

So it's consistent with what we have done with bluetooth and usb
directories/targets.

R=bryeung@chromium.org,miket@chromium.org,thestig@chromium.org
TBR=thestig@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16142004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204040 0039d316-1c4b-4281-b951-d872f2087c98

Add an explicit test comparing pids to ensure that the browser has restarted - this fixes a race.

BUG=244579
TEST=manual
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/16332003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204039 0039d316-1c4b-4281-b951-d872f2087c98

> Don't track whether a resize ack is pending during layout tests
> 
> Unlike normal operation, in layout tests the renderer can request a synchronous
> change of its size. The renderer and the browser therefore often run out of
> sync. However, it's important that the renderer always acks a resize request
> from the browser.
> 
> Previously, I tried to track the size the browser expects the renderer to have
> in the renderer, however, this turns out to not work when the compositor is in
> hidpi mode. Instead of trying to fix this up somehow, just ignore whether or
> not the browser is expecting resize acks during layout tests
> 
> BUG=244369
> 
> Review URL: https://chromiumcodereview.appspot.com/16285005

Breaks fast/hidpi on windows

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/16326004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204038 0039d316-1c4b-4281-b951-d872f2087c98

These always pass and just output the results for now.
BUG=chromedriver:10
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15979030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204037 0039d316-1c4b-4281-b951-d872f2087c98

These cases weren't caught by the automated pass and/or needed to be
solved in another way than using .get().

BUG=245942
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/16226028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204036 0039d316-1c4b-4281-b951-d872f2087c98

- Use a base::hash_map instead of a std::map for the
  SimpleBackendImpl::EntryMap type, to reduce heap usage.

  This saves 3 pointers/node on Android, since there is no
  need for an ordered map here.

- Avoid creating a new closure on every call to
  SimpleIndex::PostponeWritingToDisk. Each base::Bind() call
  creates a new heap-allocated reference-counted object.

  Given that this function is called for every mutating
  operation on the index, it's a good idea to get rid of it.

  Since the called function and its argument never change,
  create the closure only once and reuse it on every
  write_to_disk_timer_.Start() call.

- Avoid performing one extra lookup and one extra call
  to PostponeWritingToDisk() in SimpleIndex::Remove().

- Remove un-necessary temporary string creations and a tiny
  typo.

R=felipeg@chromium.org, gavinp@chromium.org, pasko@chromium.org, pliard@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/14877019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204035 0039d316-1c4b-4281-b951-d872f2087c98