- 10 May, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e4faae213dfd..29f4ba7d6eb8 git log e4faae213dfd..29f4ba7d6eb8 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 jonahr@google.com generate_stats filters duplicate neighboring rows. Created with: gclient setdep -r src/third_party/angle@29f4ba7d6eb8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: Ib9767cfcb5844adc4a84eac219f8e745f7383928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606340Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658783}
-
John Budorick authored
This reverts commit 10107c8f. Reason for revert: wrong cpu. Original change's description: > Add compile and luci configs for android-cronet-marshmallow-perf-arm64-rel. > > Bug: 861983 > Change-Id: I1404f93c0592c4e7c14d6194f5963f0618f27e43 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604308 > Commit-Queue: John Budorick <jbudorick@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658768} TBR=martiniss@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: Icee52669d4aa64905e8041a42f811b85df8cf05f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 861983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606597Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#658782}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7de0e5708798db249dc1cd9372372e122fdd6ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658781}
-
Wei Li authored
Add a semi-universal way to handle enum type conversions in MetaData. In this CL, two enum properties from ImageViewBase were converted to demo the usage. BUG=938501,957272 Change-Id: I7e9df7fc7ec10bfff1303f1b0f537cab4d5068d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600858 Commit-Queue: Wei Li <weili@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#658780}
-
Yuwei Huang authored
Previously Chrome Remote Desktop uses GOOGLE_API_KEY_REMOTING_FTL and GOOGLE_API_KEY_REMOTING_FTL_MOBILE. This internal CL defines a GOOGLE_API_KEY_REMOTING macro for each of the platform: https://chrome-internal-review.googlesource.com/c/chrome/google_apis/internal/+/1283134 This CL updates google_apis and existing code to use the new GOOGLE_API_KEY_REMOTING. I'll remove GOOGLE_API_KEY_REMOTING_FTL(_MOBILE)? once this CL is checked in. Bug: 961541 Change-Id: I03073acb23950fe0d361081b1bbf2c2fdfe750f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605159Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#658779}
-
Lukasz Anforowicz authored
Bug: 937451 Change-Id: Ia65a0a90e9befd37f7abbd86e859570265ed7cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554886 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#658778}
-
Avery Musbach authored
kSplitviewAnimationDurationMs is unused. Test: manual Change-Id: I3206f1a4cbb777ed4b30ca30d4d58acd47aa217f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601422Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#658777}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6e407986cd3b..ab32f656538d git log 6e407986cd3b..ab32f656538d --date=short --no-merges --format='%ad %ae %s' 2019-05-10 bsalomon@google.com Add SkSurface::asyncReadPixels() Created with: gclient setdep -r src/third_party/skia@ab32f656538d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Change-Id: Ia1962c581803b2467fdad53114700d00ccf22bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604192Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658776}
-
Frank Poole authored
Currently, BrowserAccessibility::GetInlineTextRect may receive negative inner text offsets which later induce an access violation when retrieving character offsets. These negative inner text offsets are the result of unnecessary searching through sub-trees which do not contain the queried text offsets. This change resolves this bug by adding additional validation of inner text bounds. Any inner text offsets passed to GetInlineTextRect are pre-validated by GetInnerTextRangeBoundsRect. Bug: 960452 Change-Id: I4de0f23fcde2319874805141d396f576b176d796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605150Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Frank Poole <frpoole@microsoft.com> Cr-Commit-Position: refs/heads/master@{#658775}
-
Vlad Tsyrklevich authored
Enable GWP-ASan for PartitionAlloc support in chrome if the newly introduced enable_gwp_asan_partitionalloc flag is set. CQ-DEPEND=CL:1601972 Bug: 956824 Change-Id: I38ebf62c11449813b71691053597d76ee7006a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602317Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#658774}
-
bsheedy authored
Makes the first (and thus fatal) failure from JavaScript more clear in the XR browser tests. This is achieved by adding logging to point the user towards the failure and stack that are actually useful for debugging. This is a workaround for a limitation of browser tests in general. FAIL() and other fatal macros provided by gtest only abort the current function. Since all the JavaScript execution is handled by helper functions, this means that even if we catch a failure in JavaScript and report it as a failure, the browser test will continue to run. This can then cause debugging issues because errors/stack traces from later on in the test end up getting printed as well since the test is continuing to run in a bad state. Bug: 961378 Change-Id: Iafd4892dc7d5307fa35848a855d5f1c76bd27095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605340 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#658773}
-
Jeffrey Kardatzke authored
This gets set here and then also by debugd when we request it to generate more log data for feedback. The invocation in debugd is more specific and covers more cases and would have been overwriting this one anyways, so let's remove this one. Bug: 961857 Test: Builds Change-Id: I0581954708287689def01fdb53c18a2a4d2da5b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606781 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#658772}
-
Michael Thiessen authored
Renames TouchlessUiController to TouchlessModelCoordinator, and introduces TouchlessUiCoordinator to abstract touchless UI logic out of NoTouchActivity to be re-used by ChromeActivity et al soon. Bug: 961734 Change-Id: I8f3d815067d314166f9777b954fc8b410c4dfa56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605633Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#658771}
-
Siddhartha S authored
BUG=925151 Change-Id: I8f8e48eb34de990cf0abb7e95b55c808d758b124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606189Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#658770}
-
chrome://discardsSigurdur Asgeirsson authored
This is in preparation for pushing favicons for pages out to the graph, plus this exposes transient graph nodes reliably. Change-Id: Iee06bcf2e87c2c28c4119b70a8b4ddb9b05ff943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600362 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#658769}
-
John Budorick authored
Bug: 861983 Change-Id: I1404f93c0592c4e7c14d6194f5963f0618f27e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604308 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#658768}
-
Kyle Milka authored
If an image tile is selected clikcing the done button applies the image and closes the dialog. screencast: http://go/scrcast/NTkxNjIzNDcwMDgxNjM4NHxmNzRjYzQ4YS1iZg Bug: 937570 Change-Id: I15fd616f79908708d6c3cb6b3a55cafed80b59e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606187Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#658767}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c827dc29b351..782cc0e47030 git log c827dc29b351..782cc0e47030 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 oysteine@google.com Merge "Assert if the SMB stalls for 100 counts waiting for a chunk" Created with: gclient setdep -r src/third_party/perfetto@782cc0e47030 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I71f382576fb169c31b19efdd8b68bdfa7ba0e40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606342Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658766}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d29b3945d69..1643e6b61293 Created with: gclient setdep -r src-internal@1643e6b61293 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I3ca24853136a07c5ff1f741fb0836942794901b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605634Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658765}
-
Oriol Brufau authored
Before this change, a repeat() notation with an integral number of repetitions was expanded at parse time. This was observable when reading declared values using JS APIs. This patch makes the parser preserve that notation, like it was already happening when the number of repetitions was automatic and not integral. The resolved value in getComputedStyle() will still be expanded, though, as required by the spec. BUG=716114 TEST=external/wpt/css/css-grid/grid-definition/grid-support-repeat-002.html TEST=fast/css-grid-layout/grid-element-auto-repeat-get-set.html TEST=fast/css-grid-layout/named-grid-line-get-set.html Change-Id: I2d1286bf32aacc9e4fe0b0e8cf14f9f3871d0b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605401Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#658764}
-
Kristi Park authored
The transition was removed by changes in https://crrev.com/c/1591954. Technically, the transition is a regression from pre-M69 behavior, but is now considered accepted. Change-Id: I832263f37f29b01c8c8e8bd699240ed21431bc6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604426 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#658763}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/efe931463c18..46afbf9481fb git log efe931463c18..46afbf9481fb --date=short --no-merges --format='%ad %ae %s' 2019-05-10 steveanton@webrtc.org Revert "Reland "Version 2 "Refactoring DataContentDescription class""" Created with: gclient setdep -r src/third_party/webrtc@46afbf9481fb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6b0c449613d953ad1184615a47985a9aaecc79c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604061Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658762}
-
Nicolás Peña Moreno authored
Commits aee8357d and faed29aa landed almost at the same time, so we accidentally landed a test with the wrong script src for the helper functions. Bug: 961547 Change-Id: Id8a615477a54e56139d9d90fc4feb5f780b729a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606225Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#658761}
-
Eric Aleshire authored
BaseEarlGreyTestCase handles setup work for EG2 tests, including launching the application under test, and providing replacement hooks for +setUp (which is called once per test class). As test classes are converted to EG2, they should switch to using BaseEarlGreyTestCase and these setup functions. Tested to make sure the modified EG2 tests pass locally. Bug: 939373 Change-Id: Idc216a02e8200af697c673b9a340620ad28cb05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593799 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#658760}
-
Ryan Sturm authored
This is no longer needed. Bug: None Change-Id: Ic8750d9047dfa1968ba37cd161aa80889c3efad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605326Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#658759}
-
Moe Ahmadi authored
Language Settings page features a list of user preferred languages sent in the Accept-Language HTTP header. Users can add, delete, and reorder these languages. Language Settings page also features a switch to enable/disable translation. If enabled, a trailing label appears for every language row indicating whether or not translate is offered for that language. A disclosure indicator is also added to every language row indicating this option can be changed. 1. In edit mode, the "Translate" and "Add Language..." buttons are disabled. 2. Languages can be deleted by swiping gesture or the red delete button in edit mode. 3. The last Translate-blocked language cannot be deleted similar to other platforms. 4. Translate cannot be offered for the last Translate-blocked language; therefore the option to "Offer Translate" is disabled for it. 5. Translate cannot be offered for the target language (which may not appear in the list, e.g., the device language); therefore the option to "Offer Translate" is disabled for it. Demo: https://drive.google.com/file/d/0B2sUCLY7X-D2enZRZE9hUmUwa0pjNkpYWHVFbzV6cEhDbUVr/view?usp=sharing Bug: 957688 Change-Id: Icdf005e04d1716c42ea249229dbc7f39a043e46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595040Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#658758}
-
Oystein Eftevaag authored
Looks like the deadlocks have all been fixed; speculatively re-enabling. Bug: 950718 Change-Id: I7bf22cc8583e85fbea0a2471f5e9e691158486cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605168 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#658757}
-
Toni Barzic authored
Makes sure that in-memory FakeSessionManagerClient does not run StoreDevicePolicy callback until the owner key file was written (if new owner key has to be written). SessionManagerOperation tries to load the owner key in response to StoreDevivePolicy, and the task to load the key might be run before the task to write it (as they are not using the same sequence task runner). BUG=952855 Change-Id: I41c584869741ba3d06245c378f2ef0bccd06b0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604216 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#658756}
-
Min Qin authored
DownloadManagerService already listens to AllDownloadEventNofitier, so there is no need to implement OnDownloadInitialized(). The service manager connector can also be provided to InProgressDownloadManager ctor, so there is no need to implement GetServiceConnector(). BUG=942770 Change-Id: Ibc143b832c734e3a1fac0af6044aba99f8d7c1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606182Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658755}
-
Joe Downing authored
Change-Id: I500056f77427e6cd7204c82c7e4f06e93633b586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604427Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#658754}
-
danakj authored
Android browser tests do not provide a ContentMainDelegate through the TestLauncherDelegate, they set it via content_main.h's SetContentMainDelegate() method. They do have have the test launcher run ContentMain(), nor does BrowserTestBase run ContentMain(). Instead Android browser tests mimic the behaviour of ContentMain and call BrowserMain() directly in the test process. They ContentMainDelegate is not used in content test launcher, nor does the ContentMainParams exist or get used. And Android browser tests run child processes as threads, so child processes do not need to run ContentMain() from the content test launcher. Bug: 961849 Change-Id: Icef9590a1f97b7948229934f66f9f91cf304aeab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606402 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#658753}
-
Bailey Berro authored
- This notification is shown when a user plugs in a USB printer - Notification is currently gated on the kStreamlinedUsbPrinterSetup feature flag - With this CL, notifications are only displayed for unsaved printers - Subsequent CL will wire up a notification for a saved printer that is plugged in Bug: 951139 Change-Id: I10c6e5d3b41776b0ca79e07739c403732634569a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594798Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#658752}
-
Ryan Hamilton authored
from the QUIC fieldtrial testing config to match finch. Change-Id: Icd2f81c0c2b561db68f927baeed61c17c1da2617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606242 Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#658751}
-
Peter Wen authored
Adding these README.md files allows everyone to see the purpose of these new directories that contain many subdirectories. This makes it possible to update these README.md files when the design consensus changes. Bug: 846440 Change-Id: Ib79b8c82e728938fc0e29664452bfc06b9ae6f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602555 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#658750}
-
Austin Eng authored
This enables testing WebGPU from Blink on DEPS Dawn bots. Bug: 877147 Change-Id: Idb50a32199ded13e308b295496c31418564704a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517156Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#658749}
-
Ian Kilpatrick authored
Previously we weren't checking for "solid" edges on layout opportunities within the NGExclusionSpace. This had the effect of us thinking a particular layout opportunity was valid (when one edge wasn't against any floats). This caused us to place the element in such a way that it was "avoiding" a float higher up in the document (when it shouldn't have). This introduces a "NGClosedArea" struct, which keeps track of the "NGEdges" vectors so that before considering a layout opportunity as valid, we check it has solid edges. Bug: 959567 Change-Id: If6481a23279eee7a1b188ec4cf5129b503935cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603303 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#658748}
-
Xing Liu authored
This CL removes 5dp padding in the checkbox, so it can align with the icons above. Bug: 864785 Change-Id: I6881b0269498eb50bc7b5dd8d337fdedd8527f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604467Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#658747}
-
Ovidio Henriquez authored
This change adds a layout change listener to the ItemChooserDialog view so that it renders correctly when the layout changes while it's open. Bug: 616227 Change-Id: I100fcac4d0bddf51dedd5ab1b3b99fa6936709f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604002Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#658746}
-
Kurt Catti-Schmidt authored
This change builds upon the functionality for AXPosition added in https://chromium-review.googlesource.com/c/chromium/src/+/1584596 Unit tests were added. Bug: 928948 Change-Id: Id52d39a73725a35a9b041ea2c3172c4a9c522171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594084Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#658745}
-
Matthias Körber authored
Bug: 961755 Change-Id: I80e355db7b0a1ae0fd2fe618d0851a3843d35244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605990 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#658744}
-