1. 18 Aug, 2011 40 commits
    • ap@apple.com's avatar
      [Gtk] editing/selection/regional-indicators.html fails · 2cc5c148
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=66501
      
              * platform/gtk/editing/selection/regional-indicators-expected.txt: Land failing results.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93353 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2cc5c148
    • ap@apple.com's avatar
      Use a correct name for expected results. · e339c385
      ap@apple.com authored
              * platform/qt/editing/selection/regional-indicators-actual.txt: Removed.
              * platform/qt/editing/selection/regional-indicators-expected.txt: Copied from LayoutTests/platform/qt/editing/selection/regional-indicators-actual.txt.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93352 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e339c385
    • ap@apple.com's avatar
      [Qt] editing/selection/regional-indicators.html fails · 6d62ec94
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=66500
      
              * platform/qt/editing/selection/regional-indicators-actual.txt: Land failing results.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93351 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6d62ec94
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r93329. · f957c596
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/93329
      https://bugs.webkit.org/show_bug.cgi?id=66497
      
      Turned text on chromium win blue (Requested by jamesr_ on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-18
      
      Source/WebCore:
      
      * WebCore.gypi:
      * platform/graphics/chromium/ContentLayerChromium.cpp:
      * platform/graphics/chromium/ContentLayerChromium.h:
      * platform/graphics/chromium/ImageLayerChromium.cpp:
      (WebCore::ImageLayerTextureUpdater::prepareToUpdate):
      * platform/graphics/chromium/LayerChromium.cpp:
      (WebCore::LayerChromium::LayerChromium):
      (WebCore::LayerChromium::pushPropertiesTo):
      (WebCore::LayerChromium::dumpLayerProperties):
      * platform/graphics/chromium/LayerChromium.h:
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::initialize):
      (WebCore::LayerRendererChromium::releaseTextures):
      (WebCore::LayerRendererChromium::updateRootLayerContents):
      (WebCore::LayerRendererChromium::drawRootLayer):
      (WebCore::LayerRendererChromium::invalidateRootLayerRect):
      (WebCore::LayerRendererChromium::rootLayerChanged):
      (WebCore::LayerRendererChromium::viewportChanged):
      (WebCore::LayerRendererChromium::updateLayers):
      (WebCore::LayerRendererChromium::drawLayers):
      (WebCore::LayerRendererChromium::paintLayerContents):
      (WebCore::LayerRendererChromium::drawLayersInternal):
      (WebCore::LayerRendererChromium::getFramebufferPixels):
      (WebCore::LayerRendererChromium::cleanupSharedObjects):
      (WebCore::LayerRendererChromium::layerTreeAsText):
      (WebCore::LayerRendererChromium::dumpRenderSurfaces):
      * platform/graphics/chromium/LayerRendererChromium.h:
      (WebCore::LayerRendererChromium::rootLayer):
      * platform/graphics/chromium/NonCompositedContentHost.cpp: Removed.
      * platform/graphics/chromium/NonCompositedContentHost.h: Removed.
      * platform/graphics/chromium/RenderSurfaceChromium.cpp:
      (WebCore::RenderSurfaceChromium::dumpSurface):
      * platform/graphics/chromium/TiledLayerChromium.cpp:
      (WebCore::TiledLayerChromium::createTilerIfNeeded):
      (WebCore::TiledLayerChromium::tilingTransform):
      * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
      (WebCore::CCHeadsUpDisplay::draw):
      * platform/graphics/chromium/cc/CCLayerImpl.cpp:
      (WebCore::CCLayerImpl::CCLayerImpl):
      * platform/graphics/chromium/cc/CCLayerImpl.h:
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      (WebCore::CCLayerTreeHost::CCLayerTreeHost):
      (WebCore::CCLayerTreeHost::initialize):
      (WebCore::CCLayerTreeHost::createRootLayerPainter):
      (WebCore::CCLayerTreeHost::invalidateRootLayerRect):
      (WebCore::CCLayerTreeHost::setRootLayer):
      (WebCore::CCLayerTreeHost::setViewport):
      (WebCore::CCLayerTreeHost::reallocateRenderer):
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      (WebCore::CCLayerTreeHost::rootLayer):
      (WebCore::CCLayerTreeHost::viewportContentRect):
      (WebCore::CCLayerTreeHost::viewportScrollPosition):
      (WebCore::CCLayerTreeHost::viewportVisibleRect):
      * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
      (WebCore::CCTiledLayerImpl::draw):
      
      Source/WebKit/chromium:
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::paint):
      (WebKit::WebViewImpl::setRootGraphicsLayer):
      (WebKit::WebViewImpl::setRootPlatformLayer):
      (WebKit::WebViewImpl::didRecreateGraphicsContext):
      (WebKit::WebViewImpl::updateLayerTreeViewport):
      * src/WebViewImpl.h:
      
      LayoutTests:
      
      * platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/ancestor-overflow-change-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
      * platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
      * platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
      * platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
      * platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
      * platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
      * platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
      * platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
      * platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
      * platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
      * platform/chromium-gpu-linux/media/video-zoom-expected.png:
      * platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93350 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f957c596
    • rniwa@webkit.org's avatar
      Skip tests added by r93291 on GTK because GTK's DRT doesn't support... · 316cd3d4
      rniwa@webkit.org authored
      Skip tests added by r93291 on GTK because GTK's DRT doesn't support textInputController.doCommand yet,
      which is tracked by the bug 66496.
      
      * platform/gtk/Skipped:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93349 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      316cd3d4
    • rniwa@webkit.org's avatar
      GTK rebaseline after r93221. · 0f45e9ff
      rniwa@webkit.org authored
      * platform/gtk/editing/selection/collapse-selection-in-bidi-expected.txt:
      Copied from LayoutTests/platform/win/editing/selection/collapse-selection-in-bidi-expected.txt.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93348 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0f45e9ff
    • rniwa@webkit.org's avatar
      SimplifiedBackwardsTextIterator returns incorrect offset with first-letter rule · 31471910
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66086
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      The bug was caused by SimplifiedBackwardsTextIterator's not taking care of first-letter at all.
      Fixing the bug by detecting RenderTextFragment in handleTextNode.
      
      Also added m_shouldHandleFirstLetter to SimplifiedBackwardsTextIterator to keep track of whether or not
      the next call to handleTextNode needs to process the first-letter part of the text fragment.
      
      Test: editing/text-iterator/backward-textiterator-first-letter-crash.html
      
      * editing/TextIterator.cpp:
      (WebCore::firstRenderTextInFirstLetter): Extracted from handleTextNodeFirstLetter.
      (WebCore::TextIterator::handleTextNodeFirstLetter): Calls firstRenderTextInFirstLetter.
      (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
      (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
      (WebCore::SimplifiedBackwardsTextIterator::handleFirstLetter): Added.
      * editing/TextIterator.h:
      
      LayoutTests: 
      
      Added a test to ensure WebKit does not hit assertions in SimplifiedBackwardsTextIterator.
      Also fixed a bug in first-letter-word-boundary.html and updated expected offsets for move backward by word
      from 0 to 1 because there is unrendered space before "hello".
      
      * editing/text-iterator/backward-textiterator-first-letter-crash-expected.txt: Added.
      * editing/text-iterator/backward-textiterator-first-letter-crash.html: Added.
      * editing/text-iterator/first-letter-word-boundary-expected.txt:
      * editing/text-iterator/first-letter-word-boundary.html:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93347 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      31471910
    • commit-queue@webkit.org's avatar
      [chromium] Assert that main thread and compositor thread are used safely · 1b35adde
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66145
      
      CCLayerTreeHostImplProxy now has public static methods isMainThread()
      and isImplThread(), and we ASSERT these in various places. If threaded
      compositing is disabled, we fake isImplThread() by setting a flag for
      the duration of compositing, so the assert is still valid.
      
      Patch by Iain Merrick <husky@google.com> on 2011-08-18
      Reviewed by James Robinson.
      
      Covered by existing tests.
      
      * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
      (WebCore::CCCanvasLayerImpl::draw):
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      (WebCore::CCLayerTreeHost::doComposite):
      * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
      (WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread):
      (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread):
      (WebCore::CCLayerTreeHostImplProxy::isMainThread):
      (WebCore::CCLayerTreeHostImplProxy::isImplThread):
      (WebCore::CCLayerTreeHostImplProxy::setImplThread):
      (WebCore::CCLayerTreeHostImplProxy::commitOnCCThread):
      (WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread):
      (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread):
      (WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread):
      (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread):
      (WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
      * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h:
      * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
      (WebCore::CCPluginLayerImpl::draw):
      * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
      (WebCore::CCTiledLayerImpl::draw):
      * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
      (WebCore::CCVideoLayerImpl::draw):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93346 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1b35adde
    • commit-queue@webkit.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=47240 · 2c6c6cdb
      commit-queue@webkit.org authored
      Fixed a cygwin path problem in the chromium port of diff_image;
      Also made the return values of the diff_image function more consistent.
      
      Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-18
      Reviewed by Dirk Pranke.
      
      * Scripts/webkitpy/layout_tests/port/chromium.py:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93345 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2c6c6cdb
    • ap@apple.com's avatar
      Regional indicator symbols that are combined should behave as a single character when editing · 45e769b0
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65395
      
      Reviewed by Dan Bernstein.
      
      Source/WebCore:
      
      Part two: make cursor movement iterator work. This fixes the problem for strings that don't
      contain more than two flags in a row, as fixing it completely doesn't seem possible with ICU.
      
      Test: editing/selection/regional-indicators.html
      
      * platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator): Added custom
      rules for regional indicator symbols.
      
      LayoutTests:
      
      * editing/selection/regional-indicators-expected.txt: Added.
      * editing/selection/regional-indicators.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93344 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      45e769b0
    • caryclark@google.com's avatar
      Fix rubber band gutter drawing for Skia on Chromium Mac · 322d7175
      caryclark@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66478
      
      Reviewed by James Robinson.
      
      No new tests. The Skia on Chromium Mac platform has
      not been enabled.
      
      This break was detected at compile time; there is no
      behavior change.
      
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
      Convert the CGImage into an SkBitmap if Skia is present.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93343 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      322d7175
    • commit-queue@webkit.org's avatar
      Add a bunch of accessors to WebAccessibilityObject to expose more of · 0792ac65
      commit-queue@webkit.org authored
      AccessibilityObject to Chromium, including range control values,
      document load state, live region attributes, and a few other
      ARIA attributes.
      
      https://bugs.webkit.org/show_bug.cgi?id=66411
      
      Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-08-18
      Reviewed by Dimitri Glazkov.
      
      * public/WebAccessibilityObject.h:
      * src/WebAccessibilityObject.cpp:
      (WebKit::WebAccessibilityObject::isAriaReadOnly):
      (WebKit::WebAccessibilityObject::isButtonStateMixed):
      (WebKit::WebAccessibilityObject::isControl):
      (WebKit::WebAccessibilityObject::isFocused):
      (WebKit::WebAccessibilityObject::isLoaded):
      (WebKit::WebAccessibilityObject::isRequired):
      (WebKit::WebAccessibilityObject::isVertical):
      (WebKit::WebAccessibilityObject::accessKey):
      (WebKit::WebAccessibilityObject::ariaHasPopup):
      (WebKit::WebAccessibilityObject::ariaLiveRegionAtomic):
      (WebKit::WebAccessibilityObject::ariaLiveRegionBusy):
      (WebKit::WebAccessibilityObject::ariaLiveRegionRelevant):
      (WebKit::WebAccessibilityObject::ariaLiveRegionStatus):
      (WebKit::WebAccessibilityObject::estimatedLoadingProgress):
      (WebKit::WebAccessibilityObject::hierarchicalLevel):
      (WebKit::WebAccessibilityObject::valueDescription):
      (WebKit::WebAccessibilityObject::valueForRange):
      (WebKit::WebAccessibilityObject::maxValueForRange):
      (WebKit::WebAccessibilityObject::minValueForRange):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93342 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0792ac65
    • jchaffraix@webkit.org's avatar
      Implement a faster path for painting tables with overflowing cells · 7e533605
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65491
      
      This change introduces a smarter way of painting if the table is big enough and we have a small amount
      of overflowing cells in the table. The new path does a binary search of the cells to repaint but adds
      the overflowing cells to the repainting cells.
      
      This saves ~50% when doing programmatic scrolling throught JS on a 500x100 table with some overflowing
      cells. Also we cap the memory usage to a ratio of the total size of the table to avoid blowing up the
      memory.
      
      Reviewed by David Hyatt.
      
      No new tests as the behavior should be the same.
      
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::RenderTableSection):
      (WebCore::RenderTableSection::layoutRows): Added some code to accumulate the overflowing cells
      in an internal HashSet (we don't need to keep them sorted and it makes it easier to use them during
      painting). If we hit the cap, flip the boolean value and clear the HashSet as the slow path does not
      care about the cell's information. Make sure that the "has overflowing cells" information is still
      properly encoded on our 2 values.
      
      (WebCore::compareCellPositionsWithOverflowingCells): Added this method as we are doing a more
      complicated sort:
          * the old path would sort one (mostly sorted) array by rows only as the stable sort would
            take care of keeping the column ordering inside a row.
          * the new path basically has to sort an unsorted array (taken partly from the HashSet).
      
      (WebCore::RenderTableSection::paintObject): Tweaked the logic to account for difference between
      m_forceSlowPaintPathWithOverflowingCell and has some overflowing cells. Also we make sure we don't
      repaint the same cell twice.
      
      (WebCore::RenderTableSection::nodeAtPoint): Changed to hasOverflowingCell(). We don't apply our
      fast path optimization here.
      
      * rendering/RenderTableSection.h: Transformed our original boolean into
      a HashSet and a boolean. The HashSet holds up the CellStruct that are overflowing
      until we reach the memory threshold. After this is hit, we just set the boolean
      to avoid using too much memory.
      
      (WebCore::RenderTableSection::hasOverflowingCell): This is the new way to determine
      if we have any overflowing cell, used only for hit testing.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93341 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7e533605
    • commit-queue@webkit.org's avatar
      An EventSource constructor should throw TypeError, when the number of arguments is not enough. · 073770a5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66454
      
      Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
      Reviewed by Adam Barth.
      
      The spec is here: http://www.w3.org/TR/WebIDL/#es-operations.
      
      Source/WebCore:
      
      Test: fast/eventsource/eventsource-constructor.html
      
      * bindings/js/JSEventSourceCustom.cpp:
      (WebCore::JSEventSourceConstructor::constructJSEventSource): Changed SyntaxError to TypeError.
      * bindings/v8/custom/V8EventSourceConstructor.cpp:
      (WebCore::V8EventSource::constructorCallback): Changed SyntaxError to TypeError.
      
      LayoutTests:
      
      * fast/eventsource/eventsource-constructor-expected.txt: Changed SyntaxError to TypeError.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93340 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      073770a5
    • commit-queue@webkit.org's avatar
      A SharedWorker constructor should throw TypeError, when the number of arguments is not enough. · 052f2a01
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66455
      
      Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
      Reviewed by Adam Barth.
      
      The spec is here: http://www.w3.org/TR/WebIDL/#es-operations.
      
      Source/WebCore:
      
      Test: fast/workers/shared-worker-constructor.html
      
      * bindings/js/JSSharedWorkerCustom.cpp:
      (WebCore::JSSharedWorkerConstructor::constructJSSharedWorker): Changed SyntaxError to TypeError.
      * bindings/v8/custom/V8SharedWorkerCustom.cpp:
      (WebCore::V8SharedWorker::constructorCallback): Changed SyntaxError to TypeError.
      
      LayoutTests:
      
      * fast/workers/shared-worker-constructor-expected.txt: Changed SyntaxError to TypeError.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93339 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      052f2a01
    • alex@webkit.org's avatar
      2011-08-17 Alejandro G. Castro <alex@igalia.com> · df3c93b0
      alex@webkit.org authored
              [GTK] Fix compilation problems with deprecations in gtk+
              https://bugs.webkit.org/show_bug.cgi?id=66073
      
              Reviewed by Martin Robinson.
      
              * platform/gtk/GtkAuthenticationDialog.cpp:
              (WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog): Added
              gtk_box_new conditional compilation for gtk+-3.
              * platform/gtk/RenderThemeGtk3.cpp:
              (WebCore::RenderThemeGtk::adjustRepaintRect):
              (WebCore::RenderThemeGtk::paintSliderTrack):
              (WebCore::RenderThemeGtk::paintSliderThumb):
              (WebCore::RenderThemeGtk::adjustSliderThumbSize): Now we have have
              GTK_TYPE_SCALE in gtk+3.
      
      2011-08-17  Alejandro G. Castro  <alex@igalia.com>
      
              [GTK] Fix compilation problems with deprecations in gtk+
              https://bugs.webkit.org/show_bug.cgi?id=66073
      
              Reviewed by Martin Robinson.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (main): G_CONST_RETURN was deprecated
              * GtkLauncher/main.c:
              (createWindow): Added gtk_box_new conditional compilation for
              gtk+-3.
              * MiniBrowser/gtk/BrowserWindow.c:
              (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
              are just supporting gtk+-3 for WebKit2.
      
      2011-08-17  Alejandro G. Castro  <alex@igalia.com>
      
              [GTK] Fix compilation problems with deprecations in gtk+
              https://bugs.webkit.org/show_bug.cgi?id=66073
      
              Reviewed by Martin Robinson.
      
              * WebCoreSupport/FullscreenVideoController.cpp:
              (FullscreenVideoController::createHud): Added gtk_box_new
              conditional compilation for gtk+-3.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93338 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      df3c93b0
    • darin@apple.com's avatar
      Made some code even more private to a particular file and class · 8c5d7b07
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66428
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _setDrawingAreaSize:]): Made this file internal.
      * UIProcess/API/mac/WKViewInternal.h: Removed _setDrawingAreaSize.
      * UIProcess/DrawingAreaProxy.h: Made sizeDidChange private.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93337 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8c5d7b07
    • commit-queue@webkit.org's avatar
      A Worker constructor should throw TypeError, when the number of arguments is not enough · cef2f177
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66456
      
      Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
      Reviewed by Adam Barth.
      
      Spec is here: http://www.w3.org/TR/WebIDL/#es-operations.
      
      Source/WebCore:
      
      Test: fast/workers/worker-constructor.html
      
      * bindings/js/JSWorkerCustom.cpp:
      (WebCore::JSWorkerConstructor::constructJSWorker): Changed SyntaxError to TypeError.
      * bindings/v8/custom/V8WorkerCustom.cpp:
      (WebCore::V8Worker::constructorCallback): Changed SyntaxError to TypeError.
      
      LayoutTests:
      
      * fast/workers/worker-constructor-expected.txt: Changed SyntaxError to TypeError.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93336 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cef2f177
    • commit-queue@webkit.org's avatar
      Fix logic error causing reverse of desired WebGL rate limiting behavior · 9680a70a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66445
      
      Patch by John Bates <jbates@google.com> on 2011-08-18
      Reviewed by Kenneth Russell.
      
      * platform/graphics/chromium/WebGLLayerChromium.cpp:
      (WebCore::WebGLLayerChromium::setTextureUpdated):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93335 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9680a70a
    • leviw@chromium.org's avatar
      Switch RenderTextControl* to new layout types · 004e29a6
      leviw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66250
      
      Reviewed by Eric Seidel.
      
      Convertikng the RenderTextControl* classes to use the LayoutUnit abstraction.
      
      No new tests as no change in behavior.
      
      * rendering/LayoutTypes.h:
      (WebCore::layoutMod): Added a function to perform the modulo operation on LayoutUnits.
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::hitInnerTextElement):
      * rendering/RenderTextControl.h:
      * rendering/RenderTextControlMultiLine.cpp:
      (WebCore::RenderTextControlMultiLine::preferredContentWidth):
      (WebCore::RenderTextControlMultiLine::baselinePosition):
      * rendering/RenderTextControlMultiLine.h:
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::layout):
      (WebCore::RenderTextControlSingleLine::controlClipRect):
      (WebCore::RenderTextControlSingleLine::preferredContentWidth):
      (WebCore::RenderTextControlSingleLine::scrollWidth):
      (WebCore::RenderTextControlSingleLine::scrollHeight):
      (WebCore::RenderTextControlSingleLine::scrollLeft):
      (WebCore::RenderTextControlSingleLine::scrollTop):
      (WebCore::RenderTextControlSingleLine::setScrollLeft):
      (WebCore::RenderTextControlSingleLine::setScrollTop):
      * rendering/RenderTextControlSingleLine.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93334 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      004e29a6
    • leviw@chromium.org's avatar
      Switch Inline rendering classes to new layout types · ff0b81a3
      leviw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66239
      
      Reviewed by Eric Seidel.
      
      Converting inline rendering classes to use the LayoutUnit abstraction from ints.
      
      No new tests as no change in functionality.
      
      * rendering/InlineBox.h:
      (WebCore::InlineBox::logicalFrameRect):
      (WebCore::InlineBox::baselinePosition):
      (WebCore::InlineBox::lineHeight):
      * rendering/InlineFlowBox.h:
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::logicalOverflowRect):
      (WebCore::InlineTextBox::setLogicalOverflowRect):
      (WebCore::InlineTextBox::baselinePosition):
      (WebCore::InlineTextBox::lineHeight):
      * rendering/InlineTextBox.h:
      (WebCore::InlineTextBox::logicalTopVisualOverflow):
      (WebCore::InlineTextBox::logicalBottomVisualOverflow):
      (WebCore::InlineTextBox::logicalLeftVisualOverflow):
      (WebCore::InlineTextBox::logicalRightVisualOverflow):
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::culledInlineAbsoluteRects):
      (WebCore::computeMargin):
      (WebCore::RenderInline::culledInlineBoundingBox):
      (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
      (WebCore::RenderInline::linesVisualOverflowBoundingBox):
      (WebCore::RenderInline::clippedOverflowRectForRepaint):
      (WebCore::RenderInline::rectWithOutlineForRepaint):
      (WebCore::RenderInline::computeRectForRepaint):
      (WebCore::RenderInline::mapLocalToContainer):
      (WebCore::RenderInline::lineHeight):
      (WebCore::RenderInline::baselinePosition):
      (WebCore::RenderInline::addDashboardRegions):
      * rendering/RenderInline.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93333 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ff0b81a3
    • jpfau@apple.com's avatar
      New XML parser: add doctype to DOM tree · 8a80bb93
      jpfau@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66408
      
      Reviewed by Adam Barth.
      
      * xml/parser/XMLTreeBuilder.cpp:
      (WebCore::XMLTreeBuilder::processDOCTYPE):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93332 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8a80bb93
    • rniwa@webkit.org's avatar
      Add a test to ensure WebKit does not paste contents before · 7272704f
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66481
      
      Reviewed by Alexey Proskuryakov.
      
      Add a regression test since this bug has been fixed by r92695.
      
      * editing/pasteboard/paste-delete-insertion-position-skip-paragraph-expected.txt: Added.
      * editing/pasteboard/paste-delete-insertion-position-skip-paragraph.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93331 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7272704f
    • dslomov@google.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=61016 · 7442ffad
      dslomov@google.com authored
      [WebWorkers][Chromium] Use v8 Isolates for in-process implementation of WebWorkers.
      This adds an implementation of in-process dedicated workers to chromium port.
      The crux of the matter is the reimplementation of WebWorkerClientImpl. WebWorkerClientImpl now
      implements all three of Worker{Loader,Context,Object}Proxies and delegates the implementation to
      WebKit's standard WorkerMessagingProxy.
      For now, we have 3 implementations of workers in chromium WebKit:
        - In-process dedicated workers (this checkin)
        - Inter-process shared workers
        - Inter-process dedicated workers (defunct after this checkin)
      This patch extracts some new common interfaces (NewWebWorkerBase and NewWebWorkerClient) for these
      three implementations.
      Removing the remainings of inter-process dedicated workers -related classes is left for a separate patch
      (it will require coordinated changes on chromuium side).
      
      Reviewed by David Levin.
      
      * public/WebCommonWorkerClient.h:
      * src/DatabaseObserver.cpp:
      (WebKit::AllowDatabaseMainThreadBridge::create):
      (WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
      (WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
      (WebKit::allowDatabaseForWorker):
      (WebCore::DatabaseObserver::canEstablishDatabase):
      * src/LocalFileSystemChromium.cpp:
      (WebCore::openFileSystemHelper):
      * src/WebSharedWorkerImpl.h:
      (WebKit::WebSharedWorkerImpl::newCommonClient):
      * src/WebWorkerBase.h:
      (WebKit::WebWorkerBase::view):
      * src/WebWorkerClientImpl.cpp:
      (WebKit::WebWorkerClientImpl::createWorkerContextProxy):
      (WebKit::WebWorkerClientImpl::startWorkerContext):
      (WebKit::WebWorkerClientImpl::terminateWorkerContext):
      (WebKit::WebWorkerClientImpl::postMessageToWorkerContext):
      (WebKit::WebWorkerClientImpl::hasPendingActivity):
      (WebKit::WebWorkerClientImpl::workerObjectDestroyed):
      (WebKit::WebWorkerClientImpl::connectToInspector):
      (WebKit::WebWorkerClientImpl::disconnectFromInspector):
      (WebKit::WebWorkerClientImpl::sendMessageToInspector):
      (WebKit::WebWorkerClientImpl::postMessageToPageInspector):
      (WebKit::WebWorkerClientImpl::postTaskToLoader):
      (WebKit::WebWorkerClientImpl::postTaskForModeToWorkerContext):
      (WebKit::WebWorkerClientImpl::postMessageToWorkerObject):
      (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject):
      (WebKit::WebWorkerClientImpl::reportPendingActivity):
      (WebKit::WebWorkerClientImpl::workerContextClosed):
      (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
      (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject):
      (WebKit::WebWorkerClientImpl::workerContextDestroyed):
      (WebKit::WebWorkerClientImpl::allowFileSystem):
      (WebKit::WebWorkerClientImpl::openFileSystem):
      (WebKit::WebWorkerClientImpl::allowDatabase):
      (WebKit::WebWorkerClientImpl::dispatchDevToolsMessage):
      (WebKit::WebWorkerClientImpl::view):
      (WebKit::WebWorkerClientImpl::WebWorkerClientImpl):
      (WebKit::WebWorkerClientImpl::~WebWorkerClientImpl):
      * src/WebWorkerClientImpl.h:
      (WebKit::WebWorkerClientImpl::newCommonClient):
      * src/WebWorkerImpl.cpp:
      (WebKit::WebWorkerImpl::newCommonClient):
      * src/WebWorkerImpl.h:
      * src/WorkerFileSystemCallbacksBridge.cpp:
      (WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
      (WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
      * src/WorkerFileSystemCallbacksBridge.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93330 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7442ffad
    • commit-queue@webkit.org's avatar
      [chromium] Draw the root/"non-composited content" in compositor side · a280e074
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=58834
      
      Patch by James Robinson <jamesr@chromium.org> on 2011-08-18
      Reviewed by Darin Fisher.
      
      Source/WebCore:
      
      Handle the root or non-composited content with a GraphicsLayer rather than special case logic in
      LayerRendererChromium. This layer's client is the NonCompositedContentHost, which routes the paint callbacks
      through the LayerPainterChromium interface out to the WebView.  The root layer is special in two ways:
      *) The root layer has a scroll offset, which changes how the visibleLayerRect maps to content space and applies a
          draw-time transform.
      *) The root layer masks the alpha channel when drawing because of concerns about subpixel AA trashing the alpha
          channel.  The root layer is always opaque so this is fine.
      *) The root layer does not have border texels and does have subpixel AA for text.
      
      Covered by compositing/
      
      * WebCore.gypi:
      * platform/graphics/chromium/ContentLayerChromium.cpp:
      (WebCore::ContentLayerChromium::paintContentsIfDirty):
      * platform/graphics/chromium/ImageLayerChromium.cpp:
      (WebCore::ImageLayerChromium::paintContentsIfDirty):
      * platform/graphics/chromium/LayerChromium.cpp:
      (WebCore::LayerChromium::pushPropertiesTo):
      * platform/graphics/chromium/LayerChromium.h:
      (WebCore::LayerChromium::scrollPosition):
      (WebCore::LayerChromium::setScrollPosition):
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::initialize):
      (WebCore::LayerRendererChromium::releaseTextures):
      (WebCore::LayerRendererChromium::viewportChanged):
      (WebCore::LayerRendererChromium::updateLayers):
      (WebCore::LayerRendererChromium::drawLayers):
      (WebCore::LayerRendererChromium::drawLayersInternal):
      (WebCore::LayerRendererChromium::getFramebufferPixels):
      (WebCore::LayerRendererChromium::cleanupSharedObjects):
      (WebCore::LayerRendererChromium::layerTreeAsText):
      * platform/graphics/chromium/LayerRendererChromium.h:
      (WebCore::LayerRendererChromium::rootLayer):
      (WebCore::LayerRendererChromium::viewportSize):
      (WebCore::LayerRendererChromium::viewportWidth):
      (WebCore::LayerRendererChromium::viewportHeight):
      * platform/graphics/chromium/NonCompositedContentHost.cpp: Added.
      (WebCore::NonCompositedContentHost::NonCompositedContentHost):
      (WebCore::NonCompositedContentHost::~NonCompositedContentHost):
      (WebCore::NonCompositedContentHost::invalidateRect):
      (WebCore::NonCompositedContentHost::invalidateEntireLayer):
      (WebCore::NonCompositedContentHost::setScrollPosition):
      (WebCore::NonCompositedContentHost::notifyAnimationStarted):
      (WebCore::NonCompositedContentHost::notifySyncRequired):
      (WebCore::NonCompositedContentHost::paintContents):
      (WebCore::NonCompositedContentHost::showDebugBorders):
      (WebCore::NonCompositedContentHost::showRepaintCounter):
      * platform/graphics/chromium/NonCompositedContentHost.h: Added.
      (WebCore::NonCompositedContentHost::create):
      (WebCore::NonCompositedContentHost::graphicsLayer):
      * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
      (WebCore::CCHeadsUpDisplay::draw):
      * platform/graphics/chromium/cc/CCLayerImpl.h:
      (WebCore::CCLayerImpl::scrollPosition):
      (WebCore::CCLayerImpl::setScrollPosition):
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      (WebCore::CCLayerTreeHost::CCLayerTreeHost):
      (WebCore::CCLayerTreeHost::initialize):
      (WebCore::CCLayerTreeHost::invalidateRootLayerRect):
      (WebCore::CCLayerTreeHost::setRootLayer):
      (WebCore::CCLayerTreeHost::setViewport):
      (WebCore::CCLayerTreeHost::reallocateRenderer):
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      (WebCore::CCLayerTreeHost::rootLayer):
      (WebCore::CCLayerTreeHost::viewportSize):
      
      Source/WebKit/chromium:
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::paint):
      (WebKit::WebViewImpl::setRootGraphicsLayer):
      (WebKit::WebViewImpl::didRecreateGraphicsContext):
      (WebKit::WebViewImpl::updateLayerTreeViewport):
      * src/WebViewImpl.h:
      
      LayoutTests:
      
      Update pixel baselines that changes due to subtle blending
      differences, primarily on scrollbars. I don't know why these keep
      changing.
      
      * compositing/checkerboard-expected.png:
      * platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
      * platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
      * platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
      * platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
      * platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
      * platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
      * platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
      * platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
      * platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
      * platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
      * platform/chromium-gpu-linux/media/video-zoom-expected.png:
      * platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93329 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a280e074
    • thakis@chromium.org's avatar
      Fix "missing return" gcc warning in ScrollAnimatorNone · b1d8202a
      thakis@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66480
      
      Reviewed by Tony Chang.
      
      * platform/ScrollAnimatorNone.cpp:
      (WebCore::ScrollAnimatorNone::PerAxisData::curveAt):
      (WebCore::ScrollAnimatorNone::PerAxisData::curveDerivativeAt):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93328 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b1d8202a
    • commit-queue@webkit.org's avatar
      [GTK] [WK2] Activating sub menus cause the WebProcess to crash · 22dc6040
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66471
      
      Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-18
      Reviewed by Anders Carlsson.
      
      * UIProcess/gtk/WebContextMenuProxyGtk.cpp:
      (WebKit::WebContextMenuProxyGtk::createGtkMenu):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93327 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      22dc6040
    • simonjam@chromium.org's avatar
      Revalidate expired resources if they're requested after the initial document load · 37288fed
      simonjam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52153
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      Test: http/tests/cache/subresource-multiple-instances.html
      
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::determineRevalidationPolicy):
      
      LayoutTests:
      
      * http/tests/cache/subresource-multiple-instances-expected.txt: Added.
      * http/tests/cache/subresource-multiple-instances.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93326 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      37288fed
    • tony@chromium.org's avatar
      [chromium] Marking tests needing win/linux baselines as such in · 6784f325
      tony@chromium.org authored
      test_expectations.txt.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93325 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6784f325
    • rniwa@webkit.org's avatar
      Dump-as-markup conversion: editing/pasteboard/block-wrappers-necessary.html · dadb85e1
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66420
      
      Reviewed by Kent Tamura.
      
      Converted the test.
      
      * editing/pasteboard/block-wrappers-necessary-expected.txt: Added.
      * editing/pasteboard/block-wrappers-necessary.html:
      * platform/chromium-cg-mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
      * platform/chromium-linux/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
      * platform/chromium-win-vista/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
      * platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
      * platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
      * platform/gtk/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
      * platform/gtk/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
      * platform/mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
      * platform/mac/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
      * platform/mac/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
      * platform/qt/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
      * platform/qt/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93324 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dadb85e1
    • rniwa@webkit.org's avatar
      Dump-as-markup conversion: editing/pasteboard/5368833.html · 8cee4de8
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66416
      
      Reviewed by Kent Tamura.
      
      Converted the test and also renamed the test to a more descriptive name.
      
      * editing/pasteboard/5368833.html: Removed.
      * editing/pasteboard/paste-blockquote-and-paragraph-break-expected.txt: Added.
      * editing/pasteboard/paste-blockquote-and-paragraph-break.html: Copied from LayoutTests/editing/pasteboard/5368833.html.
      * platform/chromium-linux/editing/pasteboard/5368833-expected.png: Removed.
      * platform/chromium-win/editing/pasteboard/5368833-expected.png: Removed.
      * platform/chromium-win/editing/pasteboard/5368833-expected.txt: Removed.
      * platform/gtk/editing/pasteboard/5368833-expected.txt: Removed.
      * platform/mac-leopard/editing/pasteboard/5368833-expected.png: Removed.
      * platform/mac/editing/pasteboard/5368833-expected.png: Removed.
      * platform/mac/editing/pasteboard/5368833-expected.txt: Removed.
      * platform/qt/editing/pasteboard/5368833-expected.txt: Removed.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93323 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8cee4de8
    • tony@chromium.org's avatar
      Update chromium gpu expected results after r93275. · 89a4089c
      tony@chromium.org authored
      * platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png: Removed.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93322 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      89a4089c
    • tony@chromium.org's avatar
      Update baselines for mac and win after test changes/fixes in r93275. · 5e9ddebf
      tony@chromium.org authored
      * platform/chromium-cg-mac/fast/canvas/canvas-composite-expected.png:
      * platform/chromium-win/fast/canvas/canvas-composite-expected.png:
      * platform/chromium-win/fast/canvas/canvas-composite-transformclip-expected.png: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93321 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5e9ddebf
    • tony@chromium.org's avatar
      Add checksums to png results. Still trying to find out why they · 82098f02
      tony@chromium.org authored
      went missing in the first place.
      
      * fast/frames/frame-set-scaling-3d-expected.png:
      * fast/frames/frame-set-scaling-centered-expected.png:
      * fast/frames/frame-set-scaling-expected.png:
      * fast/frames/frame-set-scaling-rotate-expected.png:
      * fast/frames/frame-set-scaling-skew-expected.png:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93320 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      82098f02
    • andersca@apple.com's avatar
      Fix libc++ C++0x build · b6cf14aa
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66479
      
      Reviewed by Adam Roben.
      
      Add missing includes.
      
      * DumpRenderTree/LayoutTestController.cpp:
      * DumpRenderTree/mac/CheckedMalloc.cpp:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93319 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b6cf14aa
    • rniwa@webkit.org's avatar
      dump-as-markup conversion: editing/pasteboard/testcase-9507.html · 3caf3c36
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66448
      
      Reviewed by Kent Tamura.
      
      Converted the test.
      
      * editing/pasteboard/testcase-9507-expected.txt: Added.
      * editing/pasteboard/testcase-9507.html:
      * platform/chromium-linux/editing/pasteboard/testcase-9507-expected.png: Removed.
      * platform/chromium-win/editing/pasteboard/testcase-9507-expected.png: Removed.
      * platform/chromium-win/editing/pasteboard/testcase-9507-expected.txt: Removed.
      * platform/gtk/editing/pasteboard/testcase-9507-expected.png: Removed.
      * platform/gtk/editing/pasteboard/testcase-9507-expected.txt: Removed.
      * platform/mac-leopard/editing/pasteboard/testcase-9507-expected.png: Removed.
      * platform/mac/editing/pasteboard/testcase-9507-expected.png: Removed.
      * platform/mac/editing/pasteboard/testcase-9507-expected.txt: Removed.
      * platform/qt/editing/pasteboard/testcase-9507-expected.txt: Removed.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93318 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3caf3c36
    • andersca@apple.com's avatar
      More C++0x libc++ build fixes · 1952a0a6
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66476
      
      Reviewed by Adam Roben.
      
      * Plugins/Hosted/NetscapePluginHostProxy.mm:
      (WKPCSetException):
      Use a WTF String here instead of an STL string.
      
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
      std::make_pair now takes rvalue references, so get rid of the template arguments and let
      the compiler deduce them instead.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93317 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1952a0a6
    • andersca@apple.com's avatar
      Fix clang libc++ C++0x build · 857c37fd
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66475
      
      Reviewed by Adam Roben.
      
      Remove calls to isnan and isfinite with integer arguments.
      
      * css/CSSPrimitiveValue.cpp:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore::WebGLRenderingContext::viewport):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93316 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      857c37fd
    • aroben@apple.com's avatar
      Update the device scale factor when the WebView's window changes · 4a6023cd
      aroben@apple.com authored
      Fixes <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
      WebView is moved between windows with different backing scale factors
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit/mac:
      
      * WebView/WebView.mm:
      (-[WebView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
      window at all) might have a different backing scale factor than the previous one.
      (-[WebView _deviceScaleFactor]): Moved to the WebFileInternal category.
      
      Source/WebKit2:
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
      window at all) might have a different backing scale factor than the previous one.
      (-[WKView _deviceScaleFactor]): Moved to the new FileInternal category.
      
      Tools:
      
      Test that WebKit updates style when a WebView is moved between differently-scaled windows
      
      * TestWebKitAPI/JavaScriptTest.cpp:
      (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
      (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
      gtest's built-in error messages.
      
      * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
      WKView * for convenience on Mac. Added compareJSResult helper function for implementing
      those overloads.
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
      
      * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
      (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
      (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
      (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
      (TestWebKitAPI::setPageLoaderClient): Set up the client.
      (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
      (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
      SyntheticBackingScaleFactorWindow and returns it.
      (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
      that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
      window, is moved to a differently-scaled window, and is taken out of the window.
      (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
      WebKit1 and WebKit2.
      (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
      
      * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
      
      * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
      (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
      
      * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
      * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
      (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
      initializer.
      (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
      
      (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
      (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
      Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93315 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4a6023cd
    • aroben@apple.com's avatar
      Make WebPageProxy keep track of the current device scale factor · 3ff27805
      aroben@apple.com authored
      The device scale factor is no longer considered part of WebPageProxy's "view state". It now
      has its own setter/getter. This made the code a little simpler and more similar to the page
      scale factor. Each port-specific WebKit2 view is now responsible for calling
      WebPageProxy::setDeviceScaleFactor whenever it thinks the device scale factor might have
      changed.
      
      Fixes <http://webkit.org/b/66466> WebKit2 requires every port-specific view to keep track of
      the current device scale factor
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/API/efl/PageClientImpl.cpp:
      * UIProcess/API/efl/PageClientImpl.h:
      * UIProcess/API/gtk/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      * UIProcess/PageClient.h:
      * UIProcess/qt/QtWebPageProxy.h:
      * UIProcess/win/WebView.h:
      Removed deviceScaleFactor.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _deviceScaleFactor]): Added. Code came from PageClientImpl::deviceScaleFactor.
      (-[WKView _windowDidChangeResolution:]): Changed to call WebPageProxy::setDeviceScaleFactor.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::WebPageProxy): Initialize m_deviceScaleFactor.
      (WebKit::WebPageProxy::viewStateDidChange): Removed device-scale-factor-related code.
      (WebKit::WebPageProxy::setDeviceScaleFactor): Added. Records the new device scale factor and
      tells the DrawingAreaProxy about it if it's actually changed.
      (WebKit::WebPageProxy::creationParameters): Use m_deviceScaleFactor instead of calling out
      to the PageClient.
      
      * UIProcess/WebPageProxy.h: Added m_deviceScaleFactor and setDeviceScaleFactor, which
      replaces the DeviceScaleFactor ViewStateFlag.
      (WebKit::WebPageProxy::deviceScaleFactor): Inlined this now-simple getter.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93314 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3ff27805