GitLab

API still not implemented.

BUG=None
TEST=Check there is no exception on attempt to pin a file.


Review URL: http://codereview.chromium.org/9696029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126714 0039d316-1c4b-4281-b951-d872f2087c98

Add BluetoothAdapter::GetDevice() so that the options handler can
retrieve a BluetoothDevice* for an address that it receives from
JavaScript, so it doesn't have to cache structures by itself.

Include a reference to the owning BluetoothAdapter* in BluetoothDevice
since the underlying CreateDevice and CreatePairedDevice method calls
are actually made on adapter clients, and need its object path. Make
BluetoothDevice a friend of BluetoothAdapter so it can retrieve that
object path (we don't want anything D-Bussy in the public API).

BluetoothDevice gains a BluetoothAgentServiceProvider member which is
set during pairing, and implements BluetoothAgentServiceProvider::Delegate
to receive the method calls passing them on to BluetoothOptionsHandler
via the BluetoothDevice::PairingDelegate interface it implements.

Rather than require the options handler to deal with callbacks, cache the
service provider callbacks within BluetoothDevice so that replies are done
with ordinary method calls asynchronously.

Use a weak pointer factory in BluetoothOptionsHandler in case error callbacks
are called after destruction. Declare constants for strings between the C++
code and JavaScript at the top, rather than inline.

Clean up JavaScript code to disambiguate "connect" vs. "accept" and
"cancel" vs. "reject".

BUG=chromium-os:21320
TEST=extensively on device

Change-Id: I941ca42f676e7a6e557c657b6213a74429eb4376


Review URL: http://codereview.chromium.org/9694054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126713 0039d316-1c4b-4281-b951-d872f2087c98

Now that all the new tests have landed, the old versions can be
removed. Also removes data files which are Chrome OS only, we can
add it back to ChromeOS specific tests when we have those.

BUG=110779,106263
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9666032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126712 0039d316-1c4b-4281-b951-d872f2087c98

In the File Browser if there are several actions available for a file then the most recently used one becomes the default (it is invoked on double click etc). On a fresh profile when all timestamps are equal this is a matter of chance. 
The patch gives higher priority to the actions of the File Browser (only as long as timestamps are equal).

BUG=chromium-os:27216
TEST=Start on a fresh profile, observe that "View" is shown for an image file, not "Upload to Picasa"


Review URL: http://codereview.chromium.org/9692049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126711 0039d316-1c4b-4281-b951-d872f2087c98

The new button assets have sharper edges, which better matches the look of the frame.  They are also more tightly spaced.

BUG=117433
TEST=visual

Review URL: https://chromiumcodereview.appspot.com/9707001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126710 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Careful review by Mark. And a unittest.


Review URL: http://codereview.chromium.org/9706001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126709 0039d316-1c4b-4281-b951-d872f2087c98

The macro usage as-is would evaluate the whole content of the if-statement for HANDLE_EINTR, instead of just the write(...) part - as a result, EINTR will not be handled

CID=103483
BUG=none
TEST=none


Review URL: http://codereview.chromium.org/9689034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126708 0039d316-1c4b-4281-b951-d872f2087c98

This change *must* be accompanied by (internal) changes that add Flapper to and
remove NPAPI Flash from the packages.


Review URL: http://codereview.chromium.org/9703028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126707 0039d316-1c4b-4281-b951-d872f2087c98

---

ash uber tray: Add the detailed network popup

BUG=110130, 109480
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9664056

TBR=sadrul@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9702035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126706 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9703035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126705 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9706030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126704 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9707002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126703 0039d316-1c4b-4281-b951-d872f2087c98

The fix is to ensure we do not miss calling MessageLoopForUI::RemoveObserver() in both destructors.

BUG=117278
TEST=Manual verify both destructors contain the call.


Review URL: http://codereview.chromium.org/9692070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126702 0039d316-1c4b-4281-b951-d872f2087c98

This fixes an oversight in r117285.  That commit should have included
these changes, but the diffs were accidentally misplaced.

Prior to this commit, all PostCommitMessage tasks would seem to have
succeeded.  However, this bug did not affect the return values from
ProcessCommitResponseCommand, so the syncer should be able to detect
commit failures even without this fix.

BUG=117893
TEST=


Review URL: http://codereview.chromium.org/9695016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126701 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110130, 109480
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9664056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126700 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106763
Review URL: https://chromiumcodereview.appspot.com/9706004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126698 0039d316-1c4b-4281-b951-d872f2087c98

If the DnsConfig is available, we can serve the requests synchronously in Resolve. However, we might not receive the DnsConfig until the Job is placed in the queue. In that case, we attempt to serve the jobs once DnsConfig is available.

BUG=114826
TEST=./net_unittests --gtest_filter=HostResolverImplTest.ServeFromHosts

Original review: https://chromiumcodereview.appspot.com/9667025/


Review URL: http://codereview.chromium.org/9705017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126697 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:26924
TEST=Open file manager, verify if progress bar behaves as described in 26924


Review URL: http://codereview.chromium.org/9652024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126694 0039d316-1c4b-4281-b951-d872f2087c98

Move the dependency to the base target, causing Java to be compiled on all
configurations (including trybots and the main waterfall bot). We currently
build two source files.

BUG=
TEST=Build output should execute the "base_java" action.

Review URL: http://codereview.chromium.org/9699018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126693 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=ExtensionFileBrowserPrivateApiTest.*

Review URL: https://chromiumcodereview.appspot.com/9695035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126692 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117587
TEST=build chrome, make sure cloud print from incognito window brings up a proper login dialog

Review URL: https://chromiumcodereview.appspot.com/9689075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126691 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/9704016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126690 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117959
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9705010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126689 0039d316-1c4b-4281-b951-d872f2087c98

staged: http://goto.google.com/jojso
BUG=12133

Review URL: http://codereview.chromium.org/9452019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126688 0039d316-1c4b-4281-b951-d872f2087c98

TBR=akalin@chromium.org
BUG=118203
TEST=waterfall.sh

Review URL: https://chromiumcodereview.appspot.com/9705028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126687 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:118115
TEST=Open the Wi-Fi and Cellular drop-downs from the main settings page.  Confirm resources correctly updated.

Review URL: https://chromiumcodereview.appspot.com/9704013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126686 0039d316-1c4b-4281-b951-d872f2087c98

 This is clone of issue 9689027, which I can't access due to some internal error.

BUG=115510
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9699013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126685 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126684 0039d316-1c4b-4281-b951-d872f2087c98

Includes many upstream h264 fixes as well.

ffmpeg_revision:
http://src.chromium.org/viewvc/chrome?view=rev&revision=126470

ffmpeg_hash:
http://git.chromium.org/gitweb/?p=chromium/third_party/ffmpeg.git;a=commit;h=ddcf259fa5fb83159d441bd71f54e617e2a4afd3

Includes the following patches:
ddcf259 Update Windows binaries to pull in latest fixes.
707d08c h264: Fix invalid interlaced/progressive MB combinations for direct mode prediction.
d6e7e28 h264: error out on invalid bitdepth.
8b29ceb h264: prevent overreads in intra PCM decoding.
9d8f016 h264: fix mmxext chroma deblock to use correct TC values.
8052a84 h264: change underread for 10bit QPEL to overread.
f476438 h264: don't use redzone in loopfilter on win64.
400de19 Revert commit c98c1f434 due to webm regression.
ed45601 Move struc FFTContext below SECTION_RODATA
d881f5b Reverts removal of problen check in a2edf3dd.

BUG=117912
TEST=ffmpeg_regression_tests

Review URL: https://chromiumcodereview.appspot.com/9693060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126683 0039d316-1c4b-4281-b951-d872f2087c98

Should make the gpu pixel tests less flaky. This patch make the pixel test wait till the browser window is at the desired size before taking a snapshot.

Bug=None
Test=linux_gpu,win_gpu,mac_gpu try bots
TBR=zmo

Review URL: https://chromiumcodereview.appspot.com/9699028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126682 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117644
TEST=Green trybots
Review URL: https://chromiumcodereview.appspot.com/9696018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126681 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/9701008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126680 0039d316-1c4b-4281-b951-d872f2087c98

TBR=erg@chromium.org
BUG=118196
TEST=waterfall.sh went from 53 to 0 leaks with Password

Review URL: https://chromiumcodereview.appspot.com/9700027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126679 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126678 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9600052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126677 0039d316-1c4b-4281-b951-d872f2087c98

Binary file commit in preparation for a CL to update the toolbar on Ash.

BUG=none
TEST=none
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9705022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126675 0039d316-1c4b-4281-b951-d872f2087c98

This requirement has been removed in FIPS 198-1.

R=rsleevi@chromium.org
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9695058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126674 0039d316-1c4b-4281-b951-d872f2087c98

Exclude IndexedDBUILayoutTest.WorkerLayoutTests on Valgrind Mac b/c it's failing like IndexedDBUILayoutTest.LayoutTests

BUG=110612
TBR=dgrogan@chromium.org
TEST=

Review URL: https://chromiumcodereview.appspot.com/9706026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126673 0039d316-1c4b-4281-b951-d872f2087c98

R=ben@chromium.org
BUG=117682
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9702024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126672 0039d316-1c4b-4281-b951-d872f2087c98

R=ben@chromium.org
BUG=118116
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9706007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126671 0039d316-1c4b-4281-b951-d872f2087c98