- 17 Jul, 2018 40 commits
-
-
jdoerrie authored
Similarly to r574552 this change moves the map of descriptors from the platform implementations to the BluetoothRemoteGattCharacteristic base class. In addition, default implementations for GetDescriptor() and GetDescriptors() are provided. Lastly, this change cleans up a few lint errors, mostly missing includes. Bug: 821766 Change-Id: Iada71c198d241acf3bddcc1414ff89aa150c1c84 Reviewed-on: https://chromium-review.googlesource.com/1136296Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#575603}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0c5d09a8e978..9e945c84d2be git log 0c5d09a8e978..9e945c84d2be --date=short --no-merges --format='%ad %ae %s' 2018-07-17 manojgupta@google.com cros_chrome_sdk: Use cros nm for target builds. Created with: gclient setdep -r src/third_party/chromite@9e945c84d2be The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I728eb50ce12cb807ca24f04ae25cffd769e7d57a Reviewed-on: https://chromium-review.googlesource.com/1139916Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575602}
-
Leszek Swirski authored
Bug: chromium:823663 Change-Id: I228aab31b4f152e0edc8310d3f4674a7f2022964 Reviewed-on: https://chromium-review.googlesource.com/1138617Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#575601}
-
Rakina Zata Amni authored
We previously implemented constructable CSSStyleSheet synchronously, but discussions in https://github.com/WICG/construct-stylesheets/issues/2 have gravitated away from that and we are now interested in asynchronous creation of CSSStyleSheet. This CL added Document.createCSSStyleSheet that returns a Promise<CSSStyleSheet>, while also removing the exposed CSSStyleSheet that was previously exposed. Note that because CSS parsing is still done on the main thread, this function is actually still blocking. The previously implemented CSSStyleSheet is changed to only produce empty CSSStyleSheets in this CL: crrev.com/c/1126898 Bug: 807560 Change-Id: I9f9d17ae04829ff399ae384f8b3a6d97a3b0613b Reviewed-on: https://chromium-review.googlesource.com/1126754 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#575600}
-
Takayoshi Kochi authored
This was implemented in crbug.com/633007 but was never adopted by any standards, and could not get much attention from developers except for testing use cases. As this was dismissed from the standard, we have to pursue the testing use cases in other forms. Bug: 829713 Change-Id: I2b053a15e96d68ff5a8c632e65b7b2feefb15dab Reviewed-on: https://chromium-review.googlesource.com/999453Reviewed-by:
-
Markus Heintz authored
Bug: 850161 Change-Id: I1fdb08aa752c5297e59245065830955447e01cf1 Reviewed-on: https://chromium-review.googlesource.com/1127163 Commit-Queue: Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#575598}
-
Vadym Doroshenko authored
This CL is implementation of overriding of prefilled values in username fields if the server believes that these values are placeholders. The life of server prediction for filling prefilled values is the following (it's called may_use_prefilled_placeholder in code): 1. The server sends it and it's propagated as part of FormStructure to FormParser (it's implemented before this CL). 2. It's parsed in password_field_prediction.cc to PasswordFieldPrediction 3. FormParser puts it to PasswordForm. 4. In password_form_fill_data.cc it's propagated to PasswordFormFillData 5. It's sent to the renderer over MOJO 6. PasswordAutofillAgent uses it to override prefilled values if any. The reason of putting processing may_use_prefilled_placeholder in FormParser not in NewPasswordFormManager is that NewPasswordFormManager should know nothing about form structure, it's FormParser responsibility to process it. Small deletion of dead code is done: parameter |set_selection| from FillUserNameAndPassword, since it's never set to true. Bug: 847793, 831123 Change-Id: Id86d0992428e520718a6ab6e9f50e8064444d030 Reviewed-on: https://chromium-review.googlesource.com/1124474 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#575597}
-
Javier Fernandez authored
Leading white-spaces are indeed breaking opportunities that should prevent, if there are no other css properties forcing it, breaking text in the middle of a word when honoring the word-wrap/overflow-wrap CSS property. We are doing so if the leading white-space sequence is longer than 1 character, but when we have a single leading white-space, we are missing that breaking opportunity and we may lead to cases, like the one described in the bug. However, this breaking opportunity should be considered together with other provided by the word-break CSS property (eg, break-word or break-all). There is a discussion [1] in the CSS WG github about this issue, which provides an interoperability analysis of a few cases where a single leading white-space character may produce different results, depending on the browser and the combination of line-breaking properties. [1] https://github.com/w3c/csswg-drafts/issues/2907 Bug: 854624 Change-Id: I49ec8282e899a32990662c104b48cab04057b909 Reviewed-on: https://chromium-review.googlesource.com/1130515 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#575596}
-
Yuichiro Hanada authored
This CL introduces InputMethodSurface class for handling input method surface role. Also the version of remote_shell interface is bumped to 17. Bug: 845079 Test: Ran on DUT. Change-Id: I79d26a941deb621c5155e53ad6989414a6bd3614 Reviewed-on: https://chromium-review.googlesource.com/1131052 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#575595}
-
Matt Falkenhagen authored
The file has many tests. Give it a long timeout. Bug: 863160 Change-Id: Idfad60c6e088b97bdc279c648037ecbf5d33861f Reviewed-on: https://chromium-review.googlesource.com/1139935Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#575594}
-
Kenichi Ishibashi authored
These are not recorded when S13nServiceWorker is enabled. Bug: 852673 Change-Id: I0dd94ec089e7a6e36b0cc9fbc2ee85078e622725 Reviewed-on: https://chromium-review.googlesource.com/1119738Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#575593}
-
Kenichi Ishibashi authored
When we load subresorces from the main thread and dedicated workers we use RenderViewImpl's RendererPreferences to check DNT header should be set or not. Since RenderViewImpl may not be available for service workers we need another way to pass RendererPreferences from browser to renderer. This CL adds a method to ContentBrowserClient to get RendererPreferences from chrome/ to content/, and piggybacks the preferences in EmbeddedWorkerStartParams to populate it from browser to renderer. Bug: 853085 Change-Id: Ibdd6bac46bbf0e27c02866f496482041e8789138 Reviewed-on: https://chromium-review.googlesource.com/1130967 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Javier Fernandez authored
We should not extend selection looking for special elements if the delete operation has been triggered by a caret based selection. This change is based on a recent [1] resolution of the Editing TF, which acknowledges that behavior of single-cell tables must be the same that multi-cell tables and even if the last character is deleted, we should not delete the whole table structure. A different case would be when the user actively selects the whole content of a table; in this case, as we do in multi-cell tables, the structure of single-cell tables should be deleted together with the content. [1] https://github.com/w3c/editing/issues/163 Bug: 731320 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8c3e4efcc63410bf30b4889a715d92e9dda8189b Reviewed-on: https://chromium-review.googlesource.com/1126255 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575591}
-
Mark Cogan authored
This CL updates the tab grid transitions to cleanly match the presented tab views. The basic abstraction for this transition is the GridToTabTransitionView protocol which defines a set of 'cell' and 'tab' views, and methods to lay them out. The general idea is that a view conforming to this protocol can either be in 'cell' mode (where it exactly matches a tab grid cell), or in 'tab' mode (where it exactly matches an open tab). Most of the work is done by the GridTransitionCell subclass of GridCell, which positions and scales the "tab" and "cell" views it is supplied with so they animate smoothly. All of this positioning/scaling logic is internal to that class and nothing else depends on it. Providing the transition cell with the tab views is handled in the transition animator, mostly leveraging the content area layout guide. This doesn't require any direct integration with the tab view (that is, the BVC) beyond that layout guide. Approaches I abandoned: - letting -layoutSubviews position the tab/grid views. The problem with this approach (which is much cleaner from an API perspective) is that the timing of the layout passes is unpredictable, it it resulted in changes being made that weren't fully animated (for example, subviews would be scaled and positioned without animation, and then the superview would scale with an animation). - using layout constraints for GridTransitionCell's tab views. This is probably the correct thing to do long-term; mostly this was a decision made under time constraints, but since ultimately animating constraint changes depends on -layoutSubviews being called at the right times, I did have some concerns given the difficulties described above. It's unfortunate that grid_cell.mm is mixing constraint- and frame-based layout, but it is confined to that single file. Bug: 851460, 850507, 862343 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If6d55f14aa05e705143547b61773fdb34796ad2d Reviewed-on: https://chromium-review.googlesource.com/1136647 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#575590}
-
Mark Cogan authored
Per the bug, add corner rounding and change the scale of the reduced motion animation. Note that this CL uses 26px corner radius for better visibility given how brief the animation is. Bug: 851871 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9f2c3b02ce53abed3570f33a09017ee7a9273ed1 Reviewed-on: https://chromium-review.googlesource.com/1138618Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#575589}
-
Mark Cogan authored
This CL fixes the problem of the tab grid (the root view controller) being briefly visible when the app launches. Note that this problem isn't simply a matter of the initial tab view controller (the BVC) being presented with an animation at launch; even if the presentation isn't animated, the tab grid is visible for several frames as the app launches. The fix in this CL is to (again) insert the launch image view on top of the tab grid during launch. This is done inside the TabGridCoordinator. If the launch view is present, the presentation of the tab view controller isn't animated. The launch view is removed the first time a presentation completes, and it is never added again. There are a few problems with this approach that should be resolved after M69 launches: - Futzing around with view hierarchies isn't something a coordinator should do. I'm doing it that way here because it at least keeps things well-contained. - Jamming the launch view in to spackle over UIKit glitches is getting kind of old. Bug: 826288 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I701b550f9eef16452a608b839c9a321b6b7a966a Reviewed-on: https://chromium-review.googlesource.com/1138329Reviewed-by:
-
Mikel Astiz authored
This reverts commit 1e3235b3. Reason for revert: suspect for breaking webkit_layout_tests on Mac, e.g. test offset-from-point-complex-scripts.html. Bug: 864405 Original change's description: > Add support for mid ligature positions > > Makes XPositionForOffset and CharacterIndexForPosition support > return results inside a ligature glyph (while still not breaking ZWJs) > by using a character-based TextBreakIterator inside glyphs. > > Bug: 473476 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I723cc8ba081958ff2d470d3e73ead6cbe327cf60 > Reviewed-on: https://chromium-review.googlesource.com/1085554 > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Commit-Queue: Fernando Serboncini <fserb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575496} TBR=eae@chromium.org,kojii@chromium.org,drott@chromium.org,fserb@chromium.org Change-Id: Id20c3aca9139d65e4187009e7ef7b45f87cceb5e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 473476 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1140073Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575587}
-
Ned Nguyen authored
Bug:863767 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ibe182c3bc7acaf9a0519da2eb365e443df460d68 TBR=perezju@chromium.org Change-Id: Ibe182c3bc7acaf9a0519da2eb365e443df460d68 Reviewed-on: https://chromium-review.googlesource.com/1138407Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#575586}
-
Sergei Datsenko authored
If feature flags has changed drivefs may need a restart before it's able to serve requests. In this case mounting will fail. Make browser handle this situation by retrying after some time. BUG=chromium:845390,chromium:845388 Change-Id: I0d4cdcf0e981b0966a23d91d3dc6fd30a32fb927 Reviewed-on: https://chromium-review.googlesource.com/1139943Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#575585}
-
Alexey Khoroshilov authored
Bug: 849582 Change-Id: I6e75d9a62b4b58569c2c29b913c0a6a0cab0bf83 Reviewed-on: https://chromium-review.googlesource.com/1139057Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Alexey Khoroshilov <sense@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#575584}
-
Sergey Poromov authored
In order to ensure investigation of the issue when extensions are not yet loaded after 5 minutes (timeouted), double-check pending list. For the case if there are policy configured extensions that are installed, but not loaded, new metrics will be reported: Extensions.ForceInstalledTimedOutAndNotInstalledCount BUG=787970 TEST=Unit tests updated Change-Id: I2ade477fe96e9b32546c4ce819c4316ff31b17bd Reviewed-on: https://chromium-review.googlesource.com/1135246 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I533bb35d10dcf5a35ee0ab8abc1d855fed0df256 Reviewed-on: https://chromium-review.googlesource.com/1139905Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575582}
-
Alexey Baskakov authored
Modernize it. Add unit test. Bug: 860581 Change-Id: I136f85f234a843321b49976659f37aa2865ba318 Reviewed-on: https://chromium-review.googlesource.com/1139844 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#575581}
-
Ioana Pandele authored
This CL: - Adds 24dp spacing in between the generated password text view and the explanation text view. - Changes the padding of the generation dialog's custom view layout to 24dp. - Changes the text line height to 20sp. - Changes the appearance of the generated password text. Bug: 835234 Change-Id: I4e9a683298674ab81e67fb08c39a9d5dcdd3e3b3 Reviewed-on: https://chromium-review.googlesource.com/1138327Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#575580}
-
Yutaka Hirano authored
With this CL, CORSURLLoader::fetch_cors_flag_ which represents the CORS flag in the spec will not be set if the request's mode is "no-cors". This CL also fixes how the origin header is attached. Bug: 736308 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I9cc510377ad97ec0ac99039e98b888e1eb91f2f6 Reviewed-on: https://chromium-review.googlesource.com/1139938Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#575579}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9fb90f83997a..bf2a980d03db git log 9fb90f83997a..bf2a980d03db --date=short --no-merges --format='%ad %ae %s' 2018-07-17 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@bf2a980d03db The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I8a791798941543b77cddb1db60fb00c7d54f43f8 Reviewed-on: https://chromium-review.googlesource.com/1139913Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575578}
-
Ramin Halavati authored
Switch EnableEphemeralFlashPermission switch's default value to true. Bug: 850062 Change-Id: I42cc3adb918f9c0e95d5ad17f08577d6149b3999 Reviewed-on: https://chromium-review.googlesource.com/1138238 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#575577}
-
Mikel Astiz authored
This reverts commit 02a52f51. Reason for revert: suspect of causing test failures on multiple bots for test flexbox-with-overflow-auto-child-crash.html. Bug: 864402 Original change's description: > [layoutng] Use the correct layout algorithm to compute min/max sizes > > This also required adding a check in NGBlockNode::ComputeMinMaxSize > for whether we are inside of PerformLayout -- on Mac, we can > compute preferred sizes outside of layout; however, we can't do > actual layout in that case, so we have to fallback to legacy > min/max size in this case (c.f. RenderViewImpl::CheckPreferredSize()) > > Bug: 635619 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: I0caf0c6c79264074ccaf9f45b83a420950dab715 > Reviewed-on: https://chromium-review.googlesource.com/1131562 > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575545} TBR=cbiesinger@chromium.org,ikilpatrick@chromium.org,mstensho@chromium.org Change-Id: I02d8cbfe883bafb2a3780ec46bd11b9e786678f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1140033Reviewed-by:
-
Kent Tamura authored
We'd like to fix a confusing UI issue, and to know the impact of a possible fix. Bug: 637639 Change-Id: I7af67ac314f61723c7904cf0fee408ac2b60e774 Reviewed-on: https://chromium-review.googlesource.com/1139940 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#575575}
-
Luciano Pacheco authored
Change tests that interact with Drive to expand it when needed. Bug: 864291 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ibd013801c4bb5c1d1f3224707090eaf7ff0009a6 Reviewed-on: https://chromium-review.googlesource.com/1139848 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#575574}
-
Mikel Astiz authored
This reverts commit 6be34509. Reason for revert: suspect for webkit_layout_tests failures on MSAN, complaining about use-of-uninitialized-value, e.g.: https://chromium-swarm.appspot.com/task?id=3ebe376bfe81a410&refresh=10&show_raw=1 Bug: 864399 Original change's description: > Prevents compositor frames from being sent when SurfaceLayer is not visible. > > This CL is 3/3 in effort to fix the regressions caused by sending > unneeded compositor frames. > > This CL provides a signal from the SurfaceLayerImpl to the VideoFrameSubmitter > to prevent compositor frames from being sent at undesired times (occlusion, not > being added into the layer tree). > > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I428860047eaf4c50abc2e662914a643158f1276b > Reviewed-on: https://chromium-review.googlesource.com/1101708 > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Justin Novosad <junov@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575462} TBR=dcheng@chromium.org,enne@chromium.org,fsamuel@chromium.org,junov@chromium.org,mlamouri@chromium.org,liberato@chromium.org,lethalantidote@chromium.org Change-Id: If2870c03ec0f46546d098cb3fae65edee5b3d772 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1139993Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8b9b9154. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21474 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/overflow-wrap TBR=robertma No-Export: true Change-Id: Ie749854f3c165f68c9301408cbd531e412be840f Reviewed-on: https://chromium-review.googlesource.com/1139899 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#575572}
-
Colin Blundell authored
Part of the porting of //components/gcm_driver to use IdentityManager rather than SigninManager and ProfileOAuth2TokenService. This particular change is completely straightforward, with GCMProfileService's helper class IdentityObserver observing IdentityManager rather than SigninManager. Bug: 809923 Change-Id: I821893895b2b122cec852a5bbe0c62f1a0b52670 Reviewed-on: https://chromium-review.googlesource.com/1113926 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#575571}
-
Haruka Matsumura authored
This CL adds the destructor in order to promptly freed stack-allocated HeapHashCollections, and also added tests to check it work exactly. heap_allocator: We needs to check whether the backing collection is sweep-forbidden when the destructor is called. So, we added this check flag. Bug: 854480 Change-Id: If9fc8324b839714ae978665b6f7540d7f5ea15e4 Reviewed-on: https://chromium-review.googlesource.com/1123969 Commit-Queue: Haruka Matsumura <harukamt@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#575570}
-
Dean Liao authored
As current VideoFrame cannot represent real buffer layout, I propose to add a new class, VideoFrameLayout, to store size of physical buffers codec needs as well as format and coded_size of a frame. Also, it stores stride (bytesperline) per buffer to calculate each color plane's size. BUG=b:110815424 TEST=pass media_unittests --gtest_filter=VideoFrameLayout.* Change-Id: Idf96adff1a5d28d4b60bfb208bb51e197d3292ae Reviewed-on: https://chromium-review.googlesource.com/1114568 Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#575569}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5f74c8ef3938..0c5d09a8e978 git log 5f74c8ef3938..0c5d09a8e978 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 vapier@chromium.org cros lint: respect pylintrc indent-string setting Created with: gclient setdep -r src/third_party/chromite@0c5d09a8e978 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I13a674ae3858ffe8fa1d15a38766c3dcff8bb3ec Reviewed-on: https://chromium-review.googlesource.com/1139914Reviewed-by:
-
Dominick Ng authored
Currently this is to assist with reviewing cleanup and rename CLs only. BUG=None Change-Id: I4a52b12ba2cac157a8611bcc988dc5887f77e7e3 Reviewed-on: https://chromium-review.googlesource.com/1139936Reviewed-by:
-
Matt Falkenhagen authored
This will enable us to disable the optimization via a field trial kill switch if needed. Bug: 854905 Change-Id: Ic312cbedd7685761a45fee986061767b14295afa Reviewed-on: https://chromium-review.googlesource.com/1139457Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/381ff28a..f1b3e80f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id4dc8d189707c9eac6591cace44b53550db5ce72 Reviewed-on: https://chromium-review.googlesource.com/1139898Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575565}
-
Matt Falkenhagen authored
There is no evidence of the CHECKs failing. Bug: 857005 Change-Id: I8bb1b4372770987409996739f8c6b051e831809e Reviewed-on: https://chromium-review.googlesource.com/1139837Reviewed-by:
-
