- 02 Oct, 2020 40 commits
-
-
Lukasz Anforowicz authored
1. In navigation-related cases //chrome layer is able to focus the Omnibox itself, without relying on the //content layer. In particular, //chrome layer can trigger focus changes from Browser::UpdateUIForNavigationInTab or FocusTabAfterNavigationHelper. This assertion is reinforced by extra tests added in this CL, where both of the new test cases provide secondary verification that pressing the Home button ends up focusing the omnibox. 2. Controlling the focus from within the //content layer might lead to incorrectly focusing the Omnibox. In particular, when (before this CL) content::RenderFrameHostManager::CommitPending used to call SetFocusToLocationBar it might get incorrect result from RenderFrameHostManager::FocusLocationBarByDefault because of A) unfortunate timing (last committed entry is not yet updated at the time of RFHM::CommitPending) B) fact that pending entry is missing in navigations initiated via RenderFrameProxyHost See https://crbug.com/1127220#c1 (and c2) for more details. Based on 1+2 above, this CL removes the call to SetFocusToLocationBar from content::RenderFrameHostManager::CommitPending. In the future CLs we might want to explore whether the 2 other remaining calls of WebContentsDelegate::SetFocusToLocationBar are necessary and whether WebContentsDelegate::FocusLocationBarByDefault is necessary. This exploration is not needed for fixing the immediate bug at hand. Fixed: 1127220 Change-Id: I06eb2d03163809a7dd7a832ccd9dfd081949ecbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441734 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#813312}
-
Meilin Wang authored
This CL adds handlers for "Learn More" and "Refresh" buttons on the disconnected view. Misc: 1. Minor refactoring on |PhoneHubTrayTest|. 2. Adds initial value for |num_schedule_connection_now_calls_|. BUG=1106937,1126208 TEST=unittested. Change-Id: I3e6c74b331710c1f6607865061f12267f8d27af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439639 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#813311}
-
Darwin Huang authored
Change-Id: I43fd98349c7f049b650615d2f06ea0d071f88689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444069Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813310}
-
Josh Simmons authored
Change-Id: I415223a882f5605189bc72c16b6ddfeba7ff4feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446770Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#813309}
-
Esmael El-Moslimany authored
Only the <iron-icon> elements should be flipped when multiple icons are specified. Bug: 1108272 Change-Id: Ic8fb4772456092fe0150e11df47c61d6a8981eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441479 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#813308}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4258.0-1601290734-benchmark-87.0.4278.0-r1 to 87-4258.0-1601290734-benchmark-87.0.4279.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If4060611c749eb07215c8f1228d5d627d941e20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446587Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813307}
-
Nate Chapin authored
These helpers are fairly thin wrappers around JSEventHandlerForContentAttribute. We still need a static helper to handle the cases where CreateAttributeEventListener() returned nullptr, but merging everything into JSEventHandlerForContentAttribute simplies things overall. Change-Id: I12ebed0dbc1506710588f90d2d88d36bbc6a8a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441017Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#813306}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 87-4265.0-1601286022-benchmark-87.0.4278.0-r1 to 87-4265.0-1601286022-benchmark-87.0.4279.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5c2bc0f4da4c602d17e4963ecc177e14c58e5cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446586Reviewed-by:
-
Moe Ahmadi authored
Fixed: 1130861 Change-Id: I16f50fadf195a3ae6923e630781c36ba17ce7b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439558 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#813304}
-
Xiaohui Chen authored
Add more data type check for backend response. Bug: b:169854546 Test: run locally and start ambient mode with celsius settings Change-Id: If2cd60b363943fe6f3728a9e614a8a1f35431b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444178Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#813303}
-
Alice Wang authored
This CL changes the onPrimaryAccountSet() and onPrimaryAccountCleared() methods to default in IdentityManager.Observer to avoid redundant empty implementation. Bug: 1132873 Change-Id: I573cb7e4e6bb4e4d12217aff1249a9da8f249dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438424Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#813302}
-
Etienne Bergeron authored
This CL is making the TtsPlatformImpl instance a leaky instance since the singleton is alive for the whole duration of the process. The use of WeakPtr is no longer required. Bug: 1133813 Change-Id: I311e8bd354523be7cbdb07d0e87876141ec5e81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441967Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#813301}
-
Etienne Bergeron authored
This CL is making the TtsPlatformImpl instance a leaky instance since the singleton is alive for the whole duration of the process. Bug: 1133813 Change-Id: Iecdf3ea3451308376412d91c3766510364caeaa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441965Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f2fceb9ed0e..39117d2b244e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kelvinjiang@google.com,anthonyvd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kelvinjiang@google.com,anthonyvd@google.com Change-Id: I7321d5d11f9ebe0ef1c50bcf4a65feba45bbfcf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446577Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813299}
-
Jeroen Dhollander authored
Previously the menu boundary changes were not applied if the quick answer views (QuickAnswerView or NotificationView) were still pending, causing the quick answer view to show up too low. Bug: b/168936614 Tests: ash_unittests --gtest_filter="QuickAnswer*" and manually deployed Change-Id: I1f81cbed4d9c5e8e718d556e2763ec9727c5fe36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439538 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4265.0-1601289755-benchmark-87.0.4278.0-r1 to 87-4265.0-1601289755-benchmark-87.0.4279.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7187aa33e62ea31de924e53303bc6eb8faff2de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446585Reviewed-by:
-
Xing Liu authored
This reverts commit b6c9ce8c. Reason for revert: Break tests. Original change's description: > Download later: Enable the feature in field trial config. > > This CL adds download later feature to fild trial json config file. > > TBR=mpearson@chromium.org > > Bug: NONE > Change-Id: I0de7dcb2afeb796ac02083a65a8cf6ee2f205d97 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438576 > Commit-Queue: Xing Liu <xingliu@chromium.org> > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812140} TBR=mpearson@chromium.org,dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: NONE Change-Id: Ia42eb881149a35a274b3e97f16d9adc5884e811c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446193Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813296}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/dcffb3db73cd..ce72574b54b1 2020-10-02 thestig@chromium.org Rename third_party/base/logging.h to check_op.h. 2020-10-02 thestig@chromium.org Remove unneeded logging.h includes. 2020-10-02 thestig@chromium.org Add third_party/base/check.h and notreached.h. 2020-10-01 tsepez@chromium.org Add some missing const to pdf417. 2020-10-01 thestig@chromium.org Fix gcc build for cfgas_stringformatter.cpp. 2020-10-01 tsepez@chromium.org Use vector of cppgc::Member in XFA_ResolveNodeRS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ia56f096ff90b7a7f26d64108d2a6a8220afc3d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446570Reviewed-by:
-
Jan Wilken Dörrie authored
This change drops usages of autofill::PasswordForm in //chrome/browser/ui/passwords in favor of password_manager::PasswordForm. TBR=mamir Bug: 1067347 Change-Id: Idf30b2c8fc2aabd6604212a4977485a8507a74e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445769 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#813294}
-
Joshua Pawlicki authored
This also packages the updater.exe into the same zip. From here, we'll build a thin signing pipeline in the signing service to unpack the zip and run the code. The .exe upload can be removed later once the new system is working. Bug: 926234 Change-Id: Ia23999927519fa93b9164bfac42357d41ae6c422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443216Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#813293}
-
Dave Tapuska authored
Remove APIs that no longer are called. Move APIs that are called by blink to be directly on WebViewImpl if possible. BUG=1097816 Change-Id: Ibab11949b7221774657acde3542590bb3b834294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441964 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#813292}
-
chinsenj authored
This CL changes hardcoded values to use their respective color providers, allowing them to handle light/dark mode. Test: manual Bug: 1127498 Change-Id: I81b7a877dc0aff37d2fe080e6ee15ff73c094704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444489 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
-
Piotr Roguski authored
Adding TracingObserverProto for serializing memory dump in to proto format needed for migration of memory-infra to Perfetto. See crbug.com/1098746 for more details. Bug: 1098746 Change-Id: If78a00672263f0cb061d5f505a62da912c2d7091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324841 Commit-Queue: Piotr Roguski <piotr.roguski@mobica.com> Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#813290}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/be82703d7841..be7345166a4f 2020-10-02 rwkeane@google.com [Discovery] Add Flag to Disable NSEC Record Receiving If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I61dd14b192ee7575b342d1718fb42de230bd0dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445702Reviewed-by:
-
Dylan Cutler authored
This API leaks whether or not a particular Chrome client supports locking device orientation. This bit of information can be used to partially fingerprint users across different origins. The instrumentation reports digests of whether or not screen orientation locking is supported for UKM for us to analyze how much entropy about a user's origin this API leaks. Bug: 973801 Change-Id: I3c89aa6ecdabf166e490f359cb5493a95608d037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443511 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#813288}
-
Andre Le authored
This is a reland of 2e1031ec Original change's description: > [CrOS PhoneHub] Add enable hotspot and locate phone controller to quick > actions UI. > > - Add enable hotspot and locate phone quick actions controllers. > - Connect the controllers to quick actions UI. > - Minor changes in fake tether controller for testing. > > BUG=1106937,1126208 > > Change-Id: I1d4ace03120a4c51fcb351b7c19f33252b3fb81c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428735 > Commit-Queue: Andre Le <leandre@chromium.org> > Reviewed-by: Tim Song <tengs@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812915} Bug: 1106937 Bug: 1126208 Change-Id: Ica4cafc1d2dac4d0c579fcbead6a7b771e35b87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445835 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
-
Jazz Xu authored
This CL extends the freeze timer function to allow the controls freeze between sessions. This will avoid controls changing from one session to another when the active session goes next track. We will now always wait for a brief time to see if the previous session resumes before we update our controls. Bug: 1134458 Change-Id: I7b6d9d2ad1861b02c2399c6527b57cad685aba3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442195Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813286}
-
Tibor Goldschwendt authored
* Show modules even if there is no promo. Modules wait until the promo has sent a loaded event. Before, this event was only sent if there was a promo. This CL changes it so that the event is sent even if there is no promo. * Only log NewTabPage.Modules.ShownTime after modules are allowed to be visible. This could be after they are added to the DOM in case the promo takes longer to load. Bug: 1134269 Change-Id: I5975524ba3c783de66dda2b98d347442f6b73a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443693 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#813285}
-
Yuly Novikov authored
- No longer sharing GCEs with Chromium in chromium.star - tools/build repo restructure - No more mb_config_buckets.pyl Bug: 1123215 Change-Id: I3874ba6a63873dc560837c87372ee22a6a7a061a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444440Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#813284}
-
Francois Beaufort authored
This CL makes sure InvalidStateError and OperationError are respectively thrown when calling getPhotoCapabilitlies & getSettings if the MediaStreamTrack is ended and stopped while getting photo capabilities and settings. Bug: 1134569 Change-Id: Ie318319885b7796b17cb155ffcd2a81d7f98de17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445016Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#813283}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I322725001ea3c08514ff496b9ecb0f80b048b9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445703Reviewed-by:
-
Darin Fisher authored
As part of this change, DesktopCaptureDevice will explicitly stop capturing frames if it encounters a permanent error. This should be a no-op since OnError implementations are supposed to destroy the DesktopCapturer. A test is added to confirm that the throttling logic still works properly when the callbacks run asynchronously, and the Lacros desktop capturer is modified to run OnCaptureResult asynchronously. This CL is important because it sets the stage for further improvements to the Lacros capturer. It will need to use mojo's QueryVersion method to check for newer methods on ScreenManager that will enable more optimal screen capture using shared memory. QueryVersion runs asynchronously, which is why this CL is needed. Bug: 1133046 Change-Id: I455294abaecdafa7e8e75d6ea660045e51c1ee4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440928 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/16ebcf601d7f..ed3a93f690de 2020-10-02 senorblanco@chromium.org Fix rectangular mipmap textures used as color attachments. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib456da342d0c3c99ec475dffa2a8358eb32676f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445697Reviewed-by:
-
Jazz Xu authored
This CL modifies media tray bubble behavior such that when the dialog is opened and all media stops playing, we will show an empty state indicating there's no media playing instead of close the dialog immediately. Bug: 1134414 Change-Id: I3f0f2489da2189e6a71f74f6a00855d8b4a535f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444529Reviewed-by:
-
George Steel authored
Allow checks which skip a prefix, as needed for proper behavior in TransformOperations::BlendRemainingByUsingMatrixInterpolation(). This method will now only create InterpolatedTransformationOperations which are actually box-size dependent (as originally intended) ans create a matrix otherwise. Add a DCHECK for this property. Note that the interpolation defined in the css-transforms-1/2 specs assume that transform styles are calculated after layout, with matrix interpolation always producing a Matrix3DTransformOperation. As style is calculated before layout, this isn't possible in cases where the inputs to matrix interpolation are layout-dependent, so we have InterpolatedTransformOperation to defer interpolation in these cases. There is a currently CSSWG resolution to spec this behavior and give InterpolatedTransformOperation a defined serialization, having interpolation return a matrix as per the current spec where possible (the inputs of matrix interpolation are layout-independent) and an interpolated operation otherwise (where the current spec is inconsistent). The added DCHECK enforces this behavior. Resolution: https://github.com/w3c/csswg-drafts/issues/2854 This is to prepare for using DependsOnBoxSize for invalidation of compositor animations, enabling acceleration of percent-containing transform. Design Doc: https://docs.google.com/document/d/1zgr5CHRMpvlqodn1e0eM9J3MjL2eEMfAHrHsZUK7gMM/ Bug: 389359 Change-Id: I2302546225ac52f47104d2dd77b02f874d2f6ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432194Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#813278}
-
Haiyang Pan authored
The pool has plenty of 4-cores for extra builds: http://shortn/_yG5NjPy3mD And 100 more 4-cores are added to the pool in crrev.com/i/3308210 Bug: 997376, 1127110 Change-Id: I377f3192f5da13f59c1d057f28b2b97ab3f08dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446511Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#813277}
-
Denis Kuznetsov authored
BUG=b:169122360 Change-Id: I7aac27aaaa769dec9a046c40e822d6f96b94d76b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445500 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#813276}
-
Joshua Pawlicki authored
This prevents the --install process from exiting before the global service is actually available. Additionally, since we are going to call UpdateService to update the app registration anyways, this is the appropriate time to wait until its there. Bug: 1131654 Change-Id: Ifff75fafdf71a46877e9918bc26a40961703b86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441283 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813275}
-
Anastasia Helfinstein authored
This is a pure refactor with no functional change. TBR=akihiroota@chromium.org AX-Relnotes: n/a. Bug: None. Change-Id: Ic729688e78abc23769b56f6aceb0aff4201e40c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444433Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#813274}
-
Becca Hughes authored
This is a reland of af996d67 The break is fixed upstream and rolled into Chromium. TBR=calamity@chromium.org,steimel@chromium.org Original change's description: > Reland "Use JS modules for the NTP module" > > This is a reland of 7927c8a6 > > TBR=calamity@chromium.org,steimel@chromium.org > > Original change's description: > > Use JS modules for the NTP module > > > > Uses JS modules for the NTP module and updates > > closure so it can resolve chrome://kaleidoscope. > > > > Change-Id: I985b20a7faca215bd5194a4a21c790d5a4ff0262 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435441 > > Reviewed-by: calamity <calamity@chromium.org> > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#811807} > > Change-Id: I348d2116dc851394804866642a24da48d25e3edf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441109 > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812268} Change-Id: I2c7dde07d627238c7789f21be2fecc0f49bf2e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446110Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#813273}
-
