GitLab

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2743723002
Cr-Commit-Position: refs/heads/master@{#455763}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2742783002
Cr-Commit-Position: refs/heads/master@{#455762}

This utilizes length of scripts and stylesheets recently exposed in the protocolto avoid requesting content in CoverageModel.

Review-Url: https://codereview.chromium.org/2735133004
Cr-Commit-Position: refs/heads/master@{#455761}

Revert of webrtc-internals: dont remove tab (patchset #1 id:1 of https://codereview.chromium.org/2739443002/ )

Reason for revert:
This is breaking some Mac builds
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/14781

Original issue's description:
> webrtc-internals: dont remove tab
>
> instead of removing the tab when a peerconnection is garbage collected
> this adds a symbol which removes the tab on click.
>
> BUG=416876
>
> Review-Url: https://codereview.chromium.org/2739443002
> Cr-Commit-Position: refs/heads/master@{#455743}
> Committed: https://chromium.googlesource.com/chromium/src/+/b31e6f5fc2cae4ce8efdb57eb995a0c2e583dd75

TBR=guidou@chromium.org,tommi@chromium.org,philipp.hancke@googlemail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=416876

Review-Url: https://codereview.chromium.org/2745433004
Cr-Commit-Position: refs/heads/master@{#455760}

This will let us simplify the Mojo code a bit in the future, and it
makes it consistent with all other ResourceHandler methods, which
always use ResourceController for resuming and cancellation, rather
than returning a bool.

No ResourceHandler currently takes advantage of this behavior, though
this CL updates all intermediary ResourceHandlers to support it.

BUG=687240

Review-Url: https://codereview.chromium.org/2668603003
Cr-Commit-Position: refs/heads/master@{#455759}

Changes VrShellDelegate to only be created when VR classes are available, and adds a check to static native method to ensure VR classes are available.

BUG=700002

Review-Url: https://codereview.chromium.org/2744623002
Cr-Commit-Position: refs/heads/master@{#455758}

Follow up cleanup after https://codereview.chromium.org/2716493004/

BUG=695189

Review-Url: https://codereview.chromium.org/2735063005
Cr-Commit-Position: refs/heads/master@{#455757}

On backend notification, the UI must remove all displayed suggestions and
reload all suggestions.

BUG=699124

Review-Url: https://codereview.chromium.org/2739153002
Cr-Commit-Position: refs/heads/master@{#455756}

Similar to crrev/2632043002/, this CL create TestRule for each existing test base
class (ContentDetectionTestBase, JavaBridgeTestBase, NativeLibraryTestBase).
It refactors these test base classes and new TestRules on top of test common layer.
It also remove any inheritance field reference for mTestCallbackHelperContainer to
calling the new API getTestCallbackHelperContainer() for the purpose of common
implementation.

BUG=640116

Review-Url: https://codereview.chromium.org/2739603003
Cr-Commit-Position: refs/heads/master@{#455755}

https://skia.googlesource.com/skia.git/+log/08541e8d7f28..c65aec976196

$ git log 08541e8d7..c65aec976 --date=short --no-merges --format='%ad %ae %s'
2017-03-09 bsalomon Make GrClip.h private
2017-03-08 caryclark limit addEndMoveSpans loop in pathops

Created with:
  roll-dep src/third_party/skia
BUG=684553


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: I8fb788b1ad19d487930809d3dda039660584d4ee
Reviewed-on: https://chromium-review.googlesource.com/451885Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#455754}

Revert of Include the AppData file for Chrome and Chromium (patchset #4 id:60001 of https://codereview.chromium.org/2424093003/ )

Reason for revert:
This is breaking linux build bot (again), please do not submit before fixing:

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/16722

Original issue's description:
> Include the AppData file for Chrome and Chromium
>
> Add the two AppData files, one for Chromium and one for Chrome. The Chrome one
> will be filled with the information from the common/google-chrome/google-chrome.info
> file and should reflect the current channel (stable, beta, devel). On the other
> side the Chromium one should be a general one and it will be reused by
> distributions that are packaging the Chromium themselves.
>
> For AppData specification please see:
> https://people.freedesktop.org/~hughsient/appdata/
>
> BUG=654190
>
> Review-Url: https://codereview.chromium.org/2424093003
> Cr-Original-Commit-Position: refs/heads/master@{#455457}
> Committed: https://chromium.googlesource.com/chromium/src/+/d6807b9a7da70dae9191b93d4ec6157187515078
> Review-Url: https://codereview.chromium.org/2424093003
> Cr-Commit-Position: refs/heads/master@{#455731}
> Committed: https://chromium.googlesource.com/chromium/src/+/caa17f475b1ccf16ce0d4f89902663f4462396a8

TBR=phajdan.jr@chromium.org,xhwang@chromium.org,tomas.popela@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=654190

Review-Url: https://codereview.chromium.org/2738043003
Cr-Commit-Position: refs/heads/master@{#455753}

This patch adds functionality to the testing class NavigationSimulator,
to allow for NavigationThrottles to defer and cancel the navigation.

The new functionality is tested by new NavigationSimulator unit tests,
as well as new subresource filter unit tests exercising the untested
SubframeNavigationFilteringThrottle.

BUG=637415
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2698393002
Cr-Commit-Position: refs/heads/master@{#455752}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/a105b33..13fe480

$ git log a105b33..13fe480 --date=short --no-merges --format=%ad %ae %s
2017-03-09 kjellander@webrtc.org Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001 of https://codereview.webrtc.org/2736233003/ )
2017-03-09 kthelgason@webrtc.org Reland of Add unit tests for RTCMTLVideoView. (patchset #1 id:1 of https://codereview.webrtc.org/2733953006/ )
2017-03-09 kthelgason@webrtc.org Reland of Add Metal video view in AppRTCMobile and metal availability macro. (patchset #1 id:1 of https://codereview.webrtc.org/2739793003/ )
2017-03-09 oprypin@webrtc.org Revert of Enable cpplint and fix cpplint errors in webrtc/*audio (patchset #4 id:180001 of https://codereview.webrtc.org/2683033004/ )
2017-03-09 kjellander@webrtc.org PyLint fixes for tools-webrtc and webrtc/tools
2017-03-09 kwiberg@webrtc.org Make error reporting more detailed
2017-03-09 oprypin@webrtc.org Enable cpplint and fix cpplint errors in webrtc/*audio
2017-03-09 ilnik@webrtc.org Fix CpuTimeTest to tolerate MSAN interference (some background test-related work).
2017-03-09 nisse@webrtc.org Reland of Delete unused TaskRunner abstraction. (patchset #1 id:1 of https://codereview.webrtc.org/2732363004/ )
2017-03-09 nisse@webrtc.org Revert of Delete cryptstring.h and cryptstring.cc. (patchset #1 id:1 of https://codereview.webrtc.org/2740633003/ )
2017-03-08 nisse@webrtc.org Delete cryptstring.h and cryptstring.cc.
2017-03-08 zhihuang@webrtc.org Add the function ToRtpParameters.
2017-03-08 nisse@webrtc.org Delete deprecated PeerConnection methods, and corresponding using declarations.
2017-03-08 kthelgason@webrtc.org Revert of Add Metal video view in AppRTCMobile and metal availability macro. (patchset #5 id:80001 of https://codereview.webrtc.org/2722583002/ )
2017-03-08 kthelgason@webrtc.org Revert of Add unit tests for RTCMTLVideoView. (patchset #6 id:100001 of https://codereview.webrtc.org/2723903003/ )
2017-03-08 alessiob@webrtc.org Conversational Speech generator, main script with shell arguments
2017-03-08 kjellander@webrtc.org Refactor + enable GN check on video_coding_utility
2017-03-08 elad.alon@webrtc.org GetTransportFeedbackVector return vector with lost packets too, sorted by seq-num
2017-03-08 kjellander@webrtc.org Enable GN check for webrtc/logging
2017-03-08 kjellander@webrtc.org Revert of Temporarily disable failing video_quality_loopback_test.py (patchset #1 id:1 of https://codereview.webrtc.org/2704073002/ )
2017-03-08 nisse@webrtc.org Revert of Delete unused TaskRunner abstraction. (patchset #2 id:20001 of https://codereview.webrtc.org/2622923002/ )
2017-03-08 solenberg@webrtc.org Remove VoEVolumeControl interface.
2017-03-08 nisse@webrtc.org Delete unused TaskRunner abstraction.
2017-03-08 kjellander@webrtc.org Enable GN check for webrtc/modules/video_processing
2017-03-08 ilnik@webrtc.org Disable failing 15 thumbernails full-stack test on windows

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2741663003
Cr-Commit-Position: refs/heads/master@{#455751}

Follow-up to https://codereview.chromium.org/2730183003:
* The types in IDLTypes.h are traits types with no member functions, so
  using CORE_EXPORT does not have any effect and we can drop it.
* Export the entire NativeValueTraits specializations in
  NativeValueTraitsImpl.h instead of only their nativeValue() member
  functions.
  In addition to avoiding some repetition in the code, doing so also solves
  some linkage issues on Windows with debug component builds, where targets
  such as 'webkit_unit_tests' or 'blink_media_unittests' would fail to
  reference the aforementioned specializations and lead to errors like this:

    FAILED: media_blink_unittests.exe media_blink_unittests.exe.pdb
    E:/b/depot_tools/python276_bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /OUT:./media_blink_unittests.exe /PDB:./media_blink_unittests.exe.pdb @./media_blink_unittests.exe.rsp
    V8RecordTest.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static class WTF::Vector<struct std::pair<class WTF::String,int>,0,class WTF::PartitionAllocator> __cdecl blink::NativeValueTraits<struct blink::IDLRecord<struct blink::IDLString,struct blink::IDLLong> >::nativeValue(class v8::Isolate *,class v8::Local<class v8::Value>,class blink::ExceptionState &)" (__imp_?nativeValue@?$NativeValueTraits@U?$IDLRecord@UIDLString@blink@@UIDLLong@2@@blink@@@blink@@SA?AV?$Vector@U?$pair@VString@WTF@@H@std@@$0A@VPartitionAllocator@WTF@@@WTF@@PEAVIsolate@v8@@V?$Local@VValue@v8@@@6@AEAVExceptionState@2@@Z) referenced in function "void __cdecl blink::RecordTestV8Internal::setStringLongRecordMethod(class v8::FunctionCallbackInfo<class v8::Value> const &)" (?setStringLongRecordMethod@RecordTestV8Internal@blink@@YAXAEBV?$FunctionCallbackInfo@VValue@v8@@@v8@@@Z)

  The exception to the rule here is IDLSequence: since it needs template
  parameters of its own, it is not a full specialization of
  NativeValueTraitsBase, and at least win_clang complains when it is
  exported:

    E:\b\c\b\win_clang\src\third_party\WebKit\Source\bindings\core\v8\NativeValueTraitsImpl.h(289,8):  error: 'dllimport' attribute ignored [-Werror,-Wignored-attributes]
    struct CORE_EXPORT NativeValueTraits<IDLSequence<T>>

BUG=685754
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2742453002
Cr-Commit-Position: refs/heads/master@{#455750}

The issue is that PSS::GetModelTypeStoreFactory requires valid PSS which doesn't
have to be available when sync is disabled (for example in guest mode on
ChromeOS). The reason it is currently wired through PSS is that PSS conveniently
has path and blocking task runner required for ModelTypeStore.

I added static GetModelTypeStoreFactory function that takes profile path and
SequencedWorkerPool. It ensures that, for a given path, all task runners use the
same sequence token and thus properly sequneced. Datatypes that wish to be
hosted in shared leveldb database should use this factory function.

I also fixed issue that backend_map_ is accessed from multiple threads and thus
might get corrupt. I wrapped it into a class with lock.

BUG=688533
R=skym@chromium.org

Review-Url: https://codereview.chromium.org/2732333003
Cr-Commit-Position: refs/heads/master@{#455749}

Add arguments to the editing functions.

BUG=676290

Review-Url: https://codereview.chromium.org/2740833003
Cr-Commit-Position: refs/heads/master@{#455748}

This is one of the few CLs refactoring budget pool mechanisms for the
addition of the new WakeupBudgetPool.

- Move TimeBudgetPool into budget_pool.h to keep task_queue_throttler
size manageable.
- Split TimeBudgetPool into BudgetPool (interface) and TimeBudgetPool
(realisation).

There will be a separate CL uncoupling TaskQueueThrottler from BudgetPool.

R=alexclarke@chromium.org,skyostil@chromium.org

BUG=699541

Review-Url: https://codereview.chromium.org/2741473002
Cr-Commit-Position: refs/heads/master@{#455747}

BUG=NONE

Review-Url: https://codereview.chromium.org/2738183003
Cr-Commit-Position: refs/heads/master@{#455746}

Merge internal change: 149537594

BUG=

Review-Url: https://codereview.chromium.org/2740453006
Cr-Commit-Position: refs/heads/master@{#455745}

This CL exposes the Open in New Tab and Open in New Incognito Tab methods of
the Reading List Coordinator as part of the
ReadingListCollectionViewControllerDelegate.

BUG=676290

Review-Url: https://codereview.chromium.org/2745563002
Cr-Commit-Position: refs/heads/master@{#455744}

instead of removing the tab when a peerconnection is garbage collected
this adds a symbol which removes the tab on click.

BUG=416876

Review-Url: https://codereview.chromium.org/2739443002
Cr-Commit-Position: refs/heads/master@{#455743}

DOMDataStore holds a pointer to a separately allocated DOMWrapperMap (which
itself contains a HashMap with a reference to the actual hashtable). This
reduces the number of heap allocations (and pointers to follow to manage
non-main-world wrappers) by one.

Review-Url: https://codereview.chromium.org/2742553002
Cr-Commit-Position: refs/heads/master@{#455742}

We now use MSVC 2015, which supports expression SFINAE.

Review-Url: https://codereview.chromium.org/2739513003
Cr-Commit-Position: refs/heads/master@{#455741}

There's a situation that hits a DCHECK() in
MediaCustomControlsFullscreenDetector when the video become
fullscreen but the page navigates away before the timer fires.
This CL solves the issue by stopping the timer when the
ExecutionContext is destroyed.

This CL also moves the common parts of MockWebMediaPlayer into
EmptyWebMediaPlayer. There are still some other
MockWebMediaPlayers which will be adopted in a follow-up.

BUG=698034

Review-Url: https://codereview.chromium.org/2729613007
Cr-Commit-Position: refs/heads/master@{#455740}

will enable skia CL https://skia-review.googlesource.com/c/9461/

BUG=

Review-Url: https://codereview.chromium.org/2743533002
Cr-Commit-Position: refs/heads/master@{#455739}

This CL fixes REMOVING_DATA_DIR part.
Conceptually, this splits RemoveArcData() into two methods.
- RequestArcDataRemoval(): Requests to remove the data when possible.
- StartArcDataRemoval(): Actually triggers to remove the data.

Note: the state transition cannot be simplified in this CL yet,
because OnSessionStopped(), it is unknown whether the stop is triggered
by RequestDisable() or not (existing race problem, but not regression).
When its state is fixed, the state transition related to REMOVING_DATA_DIR
can also be simplified.

cf) Part1: crrev.com/2737453003

BUG=657687
BUG=b/31079732
TEST=Ran trybots.

Review-Url: https://codereview.chromium.org/2734873002
Cr-Commit-Position: refs/heads/master@{#455738}

Network traffic annotation added to four files in Safe Browsing.

BUG=656607

Review-Url: https://codereview.chromium.org/2697193003
Cr-Commit-Position: refs/heads/master@{#455737}

BUG=617892

Review-Url: https://codereview.chromium.org/2745513002
Cr-Commit-Position: refs/heads/master@{#455736}

After a recent refactoring, all decisions to fetch have been moved into
SchedulingRemoteSuggestionsProvider. One case fall through the cracks:
clearing suggestions (by sign-in/out) when an NTP is open.

This CL fixes the bug by fetching immediately after suggestions get
cleared.

BUG=698991

Review-Url: https://codereview.chromium.org/2736033004
Cr-Commit-Position: refs/heads/master@{#455735}

Previously, UserClassifier used suggestions impressions as activity
signal. This breaks for condensed NTP when impressions are tied to
opening an NTP.

This CL replaces this signal by clicks. Clicks were previously recorded
and not used. After this CL, impressions will stay being recorded. The
reason is that with further changes in the UI, we may need it again. There is a TODO to remove this metric if not used.

This CL also changes default values for activity metrics. The reason is
to make sure that a new user is classified in the middle class.

Lastly, the CL relaxes the thresholds. Currently, we have 67% rare, 33% active users, 1% active consumers. The aim is to move closer towards 55% / 40% / 5%.

BUG=699021

Review-Url: https://codereview.chromium.org/2732243002
Cr-Commit-Position: refs/heads/master@{#455734}

Remove from the UI the suggestions marked as invalid by the backend content
suggestion service.

BUG=699124

Review-Url: https://codereview.chromium.org/2739873003
Cr-Commit-Position: refs/heads/master@{#455733}

Network traffic annotation is added to network request of sync.

BUG=656607

Review-Url: https://codereview.chromium.org/2707363004
Cr-Commit-Position: refs/heads/master@{#455732}

Add the two AppData files, one for Chromium and one for Chrome. The Chrome one
will be filled with the information from the common/google-chrome/google-chrome.info
file and should reflect the current channel (stable, beta, devel). On the other
side the Chromium one should be a general one and it will be reused by
distributions that are packaging the Chromium themselves.

For AppData specification please see:
https://people.freedesktop.org/~hughsient/appdata/

BUG=654190

Review-Url: https://codereview.chromium.org/2424093003
Cr-Original-Commit-Position: refs/heads/master@{#455457}
Committed: https://chromium.googlesource.com/chromium/src/+/d6807b9a7da70dae9191b93d4ec6157187515078
Review-Url: https://codereview.chromium.org/2424093003
Cr-Commit-Position: refs/heads/master@{#455731}

BUG=chromium:699966
TBR=nednguyen@google.com,eakuefner@chromium.org
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2743683002
Cr-Commit-Position: refs/heads/master@{#455730}

BUG=699537

Review-Url: https://codereview.chromium.org/2742583004
Cr-Commit-Position: refs/heads/master@{#455729}

In LayoutGrid::applyStretchAlignmentToChildIfNeeded()
we're subtracting the top and bottom border and padding
to the desired height.
If the height is 0px due to the margins on the item
and not enough space on the cell, and the border or padding
are not 0px, then we end up with negative values.

In this patch we protect the call to setOverrideLogicalContentHeight()
to avoid passing a negative value.

BUG=697317
TEST=fast/css-grid-layout/grid-crash-huge-margins-and-min-height-max-content.html

Review-Url: https://codereview.chromium.org/2744593002
Cr-Commit-Position: refs/heads/master@{#455728}

Start tracking user session initialization in local state and use
that flag to determine whether to force a policy load instead of relying
on the oauth token status. This is important because forcing a policy load
when it's not strictly required can lock users out of their accounts.

This flag is not persisted across restarts of ephemeral sessions (including crash-induced restarts) so policy code will force a policy reload after a crash (identical to previous ephemeral behavior, so no behavior change from this CL)

BUG=684031

Review-Url: https://codereview.chromium.org/2711113003
Cr-Commit-Position: refs/heads/master@{#455727}

BUG=698231

Review-Url: https://codereview.chromium.org/2732213006
Cr-Commit-Position: refs/heads/master@{#455726}

This fix is follow up for https://codereview.chromium.org/2682453002 with
more fixes for keyword conflicts resolution. Previous solution was not
handling correctly conflicting engines in model when updating engine.

BUG=697745

R=pkasting@chromium.org, vasilii@chromium.org

TBR=ananta@chromium.org

Review-Url: https://codereview.chromium.org/2736713002
Cr-Commit-Position: refs/heads/master@{#455725}

BUG=698971

Review-Url: https://codereview.chromium.org/2740653002
Cr-Commit-Position: refs/heads/master@{#455724}