- 19 Jun, 2020 40 commits
-
-
Andy Paicu authored
TBR=dmurph@chromium.org Bug: 1097050 Change-Id: Ia5c9c5fd02f813b1c01e01a0b05009dd5f969266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253853Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780289}
-
Andy Paicu authored
TBR=arthursonzogni@chromium.org Bug: 1097060 Change-Id: Ic873cfd8030d8ef0b25604b638edd895355353be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252808Reviewed-by:
-
Alexander Surkov authored
Bug: 1096512 Change-Id: I15c797578815ee2d706cf2311cdb2ec722fcb67e AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252602 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#780287}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3340bd2d130c..23c845754ce8 2020-06-19 wolfi@chromium.org [Issues] Do not show issues banner in console again after interaction 2020-06-19 mathias@chromium.org Fix stylelint-config-standard issues in animation/animationTimeline.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I27fd23df348679619d2dfdd7e2a2e595bdcf8eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253883Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780286}
-
Denis Kuznetsov authored
Bug: 981472 Change-Id: If149ecb5692c7f2e468cf50f91f85552272f1798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238835 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780285}
-
Alice Wang authored
This CL adjusts the peek height and some spacing in the account picker bottom sheet UI used in web sign-in flow. Screenshot: https://crbug.com/1083773#c5 Bug: 1083773 Change-Id: I1d6f19ad07e937174b45200faba598ae91a0d2e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250045 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#780284}
-
Ramin Halavati authored
Static |Browser::Create| function calls |CanCreateBrowserForProfile| to make sure the passed profile can be used to create browser. Different items in this function are individually checked again in browser constructor to return proper crash message if constructor is called directly with a wrong profile, but |AllowsBrowserWindows| was missing before and is now added. Bug: 1033903 Change-Id: Iae710ed21243fddea3b54426eccae0077aba56c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984317 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#780283}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592557014-0fc653e79e8d54496b6e208718c321ae21bb710d.profdata to chrome-win64-master-1592560372-5e1e91918016f52d8aaeea816d2c59deb0aa5d08.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifd4582ce389f98fb677cf118dd7c679dd1a25d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253882Reviewed-by:
-
Ioana Pandele authored
Variations of the test are flaking often on Mac10.15 TBR=timvolodine@chromium.org Bug: 1096054 Change-Id: Ib3258a6f78bfa4e86d97089be180517d50ca8e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249782Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#780281}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592524547-91f52ddd745cbca9c170dfb725dd8a14e0e7d1c6.profdata to chrome-mac-master-1592568001-2ce2e0984e1a1c64d6f424e415ec04a2dca940b3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Icd5dd5fc4db438cea42527c42beb76f9b057a274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253885Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I5f57419a90b8973ea016a872ba9c9a75773eca51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253155Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780279}
-
Roman Sorokin authored
Eventually this class should go away. This CL removes obsolete parts * Gaia screen - flow moved to the Views implementation * RemoveUserDelegate - ditto Bug: 1079199, 1067260 Change-Id: I231154e31b49eb5b645cd01b6e4605edb75f05c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253900 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#780278}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592528104-1ddf0a60ec7fe7a5cf7de6fddb41394c2841acdd.profdata to chrome-win32-master-1592560372-e09cb0657078c6c75bd738f91c59baf5eafe0404.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Icec68f40a757edb8ffdefd9bd54fdaf82d8502c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253880Reviewed-by:
-
Etienne Pierre-Doray authored
While keeping FixedMaxBestEffortTasks enabled. MayBlockWithoutDelay is suspected to cause too many thread creation in blink_perf which tracing can't handle. Bug: 1095596 Change-Id: Ic8dd5a12cb729b1c4e5a5ce6bc3087eb81cd050a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248726Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#780276}
-
Alice Wang authored
This CL implements the method addAccount() in AccountPickerDelegate. Bug: 1092398 Change-Id: Ic7928d1be18e3e91b671b3347dd3a085775600f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253761 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
arthursonzogni authored
Patch https://chromium-review.googlesource.com/c/chromium/src/+/2186641 switched from RFH::is_active() toward RFH::IsCurrent(). We can have !is_active() && IsCurrent(), it means a different set of IPC will be able to go through the check. In particular, I suspect a RenderFrameHostImpl pending deletion might have some of its proxies not created and/or destroyed. Then it will cause the crash from bug 1093943 R=alexmos@chromium.org, sreejakshetty@chromium.org Bug: 1093943 Change-Id: Ie293dc8ae3e930677f85233044a29d0097af4b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252803 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#780274}
-
Mikel Astiz authored
When interacting with the sync server, HTTP errors that represent auth errors (401) get treated as SyncerError::SYNC_AUTH_ERROR. When reporting these cases in metric like Sync.SharingMessage.CommitResult, they should not contribute as "Sync server error", since the nature of the problem is different and very likely transient (i.e. expired tokens). In follow-up patches, the actual logic to handle this situation should be improved. Bug: 1097054 Change-Id: I2e806fab89a49e8840324f98d68f1aadd1c40080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253845 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#780273}
-
Mohammad Refaat authored
Removes TabModelList from IOSChromeLocalSessionEventRouter. Instead the observer uses an AllWebStateListObservationRegistrar and an inner observer class to perform the same updates. Bug: 1050147 Change-Id: Ic9d00b601135764b44e91c1b999fa5d2c8662755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249670 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#780272}
-
Tanmoy Mollik authored
This reverts commit 4a914f21. Reason for revert: Build failure in https://ci.chromium.org/p/chrome/builders/ci/arm64-unpublished-builder and https://ci.chromium.org/p/chrome/builders/official/android-arm-official-next Possible reason might be renaming //chrome/android:monochrome_public_bundle__base_libs_and_assets_expectations and //chrome/android:trichrome_chrome_bundle__base_libs_and_assets_expectations Original change's description: > Android: Define paths to expectation files in leaf targets > > This is easier to follow then deriving it in the templates. > > Also changes webview expectations apk->bundle > > Bug: 1095654 > Change-Id: I5952ee9a660e4f32b22ef4100fea2f231d9eb96d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245880 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780157} TBR=torne@chromium.org,agrieve@chromium.org,mheikal@chromium.org Change-Id: I8ef314098ae3949d21fc885b885b467314f6d695 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1096987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252344Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#780271}
-
Sharon Yang authored
Rename ComponentContextForCurrentProcess to ComponentContextForProcess. Move function to process_context from default_context. Remove default_context files. Remove unused includes. Test: CQ Bug: 1090364 Change-Id: I11d591cc87be7170513016713e77a816fc8e8fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242163 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#780270}
-
Javier Ernesto Flores Robles authored
Update Tooltip specs to the ones detailed in the attached bug. Bug: 1090777 Change-Id: I4e76f3c2e168bc8e4ffd8bb1dc88fb343db817fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253899 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#780269}
-
Lukasz Krakowiak authored
Method QuitClosure() provides more deterministic behaviour than QuitWhenIdleClosure(). R=wez@chromium.org Change-Id: I523bae5be0a176d5e6239573f20c78894a43e352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236398Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#780268}
-
Stephen Nusko authored
This reverts commit efddc7e5. Reason for revert: task runner needs to be set in slow_window_capturer_chromeos.cc Original change's description: > Revert "When Serializing the CopyOutputRequest use the threadpool for expensive copies." > > This reverts commit f248d2a2. > > Reason for revert: Suspected of causing failures for AuraWindowVideoCaptureDeviceBrowserTest.* > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19215 > > Original change's description: > > When Serializing the CopyOutputRequest use the threadpool for expensive copies. > > > > Currently when Chrome requests a screenshot we send a CopyOutputRequest > > from the browser. However while taking this screenshot we need to > > transfer it over a mojo pipe. This serialization takes 100-200 ms an > > example traces in the linked bug on the VizCompositor thread and then > > another 100-200 ms to deserialize it on the CrBrowserMain. This can > > block high priority tasks which delay input handling causing visible > > jank to users. > > > > We fix this by doing the expensive copies on the ThreadPool, most other > > copy tasks only take a couple ms so this removes most of the pain > > relatively easily. > > > > Tests had to be updated to know to wait for > > CopyOutputResult::SendResult to complete async. > > > > > > Bug: internal b/152858656 > > Change-Id: I114d65894c80742309bc2a02fdd2a0a7ad56dae7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201762 > > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > Reviewed-by: vmpstr <vmpstr@chromium.org> > > Reviewed-by: Mitsuru Oshima (slow:gardening) <oshima@chromium.org> > > Reviewed-by: Chris Palmer <palmer@chromium.org> > > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#779930} > > TBR=palmer@chromium.org,oshima@chromium.org,vmpstr@chromium.org,eseckler@chromium.org,nuskos@chromium.org > > Change-Id: I7c3a2011728b442580dd2c2da4816c0426649a4b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: internal b/152858656 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253678 > Reviewed-by: calamity <calamity@chromium.org> > Commit-Queue: calamity <calamity@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780185} TBR=palmer@chromium.org,oshima@chromium.org,vmpstr@chromium.org,calamity@chromium.org,eseckler@chromium.org,nuskos@chromium.org # Not skipping CQ checks because this is a reland. Bug: internal b/152858656 Change-Id: I9fa3e36dd6e874ada1fe336157eee73011b16b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252802 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#780267}
-
Javier Ernesto Flores Robles authored
Bug: 1090777 Change-Id: Idf8a990bf402771af5836f5f5bcd292dc46316b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253763 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Andy Paicu authored
TBR=szuend@chromium.org Bug: 1097005 Change-Id: Ief101f02088c1bebe8a592f42aa81e7cb884d64a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252248Reviewed-by:
-
Tanmoy Mollik authored
This reverts commit 9b955d94. Reason for revert: org.chromium.chrome.features.start_surface.StartSurfaceTest#testSearchInIncognitoSingleSurface__Instant_Return is flaky. I suspect this cl is the reason for that Original change's description: > [StartSurface] Switch to normal tab model on resume to V2 start surface > > This CL also solves the scroll issue of the incognito description. > > Screen records: > Resume: > https://drive.google.com/file/d/1jPFCAEwTDzI4PO-Ef-HdvRV6KeZoW4fD/view?usp=sharing > > Scroll: > https://drive.google.com/file/d/1C2lFMBKmdTaipWcHBG9mAYCJNuhoiYK_/view?usp=sharing > > Bug: 1093506 > Change-Id: I5d7365daa530b23f897a19665076cbc32238224f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243334 > Commit-Queue: Ganggui Tang <gogerald@chromium.org> > Auto-Submit: Ganggui Tang <gogerald@chromium.org> > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779878} TBR=yusufo@chromium.org,gogerald@chromium.org,wychen@chromium.org Change-Id: I97a65d561d8b3c3a28cf8a4b40b4354166669d8e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1097002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252805Reviewed-by:
-
Tanmoy Mollik authored
This reverts commit 9d41ebe6. Reason for revert: org.chromium.chrome.features.start_surface.StartSurfaceTest#testSearchInIncognitoSingleSurface__Instant_Return is flaky. This cl is causing a merge error to revert the original cl https://crrev.com/c/2252688 Original change's description: > [StartSurface] Set incognito description height to match parent > > This CL fixes the bug in > https://chromium-review.googlesource.com/c/chromium/src/+/2243334 > > Without setting the height to match_parent, it will be unscrollable > when its content is short. > > Screen record before > https://drive.google.com/file/d/1CUOz6ErGL2fxkF2pGAC_fGWEcTGy8hrD/view?usp=sharing > > Screen record after > https://drive.google.com/file/d/1CeuBtjQbGRovJC8H0Vk-wY6wpWqmlQJ0/view?usp=sharing > > Bug: 1093506 > Change-Id: Iff9df7ef0050885c02fe55676dbfa2046d6e78a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253143 > Commit-Queue: Ganggui Tang <gogerald@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Auto-Submit: Ganggui Tang <gogerald@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780086} TBR=gogerald@chromium.org,wychen@chromium.org Change-Id: I7abf532c1da073c32b1c604540c5ef68728587f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1097002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252046Reviewed-by:
-
Francois Doray authored
With this CL, a PageScheduler has 2 WakeUpBudgetPools: - A WakeUpBudgetPool for frames that are same-origin with the main frame. - A WakeUpBudgetPool for frames that are cross-origin to the main frame. A FrameScheduler moves its throttleable TaskQueues to the appropriate WakeUpBudgetPool when its "FrameOriginType" changes. This CL does not affect behavior. However, in an upcoming CL, the WakeUpBudgetPool for frames that are same-origin with the main frame will allow unaligned wake ups if there hasn't been a wake up in the last 60 seconds. Bug: 1075553 Change-Id: Ic45306f7d20d2fc0f4a1d9618dc6eca449e946dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248320 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780262}
-
Andy Paicu authored
TBR=xiaochengh@chromium.org Bug: 1097000 Change-Id: I94edbeb778bf35ea18a18412262ef57e4dfbabdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252145Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f2f2cf0206e5..3340bd2d130c 2020-06-19 mathias@chromium.org Fix stylelint-config-standard issues in accessibility/axBreadcrumbs.css 2020-06-19 kimanh@chromium.org Revert "Split computed-pane-properties_tests.ts to avoid timeouts" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142,chromium:1096439 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If533a9c60ee078736738c0d7bdeb68285cc6d127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253878Reviewed-by:
-
arun manickam authored
The args - `cached_package_labels` is added in core gni. This CL updates the args in local-sdk script to prevent local script failures. Bug: None Test: manual testing Change-Id: I4d7ad136e461551540180ff463b1194a3bd42dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252567 Auto-Submit: Arun Manickam <arunmanickam@google.com> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
Andy Paicu authored
TBR=adanilo@chromium.org Bug: 1097013 Change-Id: I1ed5abccd73b2c8c2ad71dccca8fde5863232d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253762Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e7ae237eb9e9..84fb97ba9452 2020-06-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 99651228b238 to 545d158a2ff9 (2 revisions) 2020-06-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7a1d99d0be42 to eb6824408d08 (3 revisions) 2020-06-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 24a17f5fe4ef to 7942c0830780 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I3fd23e39ecb467344088f6845141d47d4e524c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253571Reviewed-by:
-
Victor Hugo Vianna Silva authored
This is a reland of 39818338 Reason for reland: The original CL missed .js extensions in two of its imports. When the new dialog started being used in crrev.com/c/2246157 this caused several tests to fail. TBR=aee@chromium.org Original change's description: > [b4p/Settings] Add dialog for removing duplicated passwords > > For a b4p user, in case some password has copies attached both to the > device and the Google Account, attempting to delete it should show a > dialog that allows selecting which copies to remove. This CL implements > this dialog but does not yet wire it in. Some details in the UI are left > for future CLs, such as the user avatar and displaying the website > associated with the password to be deleted. Note RemovePasswordBehavior > is not used here, for reasons that are better explained in > crrev.com/c/2246157. > > Screenshot of implementation: > https://screenshot.googleplex.com/hZnTiuy80tL > > Screenshot of mock: > https://screenshot.googleplex.com/pGV0iMTQBxw > > Bug: 1049141 > Change-Id: I50ca0e5bfc99dbc76c12c345c00f82788bbc377c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248180 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779743} Bug: 1049141 Change-Id: I39cc548744d7d290b98de3376b96eb7c5472efae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252246 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#780256}
-
Caitlin Fischer authored
As described in more detail here (crbug.com/1096582), this test seems to cause testSingleSyncSignout and testSingleDisableSync to be flaky. Added a bug to re-enable testRegularPlusIncognito. Bug: 1094932 Change-Id: I87ce718f3d533f5684d97ff5aadb6f8cf8c9ba2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252638Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#780255}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592545853-4aad13dd3d5b31e6b22212a49c45cb09e0a49e05.profdata to chrome-win64-master-1592557014-0fc653e79e8d54496b6e208718c321ae21bb710d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I6958144b98aa99629e5b26628b97c9328e361b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253572Reviewed-by:
-
Maksim Sisov authored
It doesn't seem to be used at all. Thus, remove that. Change-Id: I5aba62543107efe4cc719d9e8168ac1f7f7c38db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250112 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#780253}
-
Caitlin Fischer authored
Original description: Replace GzipUncompress calls with DecodeLogDataToProto. Also, remove "ukm::", where applicable, from ukm_service_unittest.cc Bug: 1086910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222521Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Original-Commit-Position: refs/heads/master@{#777137} Change-Id: Ia59944a291b095755f5b9cb889f6c16b5388a704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248750 Cr-Commit-Position: refs/heads/master@{#780252}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. TBR=kinuko Bug: 1031540 Change-Id: I302009b875c8cdad1465cb72331fdd22dd33adeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249674 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#780251}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I521397e8ea474bdf7a66d2b28d38508e06fe389c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251525Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#780250}
-
