GitLab

In python3 map() return an iterable but doesn't actually do the map yet,
so the exception for the file being on another drive was produced in
code later and not caught. Force the expansion of the iterable using
list(map(...)).

Bug: 941669
Change-Id: I4f56f25a42cab102f4cd2f988907a60ec7e816af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517583Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823980}

Change-Id: I182f05b751b12cd30ff44f6cb09b6c13cb128510
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519450
Auto-Submit: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823979}

Addresses regression introduced in:
https://chromium-review.googlesource.com/c/chromium/src/+/2369433

ComputedStyleUtils::ComputedPropertyValue can return a null value if
the value cannot be parsed, which leads to a potential null pointer
dereference.

Bug: 1126364
Change-Id: I31a74283a4cbfe9c6875fb9c832d6085ab21ae39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517044Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823978}

On startup, ::NtQuerySystemInformation() is invoked to get the number
of hard faults and determine if the startup is "warm" or "cold". The
function can fail if the provided buffer is too small. In that case,
we resize the buffer to the size requested by the function and we
retry. In some cases, the size returned by the function is very large
(> 1 MB). It is undesirable to invoke a function to fill a large buffer
just to record startup histograms.

This CL does not get the hard fault count if it requires a buffer with
a size >= 512 KB. The failure to get the hard fault count is reported
in the "undetermined" bucket of the Startup.Temperature histogram.
Histograms suffixed with the startup temperature are obviously not
recorded.

Bug: 1085716
Change-Id: I0864a2af26e07cddcab4e094d344473ccbb5b9a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302829Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823977}

This reverts commit 7b6fabaa.

Reason for revert: Lots of crostini tests are failing since https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/11029

Original change's description:
> Reland "Reland "Crostini settings string changes.""
>
> This is a reland of 6b11534a
>
> OK, this time for sure. The tast-test change below was submitted, but the
> relevant ChromeOS uprev was blocked for days. This is now through so we
> can reland again, for real this time.
>
> Original change's description:
> > Reland "Crostini settings string changes."
> >
> > This is a reland of da531d49
> >
> > Now that https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/2505407
> > is landed, this should be safe.
> >
> > Original change's description:
> > > Crostini settings string changes.
> > >
> > > Instead of "Linux (Beta)", now shows as "Developers"
> > >
> > > Bug: 1140370
> > > Change-Id: Id4e076b5d918e41e22e5c59d65958da9e75a3f55
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486528
> > > Commit-Queue: Nicholas Verne <nverne@chromium.org>
> > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> > > Reviewed-by: David Munro <davidmunro@google.com>
> > > Auto-Submit: Nicholas Verne <nverne@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#820205}
> >
> > Bug: 1140370
> > Change-Id: Ibb5bd28f9647847dddaf109e9da86d91b17dd863
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505324
> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> > Reviewed-by: David Munro <davidmunro@google.com>
> > Commit-Queue: Nicholas Verne <nverne@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#822525}
>
> Bug: 1140370
> Change-Id: I76e0dfa45877db5d633a70126c0f5bd2a70a15f9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515799
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Commit-Queue: Nicholas Verne <nverne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823503}

TBR=khorimoto@chromium.org,nverne@chromium.org,davidmunro@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1140370
Change-Id: Icc3b386e702e544e153d1e8893e5781a281d29c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519452Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823976}

This CL updates the behavior of the Done button according to the other
buttons on the top Toolbar.

Bug: 1140518
Change-Id: I9e34024c4826a47fb9547ba3d0966f50596fbd1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512917Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823975}

This is probably best illustrated by the following piece of stack trace
obtained from chromium 87.0.4276.2 built against libstdc++ instead of
libcxx:
  # base::debug::CollectStackTrace()
  # base::debug::StackTrace::StackTrace()
  # logging::LogMessage::~LogMessage()
  # logging::LogMessage::~LogMessage()
  # base::internal::LockImpl::Try()
  # base::SequenceCheckerImpl::CalledOnValidSequence()
  # base::internal::WeakReference::Flag::Invalidate()
  # base::internal::WeakReferenceOwner::~WeakReferenceOwner()
  # content::ServiceWorkerRegistrationObjectHost::~ServiceWorkerRegistrationObjectHost()
  # std::unique_ptr<>::~unique_ptr()
  # std::_Rb_tree<>::_M_drop_node()
  # std::_Rb_tree<>::_M_erase()
  # content::ServiceWorkerContainerHost::~ServiceWorkerContainerHost()
  # std::default_delete<>::operator()()
  # content::ServiceWorkerHost::~ServiceWorkerHost()
  # std::default_delete<>::operator()()
  # std::unique_ptr<>::~unique_ptr()
  # content::ServiceWorkerVersion::~ServiceWorkerVersion()
  # content::ServiceWorkerRegistration::~ServiceWorkerRegistration()
  # content::ServiceWorkerRegistrationObjectHost::~ServiceWorkerRegistrationObjectHost()

Its important to note here that all the calls to the
~ServiceWrokerRegistrationObjectHost happen with the same "this"
object, meaning this is a double-delete bug. It only happens with libstdc++
due to a difference in std::map::erase method implementation. The
difference is illustrated by the following example.

  #include <map>
  #include <memory>
  #include <stdio.h>

  struct A;
  std::map<int, std::unique_ptr<A>> g_map;
  struct A {
    ~A() { printf("Map size on A DTOR call: %zd\n", g_map.size()); }
  };
  int main(int argc, char* argv[]) {
    g_map[0] = std::make_unique<A>();
    g_map.erase(0);
  }

When compiled with clang trunk on goldbot.org with -stdlib=libc++ command
line argument the size of std::map is reported as 0. When using the same
compiler but with -stdlib=libstdc++ arg specified instead, the size is
reported as 1.

As far as I can tell the behavior here is not defined by any C++
standard version, its an implementation detail.

Bug: 957519, 1135070
Change-Id: Ic7d354c2129cdf790f4731a01f8c995021d23eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509793
Commit-Queue: Piotr Tworek <ptworek@vewd.com>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823974}

LoginPinInput and LoginPasswordView view should not accept digits
from the pin pad when they are read only. This fixes an issue
that would trigger multiple authentication attempts when the digits
are inserted too fast on the pin pad when using a PIN.

Additionally, these elements will make themselves read only prior
to invoking an authentication attempt and prevent any further
attempts until they are no longer ReadOnly.

Fixed: 1133902
Bug: 1136379
Change-Id: I12dcb158b856ac1407f55220af583e9df2a39b52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489883Reviewed-by: Thomas Tellier <tellier@google.com>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Roman Aleksandrov <raleksandrov@google.com>
Commit-Queue: Renato Silva <rrsilva@google.com>
Cr-Commit-Position: refs/heads/master@{#823973}

For enterprises: enterprises may enable the feature, or enable
did-you-mean without checks, as they know their machines' path to
DNS servers.

For non-enterprise users:
Adds a feature to roll out a new default-off behavior.
A heuristic-based approach for non-enterprise users will follow, though
likely in a future milestone.

Bug: 1090985, 1090985

Change-Id: I536129341c3a3eced640dd7af9d3cdf025ee28c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380212
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823972}

Ephemeral Guest profiles are not off-the-record. The tests are updated
to cover this.

Please see go/ephemeral-guest-profiles for more context.

Bug: 1125474
Change-Id: Icc1b2782ffd153ad158fecd060f325fdacfcd8fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518973Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823971}

Roll Chrome Mac PGO profile from chrome-mac-master-1604468747-33d374fd721b6c3bc2da01359a5fc589bd022b47.profdata to chrome-mac-master-1604491008-5013724a12e21f5f9a4783fc91443d2909a128dc.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I8b3bfaef972af2df54cacad8822d07157cc0cce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519164Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823970}

This restriction will control access to the confidential content by
websites/extensions using 3P Web/Extensions Screen Casting API, e.g.:
1) https://www.w3.org/TR/screen-capture/
2) https://developer.chrome.com/extensions/desktopCapture
3) https://developer.chrome.com/extensions/tabCapture
These API are mostly used for screen share, e.g.Google Meet, or
3P screen capture extensions, e.g.Screencastify.

Bug: 1134566
Change-Id: I25dbf7b8a548c5884f81cf0d1d37308b000a8863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514206
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Aya Elsayed <ayaelattar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823969}

It is an assert error. According to the method's description[1], we
should assert that it is NOT zero.

Bug: none
Change-Id: I3da2e4006a147d256b4980878ae279dd9b4ee548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519535Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#823968}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/af90f011ae79..5399fa01a3e1

2020-11-04 petermueller@chromium.org Add thin feedback icon
2020-11-04 tonykostowny@gmail.com Clear network search input on new instance of DevTools

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1099160
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ic380bfee3c1733a92544f569a597ac3fd69e5fd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519355Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823967}

https://skia.googlesource.com/skia.git/+log/938932225cef..97469f4abe0a

2020-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c3b9f252 to 1f9589cf (438 revisions)
2020-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 3bf9f4a2e65e to db8766bb239b (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bsalomon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: bsalomon@google.com
Change-Id: I01bb981470df271c678f0c8e265100a8557a7307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518906Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823966}

https://dawn.googlesource.com/dawn.git/+log/43ef0a365b84..9d6265bc0725

2020-11-04 cwallez@chromium.org Fix examples when using the wire.
2020-11-04 cwallez@chromium.org Rolling 7 dependencies
2020-11-04 jiawei.shao@intel.com Remove DAWN_NATIVE_EXPORT declaration from dawn_platform::Platform
2020-11-04 shaobo.yan@intel.com Support internal pipelines for Dawn
2020-11-03 cwallez@chromium.org DEPS: Download clang-format from hashes in buildtools
2020-11-03 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from fc5a9cfaf70c to de6938789ccb (13 revisions)
2020-11-03 cwallez@chromium.org Add the -Wdeprecated-copy-dtor warning.
2020-11-03 cwallez@chromium.org Add the disallow_unsafe_apis toggle.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: chromium:1138528
Tbr: cwallez@google.com
Change-Id: I8d0bd6b3d8c29cddc94bf4d6dc3ebee01351444f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518392Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823965}

Currently System-proxy sends the policy set credentials with every
connect request to a remote proxy. Since less secure authentication
schemes send the credentials in clear to the proxy, an attacker can
easily obtain the policy set credentials.

This CL allows admins to restrict the auth schemes for which
System-proxy can use the policy set credentials.

      - manually tested proxies set by extensions (managed and user
      installed extensions)

Bug: 1132247
Test: - browser_tests  --gtest_filter=SystemProxyManagerPolicyCredentialsBrowserTest
Change-Id: I4583762b565ec43bfdad8be4c6db87d3e2bec223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484444Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Omar Morsi <omorsi@google.com>
Commit-Queue: Andreea-Elena Costinas <acostinas@google.com>
Cr-Commit-Position: refs/heads/master@{#823964}

.... over chromeos::TabletState::Observer.

This CL is a follow up of crrev.com/c/2491517. It gets rid of
chromeos::TabletState::Observer class in favor of
display::DisplayObserver::OnDisplayTabletStateChanged().

The CL also removes the use of the `friend class` declaration in
chromeos::TabletState: ash::TabletModeController now sets the
tablet state through display::DisplayManager ->
display::DisplayObserver::OnDisplayTabletStateChanged().

Last, the CL deliberately did not got rid of chromeos::TabletState
class. Reason: TabletState can continue to be a central read-only
class for query the tablet state from any where in the source base.

BUG=1113900
R=jamescook@chromium.org

Change-Id: I532e8511c1173139937c36c5e4c282311ea17576
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518128
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823963}

On most systems partition page size is 16kB, but there are systems
where it isn't true.

Bug: 1144990, 11297512
Change-Id: I7c0b00e15b0ed210b293f0d17f33743c6974c82d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517229
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823962}

If the source and destination formats are identical, a "fast path" is
triggered to avoid an unnecessary copy - the source pixel buffer is
returned. Thus a destination pixel buffer is never needed.

This CL avoids creating a destination pixel buffer when the "fast
path" is triggered by moving the condition up for an earlier return.

Bug: chromium:1132299
Change-Id: Iac8fa014af8e9d5a6d0735cc222a2b178e9603c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517528Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823961}

Bug: 1133186
Change-Id: Iae372cb4fba850543fa62ea4ce9942f50bd82dea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519234
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Jeremie Boulic <jboulic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823960}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: Ib5447ba1416c12f2612a5baee27aa2f5ff34e364
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519354Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823959}

This reverts commit 2aa0b3d2.

Reason for revert: The flakiness seems to be due to some issues on the golden server rather than the test itself

Original change's description:
> Disable flakey SyncErrorCardPreferenceTest
>
> TBR: triploblastic@chromium.org
> Bug: 1139399
> Change-Id: Ie13bb7d23ee953f871bfd98426d7bb73cf563381
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480888
> Reviewed-by: Sky Malice <skym@chromium.org>
> Commit-Queue: Sky Malice <skym@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#818053}

TBR=skym@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1139399
Change-Id: I5bbc961a41349ad37630a328070986a583261dff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489426Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823958}

Required for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2517500

R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I2f99d233ff919992beb5d38feba08533754f6532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517526
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823957}

This fixes the roll of Dawn into Chromium after the addition of .cpp
files to the dawn_platform target.

TBR=enga@chromium.org

Bug: None
Change-Id: Ia1d34e7f5eaee615dda9138524a516fd35e80535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517525Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823956}

Roll Chrome Win32 PGO profile from chrome-win32-master-1604415585-a805ae049e5b36d9f91fb3f359143964051762d5.profdata to chrome-win32-master-1604458456-6d8a68b0c784483d981d5c288d37192b762edfa5.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ibab7e4db48d0f04feadaa1290588295158c91686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519122Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823955}

The tests started to fail on
https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests when
https://crbug.com/1113513#c16 was landed.
The revert was supposed to fix other failures.

Tbr: karandeepb@chromium.org
Bug: 1113513
Change-Id: Ia800eba3f90cf3be44bd800c999d7a694f819573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517567Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823954}

When OnActiveNetworksChanged() is called shortly after starting a
disconnect to a ConnectionStateType::kConnecting |tether_network_|, the
|tether_network_|'s ConnectionStateType may still remain in the
ConnectionStateType::kConnecting state. This may happen if on the phone,
hotspot is off but bluetooth tethering is on, and a connection attempt
is made, but the user does not acknowledge the notification to connect
on their phone, and subsequently decides to disconnect while
|tether_network_|'s ConnectionStateType is still
ConnectionStateType::kConnecting.

By the time OnDisconnectCompleted() is called, the connection state is
properly updated to ConnectionStateType::kDisconnected, so a fetch may
be necessary to promptly update |tether_network_|, as neither
OnActiveNetworksChanged() nor OnNetworkStateListChanged() may be
called shortly afterwards with the latest network information.

Fixed: 1143041
Bug: 1106937
Change-Id: Ieb5c6071cc661fed1a3310a24c57b1927348f9d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510876
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823953}

This CL adds a list of available APIs to the frameNavigated event,
which are then shown in DevTools.

Bug: chromium:1139899
Change-Id: Ic0b44e869901113d44df165f3f3db492721a8510
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514378Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823952}

https://swiftshader.googlesource.com/SwiftShader.git/+log/47c3ca108898..19f01495a8a1

2020-11-04 capn@google.com Fix LLVM alloca array size type

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I43a3407a088954ab45c5861fb78f5ba127ec9b7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519298Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823951}

Revert "Roll ChromeOS Atom AFDO profile from 88-4305.0-1604314829-benchmark-88.0.4312.0-r1 to 88-4305.0-1604314829-benchmark-88.0.4314.0-r1"

This reverts commit 17b811fe.

Reason for revert: Probably broke build on https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-cfi-thin-lto-rel/25410
https://crbug.com/1145472


Original change's description:
> Roll ChromeOS Atom AFDO profile from 88-4305.0-1604314829-benchmark-88.0.4312.0-r1 to 88-4305.0-1604314829-benchmark-88.0.4314.0-r1
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/cros-afdo-atom-chromium
> Please CC c-compiler-chrome@google.com on the revert to ensure that a human
> is aware of the problem.
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
>
> Tbr: c-compiler-chrome@google.com
> Change-Id: I0c582170559f3a344ae5922dd5ba902ead37061c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519353
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#823938}

TBR=manojgupta@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com

Bug: 1145472
Change-Id: I4c9ab02d8c2d63ea2d4847dd95a1140d4bade55a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518051Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823950}

This reverts commit 0ae8a002.

Reason for revert: Try to revert again after stopping autoroller crbug.com/1145472

Original change's description:
> Roll AFDO from 88.0.4312.0_rc-r1-merged to 88.0.4314.0_rc-r1-merged
>
> This CL may cause a small binary size increase, roughly proportional
> to how long it's been since our last AFDO profile roll. For larger
> increases (around or exceeding 100KB), please file a bug against
> gbiv@chromium.org. Additional context: https://crbug.com/805539
>
> Please note that, despite rolling to chrome/android, this profile is
> used for both Linux and Android.
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/afdo-chromium-autoroll
> Please CC gbiv@chromium.org on the revert to ensure that a human
> is aware of the problem.
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
>
> Tbr: gbiv@chromium.org
> Change-Id: Ic3a9f7301ba0c015b24ee828d31c5f6649b7b11d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518820
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#823885}

TBR=gbiv@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com

Bug: 1145472
Change-Id: Id8179b2f0feb668d408d37a773d04be280016d10
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518050Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823949}

This CL hooks ozone/wayland with the newly added 'layout_mode'
event, from zaura_shell EXO extension.

It also introduces a new path to set the global tablet state:
display::DisplayObserver.

Next, ash/wm/tablet_mode/tablet_more_controller.cc|h will switch
over to it, and rest chromeos::TabletState.

BUG=1113900

R=jamescook@chromium.org, rjkroege@chromium.org

Change-Id: Iae832c4247c04c47429255721ff69c3ba0762455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491517Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#823948}

Currently there are two scenarios which will trigger SetPhotoOptions():
1. takePhoto() from ImageCapture API
2. applyConstraints() from MediaStreamTrack object

For (2), we don't need to reconfigure photo stream.

Bug: 1142931
Test: Manually
Change-Id: I2481d6925d2b4d8f3e99b24f9a03a9e1721c99c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517232
Commit-Queue: Wei Lee <wtlee@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823947}

Enables WebXR's makeXRCompatible API to support machines with more than
one GPU. The feature is controlled by the
blink::features::kWebXrMultiGpu flag. The WebXRMultiGpu Blink runtime
enabled features was added only to enable the feature flag in tests.

Bug: 792657,876140
Change-Id: If3a2e71a58da98066b1171d8ca54ef07bc2946fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503840Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Patrick To <patrto@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#823946}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/944e8f15ba21..af90f011ae79

2020-11-04 the.derekli@gmail.com Show pretty-printed files in multi-file search
2020-11-04 petermarshall@chromium.org Add showSurvey and canShowSurvey to InspectorFrontendHost

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1112738
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I0196cee24a181c1f54a352ded20a3917cfb57e04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519410Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823945}

Bug: 1110905
Change-Id: Ia514d54ce5ca83f72de5d310a681c800811f5836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513652
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823944}

This reverts commit d90a3ba0.

Reason for revert: This breaks inputs.VirtualKeyboardChangeInput.stable
 because it refers to "US keyboard" by name. 
https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-cfi-thin-lto-chrome/12881

Original change's description:
> [InputMethodNames] Update English-related strings
>
> Proposal: http://go/cros-input-methods-naming
> Proposed names: http://go/cros-input-methods column C
> Screenshot view: http://screen/9RB3jeFjhWq4kvS
>
> Bug: 889763
> Change-Id: I5393f7e64ecc5251ab31127f9337ebe2b579a417
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517402
> Commit-Queue: My Nguyen <myy@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823898}

TBR=xiyuan@chromium.org,myy@chromium.org

Change-Id: Ia59ebb17355dca65e4221e4ecfbcc24b4a372c89
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 889763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517565Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823943}

This reverts commit ba7d8814.

Reason for revert: SaveCardBubbleViewsFullFormBrowserTestWithAutofillUpstream.Upload_ClickingNoThanksClosesBubble and a bunch of other tests started failing in https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21164


Original change's description:
> [AF] Add account indication footer to AutofillSaveCardInfoBar
>
> The footer is shown only to signed-in users have more than one account, and who do not sync.
>
> Screenshot with feature enabled in light mode:
> https://screenshot.googleplex.com/ApVmkMVQakM6ai9
>
> Screenshot with feature enabled in dark mode:
> https://screenshot.googleplex.com/BJB2jUuGoH3T5jM
>
> Bug: 1135847
> Change-Id: Ia2e031a48920e44e66503fab62f26ed87b8e1d92
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496184
> Commit-Queue: Anne Lim <annelim@google.com>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Reviewed-by: Jared Saul <jsaul@google.com>
> Cr-Commit-Position: refs/heads/master@{#823710}

TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,bsazonov@chromium.org,annelim@google.com

Change-Id: I5f235bc5843acf4ea504a78762907a019576e656
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1135847
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518852Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823942}

For GCC 8.4.0 is important to get all the first initializer in
designated init-list in case of implicit construction. Correct compile
if use explicit construction.

Error example (GCC 8.4.0):
../../components/autofill/core/browser/data_model/
autofill_structured_address_regex_provider.cc: In function 'std::__1::
string autofill::structured_address::{anonymous}::
ParseFirstMiddleLastNameExpression()':
../../components/autofill/core/browser/data_model/
autofill_structured_address_regex_provider.cc:270:61: error: no
matching function for call to 'CaptureTypeWithPattern(autofill::
ServerFieldType, const char [953], <brace-enclosed initializer list>)'

Bug: 819294
Change-Id: I6149c53fda0f5357f66eae56446d61f010bccb53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506573Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Cr-Commit-Position: refs/heads/master@{#823941}