- 25 Aug, 2020 40 commits
-
-
Elly Fong-Jones authored
Currently, WidgetDelegate has a virtual member named DeleteDelegate, which is called when its corresponding Widget's NativeWidget is about to delete itself (which usually deletes the Widget too - see the linked bug). Many subclasses, including some core Views classes, override DeleteDelegate to `delete this`. This change introduces a new WidgetDelegate parameter, called delete_self_after_widget, which controls whether the default body of DeleteDelegate should do nothing (if it is false) or delete the receiver (if it is true). This suffices to replace almost all the existing overrides of DeleteDelegate. The remaining handful will need to be defeated in detail. Bug: 1119898 Change-Id: Ic5948f77806b3a0fc102eeb50d8ffc2313e0ffaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369432Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#801516}
-
Nnamdi Theodore Johnson-Kanu authored
- Adds new string for next button in cellular_setup page - Abstracts CellularSetupPageName from cellular_page.js to a cellular_types.js - Creates new esim_flow_ui page - current UI https://imgur.com/owFzj4Z, will have another cl to update css and add images. - UI spec https://docs.google.com/presentation/d/1Mfk5ZMEmeHwSbadUbyRU0Si5k6XDIvw-j4u7TUaCIGY/edit#slide=id.g7dc3c1fe01_5_115 Bug: 1093185 Change-Id: I5a9a960de9b5c578b5e46b322c972e27d17c38d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348291 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#801515}
-
Jenny Zhang authored
The simple lacros feedback report includes the following: 1. Lacros feedback reports are sent with ChromeOS product id, so that they will be found under ChromeOS product on Listnr. 2. Prefix the chrome version string with "Lacros ", so that lacros reports can be filtered by "Version" (for example "Lacros") on Listnr. 3. Attach lacros user log in the system log. Bug:1109387 TEST: 1. Open Lacros browser, send a feedback report by clicking "Report an issue" under Help menu. 2. Verify the report can be found at http://listnr site. The chrome version string should have a "Lacros " at the beginning, for example, "Lacros 86.0.4238.0". 3. Verify the report contains both system_logs.zip and histograms.zip. The system log should contain lacros log data from /home/chronos/user/lacros/lacros.log under "lacros_user_log" section. Change-Id: I66578c33b027fd5334f5df3f0c42b5460b79faf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370804 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#801514}
-
Morten Stenshorne authored
TBR=kojii@chromium.org Bug: 982194 Change-Id: I15917a0fd2413c5ddee322d586e303a7cd236f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375646Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#801513}
-
Emily Stark authored
In https://chromium-review.googlesource.com/c/chromium/src/+/2363999/ I added a histogram that records the duration of each continuous hover over the omnibox. As mpearson@ pointed out in that CL, this loses some signal because it continues to count edits and navigations as part of the hover (whereas what we really care about in this field trial is the particular interaction where the user hovers and exits the omnibox without otherwise interacting with it). This CL modifies the histogram to emit on mouse exit or focus, whichever comes first. Bug: 1111078 Change-Id: I49ea3cab267cc6f813a4c1dab6c7454932013e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367791Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#801512}
-
Daniel Classon authored
Adds deep links to the Devices page, including the Pointers, Keyboard, Display, Power, and Stylus subpages. Also adds focus() overrides to the settings_dropdown_menu and settings_slider to assist with deep linking. Bug: 1084154 Change-Id: I8503a7cde63911f050c50a81b3dbba9ceaf0bc4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370083 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
-
Justin Cohen authored
If EarlGrey takes too long to detect a waiting state after tapWebStateElementWithID the second tab may have already closed. Increase the delay to close the tab, and to wait in the test. Bug: 1121505 Change-Id: Ib92ad4342244d95db4a888898cb7564b987fda45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375727Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801510}
-
Marijn Kruisselbrink authored
I2S: https://groups.google.com/a/chromium.org/d/msg/blink-dev/9Fcpl2KVfbk/d9VN0Fz8BwAJ Leaving the origin trial integration for now, since removing that will require larger changes to also remove all the places in chrome os code that hard-code enable the origin trial. Bug: 853326 Change-Id: I2e7dcffd7ba1103438af6544d6dd699ef9773acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360922Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#801509}
-
Haiyang Pan authored
This reverts commit d726cb9d. Reason for revert: Suspected cause of test failures in chrome_public_test_apk in Marshmallow x86 builders since: * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-fyi-rel/1869 * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1053 Verified via running the failed test locally before and after this CL Original change's description: > [Prerender] Remove cellular network checks. > > Removes all references to cellular network checks since they're no > longer controlling access to preload/prerender features. > > Removes the enum value from NetworkPredictionStatus and > FINAL_STATUS_CELLULAR_NETWORK from prerender final status. > > Change-Id: I18d55917579d02f596615743c2736b6173e559c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368361 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Mugdha Lakhani <nator@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801163} TBR=jam@chromium.org,tbansal@chromium.org,ryansturm@chromium.org,nator@chromium.org Change-Id: I364a946e938fd1a585d2e212ad14ed1ad8d0d6b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376036Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#801508}
-
Adam Lesinski authored
UTC time is being removed from the zircon kernel in favor of user-space clocks, passed to a process through proc_args. The Fuchsia libc implementation of timespec_get knows where to find the process-wide clock handle. This implementation is more portable. Bug: 1119976 Change-Id: Ia5528f51551fedb80059e0bf3960de27512cecf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368013Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Adam Lesinski <adamlesinski@google.com> Auto-Submit: Adam Lesinski <adamlesinski@google.com> Cr-Commit-Position: refs/heads/master@{#801507}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8025507f746b..5660e8b4414b 2020-08-25 bsalomon@google.com Hook DDLPromiseImageHelper up to new YUVA API. 2020-08-25 mtklein@google.com GrSempahore/GrGpuResource cleanup 2020-08-25 reed@google.com use pathbuilder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ib0a0abb7966c674c549c2d89c2303b846182ae2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375788Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801506}
-
Daniel Classon authored
Polymer doesn't recognize the mojom as a type, so use Number instead. Bug: 1084154 Change-Id: Id1cf5c92ddafe5042e364bae9439abd9b50dfd61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375691Reviewed-by:
-
Sahir Vellani authored
Route touch events on the scrollbar to ScrollbarController. This moves touch scrolling on the scrollbar from the main thread to the compositor thread. Currently, the main thread consumes gesture events to perform scrolls on the main thread. Also, touch moves are filtered if the touch start is consumed by the renderer. With this change, touch events are now consumed by the compositor thread to perform touch scrolling on the scrollbar. Touch moves are unfiltered if the renderer consumes a touch start. This is done by calling frame_widget_host_->SetHasTouchEventHandlers with the argument set to true if the platform has hit testable scrollbars. Furthermore, with this change, tapping a scrollbar part that does not cause a scroll will not cause a click event to be fired. This behaviour is consistent with mouse clicks on scrollbars, which also do not fire click events if the clicks do not cause a scroll. Note: This change removes the ability to fling the scrollbar. Bug: 1082606 Change-Id: Iea09339961c6b9c9256628aa54fd7a90ff6bcd95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229583Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#801504}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1598262024-benchmark-86.0.4240.3-r1 to 86-4183.59-1598262024-benchmark-86.0.4240.6-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I13969c0911e62f9407f4b73087e474f996d71493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376006Reviewed-by:
-
kylechar authored
Enable more pixel tests to run on SkiaRenderer+GL and SkiaRenderer+Vulkan path where they pass. Bug: 1117587, 924369 Change-Id: If12d298673f78809d9b26fb6f3bba07ecca63e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374368 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#801502}
-
Nathan Zabriskie authored
This is a reland of 8c9ffba0 The change was reverted because it was suspected that it was causing breaks on several Android CI builders. This patch will be used to investigate potential errors and attempt to reland. Original change's description: > Update callsites of PaintImage::GetSkImage > > With OOPR Canvas we need to be explicit about how SkImages will be used > in the renderer process. In OOPR mode, SkImages must be software backed > because we can no longer use GrContext in the renderer. This change > updates callsites of PaintImage::GetSkImage to specify what kind of > SkImage is required with the new GetSwSkImage and GetAcceleratedSkImage > APIs. > > Follow up CLs will cleanup remaining callsites of GetSkImage until > we can completely remove the function. > > Bug: 1018894 > Change-Id: I69f7247e36c7cbb5d30f444f1255dd84af968df0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350027 > Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798894} TBR=dcheng@chromium.org,khushalsagar@chromium.org Bug: 1018894 Change-Id: Ibdd6e47ffbd86987df003013b090191fb65df209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365352 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I0954856d061075ec3914447e189f983bc1e09ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375891Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#801500}
-
Shakti Sahu authored
This is a reland of 2a107111 Fixed a include header in the original CL that was causing build failure. Original change's description: > Video Tutorials : Modularized JNI bridge > > This CL moves the VideoTutorialServiceFactory and the JNI bridge into > the internal target. A corresponding public factory class is generated > from the internal factory using android_library_factory function. The > JNI function lives in video_tutorial_service_bridge_factory.cc which is > included in chrome/browser target while still living in > chrome/browser/video_tutorials/internal. > > Bug: 1120097 > Change-Id: I4cbc7e2763012e3780a28f58bf14e3374464e20e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368474 > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801312} TBR=dtrainor@chromium.org,hnakashima@chromium.org Bug: 1120097 Change-Id: Ieefc1d53ccb61798a43dd28b482da5eb59621e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375786Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801499}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/70f0b007..288014f2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I639912c2319c1d8e09c14cb606addf206986145f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376005Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801498}
-
Etienne Pierre-doray authored
Current implementation delegates to Join(), but there's no need to bump priority of a canceled task. This CL simply calls WillJoin(). There's a subtle race that was hidden by priority bump (which takes ThreadGroup::lock_). 1- Thread B calls GetRemainingConcurrency(). state_ is not canceled. 2- Thread A calls JobHandle::Cancel() and frees job state. 3- Thread B calls GetMaxConcurrency() -> use after free RemoveJobTaskSource() becomes necessary again to make sure the task_source doesn't become dangling while still in the queue. Once JobHandle::Cancel() returns, it's ok if we end up with dangling references of job_task_source since it's already canceled. Change-Id: I6cf831b64fc75e555e32ae9b399342d64ed3f7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369259 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#801497}
-
Andre Le authored
- Change button and title to match quick settings style. - Settings button always stay in top right. - Remove white separator when scrolling in IME Menu. Screenshot: https://screenshot.googleplex.com/PTwj2MASeNH BUG=1114949 Change-Id: I3619643bb49bf08542fdaaf75f52582173b01199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368773 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#801496}
-
Kyle Milka authored
Bug: 1009124 Change-Id: I0d15bfdff9fe26177297ba3fe799567ec595d2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327646Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#801495}
-
Pin-chih Lin authored
In test scheme while snd-aloop is probed, "Loopback Playback" and "Loopback Capture" will be shown in system tray as ALSA loopback output and input device. The input gain could be also scrollable after "Modify mic gainin the system tray" is enabled in chrome://flags. BUG=1083465 TEST=Checked "Loopback Playback" and "Loopback Capture" are in system tray when snd-aloop is probed. TEST=Checked the scrolls of playback volume and capture gain are both valid. Change-Id: Iacfc73e76d4ecbb1380b1488b5b7acee4c3c788b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352129Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Hsinyu Chao <hychao@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Pin-chih Lin <johnylin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801494}
-
Greg Kerr authored
This CL removes a number of expired histograms related to keychain reauthorization. Bug: 1088511 Change-Id: I7faa87c0327efaf4eee2d4ad8d1d89cba821d9d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373263 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#801493}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/41db2fb64914..ff77947e7ecc 2020-08-25 aninditaghosh@google.com tp: Bind httpd to IPv6 address. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:163312367,chromium:163312727,chromium:164038530 Tbr: perfetto-bugs@google.com Change-Id: Idc8161357d2dfa582f8646334cf9c1af99acee66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375710Reviewed-by:
-
Sky Malice authored
Previously FirstRunAppRestrictionInfo had a static instance that callers used. Because it could be long lived, it meant that it also listened for changes to the device. This API for changes exposed our problems, because it would crash when trying to stop listening for changes if it never started listening. The reason for the incorrect listening is that the FirstRunActivity was destroying/stopping listening. But it was possible for two separate ChromeIntentDispatcher/FirstRunActivity pairs to be calling into it. And so the first FirstRunActivity would shutdown before the second was done starting up. This had the potential to cause subsequent problems if we just guarded against the crash. So instead of having a long lived static instance, we now have a temporary that ChromeIntentDispatcher starts, and then FirstRunActivity takes strong ownership over. This fixes the fundamental problem of the two FirstRunActivities destroying the FirstRunAppRestrictionInfo that the other activity is using. However, it comes to a slight performance hit when there are two FirstRunActivities present. Because this is an edge case, having safe code seems more important than performance. Since FirstRunAppRestrictionInfo is currently not long lived, it doesn't really warrant actually listening for changes on the device. Removed the listening code for simplicity. Bug: 1119548 Change-Id: I2dea7b20222c2d433e5db0410bb96607298db5e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371642Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#801491}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.74-1598264968-benchmark-86.0.4240.3-r1 to 86-4183.74-1598264968-benchmark-86.0.4240.6-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I3e542fedc7b837d636f2d5921b010c9ac1f312e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375712Reviewed-by:
-
Jazz Xu authored
This CL adds MediaNotificationProvider and MediaNotificationProviderObserver interface serve as a connection between ash and browser. Which will be used to send MediaNotificationListViews and media session info from browser to ash. Bug: 1111420 Change-Id: I276ff5d10642450ab392096c0a6db7c00a1c1c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315092Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
Dylan Cutler authored
Bug: 973801 Change-Id: I1d19acc974abf0fdad068296339d719c51b6b129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368466 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#801488}
-
Leonid Baraz authored
The bug assigned incorrect first seq number when StorageQueue consisted of multifile files. Also, fixed incorrect setting of StorageQueue options in the test, and added a new test that democased the failure. Bug: b:165851833 Change-Id: I6bfcb96eada2b8a47e2a10ca711ba414e8de61d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373426Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Zach Trudo <zatrudo@google.com> Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#801487}
-
Christian Biesinger authored
The -17 test started failing because this does not support the automatic minimum size yet. R=ikilpatrick@chromium.org Bug: 1083010 Change-Id: I8dbbf26021529faef9a16f85322914dcab9cafcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369420 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#801486}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.74-1598267562-benchmark-86.0.4240.3-r1 to 86-4183.74-1598267562-benchmark-86.0.4240.6-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ide2b8f85be51ee2fc3796d255085cc88148e943c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375714Reviewed-by:
-
Mohamed Amir Yosef authored
Change-Id: Ifc007754b08fad94f9e433311d7f84bae571e6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374450Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#801484}
-
Stephen Nusko authored
ASYNC events are deprecated and unsupported in the new perfetto UI. This migration ensures they continue to show up properly and are supported in the new UI. Change-Id: If74d889209021f68f23615dc36b1962951ef0ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375333Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#801483}
-
Charlie Hu authored
Change-Id: Ic4e644e9cb27572eb67d49ab182e4897ea8fee77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363294 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#801482}
-
Xiaocheng Hu authored
[Sheriff] Disable LayerTreeHostTestAbortedCommitDoesntStallSynchronousCompositor.RunMultiThread_DelegatingRenderer Bug: 1121690 Change-Id: I7abee836e9c64300938cb991e0b73caf3f9f5461 NoTry: True Tbr: wangxianzhu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375893Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#801481}
-
Aleks Totic authored
Read correct CSS axis when cells are orthogonal. Also, couple of cleanup one-liners to lighten the big patch. Bug: 958381 Change-Id: Ifece05e61f4ed42c6e1965bda1a58034f224d6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373272 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
-
Nick Burris authored
In crrev.com/c/2254058, AndroidPaymentAppFinder was changed to mark app store payment apps as preferred payment apps. The patch made the assumption that the payment app was valid, which is not necessarily the case, e.g. if the TWA has an invalid app store payment app identifier. This patch checks for the app rather than asserting. Verified fix with the test TWA from the bug. Bug: 1120346 Change-Id: Ibd3f5bcd8f562d46583b1e580a3fc997d848c58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369255Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#801479}
-
Anders Hartvoll Ruud authored
Currently we are creating a new ScrollTimeline for every frame, even for is_animation_style_change==true, in which case we don't even look at the 'timeline' variable. This CL moves the timeline computation to the branch handling new animations, such that we don't waste time by creating timelines that are never used. Bug: 1074052 Change-Id: If9327fa9dbc97666aae3377cc8b22deb95382932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374448 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#801478}
-
Alex Ilin authored
Standard context menu options aren't available in profile picker web contents. For example, "View page source" and "Inspect" don't work at all in the system profile. This change also helps fix the bug when the profile picker window closes after dismissing the context menu (I don't know what's the cause of this though). Bug: 1121543, 1121541 Change-Id: Iad91145481c8b5d8184f0bf600cea5a8a39f158c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374451Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801477}
-
