GitLab

GetOwnerName() must return unique value for each handler within
the same invalidation service. This is currently not the case for
CloudPolicyInvalidator.

This change documents this contract to avoid further API misuse and
updates TODO for codepath depending on this contract.

Bug: 1020117, 1049591
Change-Id: I7fbda6569bf6837c274be753fee5a472bbe2fff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049973Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#740273}

Bug: v8:10149
Change-Id: I3abaf70fef14307cc40adbc3759b6ec9c84c31d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050484
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740272}

There is no need to listen invalidations for commit-only types, so this
change filters them out at the moment of registration.

Bug: 1007932
Change-Id: Iedda8432a875d592024f7c417b3a3ff87b436eee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047066
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740271}

This reverts commit 5381b40a.

Reason for revert: this CL probably caused GmockCallbackSupportTest.RunOnceClosureValueMultipleCall failures. 
The first failed build https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/3283

Test 'GmockCallbackSupportTest.RunOnceClosureValueMultipleCall' completed with the following status(es): 'FAILURE','FAILURE'

Test 'GmockCallbackSupportTest.RunOnceClosureValueMultipleCall' had the following logs when run:

================================================================================

[ RUN      ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall
../../base/test/gmock_callback_support_unittest.cc:174: Failure
Death test: check.Call()
    Result: died but not with expected error.
  Expected: contains regular expression "copyable_cb->data"
Actual msg:
[  DEATH   ]
Stack trace:
#0 0x57c25d527cd4 base::test::GmockCallbackSupportTest_RunOnceClosureValueMultipleCall_Test::TestBody()

[  FAILED  ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall (26 ms)
[ RUN      ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall
../../base/test/gmock_callback_support_unittest.cc:174: Failure
Death test: check.Call()
    Result: died but not with expected error.
  Expected: contains regular expression "copyable_cb->data"
Actual msg:
[  DEATH   ]
Stack trace:
#0 0x58a33c3f9cd4 base::test::GmockCallbackSupportTest_RunOnceClosureValueMultipleCall_Test::TestBody()

[  FAILED  ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall (29 ms)


Original change's description:
> Fix flaky SingleSampleMetricsFactoryImpl DCHECK_DEATH test.
> 
> Test was missing the FLAGS_gtest_death_test_style = "threadsafe"
> declaration that's necessary for multi-threaded death tests. See
> https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#death-tests-and-threads
> 
> R=​isherman
> 
> Fixed: 1009360
> Change-Id: I795e055c9fdfda727853ce52c1278dd430cbfdef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049023
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Commit-Queue: Ilya Sherman <isherman@chromium.org>
> Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740119}

TBR=dalecurtis@chromium.org,isherman@chromium.org

Change-Id: I06415066abd98925dc7dcaac961e666ca68d6864
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050365Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740270}

This is a reland of bf17bc25

Original change's description:
> [Extensions] Enable content verification for new policy non-webstore installs
> 
> After this commit:
>  * For non-webstore policy force-installed extensions, write
>  computed_hashes.json on installation.
>  * If (according to computed_hashes.json) extension's resource is
>  detected corrupted, this extension will be disabled and  reinstalled.
>  This applies only for policy force-installed extensions, and for
>  webstore extensions it worked before this commit.
> 
> This commit will NOT change behavior for already-installed extension.
> So, if some (non-webstore) extension was already corrupted, it will not
> be detected. The reason for this is that there is no source of truth for
> resources of already-installed non-webstore extension. It's possible to
> reinstall all previously-installed non-webstore extensions, but it's out
> of scope of this commit. See the bug for more details.
> 
> Bug: 958794
> Change-Id: Ie9c014e7fd998f4eae6e852a59bd692d57ff7d8c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012964
> Commit-Queue: Oleg Davydov <burunduk@chromium.org>
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> Reviewed-by: Sergey Poromov <poromov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#737034}

Bug: 958794
Change-Id: I90d2c398712b1c716f5299a199c72e12e42b0c8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033160Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Oleg Davydov <burunduk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740269}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fec8f201c2c6..582021e12e80


Created with:
  gclient setdep -r src-internal@582021e12e80

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I4c62f4076a583aa9a1bd79300fa59779d9006774
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050087Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740268}

This test is exercising code from Devtools that is not used and is being removed
in another CL [1].

Given that this code isn't used it was decided that we're good to remove this
test as it's not providing any benefit given it tests code that never gets
called.

[1]:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2050223/

Change-Id: If4728429468c37ff9c58dbedf6508fb2e3133bfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049964Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740267}

Change-Id: I402e71b8a54a78437dc0f339ed4b9636e2d77430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044081Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740266}

Fixes an issue where web_engine_integration_tests was attempting to
deploy WebEngine by the wrong filename, with the release channel as
part of the .far filename.

Change-Id: I68c7a8c0bb897627d6f94d9825f83a81ee8a0c1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042128
Auto-Submit: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740265}

Tbr: yangguo@chromium.org
Bug: chromium:1050756
Change-Id: Ieb0d3b0110e02373053900922e54112d05321dc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049968
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740264}

1) Remove inline definition of virtual function.
2) Remove CONTENT_EXPORT from virtual overrides. They should always be
   accessed via vtables.
3) Add const to a class member that supports it.
4) Use scoped_refptr instead of raw pointer argument on method that ends
   up holding a reference to the argument.

Bug: 1016065
Change-Id: I24fb866a98f278e915e62378eca49f35231846d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045656
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740263}

This patch adds some additional logging for two scenarios:
* When TestBrowserDialog::VerifyUi reports that >1 Widget was added, we
  will log the titles of all the Widgets that were added.
* Added some DCHECKs that will hopefully produce a stack trace if
  ExtensionsMenuItemView fails to be constructed or is destructed before
  TestBrowserDialog::VerifyUi runs.

I intend to revert this patch after the associated bug is fixed.

Bug: 1050012
Change-Id: If9f86ee91ff748b1a73b979d4961cd3d04496798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043800
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Auto-Submit: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740262}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/26a68eeffcd0..c05ee8a3ffb4

git log 26a68eeffcd0..c05ee8a3ffb4 --date=short --first-parent --format='%ad %ae %s'
2020-02-11 jacktfranklin@chromium.org [Unittest] Add unit tests to UIString

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@c05ee8a3ffb4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1009443
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ibe0ffc170e79e15cd12479e947d47f69c75d8a39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050088Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740261}

This is no longer supported in the spec.

Some cleanup is possible now (such as removing IntrinsicLength()), but
I will do that in a future CL.

Bug: 991096
Change-Id: I59cc600f4b8f2e49334756615cf2df5fe9f40378
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042129
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740260}

The previous SettingsBasicPageBrowserTest were loading the entire
Settings page, and attempted to test various subtle scrolling logic
which ended up being flaky, and disabled for 3 years.

Re-instating a subset of these tests, so that there is some coverage
for settings-basic-page, as opposed to none. The problematic tests
have been deleted. Also the new tests only load basic_page.html
similar to other Settings' unit tests.

Bug: 738146
Change-Id: I7b90fb95ed62bec3854543446f03963a834cea4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045225
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740259}

This is a reland of 26f2d0fd

It attempts to fix the compile failures by adding the dep from
https://chromium-review.googlesource.com/c/chromium/src/+/2048918 .

Original change's description:
> Added a mojo generated Pagehandler for chrome://media-app.
>
> This CL defines a mojom file for the mojo interface
> between the Browser and the chrome://media-app page and
> implements the relevant CPP (Page Handler) and JS
> (mojo_api_bootstrap.js) interfaces. This interface is leveraged to
> expose the native browser open feedback dialog functionality
> to the page via a MediaAppUIDelegate.
>
> This Cl also adds the kFeedbackSourceMediaApp constant to
> the chrome::FeedbackSource enum to allow feedback dialogs
> opened by the media app to be correctly logged.
>
> Bug: 996088,1045222
> Change-Id: Ia6f28c2330cfb592f9440778b94ebf45da89dbc2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015874
> Commit-Queue: Zain Afzal <zafzal@google.com>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740168}

Bug: 996088, 1045222
Change-Id: I238de16b39d1381a5c384ea5cf537acb073c41b6
Tbr: zafzal, xiyuan, tapted, sammc, ortuno
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050443
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740258}

This exposes the MathConstants subtable using HarfBuzz's API
for the OpenType MATH table. See:
https://mathml-refresh.github.io/mathml-core/#layout-constants-mathconstants

Bug: 6606
Change-Id: I9a60d13a5a3314a320151b5352c83c5308c95e33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041485
Commit-Queue: Rob Buis <rbuis@igalia.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#740257}

This CL updates the new error page workflow, making sure that real error
page HTML is used when the error is done on provisional navigation.

For that, it is making sure that the context of the failed navigation
is passed to the navigation to the error page file.
It is also injecting the HTML of the error page into the loaded file
when the navigation finishes.

Bug: 991608
Change-Id: I382d9172bc4cdbd624d8629e6099c366f67d68a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024895
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740256}

This is a reland of 139c1efd

Original change's description:
> Run policy-presubmit when presubmit is changed
> 
> When policy templates are changed, syntax_check_policy_template_json.py is run as part of the presubmit checks. It should also be run when changes to the file itself were made.
> 
> Bug: 1045930
> Change-Id: Ic8870bd748d80d87b99b93889640cf2ebbbf0b27
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022794
> Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
> Commit-Queue: Anina Koehler <aninak@google.com>
> Cr-Commit-Position: refs/heads/master@{#737240}

Bug: 1045930
Change-Id: Ie55596dac9c5104e49af1781246c2b3fce538283
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043886Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Anina Koehler <aninak@google.com>
Cr-Commit-Position: refs/heads/master@{#740255}

First pass attempt at showing the Desktop PWA CCT toolbar on ChromeOS
when ARC apps need to show a CCT toolbar.

Design Doc: https://docs.google.com/document/d/166h__sHZGVD7eTBKkBMF7beLGOmT6mwTVe8dtsTCU7A/edit?usp=sharing

Screenshot before changes:
https://drive.google.com/open?id=0B486O0P6jAtRcHZQZXJpSmF5RFBaQ2x1TnRtS1FFbkQyNkpR

Screenshot after changes:
https://drive.google.com/open?id=0B486O0P6jAtRZ0ptUEJXemUwczNjTjlGejFPZ1ZaZS02RXFr

ARC CL here: https://googleplex-android-review.git.corp.google.com/c/platform/vendor/google_arc/+/9574364

Bug: b/64863368
Change-Id: Icff957b40c69e93082e7f4b8bdd8688fcd34d351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866227
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740254}

Bug: 1045348
Change-Id: I5c5950cb53e424d756d1de98fea122d6d75815e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046131
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740253}

When the retrieval intent completes, TrustedVaultClient needs to be
notified about possible changes, for it to once again pull the latest
keys from the backend.

Because waiting for a PendingIntent required overriding
onActivityResult() in Activity/Fragment, the method is moved away from
TrustedVaultClient into SyncSettingsUtils.

Change-Id: I8f516966977e513ed7c6569c401ab93f8dd46a80
Bug: 1012659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015164
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740252}

This change includes special handlers for ArcPolicy,
NativePrintersBulkConfiguration, DeviceNativePrinters,
External​Print​Servers policies and "Dictionary" data type policies for
extensions.
Now it's allowed to use commas after last objects in JSON lists and
dictionaries.

Bug: 843988
Change-Id: I3ced2d1cfb3e009287b95ee07ccc47595ae29edf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041618Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740251}

TBR=ikilpatrick@chromium.org

Bug: 1050315
Change-Id: I2ea0191336657a91472c3407f507a6a0c7eec5d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049012Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740250}

This CL changes behavior on failed requests:
1. When request fails with auth error, access token isn't invalidated
if the request was sent with old access token.
2. When request fails with other errors, which allow retry, access
token is refreshed right before retry.

Bug: 1020117
Change-Id: Ie7123eab78ecf1a4dee2b8ae4efe8d931f2ea15a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047226Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#740249}

Bug: 1045348
Change-Id: I6bce0d04ace4fe3d6694ec5103d407f9be4cb604
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044097Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740248}

Bug: 1026426
Change-Id: Id6b62c39b9184532a8e3e3c34c2bdee98a37240e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045171
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740247}

Roll broadwell AFDO profile from 82-4028.0-1581331201-benchmark-81.0.4044.14-r1 to 82-4028.0-1581331201-benchmark-81.0.4044.15-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I96e4d4403104edc787c90d3c8d2cd1ea7e11ee36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050086Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740246}

Using wpt-import in Chromium db8ecb4a.
With Chromium commits locally applied on WPT:
5579aad0 "SharedWorker: Name shared workers identically in credentials mode WPT"
822dbfeb "[LayoutNG] Clip when hit-testing floats inside clipped containers."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bjonesbe@adobe.com:
  external/wpt/css/css-shapes
domenic@chromium.org, ricea@chromium.org:
  external/wpt/streams
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
hongchan@chromium.org, rtoy@chromium.org:
  external/wpt/webaudio

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Id2c503814900ce3e117f6d86380a64806a70127b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050123Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740245}

Prior to this CL, blink.mojom.SessionStorageNamespace had two methods:
OpenArea() and Clone(). OpenArea() takes an Origin argument which must
be validated by browser security policy, while Clone() should go
directly to the Session Storage implementation (eventually in the
Storage Service, which may run outside of the browser).

This CL reduces SessionStorageNamespace to only the Clone() method,
while moving Session Storage's StorageArea binding to a new message on
StoragePartitionService.

No functional changes, just implementation plumbing so that the same
effective behavior is preserved over the new IPC layout.

Bug: 1000959
Change-Id: I6dcb8d52e7b4c34d58590fb6fbafb3f263e70fbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045208Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740244}

Change-Id: I1ee2e4c4f78a6471a4db50939076f13f9f978926
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048423Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740243}

In refactoring I omitted a construction call, oops.

Bug: 1050801
Change-Id: I2712a470b1f009bdf1b458b774811dd38320744e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048308
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740242}

Roll silvermont AFDO profile from 82-4037.0-1581330937-benchmark-81.0.4044.14-r1 to 82-4037.0-1581330937-benchmark-81.0.4044.15-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I0195760037959fe58627458aae212a09a97d3433
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050085Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740241}

Remove extraneous namespacing in:
- //third_party/blink/renderer/core/clipboard
- //third_party/blink/renderer/modules/clipboard

Refactoring change. No intended functional changes.

Change-Id: I429ccb28faa94a0641d0e2e8a93564265c250023
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048031
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740240}

The origin filter callback is used as part of a for loop so it's repeating:
* https://cs.chromium.org/chromium/src/components/domain_reliability/context_manager.cc?rcl=5d9822b10066adfbb4f5b1b0b677d2b04600ca4c&l=80
* https://cs.chromium.org/chromium/src/components/domain_reliability/context_manager.cc?rcl=5d9822b10066adfbb4f5b1b0b677d2b04600ca4c&l=105

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40
Change-Id: I9cc19b765c405ca218d2581a13a02c7a4daaac5b
Bug: 714018
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030960
Auto-Submit: Jose Lopes <jabolopes@google.com>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Jose Lopes <jabolopes@google.com>
Cr-Commit-Position: refs/heads/master@{#740239}

Bug: 803259
Change-Id: Ie56282ccf14edaa1cff0bb092c4be07b51d1691c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049006
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740238}

StartPendingSubscriptionRequest() might be called while there is no
changes in corresponding request. Old behavior is to cancel the request
and start the new one, new behavior is to do nothing.

The purpose of this change is to avoid redundant traffic and make
redundant StartPendingSubscriptionRequest() calls almost zero-cost to
simplify further improvements.

Bug: 1020117
Change-Id: I7458debc54505fd25bfe9f37c16a431ff0ce87cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047244
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740237}

The deprecated TRACE_EVENT_ASYNC* macros have been superseded by
TRACE_EVENT_NESTABLE_ASYNC*.

Updating to the new macros is mostly straight-forward, except in cases
where STEP_INTO/PAST macros were used extensively: In those cases, the
steps have been converted into nested sub-events.

Bug: 1038710
Change-Id: I43faf61f15544b4a097dc3cb00ce2773fed922db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041624Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740236}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/549953bc1d82..fec8f201c2c6


Created with:
  gclient setdep -r src-internal@fec8f201c2c6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ibd7780ff4eb9bec76eced29bc162402bee1b6f50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049610Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740235}

Change-Id: Id26d5ecb09fc21301dde8eb0cf067fa4edc18d2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044217Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Zinovy Nis <zynis@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#740234}