GitLab

Have FindContainerScanResults() attempt to find media "container" directories as parents of found media folders with sufficient density (which gives us confidence that it is a media container.) This version looks beyond the immediate parents, further up the directory tree.


BUG=

Review URL: https://codereview.chromium.org/285433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275264 0039d316-1c4b-4281-b951-d872f2087c98

This change fixes a long standing race condition where Core could be
destroyed on either the owner thread or the task runner thread.

See related discussion in https://codereview.chromium.org/12647008/

BUG=

Review URL: https://codereview.chromium.org/317773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275263 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds an additional action to the notification shown
when an extension or app is consuming excessive disk space.

BUG=347801
TEST=browser_tests (ExtensionStorageMonitorTest.*)

Review URL: https://codereview.chromium.org/310183005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275262 0039d316-1c4b-4281-b951-d872f2087c98

This sometimes causes a few issues with multimonitor setups. Also, r274853 fixes it more thoroughly.

> Add SM_CXSIZEFRAME and SM_CXPADDEDBORDER metrics to get window border size.
> 
> Vista added the SM_CXPADDEDBORDER system metric which needs to be included
> in the border size. The previous code happened to work with 32-bit Chrome
> because Windows added the padding into SM_CXSIZEFRAME (and set the padding to 0)
> for backwards compatibility, but with 64-bit that changed.
> GetSystemMetrics(SM_CXPADDEDBORDER) should always return 0 on XP.
> 
> BUG=361720
> 
> Review URL: https://codereview.chromium.org/243173005

BUG=361720,379321
TBR=jbauman@chromium.org

Review URL: https://codereview.chromium.org/321463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371692

Review URL: https://codereview.chromium.org/304793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275260 0039d316-1c4b-4281-b951-d872f2087c98

BUG=358413

Review URL: https://codereview.chromium.org/308073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275259 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/318753007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275258 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380890

Review URL: https://codereview.chromium.org/317833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275257 0039d316-1c4b-4281-b951-d872f2087c98

The name AwRenderFrameObserver is insufficiently explicit since it
deals only with printing.

BUG=

Review URL: https://codereview.chromium.org/314103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275256 0039d316-1c4b-4281-b951-d872f2087c98

> Add an extension override bubble and warning box for proxy extensions.
> 
> Also use the browser action highlighting for extensions that have a browser action icon.
> 
> BUG=381291
> R=dbeam@chromium.org, rdevlin.cronin@chromium.org, sky@chromium.org
> 
> Review URL: https://codereview.chromium.org/288923004

TBR=finnur@chromium.org

Review URL: https://codereview.chromium.org/312403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275255 0039d316-1c4b-4281-b951-d872f2087c98

The chromium.perf waterfall will now only run these tests on the
expected bots (desktop bots with GPUs). Re-enabling these tests.

> Disable tab capture tests as they're failing on chromium.perf.
> 
> BUG=377089
> NOTRY=True
> TBR=kbr@chromium.org
> 
> Review URL: https://codereview.chromium.org/303203002

TBR=tonyg@chromium.org

Review URL: https://codereview.chromium.org/317983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275254 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/319493007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275252 0039d316-1c4b-4281-b951-d872f2087c98

It now works when flash is disabled, previously it hung.

PERF SHERIFFS: This will change results on benchmarks that use typical_25.

BUG=
TBR=dtu@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/313373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275251 0039d316-1c4b-4281-b951-d872f2087c98

Convert local printer capabilites to CDD format to unify with cloud printers and PDF printer. This is a necessary step for adding paper size capability to local printers.

BUG=239879

Review URL: https://codereview.chromium.org/313723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275250 0039d316-1c4b-4281-b951-d872f2087c98

Reverted becuase of Mac ASan Tests (3) failure.
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%283%29/builds/2353

> DevTools: Parallel DiscoveryRequest
> 
> BUG=
> 
> Review URL: https://codereview.chromium.org/314603006

TBR=vkuzkokov@chromium.org

Review URL: https://codereview.chromium.org/317263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275249 0039d316-1c4b-4281-b951-d872f2087c98

This CL sets the first party for cookies url in
RenderFrameImpl::willSendRequest. It is currently done in blink, but this will be removed by https://chromiumcodereview.appspot.com/314093002/.

BUG=376025

Review URL: https://codereview.chromium.org/317853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275247 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275246 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dcheng@chromium.org
BUG=

Review URL: https://codereview.chromium.org/314163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275245 0039d316-1c4b-4281-b951-d872f2087c98

rollback.

BUG=362679

Review URL: https://codereview.chromium.org/316563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275243 0039d316-1c4b-4281-b951-d872f2087c98

Currently it is set in blink in FrameFetchContext::addAdditionalRequestHeaders.
This CL moves it to RenderFrameImpl::willSendRequest.

BUG=376025

Review URL: https://codereview.chromium.org/313313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275241 0039d316-1c4b-4281-b951-d872f2087c98

WebTestProxyBase::didFinishLoad does non-trivial work that can lead to the
WebFrameTestProxy being delete synchronously.

BUG=357283

Review URL: https://codereview.chromium.org/313683004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380841

Review URL: https://codereview.chromium.org/313983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275239 0039d316-1c4b-4281-b951-d872f2087c98

This happens to work correctly even if it's uninitialized, but it was causing an MSan error.

BUG=376814
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/319603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275238 0039d316-1c4b-4281-b951-d872f2087c98

Surface.writeToParcel() calls release() which drops the native reference
to make it harder to leak things (essentially it implies a
transfer-of-ownership). For the APIs here this breaks things since
you can only ask the browser for a handle once. Wrap the Surface
in another Parcelable object to avoid destruction.

BUG=149281
TBR=piman@chromium.org for gyp change
NOTRY=True

Review URL: https://codereview.chromium.org/311163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275237 0039d316-1c4b-4281-b951-d872f2087c98

Re-enable the shelf auto-hide feature, and the supporting gestures, while in touchview mode.

This effectively reverts the portions of the following reviews which impact the shelf and the launcher context menu.
https://codereview.chromium.org/205603003/
https://codereview.chromium.org/247363005/

TEST=ShelfLayoutManagerTest, LauncherContextMenuTest
BUG=370985

Review URL: https://codereview.chromium.org/305003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275236 0039d316-1c4b-4281-b951-d872f2087c98

Implement webkit/common/gpu.

Minor fixes to the gin unit tests (it defines its own test runner so shouldn't depend on run_all_unittests -- GN found this because run_all_unittests in the GN build is a source_set instead of a static library and results in a duplicate definition).

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/319583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275233 0039d316-1c4b-4281-b951-d872f2087c98

Landing the three sides needed for 343327 required some temporary casts.
Remove them.

BUG=343327

Review URL: https://codereview.chromium.org/312323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275231 0039d316-1c4b-4281-b951-d872f2087c98

Also use the browser action highlighting for extensions that have a browser action icon.

BUG=381291
R=dbeam@chromium.org, rdevlin.cronin@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/288923004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275229 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379171
TBR=sadrul@chromium.org

Review URL: https://codereview.chromium.org/311053010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275228 0039d316-1c4b-4281-b951-d872f2087c98

base_unittests was failing on iOS 6 devices. This fixes it.

Review URL: https://codereview.chromium.org/314123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275227 0039d316-1c4b-4281-b951-d872f2087c98

The crash looks related to http://crrev.com/274988

BUG=381294
R=nasko@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/312373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275226 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375350

Review URL: https://codereview.chromium.org/288983010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275225 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/313873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275224 0039d316-1c4b-4281-b951-d872f2087c98

Following issues.
1. This function was not honoring the direction of the 
   scaleX and scaleY values in the canvas matrix thus 
   causing painting issues in RTL.

2. Applying the transformation matrix on the destination 
   rectangle in this function prior to drawing does not work 
   correctly in RTL because the clip rectangle in the canvas 
   is transformed as per the RTL matrix which causes the
   check for whether the destination rectangle is within the
   bounds of the clip rectangle to fail.

   We don't need to transform the destination rectangle. We 
   can set he scale factor in the matrix to 1.0 while 
   honoring the direction of the scale for RTL and round off
   the X and Y translation units as they may contain 
   floating point numbers which causes rounding errors later
   on.

I verified that the original bug 367543 for which the change in the NineImagePainter class to specify in pixels was made
still works correctly with this patch with fractional scales.


BUG=379988
R=sky

Review URL: https://codereview.chromium.org/315793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275223 0039d316-1c4b-4281-b951-d872f2087c98

This implements jar_file_jni_generator.gypi for GN.

Also, add the //ui/gl:surface_jni_headers and enable some targets that
depend on it.

BUG=359249
R=brettw@chromium.org,tfarina@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/294323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275222 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nduca@chromium.org

BUG=

Review URL: https://codereview.chromium.org/318843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275221 0039d316-1c4b-4281-b951-d872f2087c98

This change cleans up some error reporting and removes some unnecessary and
dead code. Not a very exciting change; just doing more cleanup.

BUG=239656

Review URL: https://codereview.chromium.org/311273007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275220 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=embedded=1 build
NOTRY=true
TBR=dnicoara

Review URL: https://codereview.chromium.org/317823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275219 0039d316-1c4b-4281-b951-d872f2087c98

When a tab not playing audio is sent to the background, set timer slack to its maximum value.

Support for setting timer slack is added at the MessageLoop level, the concrete implementation of this CL only affects CFMessagePump backed MessageLoops (which means just the main thread for backgrounded renderer processes at present).

The MessageLoop implementation is designed to support its use on Windows and Linux (the Windows API sets slack per-timer like the Mac one, while on Linux slack, is set per-thread via a call to prctl() using PR_SET_TIMERSLACK).

BUG=356804

Review URL: https://codereview.chromium.org/289863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275218 0039d316-1c4b-4281-b951-d872f2087c98

To support cross-compiling, the the rule needs to be prefixed by the toolchain name. This was missing in this case.

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/314053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275217 0039d316-1c4b-4281-b951-d872f2087c98