- 03 Jun, 2019 40 commits
-
-
Maks Orlovich authored
Also fix AwCookieChangeDispatcherWrapper to handle URL substrictions, as RestrictedCookieManager uses those. RestrictedCookieManager is used by the under-development (hidden by origin trials) Cookie Store API; access to it doesn't go through ContentBrowserClient::AllowGetCookie & friends, so Android WebView cookie control knobs don't work. To fix that, route RestrictedCookieManager creation via ContentBrowserClient and insert a proxy in AwContentBrowserClient that applies that policy. Bug:958923 Change-Id: Iea87f0ecebaef303492f5aad0bab7849204e94b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613923Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#665618}
-
Erik Chen authored
The method only had one caller, which required a less specialized version of the function. No point in unnecessarily exposing the method in base/. Change-Id: I5286af592168fbf013b515da4cc8010ab3c49584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637662Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665617}
-
Lowell Manners authored
This CL replaces GaiaCookieManagerServiceObserver with vanilla callbacks. Now that GCMS is owned by IdentityManager, and cannot have multiple observers, a callback interface seems more natural than an Observer class. This also has the nice side effect of removing transitive includes of gaia_cookie_manager_service.h via identity_manager.h. Change-Id: I9cdac56c8237c9a09eb2c2ce87f41f48872a9fb6 Bug: 939372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630162Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#665616}
-
Jon Mann authored
Bug: 945522 Change-Id: I9a039f9eeb3327932ac11c24352e26d6e7ac4e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638946Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#665615}
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: Id80a3835f6d6da36e8d2a96a155de4b42db82539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639074 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#665614}
-
John Abd-El-Malek authored
This regressed in r665444. Also don't execute code not needed when network service is enabled. Bug: 934009 Change-Id: I0720f72a4ce93a7b3d7bc92d61cafa6dcd5bf4a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639349Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#665613}
-
Rohan Pavone authored
Adds ChromeDriver components necessary to leverage DevTools Target.createTarget changes, allowing for new window or tab to be be created based on user preference in both headless and regular Chrome. This completes the implementation of the NewWindow command from the W3C-spec (https://w3c.github.io/webdriver/#new-window). Design Doc: http://bit.ly/chromedriver-new-window focus/blur test to confirm that focussing steps are not run during creation. Tested: WPTs webdriver/tests/new_window, all run_py_tests, and added Bug: chromedriver:2690, b/127692156 Change-Id: I638167a47aa759ce511aae734c615cc6cf76df59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636464 Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665612}
-
Aran Gilman authored
Clicking on "Distill page" (now "Toggle distilled page contents") when not on an already distilled page has the same behavior as before. If the user is already on a distilled page, the option instead take them back to the original article. This isn't a particularly useful feature in its own right, since you can return to the original page by activating the back button. However, it lays the groundwork for a toggleable icon. Bug: 925965 Change-Id: If1c448a08fefe87fdf8d6a3df297284b66e9dd41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590379 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Cr-Commit-Position: refs/heads/master@{#665611}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b457274a. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." ab94a58b "Add the remaining Client Hints to Feature Policy." b457274a "Use testdriver Action API in WPT pointerevent tests - Part 9" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I53f2db24e40ccdc1de4f34321cb39696fe49800c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641482Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665610}
-
Gayane Petrosyan authored
To display selected colors in the menu, generate icon data for all the colors listed in selected_colors_info.h and write it out to generated_colors_info.h Bug: 960982 Change-Id: I4f0c82af64802073745920fe743ccdb736865442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636251 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#665609}
-
Eric Roman authored
* Add a table of contents * Use "proxy server identifier" throughout * Rework the proxy server identifier section * Use URI formatted proxy server identifiers throughout document * Add some links between sections Change-Id: Ie61212697cf70a2532d971113dbd550639ae9f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636259 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#665608}
-
Sven Zheng authored
Currently test failed with: Buildbucket returned error "BUILDER_NOT_FOUND": builder "win-pixel-builder-rel" not found in bucket "chromium/ci" https://luci-scheduler.appspot.com/jobs/chromium/win-pixel-builder-rel/9077335688480808992 This cl should fix the error. Bug: 965769 Change-Id: If22152956afb8a518032a225fa6ef8183320f329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639643Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#665607}
-
Suman Nelson Kancherla authored
Bug: 969365, 963637 Change-Id: I22d89d46adf0193a691c6120c05d6e023fc2f56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638889Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Cr-Commit-Position: refs/heads/master@{#665606}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/bb575d48d5f9..75841d73c2de git log bb575d48d5f9..75841d73c2de --date=short --no-merges --format='%ad %ae %s' 2019-06-03 srisser@google.com Reject large arrays in GLSL 2019-06-03 chrisforbes@google.com Fix Android-integrated build 2019-06-03 amaiorano@google.com CMake: download and extract boost to third_party 2019-06-03 amaiorano@google.com Revert "Add minimal boost install for boost::backtrace" 2019-06-03 swiftshader.regress@gmail.com Regres: Update test lists @ bb575d48 Created with: gclient setdep -r src/third_party/swiftshader@75841d73c2de The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I78af9f77200cd82e81da28f28eb8883b6b1def13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640371Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665605}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d2a6686a1066..102b7289a9f2 git log d2a6686a1066..102b7289a9f2 --date=short --no-merges --format='%ad %ae %s' 2019-06-03 gustaf@webrtc.org Prevent howling in RunPlayoutAndRecordingInFullDuplex 2019-06-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aaa0f87a..a3e71ebf (665423:665525) Created with: gclient setdep -r src/third_party/webrtc@102b7289a9f2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6f3fe5f72a5fe0f667dd13b2b8065c0472309e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641425Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665604}
-
Darin Fisher authored
Change-Id: I13b8a55916bfe8aaa8380b08874496f53409882d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639346Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665603}
-
Eugene But authored
This adds ActivityServiceControllerTestCase to EG2 tests. TBR=mrefaat@chromium.org Bug: 866147 Change-Id: I0567c72c39edb232f5171e04b71445b753bff86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638978 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#665602}
-
Navid Zolghadr authored
Add callback supports to the RenderWidgetTargeter and use the async targetting in drag and drop code and register a callback to send drag events using the callback. Note that since drag and drop events aren't WebInputEvent it is not possible to use FindTargetAndDispatch function of RenderWidgetTargeter at this time. The original CL https://chromium-review.googlesource.com/c/chromium/src/+/1596840 was reverted due the added test being flaky. This CL is the same as the original CL expect it has the same test with another way of checking the logic. TBR=sadrul@chromium.org Bug: 804633 Change-Id: I46f15a2b694c3ad9d3574473c2a46ba13dcbfb79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641383Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#665601}
-
Morten Stenshorne authored
Turns out that the DCHECK added added with https://chromium-review.googlesource.com/c/chromium/src/+/1622806 can fail. Use a different approach, where we never allow skipping to ancestors of an replaced element when adding percentage height descendants of said replaced element. Bug: 969429 Change-Id: I3380ed24ab3b2767bf79e975b1c4083a3840c3a5 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640642Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#665600}
-
Joonghun Park authored
Currently, the code snippet assigns int value to int pointer directly. The assigning should happen to the dereferenced memory. Change-Id: Id787ecef400075adeb13c68c5d356a7349ebc21c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640527Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#665599}
-
Marc Treib authored
This affects SyncableServiceBasedModelTypeController (and all its implementations). Types that don't run on the UI thread (i.e. that implement NonUiSyncableServiceBasedModelTypeController) do still need the provider. Bug: 906995 Change-Id: I9446c0bba4bc0803f45328beb2af1ead46f29693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566300 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#665598}
-
Danil Chapovalov authored
That allows to use chromium's implementation of the webrtc::TaskQueueFactory explicitly instead of indirectly through the global variable Bug: webrtc:10284 Change-Id: Ifa97112a2a5bbaa364e14f85f04e4122d907416d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639388Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#665597}
-
Xiaoqian Dai authored
Bug: 945951 Change-Id: Ic7f983f95cff0b54ebffebea87024e524906d92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625827 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#665596}
-
Wez authored
Adds a single-client equivalent of ScopedServiceBinding<>, useful for e.g. Agents which public separate services to each connected component, and expect that there will be at most one connection to each service by the component. Bug: 920920 Change-Id: Id7b527fb2e636bd9ef54290a0ac8d947d60a51b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574652Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#665595}
-
Siye Liu authored
When user clicks outside editable region to terminate current ongoing composition, some IMEs may signal us with a collapsed composition range which length is 0. We should not consider it as a valid composition. Bug: 966484 Change-Id: I0351101b93b2f85536b841b2ba3721af2769d30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638378Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#665594}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ec93e04..d6158eea Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic1c4454959625ef7c726dee1caca5033792f4ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640155Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665593}
-
Robert Ogden authored
Bug: 944286 Change-Id: Ib7926e5c03b1066c48c10f71889bbd9accff3129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639457Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#665592}
-
Fei Ling authored
The changes: - Implementation of the test runner test.py; - A simple test for policy ForceGoogleSafeSearch; To run the test, use: ``` python test.py --test tests.ForceGoogleSafeSearchTest \ --test_arg=--chrome_installer=<path_to_mini_installer_exe> \ --test_arg=--chromedriver=<path_to_chromedriver_exe> \ --cel_ctl=<path_to_cel_ctl_exe> \ --host=<path_to_host_file> ``` - the test framework design doc: http://go/chrome-enterprise-test-framework - doc on writing & running enterprise tests: https://g3doc.corp.google.com/javatests/com/google/chrome/cros/test/celab/g3doc/write_enterprise_test.md?cl=250383764 References: Change-Id: I62b10712934507c6619adf36f0b1441c5194a931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635870 Commit-Queue: Fei Ling <feiling@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#665591}
-
David Benjamin authored
Per the bug, there were two issues, one of which was fixed and the other sounds like it was fixed in newer ALSA in 2014 (comment #17). Remove the suppression. Bug: 374135 Change-Id: I37c8ca04dd9c7cf8d33b12940cd5457b0cbe6e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641202Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#665590}
-
Rohan Pavone authored
Handles promises according to W3C-spec (https://w3c.github.io/webdriver/#execute-async-script) for asynchronous user scripts. This removes the global "result" object that contains results of the latest script to execute and allows for scripts to wait until results are ready before returning (instead of polling for results after the script completes). run_py_tests.py. Tested: WPTs webdriver/test/execute_async_script, and python Bug: chromedriver:2398 Change-Id: I9f6cdeb5b3e93fcfd3e63090ce8b3aed275d71be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636627 Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#665589}
-
Steve Kobes authored
This avoids spurious layout shift reports when a static-positioned element loses its PaintLayer and cc::Layer at the same time (a common scenario at the end of a transition animation). Bug: 960614 Change-Id: I0ab8b693dbb764880090d1b078cb138f4ca1ddb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636403 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665588}
-
Paul Miller authored
BUG=968636 Change-Id: Ic838ed2cbb1c0725cc7c579c10c77e7a5323428e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639106 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#665587}
-
Owen Min authored
The scheduler will 1) Check browser status to decide if cloud reporting can be enabled. 2) Listen for the policy changes. 3) Schedule next report with a timer. 4) Update lastUploadTimestamp in local_state. Bug: 956237 Change-Id: I18dc5bd763417980053a9c63857a66dab062ea54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623459 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#665586}
-
David Tseng authored
On trunk, we currently fire (infer) a focus event when the focused node changes. For events originating from Blink, it is not reliable to infer focus events because |event_from| cannot be properly associated with the generated or inferred event or even the set of node updates. This issue only comes up when repeated accessibility actions are performed, quickly. The change will fix firing of some focus events that contain the wrong event from value. The user visible change is that ChromeVox will not sync focus (thinking it is not a focus triggered from its own action). Change-Id: I9926e1d0a03f8a70011c7d38d709eb1c77baee26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640141 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#665585}
-
James Hawkins authored
Likely fixes crashes during shutdown seen in Smart Lock. R=hansberry@chromium.org Bug: 969142 Fixes: 969142 Test: none Change-Id: I9c55e5995c27c2a93005e549a98b319f056123a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639320 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#665584}
-
Sinan Sahin authored
Bug: 958414 Change-Id: I5fe989239f165cc5a8ce28f8e1fb6e11f18b04e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604423 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#665583}
-
chrome://proximity-authJosh Nohle authored
This fixes segfaults that occur on the chrome://proximity-auth page when there is no local device metadata. This can happen if a successful DeviceSync hasn't completed yet. Bug: 945991 Change-Id: I9d767e6e26982360d685faba6126720787624951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640368 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#665582}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6e80eaeb0400..062420146dfd git log 6e80eaeb0400..062420146dfd --date=short --no-merges --format='%ad %ae %s' 2019-06-03 dburger@chromium.org Add grunt-unittest-only-postsubmit ignored in config skew check Created with: gclient setdep -r src/third_party/chromite@062420146dfd The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ic493b61bbe9fa491dd8d1b759d187cc35707d0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641214Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665581}
-
Marc Treib authored
With this change, pseudo-USS types will continue tracking metadata when Sync is stopped temporarily (i.e. SyncStopDataFate::KEEP_DATA). This brings pseudo-USS a bit closer to real USS, and it will allow us to actually shut down Sync when we're in the "Sync paused" state. Bug: 906995 Change-Id: I92fe4b6c6aab2c99eb2c7335aea18325b9b98d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538285 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#665580}
-
Kurt Horimoto authored
This test is failing on iPad for the slim nav bot. TBR=eugenebut@chromium.org NOTRY=true Bug: 968296 Change-Id: I231bf42f8c8fa3aa2f1bf3195e31f9b69a085543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639086 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#665579}
-