- 22 Oct, 2019 40 commits
-
-
Lukasz Anforowicz authored
This CL disables the following tests on CrOS: - RenderFrameHostImplBrowserTest.VisibilityScrolledOutOfView - SignedExchangeRequestHandlerBrowserTest.Simple - SignedExchangeRequestHandlerBrowserTest.VariantMatch Bug: 1016865, 954217 Change-Id: Ifa0bc6652c581bcfbc524931121975dedf9807fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873889 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708337}
-
Stefan Zager authored
BUG=1014273 TBR=chrishtr@chromium.org Change-Id: I34be160b2fb69cec8b9f0bd098bf5ae22386527c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873148 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#708336}
-
Jasper Chapman-Black authored
Bug: 1011921 Change-Id: I33b2f87730acfcee33a19bc143e9fe92bf7aba36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874229Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708335}
-
Chris Mumford authored
This change switches from using testing::CreateFunctor when calling testing::Invoke() to a C++ lambda. This improves test readibility and makes easier an upcoming changes to gmock_mutant.h (switch away from base::Bind()). Bug: 1007833, 806952 Change-Id: I73784234ade2a344c0a329615ca17d586f962da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874192Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#708334}
-
Kevin Ellis authored
Bug: 981210 Change-Id: Ibb4b4a68944c86ef5b65db7472b3790620678150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873907Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#708333}
-
Peter Kasting authored
Bug: 82078 Change-Id: Idb949d0a3d0d70077aa9a0e88558d504507a1e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866431 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#708332}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2638f3d44b02..915b779f9cfd git log 2638f3d44b02..915b779f9cfd --date=short --no-merges --format='%ad %ae %s' 2019-10-22 michaelludwig@google.com Revert "Track device coordinate space as matrix" Created with: gclient setdep -r src/third_party/skia@915b779f9cfd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I1b8227f1ca283d80edac88395e766d914c97ece9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873875Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708331}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 56e97f99. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 707870e6 "CSS: WPT tests property values are supported." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source eirage@chromium.org: external/wpt/pointerlock foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio kojii@chromium.org: external/wpt/css/css-writing-modes mek@chromium.org: external/wpt/webmessaging mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Idc2baf9bd66f5a8e6c296fc63b065b73b1e06bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873985Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708330}
-
Steven Bennetts authored
This CL provides all password fields supported in the UI in mojo. All such fields are already set to a fake value deep in the model so that plaintext values will not be accidentally leaked, and the UI already correctly identifies such values when provided. Bug: 1014779 Change-Id: I9ba46c905722481b8ce4bc35bbd2534eb2ca2505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865812 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Victor Hsieh authored
The adb sideloading setting is per device, and requires a reboot to initiate the flow, such that the user can securely confirm the intention while the device is in a clean state. To opt out, the user needs to go through powerwash flow in order to restore the device back to fully verified state. Only the device owner can change this device setting, and the setting applies to all users on the same device. On managed device, the feature is currently disabled. entry does not show up Test: Launch chrome without --enable-features=ArcAdbSideloading, new settings Test: Launch chrome with --enable-features=ArcAdbSideloading Test: Only when ARC++ is enabled in pref, the new setting sub menu shows Test: Go through the enabling flow, and see the value in boot lockbox changed. Test: Then, go to settings to disable the feature. Powerwash flow is initiated Test: Non-device owner see the toggle disabled with a policy indicator Test: On managed device, user see the toggle disabled with a policy indicator Bug: chromium:893332 Change-Id: I2a709a9ae451d88b4bda87dead45772f63d03f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834896 Commit-Queue: Victor Hsieh <victorhsieh@chromium.org> Auto-Submit: Victor Hsieh <victorhsieh@chromium.org> Reviewed-by:Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#708328}
-
dpapad authored
It was caused by a missing dependency. Fixed: 1016699 Change-Id: I866a033782a53b2c6c1bb04479a058335cafe646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874189Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#708327}
-
Marijn Kruisselbrink authored
Bug: 740744 Change-Id: Ic22655d70695ca04ab30300293ecd24a92dab3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867295Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#708326}
-
Reilly Grant authored
This change removes the |active_configuration_| variable so that a pointer to the mojom::ConfigurationInfo for the active configuration is no longer cached and is instead computed based on configuration value of the currently selected active configuration. Bug: 1016596 Change-Id: If84f0a5207d6743d775d2f314b4f341a2dcc707e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873919 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#708325}
-
Rafael Cintron authored
Now that Dawn supports keyed mutexes, we need to update the Chromium side to take advantage of the new API. In SharedImageBackingD3D, if d3d11_texture_ has a keyed mutex, it will be stored in dxgi_keyed_mutex_. The keyed mutex is used to synchronize D3D11 and D3D12 Chromium components. dxgi_keyed_mutex_ is the D3D11 side of the keyed mutex. To create the corresponding D3D12 interface, pass the handle stored in shared_handle_ to ID3D12Device::OpenSharedHandle, which Dawn does on its side. Only one component is allowed to read/write to the texture at a time. keyed_mutex_acquire_key_ is incremented on every Acquire/Release usage. Bug: 966580 Change-Id: I44226a3c35a6f03d3fb9b0458824818156c6e2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799388Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#708324}
-
Jaeyong Bae authored
Remove the unscheduled database operations like SetIndexKeys, RenameObjectStore, etc, and move them to be kPreemptive tasks on the transaction. These operations are left over tech debt and cause bugs to occur when someone reasonably assumes that all database operations are scheduled on the transaction queue. the design document link: https://docs.google.com/document/d/1kEU2ehSMmhJ5G80-HkMSHZVkT6rXiNIyL5LUT-kIIG8/edit Bug: 1012889 Change-Id: I3d8571835ac176eac8a1a79d0c72912b36b1f06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870150Reviewed-by:
-
Evan Stade authored
Asan bots caught a unit test failure after 00722f1e which is fixed by making sure the ProfileManager outlasts the UserCloudPolicyManagerChromeOS Bug: none Change-Id: I5d3aef4dcc7e423bfdf1742469c8789b4edfd0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872573Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#708322}
-
Evan Stade authored
Bug: 268984 Change-Id: Iba37b8c99f51e34d49546403fe02597b16552af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873327Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#708321}
-
Evan Stade authored
It's already a KeyedService, so it can rely on Shutdown(). Also add some missing dependencies on other KeyedServices. Bug: 268984 Change-Id: I9c1cdb190bf0858efe2054e883fd520bbeabdb64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873275Reviewed-by:
-
Sunny Sachanandani authored
Renderer client id is propagated via command line flags, so in single process mode RenderThreadImpl gets initialized with the default client id of 1, whereas the browser allocates a globally unique client id for each renderer. Viz frame sinks are embedded in a hierarchy which identifies embedders by their client ids. So requests made by the renderer to embed other surfaces are rejected by EmbeddedFrameSinkProviderImpl because the client ids don't match. This CL fixes that by propagating the client id from the browser to RenderThreadImpl in single process mode, and includes related minor code cleanup. Bug: 1015988 Change-Id: I758f19df05ad6dc083e01e8cfc760f76ca1831a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869376Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
kylechar authored
base::AtExitManager is getting destroyed after the last fuzzer test case runs due to the static initialization. Running exit tasks after some arbitrary fuzzer test case isn't useful and destroying the TestGpuThreadService causes a crash in eglDestroySurface(). Bug: 1009165 Change-Id: Ifde4517b574aaa367a94dcbcc502bb2ad2027813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872156Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#708318}
-
Dominik Röttsches authored
On Mac OS 10.15 Catalina, NSFontManager::availableFamilies does not list "Hiragino Kaku Gothic ProN" any more but only lists it as "Hiragino Sans". However, NSFontManager::availableFontsForFamily still shows results when searching for this name. Use this as a workaround for finding a result for the standard "sans-serif" Japanese font that is stored in the preferences, which is "Hiragino Kaku Gothic ProN", until we update this font matching code to be only CoreText based. Since the previous code mentions enumerating families being essential for performing case-insensitive comparisons, add a test to ensure that the new API actually performs case-insensitive matches on all Mac OS versions (at this point back to 10.10) that we support. Bug: 1000542 Change-Id: I43aac2ce74cdc40a50d11ff075bad71a7e7a5d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872055 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#708317}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b8b45f95..1486b05e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id751da4f5ed0dbbcbbc314041024ede1201229bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873989Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708316}
-
danakj authored
Currently all mojom targets are generated on Android for Java which then causes them to all be compiled as the bots compile all targets. This makes generating Java bindings for Android explicit, and adds the flag to each mojom target that is reachable during `gn gen`. The flag is overridden by cpp_only, which would prevent Java bindings from being generated. This saves about 2 minutes per parallel compilation task when building the .javac.jar step, which is a dominant part of compile. In the experiment the total time spend on this step went from 1h21m to 1h10m. The .jar step also improved from 1h1m to 53m, with weighted time from 6m6s to 5m4s. R=agrieve@chromium.org, rockot@chromium.org TBR=jam Bug: 603143 Change-Id: I4c636ce051abcd7a89efc46224b2405cef8110dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868986 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Mustaq Ahmed authored
The word "consume" means something different from the consumption of user-activation state itself. So replaced the word with "remove", and clarified related comments. Bug: 848778 Change-Id: I94733927ff5da742e25a114a4b9227790011822b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873908 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
-
Kevin Marshall authored
Enhances the install script to place symbols from local builds into a Fuchsia build output directory. Also fixes an issue with process names being used in the module listing that was preventing user-mode stack traces from browser child processes from being symbolized properly. Process names are suffixed with a process type string, using a colon as a delimiter. Colons are used as field delimiters by the symbolizing stream parser, and so inclusion of the colon yielded unparseable entries in the module listing. Bug: 1014601 Change-Id: If4affeca56a0c69e965ee588ddc3f861726796c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863570Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#708313}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/e28f27831dbe..61cd76748f7c git log e28f27831dbe..61cd76748f7c --date=short --no-merges --format='%ad %ae %s' 2019-10-22 dneto@google.com Android.mk: Install all necessary headers (#846) Created with: gclient setdep -r src/third_party/shaderc/src@61cd76748f7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I128023e29271baa0a668a7cae95b83e24754bf55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873495Reviewed-by:
-
Nicolás Peña Moreno authored
The only usage of |v8_compile_start_time_| was removed in commit 5214e811 and the only usage of CaptureStartTime() and Duration() for probe::ExecuteScript was also removed by that commit. Therefore, the member can be removed and the call to CaptureStartTime() can be removed. Bug: 738493 Change-Id: I8f59ba31fd1d64bfba40ec3e3e07f80940253864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872775Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#708311}
-
Nico Weber authored
This reverts commit b51cfae0. Reason for revert: Breaks deterministic bots, https://crbug.com/1016240 Original change's description: > Update Crashpad to 661a07a41b8809b9df32914c11542a0c76e709d5 > > 2fb4e9e6a432 mac: Update the process_types version of > dyld_all_image_infos for 10.15 > c009b85449cb Use GTEST_SKIP() instead of custom DISABLED_TEST() > d8f85829b07b linux: fix split stack test > 7289acb78a6d linux: don't assume vdso exists > 47a342133d60 linux: use boringssl in chromium > 661a07a41b88 linux: add deps for boringssl in chromium > > Change-Id: Iae1ed525a228c4de3b879ac06097fd026ea01004 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869397 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707418} TBR=jperaza@chromium.org,mark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I211945fef0f4949c747771e10dc9584da2d0355d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871832Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#708310}
-
Min Qin authored
This reverts commit d6c08063. Reason for revert: This CL is coupled with https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1999437, so please wait for both to land Original change's description: > Revert "Move some java download files to chrome/browser/download/android" > > This reverts commit 4812124d. > > Reason for revert: Suspect causing build failure android_arm64-builder-perf > https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/122367 > > Original change's description: > > Move some java download files to chrome/browser/download/android > > > > This CL moves the DirectoryOption and DownloadDirectoryProvider.java > > > > BUG=1013759 > > > > Change-Id: I78bef333bed85a4e34a70843caaf37ef1dbfa7de > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867192 > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Commit-Queue: Min Qin <qinmin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#708254} > > TBR=dtrainor@chromium.org,qinmin@chromium.org > > Change-Id: I6f219a56fe4ad9e4e5cde3b8acfca4c045a5bfc7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1013759 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873281 > Reviewed-by: Ella Ge <eirage@chromium.org> > Commit-Queue: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708299} TBR=dtrainor@chromium.org,qinmin@chromium.org,eirage@chromium.org Change-Id: Ie92a0b729d234ff50fabc4cd4ae0affaf51e9ce9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1013759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874327 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708309}
-
Fabrice de Gans-Riberi authored
Add fast/text/small-caps-aat.html to SmokeTests to ensure no further regression. Bug: 1015566 Change-Id: Ic36dd110ae1667aa5c37cef7a24768aaee2dad97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868982Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#708308}
-
siyua authored
Logic for the dialog: 1. Show dialog when user has opted in, and after card verification starts. 2. If card is not eligible for fido, fall back to CVC, close the dialog. Card unmask prompt will be shown next. 3. If card is eligible for fido, close the dialog after card information is filled to the form. Uploaded screenshot in bug comment 21 Bug: 991037 Change-Id: Ibb32a03c491039664b0875ea40cc750f304e21b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834822Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#708307}
-
Vikas Soni authored
Re-enable AImageReader on ARM GPUs since few bug fixes related to memory regressions have been landed and we expect those fixes might have also fixed the crashes we were seeing with ARM GPUs. Will need to revert this CL if it causes crashes. Since the crashes are not reproducible locally, there is no other way to test this expect removing the GPU family from the blacklist and hence enabling it on ToT. Bug: 1013797 Change-Id: I3402d049e06824284c3b9836fd05ebe03754b43a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873393Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#708306}
-
rbpotter authored
Since we have decided to instead migrate to Polymer 3: - Remove the HTML imports polyfill from downloads, extensions, and Print Preview - Remove test changes that were made to support the polyfill - Remove changes to optimize_webui.py that were made to optimize pages using the polyfill Bug: 925517, 965770 Change-Id: I531bd3cf7814cb3ca5a32aa80b38f4e1ec16ede6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873146Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#708305}
-
Tommy Li authored
No one likes the current confirmation dialog. Begin experimentation without one. This CL puts in a new flag that can swap on and off the confirm dialog. The flag is set up so that there is NO confirm dialog by default. This is the same as how the NTP version: ConfirmNtpSuggestionRemovals. Bug: 1016514, 929477, 1205 Change-Id: If158e10da3fbdccc847aafe5221fad57c5c3639b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872182 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#708304}
-
Wei-Yin Chen (陳威尹) authored
Bug: None Change-Id: I956cb37b753b2983f90dd4750dfdb7e692c2d4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873917 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708303}
-
Christopher Thompson authored
This also adds unit-tests for SecurityStatePageLoadMetricsObserver. Bug: 1016105 Change-Id: I0bcb5720a1c489632a762e40ed93b7ec4f239bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873211 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#708302}
-
Anastasia Helfinstein authored
This change is an overhaul of how navigation between elements onscreen is handled. The design doc can be found at go/cros-switch-navigation. TL;DR each time we enter or exit a group, we construct an SARootNode for the group and an SAChildNode for each of its children. This is instead of dynamically calculating the elements of the group on each navigation event. Bug: 1011630 Change-Id: I264c1c3c9ef36fcb0d98327cd2e5fcc671b7f9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843214Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#708301}
-
Andrew Grieve authored
Small build speed improvement. Bug: 937005, 1016846 Change-Id: I126ec5fbd3652f843bfb56b185cae8209bf6fe7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874186Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#708300}
-
Ella Ge authored
This reverts commit 4812124d. Reason for revert: Suspect causing build failure android_arm64-builder-perf https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/122367 Original change's description: > Move some java download files to chrome/browser/download/android > > This CL moves the DirectoryOption and DownloadDirectoryProvider.java > > BUG=1013759 > > Change-Id: I78bef333bed85a4e34a70843caaf37ef1dbfa7de > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867192 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708254} TBR=dtrainor@chromium.org,qinmin@chromium.org Change-Id: I6f219a56fe4ad9e4e5cde3b8acfca4c045a5bfc7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1013759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873281Reviewed-by:
-
Jamie Madill authored
This reverts commit 2b7ca8e2. Reason for revert: Failed again https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%2032%20Vk%20Release%20%28Pixel%202%29/85753 https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%2064%20Vk%20Release%20%28Pixel%202%29/81952 Original change's description: > [base] Ensure that tests don't change the thread priority (reland). > > This is a reland of > https://chromium-review.googlesource.com/c/chromium/src/+/1804786. > The difference is that we don't check thread priority in > angle_deqp_tests_main, as these tests do change thread priority > on purpose. > > This CL verifies that the thread priority is normal when a test process > is launched and before/after each test. The goal is to avoid having > tests that assume they run at normal priority be disabled because of > other misbehaving tests (e.g. https://crbug.com/931706). > > TBR=sky@chromium.org,michaelpg@chromium.org,thakis@chromium.org,eseckler@chromium.org > > Bug: 931706 > Change-Id: I92a827d014278b1f5b3504f48c2441ad2e83bc65 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865405 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708194} TBR=sky@chromium.org,gab@chromium.org,thakis@chromium.org,fdoray@chromium.org,zmo@chromium.org,michaelpg@chromium.org,eseckler@chromium.org Change-Id: Ie5084dea77cd119cd4e901c254c11d6f4dceefcd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873501Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#708298}
-
