- 06 Feb, 2020 40 commits
-
-
khmel@chromium.org authored
This handles this switch and set ARC request param accordingly. TEST=Locally, unit test BUG=b:147978162 Change-Id: I739fb91481ce054ab6e175100ead6dade246a418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042375 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#739133}
-
Manu Cornet authored
Bug: 1048119 Change-Id: I0ead8b2aaee34a27c030259829ad279a6261c92c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042314Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739132}
-
Tommy Li authored
When the WebUIOmniboxPopup flag is on, this CL doesn't add the native result views. This CL is just meant to "hollow out" the OmniboxPopupContentsView when the flag is on. The next step would be add an actual views::WebView to take the place of all the child result views. This CL was deliberately kept to just a bunch of stubs to illustrate all the integration points we would need with a WebUI popup. Even when the flag is on, we keep the actual OmniboxPopupContentsView, because it's responsible for drawing the "beard" and transparent poke-through that we need even if we render the popup contents in WebUI. Bug: 1046561 Change-Id: I01d7a77413b760a290dc823b2a142921121f81cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042218Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#739131}
-
Jared Saul authored
We are still interested in these histograms. Extending their expiry by another year. Fixed: 1048207 Change-Id: I573b2bb70ddda06bbc58e01583386169f6b94c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036356Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#739130}
-
behdad authored
Not reporting metrics below: Scheduling.Renderer.BeginMainFrameQueueDurationCritical Scheduling.Browser.BeginMainFrameQueueDurationCritical As they are reported under: CompositorLatency.SendBeginMainFrameToCommit.BeginMainSentToStarted Bug: chromium:976030 Change-Id: I4a32b9234d267712d485188f1b1383c6a327fd58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024916Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#739129}
-
Anatoliy Potapchuk authored
This handler was little bit overcomplicated. This led to a bug in web kiosk mode when we update network state, but do not update the handler. Because of this convolution, in web kiosks, the network configure screen did not update itself when connected to network(which is what client will expect from the handler which observes network state). Now it behaves more logically and predictably. Bug: 1015383 Change-Id: I78b024b1d51b54b0d01d0a5a5694f6ae3f5ac19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031406 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#739128}
-
kylechar authored
Add support for CopyOutputRequest::result_selection when using SkiaRenderer with the Skia readback API. Previously the field was ignored in SkiaOutputSurfaceImplOnGpu. The skia readback API doesn't support specifying a clip rect in the destination pixel space, so this is a bit of a workaround with the potential for some rounding errors. This CL also adds SkiaReadbackPixelTest. It draw a frame containing a source image with a CopyOutputRequest. The pixels that are read back are compared against reference PNGs. The test is based on GLRendererCopierPixelTest and uses the same source and result PNGs. Bug: 1047217 Change-Id: I9f97cacafff15833d6ce97d36c69c70b55d09479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033624 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#739127}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/50984a64faec..816c2b3548fb git log 50984a64faec..816c2b3548fb --date=short --first-parent --format='%ad %ae %s' 2020-02-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-06 ehmaldonado@google.com git-cl: Remove _add_codereview_[issue_]select_options and _CODEREVIEW_IMPLEMENTATIONS. Created with: gclient setdep -r src/third_party/depot_tools@816c2b3548fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I79128767d064067a3cdaad50ed12712e0ff20c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042332Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739126}
-
Christian Biesinger authored
I am removing the auto/legacy tests because the code does not do the right thing for those and at any rate this is no longer supported. I will remove them in a later CL. Bug: 991096 Change-Id: I3d4722074b8c3f4f97d5129f54d3795a41cfce78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039591 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#739125}
-
Brandon Wylie authored
Relying on tabProvider.get() as an iterator causes an infinite loop on tablets. As an alternative, I aggregate all Tabs under each TabModel and iterate over them explicitly. Bug: 1046308 Change-Id: I3f096a0549ef9a7d463acc4eebbed46f7c9aac99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033703 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#739124}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/73f1b60756e3..7457e5e4ba27 git log 73f1b60756e3..7457e5e4ba27 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 michael.liao@microsoft.com [Common - ConfirmDialog]: Placing initial focus on OK button and making dialog SR accessible Created with: gclient setdep -r src/third_party/devtools-frontend/src@7457e5e4ba27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If999c708798defbcdeb96b649089c41ba43e57ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042657Reviewed-by:
-
Andrew Grieve authored
This reverts commit 9e9a0e96. Reason for reland: Closing file before moving it to appease windows Change-Id: Iaa9b51861232c98ef4bf7210f868dbe20544c5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040950 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#739122}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/297e9f7db90b..39dda173e881 git log 297e9f7db90b..39dda173e881 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 mfoltz@chromium.org [Open Screen] Update documentation on threading, other fixes. Created with: gclient setdep -r src/third_party/openscreen/src@39dda173e881 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I3abe87f0b1fa89c95613deca667c30a75828e8be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041807Reviewed-by:
-
Brian White authored
Updates the expires_after attribute for 48 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 30 days of 2020-08-17. Change-Id: I8116b948f4bc5a8ca791a0d320d7b552cd242d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042255 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#739120}
-
Wei-Yin Chen (陳威尹) authored
Show a chip on the tab card if that tab has search result page in its navigation stack. The chip contains the search term. When clicked, the tab would visit the search result page again. This is behind a Finch parameter "enable_search_term_chip" under TabGridLayoutAndroid. The CL is split into two, and this is part one, which only contains the diff that cannot be handled by the Formal Equivalence Checker in http://crrev.com/c/1934235/4. See also: part two (http://crrev.com/c/2036513). Bug: 1048255 Change-Id: I6fa83d1179cb3700b65afde86327ecbb148ed92b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038458 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#739119}
-
zhaoyangli authored
After app unexpectedly crashes in EG2 test, it is relaunched at -setUp of next testMethod. Currently in this situation, |appNeedsLaunching| is judged false and app is launched without TestCase +setUps at |activate| method, which will cause DCHECK failures at +tearDown. This change makes |appNeedsLaunching| judged true in this situation and run TestCase +setUps after the relaunch to prevent DCHECK failures. Bug: 1023911 Change-Id: I83bd06df7afdf2402fbb0593a6825910107534f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037852Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#739118}
-
Sigurd Schneider authored
dom-breakpoints.js usually takes ~70 on some mac bots, but occasionally exceeds 91s and runs into a timeout. This CL splits the test into two, which hopefully makes it less likely to trigger timeouts. The test and, most importantly, the test expectations are just split; they did not change. Bug: chromium:1049444 Change-Id: Ie2288bafa5807726cfd1fddc5d91189bc2ad905a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042105 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#739117}
-
Erik Chen authored
Change-Id: I8b387723819d1fd138915b507eaac4624fd34917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042683 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#739116}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e4d9391c167c..f5e5312d2154 Created with: gclient setdep -r src-internal@f5e5312d2154 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1044793 Tbr: jbudorick@google.com Change-Id: I12401cbd0db5aa03004ed14d779f5464faa9988b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042654Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739115}
-
Wan-Teh Chang authored
media/base/video_frame_pool.cc: remove an unnecessary test in a while loop. media/filters/dav1d_video_decoder.h: remove an unneeded #include. Bug: N/A Change-Id: I0014cee024c2321382f018bfbbe9065a9e135b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042675Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#739114}
-
Johannes Henkel authored
These files currently rely on getting these includes transitively via inspector_protocol generated code. Would like to make the dependency direct so it's easier to change the generated code. Change-Id: I84cb8889c6fd5c0d2245a91cb1b667f3e79f2a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037966Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#739113}
-
Peter Wen authored
Tbr: ender@google.com Bug: None Change-Id: Iba7a0e122310d7f7ba286dfd4c4296610a4f9bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042296Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#739112}
-
Ian Kilpatrick authored
This fixes timeouts that were occurring when FlexNG was enabled: https://test-results.appspot.com/data/layout_results/linux-rel/292466/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html (*/text-with-display-style.html) These tests timeout if they don't receive all the expected performance entries, causing the failure (the test never completes, waiting for the performance entries). The specific failure for FlexNG was occurring as we didn't have a ScopedPaintTimingDetectorBlockPaintHook for the flexbox on the stack, only one for the anonymous block-flow. This meant that the performance entry was never recorded for the flexbox element. Previously the ScopedPaintTimingDetectorBlockPaintHook would get emplaced in two different places - 1) Within BlockPainter 2) Within the inline painter This changes the EmplaceIfNeeded call to walk up the layout object tree to the first non-anonymous object which has a DOM node associated with it. This walk up the layout object tree should be relatively cheap. Most of the time it will be only walking up zero or one objects. Additionally with the layout object walk we don't need to EmplaceIfNeeded on nested <div>s, only when we actually encounter some text to be painted. Bug: 845235 Change-Id: I80e18539f70d2e1df56d3d85dd928dc10a35e28e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032428 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#739111}
-
Andrew Xu authored
The current test case for gfx::TransformBetweenRects only verifies the function on the source rectangle whose origin is at (0,0). This CL provides a more general test case. Bug: 1046983 Change-Id: I06a451ce7bcbad1344139792d6265d5313fe782d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036272Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739110}
-
Chris Davis authored
This change removes the watcher process. The watcher process is responsible for waiting for the browser process to exit and logs the exit code to a known registry location. Subsequent launches read from the registry location and log the value to a histogram. The watcher process was originally created prior to the creation of crashpad. Since all the watcher process is doing is waiting for the browser process to exit it makes sense to move this functionality to the crashpad process and get rid of the watcher process and code entirely. Use of the registry is now removed and the histogram is logged directly on shutdown. This change removes the chrome_watcher.dll which gives back ~ 1MB of disk space. Bug: 1043844 Change-Id: I666819e64817197e8950a9c5749c921fcebdb964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035054 Commit-Queue: Chris Davis <chrdavis@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#739109}
-
Virender Singh authored
This reverts commit c2f07278. Reason for revert: This change is causing regression. Bounding box calculation of a given element requires the |kScrollX| and |kScrollY| positions. In case of PDF there is a scroll element which lives outside the PDF node. The scroll element also reports scroll positions. During calculation of bounding boxes in AXTree::RelativeToTreeBoundsInternal |kScrollX| and |kScrollY| are applied twice. Original change's description: > Add viewport scroll information to PDFAccessibilityTree > > This CL adds following information to PDFAccessibilityTree > - ax::mojom::IntAttribute::kScrollXMin > - ax::mojom::IntAttribute::kScrollXMax > - ax::mojom::IntAttribute::kScrollX > - ax::mojom::IntAttribute::kScrollYMin > - ax::mojom::IntAttribute::kScrollYMax > - ax::mojom::IntAttribute::kScrollY > > It enables partial implementation of IScrollProvider, following methods > will work with this change > - IScrollProvider::get_HorizontallyScrollable > - IScrollProvider::get_VerticallyScrollable > - IScrollProvider::get_HorizontalScrollPercent > - IScrollProvider::get_VerticalScrollPercent > > This information is required by Screen readers to announce the current > scroll position and extent of scroll to the user. > > Tests: The best way to test this change will be through browser tests. > However, it requires the second part of the change, detailed in the > associated bug, to be completed. > > Bug: 1034521 > Change-Id: I629b2773c75f2b6b222d339cd0ae01799d695295 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985821 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Virender Singh <virens@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#728843} TBR=dcheng@chromium.org,thestig@chromium.org,mohitb@microsoft.com,virens@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1034521 Change-Id: I15675f9ba604be96e9c50c9bea1dbe84ef8c9a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041714Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#739108}
-
Yulun Wu authored
Bug: 1049281 Change-Id: Ib9d4ada81de8568cbfc5f7dc7f69ef3eb6470daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042192 Auto-Submit: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739107}
-
Jose Lopes authored
The original method declared the argument as OnceCallback: https://cs.chromium.org/chromium/src/chrome/browser/offline_pages/background_loader_offliner.h?rcl=f1e0ecaf7d175cf0f4eb923daa10511be4b11931&l=75 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Change-Id: I4f477760f4cf423d6352fd82041da75b2f0e1903 Bug: 714018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031405Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#739106}
-
Thomas Lukaszewicz authored
Views with backing Layers that set a |clip_path_| will now create a ViewMaskLayer object that masks the area designated by the clip. The View Layer and all child Layers will be masked by the ViewLayerMask. Made some small changes to the original set_clip_path() setter and calling functions. Bug: None Change-Id: Id746a72042d9f114144db01e289a603abe5afe9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031640Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#739105}
-
Colin Blundell authored
This will simplify the task of changing WebLayer to take advantage of the newly-componentized ContentMetricsHelper in a followup CL. Bug: 1030692 Change-Id: Iad9d8e557b73837ffd9c4506cec4ed63424b63cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041626 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#739104}
-
Sebastien Marchand authored
Bug: 1028410 Change-Id: I99d415261b48e05d401148dcf6b1165c0f020f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042311 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#739103}
-
nancy authored
The Crostini new terminal app is a system web app, although the app type in AppService is still Crostini. So update IsOpenedInBrowser to return true for the new terminal app id kCrostiniTerminalSystemAppId, so that AppServiceAppWindowLauncherController can skip that, and leave it to BrowserStatusMonitor to handle all windows related requests. BUG=1048906 Change-Id: Ie06f0616cf3a3ff6f25d2ad878151c8f71c98e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038930Reviewed-by:
-
gogerald authored
Bug: 1048225 Change-Id: I39b1e3d99fd092d95ad9dc9361e4912f92d6461a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036375 Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Matthias Körber authored
Change-Id: I7225bb27624db7abe7c95a13df9b79830c81ef9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035954 Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Reviewed-by:
-
Darin Fisher authored
This CL changes the IPC interface for prerendering by introducing Mojo interfaces PrerenderHandle, PrerenderHandleClient & PrerenderProcessor. PrerenderHandleClient is a rename of PrerenderDispatcher, but now with that name indicates how it relates to a requested prerender. PrerenderHandle corresponds to a requested prerender. This name is chosen intentionally to match prerender::PrerenderHandle and blink:: PrerenderHandle. These all correspond one-to-one. PrerenderProcessor is the interface used by a renderer to make requests for prerendering. It is instantiated per-frame, which enables the browser to get the render_view_id without it having to be passed over IPC as a parameter. A future CL will be able to move these interfaces into Blink, and then eliminate some of chrome/renderer/prerender, WebRenderer and other Blink layers of plumbing. As part of this change, PrerenderLinkManager's list of LinkPrerender objects is changed to be a list of std::unique_ptr<..> instead since LinkPrerender objects are no longer copyable since they have to store a mojo::Remote to the PrerenderHandleClient. This impacted a fair chunk of code. The concept of prerender_id is also removed. That is no longer needed as each PrerenderHandle instance is effectively a unique ID. This in turn caused a good amount of surgery to prerender_unittest.cc. It makes some tests unnecessary since they were testing codepaths related to no longer valid prerender IDs and such. Change-Id: I1d1911a3a44fe8b4478b9a109048c3081e78822d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036906 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#739099}
-
Robert Liao authored
This is a mechanical change to remove implicit conversions of ScopedBstr to BSTR. BUG=1034666 TBR=dtseng@chromium.org,ganesh@chromium.org,grt@chromium.org,jamiewalch@chromium.org,pmonette@chromium.org,proberge@chromium.org,sky@chromium.org Change-Id: I9fa7d62bddeecd81d1944bb289bad2a5758fe7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038171Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#739098}
-
Elly Fong-Jones authored
Currently, if a DialogDelegate's Accept() or Cancel() method leads back into its Close(), two of the registered callbacks can be run, which is a violation of DialogDelegate's contract and causes confusing workarounds in client code. This often happens in code like this: void SomeBubble::OnDialogAccepted() { NavigateTo(kSomeURL); } where NavigateTo causes a page navigation synchronously, which causes the involved bubble to be closed. Instead: * In the near term, DialogDelegate should ensure that it never delivers more than one of these callbacks * In the far term, DialogDelegate should enforce that callers do not re-enter Close() from inside Accept() or Cancel() The latter will likely need to wait for the Accept/Cancel/Close callback refactor to be finished. This change also removes the remnants of the GlobalErrorBubbleView unit test suite, which were exercising this behavior deliberately. These tests were providing very little actual coverage and I have been gradually deleting them as I refactor GlobalError anyway. Bug: 1011446 Change-Id: Ifd76330c0f79d04ce2e5741c5a1977159ee598d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042252 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#739097}
-
nancy authored
BUG=1006999 Change-Id: I2a85e86059c617e7676e9b9319fd8a245a197b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040639Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#739096}
-
Nick Burris authored
These tests need to perform cross-origin navigations as they test security restrictions that only apply to cross-origin. Bug: 1049624 Change-Id: I241962c44eaa1e4862e3df38be4b614491818b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042402Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#739095}
-
Jinsuk Kim authored
Now that Preview Tab is working on top of ThinWebView and BottomSheet, this CL deletes the old implementation that based it on OverlayPanel. Bug: 1043677 Change-Id: Icccc93cca3f09e9ae122b1e0dcb7537331136ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032466 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#739094}
-
