GitLab

Makes ServerBoundCertService::RequestHandle a real class which handles cancellation on destruction, instead of being just a void* handle.

BUG=167705

Review URL: https://chromiumcodereview.appspot.com/11689002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175902 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=any NaCl test on Linux

Review URL: https://codereview.chromium.org/11819022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175901 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168602
TEST=existing unittests

Review URL: https://codereview.chromium.org/11786006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175900 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/11649054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175899 0039d316-1c4b-4281-b951-d872f2087c98

<webview>: BrowserPlugin methods are not defined immediately after the shadow object is appended to the shadow root

BUG=169038
Test=manually


Review URL: https://chromiumcodereview.appspot.com/11820029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175897 0039d316-1c4b-4281-b951-d872f2087c98

Step got dropped in python refactor.  Adding it back.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11829034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175896 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11818011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175895 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167331
TEST=run_tests.py -v -e -n 2

Review URL: https://codereview.chromium.org/11801016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175894 0039d316-1c4b-4281-b951-d872f2087c98

Also, don't mark a test as finished until the top frame stopped loading.

BUG=111316
R=marja@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11830020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175893 0039d316-1c4b-4281-b951-d872f2087c98

With the context checking DCHECK, ash_unittests and unit_tests now run on chromeos.

BUG=161882


Review URL: https://chromiumcodereview.appspot.com/11801027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175892 0039d316-1c4b-4281-b951-d872f2087c98

This generates grd files from the three strings.xml files, as part of
translating the strings.xml strings. This also adds empty translation
files (xtb files) so that the grd files can be successfully built even
before real translations are available.

BUG=165551


Review URL: https://chromiumcodereview.appspot.com/11829009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175891 0039d316-1c4b-4281-b951-d872f2087c98

After more investigation of what it would take to share the webui code framework from chrome with content, it didn't seam feasible to do this. The code in chrome (i.e. ChromeURLDataManager) is heavily tied to chrome, and is used by chrome for non-webui stuff. The JS code is also specific to Chrome. It seems better to not bring in all this stuff to content.

> Allow multiple WebUIControllerFactory objects to be registered. This makes is possible to implement webui inside content.
> Review URL: https://codereview.chromium.org/11783038

TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/11818036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175890 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a help center link to the infobar which is displayed when
a NaCl app doesn't support the user's architecture.

R=jvoung@chromium.org,sehr@chromium.org (code), cstefansen (URL)
BUG= http://code.google.com/p/chromium/issues/detail?id=168607


Review URL: https://chromiumcodereview.appspot.com/11593020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175889 0039d316-1c4b-4281-b951-d872f2087c98

Apparently the problem is in non-media code.
See http://crbug.com/166528

> Disable Http/MediaTest.VideoBearWavPcm/0 to stop ASAN failures.
> 
> BUG=169031
> TBR=scherkus@chromium.org
> 
> Review URL: https://codereview.chromium.org/11817021

TBR=acolwell@chromium.org
Review URL: https://codereview.chromium.org/11821035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175888 0039d316-1c4b-4281-b951-d872f2087c98

It is always false and not planned to be supported

BUG=


Review URL: https://chromiumcodereview.appspot.com/11785011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175887 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tonyg
CC=sullivan

Review URL: https://codereview.chromium.org/11778070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175886 0039d316-1c4b-4281-b951-d872f2087c98

bb_tests was not passing in the path to adb to adb_logcat_monitor.py,
which broke the command.

R=boliu@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11827031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175885 0039d316-1c4b-4281-b951-d872f2087c98

For textures, delay allocating until the first setPixels
or beginSetPixels. This allows us to do a combined async
allocation/upload in beginSetPixels.

BUG=161337


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173875

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174035

Review URL: https://chromiumcodereview.appspot.com/11622008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175884 0039d316-1c4b-4281-b951-d872f2087c98

DEPS rules to make visitedlink independent of chrome/browser except chrome/browser/[api, common]

BUG=none


Review URL: https://chromiumcodereview.appspot.com/11746027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175883 0039d316-1c4b-4281-b951-d872f2087c98

Touch-events targetted to the root-window can be handled. This can happen
when, for example, an event handler is installed on the Env, or the RootWindow,
which takes some action based on the touch event.

BUG=chrome-os-partner:17053

Review URL: https://codereview.chromium.org/11833007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175882 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11824012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175881 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175880 0039d316-1c4b-4281-b951-d872f2087c98

The python unittest failed to run setUpClass/tearDownClass because of python version is 2.6 in pyauto bots. This CL makes a workaround to fix this issue.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11830030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175879 0039d316-1c4b-4281-b951-d872f2087c98

TBR=noel
TEST=
BUG=


Review URL: https://chromiumcodereview.appspot.com/11820028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175878 0039d316-1c4b-4281-b951-d872f2087c98

    
This moves thread pool related code out of the tile manager and into a
new RasterWorkerPool class. This doesn't change the behavior of the tile
manager in any way it just separates tile management logic from the
thread handling logic, which results in a significant cleanup of the
tile manager.
    
BUG=155209
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/11593030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175877 0039d316-1c4b-4281-b951-d872f2087c98

In order to facilitate the move to MessageCenterNotificationManager, we
need to be able to determine when message_center.gyp is being included
in the build.  This change defines ENABLE_MESSAGE_CENTER which can be
used for conditional compilation.

r=stevenjb@chromium.org
TBR=ben@chromium.org

BUG=168605

Review URL: https://chromiumcodereview.appspot.com/11791004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175876 0039d316-1c4b-4281-b951-d872f2087c98

Fix the last of the #includes and OVERRIDEs in preparation for removing WebKitPlatformSupport upstream.

Review URL: https://chromiumcodereview.appspot.com/11821025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175875 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168648

Review URL: https://chromiumcodereview.appspot.com/11734009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175874 0039d316-1c4b-4281-b951-d872f2087c98

callbacks for methods without any parameters, and it wasn't showing properties
for objects within arrays.

Review URL: https://codereview.chromium.org/11823033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175873 0039d316-1c4b-4281-b951-d872f2087c98

The existing code: choose the newer items, the new code: choose the older items
I wrote this existing code, but I was wrong.

BUG=165768
TEST=message_center_unittests passed


Review URL: https://chromiumcodereview.appspot.com/11827010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175872 0039d316-1c4b-4281-b951-d872f2087c98

This change appears to be breaking the ChromeOS(x86) and ChromeOS(amd64) bots.
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/11010

> Clean up: remove unnecessary if-branches on initialization of the a11y prefs.
> 
> According to the comment at preferences.cc:96, some accessibility prefs may be already registered in WizardController::RegisterPrefs. But the magnifier prefs are never registered there, hence we can remove if statements.
> 
> BUG=none
> TEST=launch ChromeOS, and login.
> 
> Review URL: https://chromiumcodereview.appspot.com/11820018

TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/11817029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175871 0039d316-1c4b-4281-b951-d872f2087c98

There is no known issues with UMA poisoning, but a command line flag has been
added to make sure.

BUG= none


Review URL: https://chromiumcodereview.appspot.com/11828009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175870 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175869 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dimich@chromium.org,jsbell@chromium.org
BUG=108628,162829
TEST=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11828025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175868 0039d316-1c4b-4281-b951-d872f2087c98

BUG=169021
R=nirnimesh@chromium.org,marja@chromium.org
CC=dennisjeffrey@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11826027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175867 0039d316-1c4b-4281-b951-d872f2087c98

This change adds an accessibility audit which runs just before tearDown() on any WebUI browser test that uses the chrome/test/data/webui/test_api.js framework.

As of this change, the test will run by default for each test case, but not cause any errors in the case of accessibility issues. As we fix accessibility issues, we can set the a11yIssuesAreErrors flag on a per-test and per-fixture basis, to catch regressions. Once the majority of WebUI pages are passing the accessibility audit, and we have a mechanism in place for ignoring false positives, we will transition to treating accessibility issues as errors by default.

http://www.chromium.org/developers/accessibility/webui-accessibility-audit has more information.

BUG=162740

Review URL: https://chromiumcodereview.appspot.com/11363170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175866 0039d316-1c4b-4281-b951-d872f2087c98

The official build was broken by r175584:
> host\desktop_process_main.cc(114): error C2039: 'InitializeCrashReporting' : is not a member of 'remoting'
> host\desktop_process_main.cc(114): error C3861: 'InitializeCrashReporting': identifier not found

Only the official builders were affected since remoting::InitializeCrashReporting() call is guarded by "#ifdef OFFICIAL_BUILD".

BUG=134694

Review URL: https://codereview.chromium.org/11827024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175865 0039d316-1c4b-4281-b951-d872f2087c98

This directory is only checked out when target_os=['android']. So we can't
assume that adb will always be in the chrome checkout.

TBR=nduca@chromium.org
BUG=None
TEST=./tools/perf/run_multipage_benchmarks --browser=list

Review URL: https://codereview.chromium.org/11820035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175864 0039d316-1c4b-4281-b951-d872f2087c98

Add ui/resources/default_[1|2]00_percent/close_dialog*.png
(copied from chrome/app/theme/default_[1|2]00_percent/web_ui_close*.png)
(these are the most up-to-date image that we want to use)
Add IDR_CLOSE_DIALOG[_H|_P] to ui_resources.grd

TODO(followup): Remove IDR_WEB_UI_CLOSE* and images, use IDR_CLOSE_DIALOG*.
(that will depend on WIP CL https://codereview.chromium.org/11830002)

BUG=166075
TEST=NONE
R=sky@chromium.org

Review URL: https://codereview.chromium.org/11785037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175862 0039d316-1c4b-4281-b951-d872f2087c98

It is preferrable to print buildbot step annotations before calling
tester runners so that the call is listed in the proper step.  This
patch removes the step annotation printed by the test runner inself.

BUG=161993
R=frankf@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11775013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175861 0039d316-1c4b-4281-b951-d872f2087c98