- 11 Apr, 2020 40 commits
-
-
Rouslan Solomakhin authored
Before this patch, an unowned function pointer would be invoked asynchronously with a reference to the possibly freed reference to the browser context, which could cause use after free in certain circumstances. This patch makes the browser context own the callback and binds the function with a weak pointer, so freeing the browser context invalidates the weak pointer, which cancels the callback execution. After this patch, freeing the browser context aborts the asynchronous callback that dereferences the browser context, so the use after free is prevented. Bug: 1065298 Change-Id: Id6de3099a55c4505e94a8a6d21fb25d6d2b34c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144311Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#758404}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e9cfb35d0901..f63c870256d3 Created with: gclient setdep -r src-internal@f63c870256d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I4b144c30e397e13f9fb8c591c865a9ca02174217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146347Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758403}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dc69fd2b80c9..adc4da30f420 git log dc69fd2b80c9..adc4da30f420 --date=short --first-parent --format='%ad %ae %s' 2020-04-11 marinaciocea@webrtc.org [InsertableStreams] Fix video receiver simulcast. Created with: gclient setdep -r src/third_party/webrtc@adc4da30f420 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065838 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I321b45438cf696e59b9522b27d948d1ea277875b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146348Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758402}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I6e23638ea9d5c9c21670a13f13b436bac27e8606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144441Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758401}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d37010c9b708..dc69fd2b80c9 git log d37010c9b708..dc69fd2b80c9 --date=short --first-parent --format='%ad %ae %s' 2020-04-11 marinaciocea@webrtc.org [InsertableStreams] Fix video sender simulcast. Created with: gclient setdep -r src/third_party/webrtc@dc69fd2b80c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065838 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia0344df076b95dd56399bf1c23040da1e9ee7dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146344Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8fb658105806..30c590849d00 git log 8fb658105806..30c590849d00 --date=short --first-parent --format='%ad %ae %s' 2020-04-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@30c590849d00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iba9afeb5ea5c93458f9ec97c7fb74ef311102eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146345Reviewed-by:
-
Roman Sorokin authored
TBR=antrim@chromium.org Fixed: 949239 Change-Id: If390e8e653dff58b9c33d3bd871cdcf6d1ad67a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144181Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758398}
-
Karandeep Bhatia authored
Remove the thread check in ClearRendererCacheOnNavigation. This should always be called on the UI thread. BUG=696822 Change-Id: I25f0059b43dd25bcabf3f52fa1c645bd5a211136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145699 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#758397}
-
Rainhard Findling authored
* Follow-up to https://crrev.com/c/2132384. * Removes the string, the C++ side logic to string construction, the communication of the string to JS, and the handling of the string in JS. Bug: 1015841 Change-Id: I5cb7b20f1309306910fd0923fcfdcedc1c1253c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139713Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#758396}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d4198aab5e3..e9cfb35d0901 Created with: gclient setdep -r src-internal@e9cfb35d0901 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: nhiroki@google.com,reillyg@google.com Change-Id: Ie0218edc35ad3179583cf06504e11e63e67f16cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146341Reviewed-by:
-
Guido Urdaneta authored
Test in https://chromium-review.googlesource.com/c/chromium/src/+/2144276 Bug: 1065838 Change-Id: I8804f187dec8f889993c757fc8466faab032c107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142033 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#758394}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I7c2d96c4816be73344b5f9d6bd66761e16d5fbc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146340Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758393}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9d8cede79b05..d37010c9b708 git log 9d8cede79b05..d37010c9b708 --date=short --first-parent --format='%ad %ae %s' 2020-04-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 666362b2..318b9b3c (758256:758358) Created with: gclient setdep -r src/third_party/webrtc@d37010c9b708 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I998196b211ac73f9078319fe692231ef60738c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146313Reviewed-by:
-
Maggie Chen authored
The timeout limit for finch is still 60 seconds. But the parameter is updated accordingly to keep the same duration. Bug:949839,1069938 Change-Id: I503c574ecd2bec076f11bb351717154ccc1b207d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146054Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#758391}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/07e64e6eeffc..6812621f27e9 git log 07e64e6eeffc..6812621f27e9 --date=short --first-parent --format='%ad %ae %s' 2020-04-11 jophba@chromium.org Upgrade ARM64 bot configuration Created with: gclient setdep -r src/third_party/openscreen/src@6812621f27e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Id5db5d3ea77b3bf5c6897c68aa170dd0afd5f61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146338Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/daf94c56bcb3..459ecee2cbdc git log daf94c56bcb3..459ecee2cbdc --date=short --first-parent --format='%ad %ae %s' 2020-04-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps Created with: gclient setdep -r src/third_party/skia@459ecee2cbdc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I5793cd915a6abedc56b0a12f6bd92354ad5ecd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146336Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/868bd943887c..1d4198aab5e3 Created with: gclient setdep -r src-internal@1d4198aab5e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1058152 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I0c346e80bdd7cf58b5a6ecc8f05bc54c11b31dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146327Reviewed-by:
-
Yuki Shiino authored
This patch adds [Exposed=Window] IDL extended attribute to the IDL interface definitions that are missing the extended attribute. The necessity of [Exposed] is determined by the current behavior regardless of what each web spec specifies. In a follow-up patch, the bindings generator will be fixed so that it won't expose IDL interfaces unless [Exposed] is specified. Bug: 839389 Change-Id: Ib2cdb8801d1e3648c2e41d16617c41171fda0005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143173Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#758387}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8da8c788..a9439a50 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I446d54418dbda6e997ddb394e8c3e865b7a384ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143866Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758386}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b36549d189fb..8fb658105806 git log b36549d189fb..8fb658105806 --date=short --first-parent --format='%ad %ae %s' 2020-04-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@8fb658105806 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I23afe6a050dc7a6482b61614d0c7120115fe553e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146329Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8619cbe2379c..5b7292c8f8e2 git log 8619cbe2379c..5b7292c8f8e2 --date=short --first-parent --format='%ad %ae %s' 2020-04-11 zmo@chromium.org Fix more compilation warnings. Created with: gclient setdep -r src/third_party/dawn@5b7292c8f8e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1064305 Tbr: cwallez@google.com Change-Id: I7e4cbdfbe5f52a3b3c494800e2c27a4198e0b03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146322Reviewed-by:
-
Dominic Mazzoni authored
I was so confused as to why these tests had wrong expectations compared to what output they gave locally. Then I finally figured out that they were disabled in a totally different file. Bug: none Change-Id: Ia418e732e27f944731670ca64ed0c881f97f15e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145753 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#758383}
-
jameshollyer authored
Recent changes to pointer lock requests(https://crrev.com/c/2069199) caused an error in logic which allowed requests made while not in focus to be able to succeed. This meant that a request made while changing focus would cause a strange state. I also added an earlier check for focus so that we error out before reaching the browser. Bug: 1068339 Change-Id: If706d2a693ca6a9aa2a8cf6c85ed622b429b97fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138501Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#758382}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da1fe3609158..868bd943887c Created with: gclient setdep -r src-internal@868bd943887c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1067290 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I484ced4bf76cdfcf7a0d608012be7b3eac5fecea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146316Reviewed-by:
-
rbpotter authored
Bug: 829414 Change-Id: Ib5d24dab8540513e1f5179c3c0914c4572395980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975305 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#758380}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c0d7928ef7b0..b8b3f5ffc0ea git log c0d7928ef7b0..b8b3f5ffc0ea --date=short --first-parent --format='%ad %ae %s' 2020-04-11 nigi@chromium.org Update pixel/corpus tests to handle expected results for Skia. Created with: gclient setdep -r src/third_party/pdfium@b8b3f5ffc0ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ie4b4bf5a51b27fd311e37b214612f5668d6ecbaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146110Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5a9dcb95a981990497a4264d9fc4cea4ea08755e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146314Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ic963ff48b5a18849b5a2a6acab3d88219c769a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146320Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I9a5464835ef17d3f723ed11b70d0830d77251781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146113Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758376}
-
Bruce Dawson authored
google.com, not chromium.org. Change-Id: Ic89c09bb251d09635f4d164706c8cc17984f7e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145089Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#758375}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I6bee4ae4c054e265162d7165fd0ae8cce4151151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145686Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#758374}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a07910e9e064..da1fe3609158 Created with: gclient setdep -r src-internal@da1fe3609158 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:790886 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I29f3e272f4fe3931861509b7b15e910ffc70c8a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146100Reviewed-by:
-
Jimmy Gong authored
- Fixes a regression where the learn more link was referencing a bad URL. Bug: 1038646 Test: local Change-Id: I010531e4749c8421963c98107ea0305657192913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146061 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#758372}
-
Thomas Lukaszewicz authored
Bug: None Change-Id: If46d7accf1681d26f8aec80086412f4fc4a27774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144477 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#758371}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b795ffdd. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 380347e7 "[css-masking] Migrate clip-path-columns-svg-clippath-usou.html to WPT" 1f1bb9a6 "Adds ability to clear out assigned nodes to slot when slot is removed from shadow root." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6fc020a8d3ee6a1dfd8f689dec152d9d5fab40f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146154Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758370}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8cc69b103725..c0d7928ef7b0 git log 8cc69b103725..c0d7928ef7b0 --date=short --first-parent --format='%ad %ae %s' 2020-04-11 thestig@chromium.org Remove page parameter from FORM_SetFocusedAnnot(). 2020-04-10 tsepez@chromium.org Cover CJX_Form methods from JavaScript 2020-04-10 dhoss@chromium.org Remove spaces adjacent to bracket characters in some PDFs 2020-04-10 ankk@microsoft.com Modify input stream from files to have LF line endings Created with: gclient setdep -r src/third_party/pdfium@c0d7928ef7b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ibebd28b498dc0fb555dc635810b8a4c2472c0e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146099Reviewed-by:
-
Kyle Horimoto authored
UX has requested that we update two strings related to UMA consent. Additionally, this CL moves two strings which were OS-specific from settings_strings.grdp to os_settings_strings.grdp. Fixed: 1043688 Bug: 967883 Change-Id: I906c942ad4b093e95fad6ddc77960d49e879a281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146081 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Sam Bowen authored
* Allow string whenever a property is text, Thing, or Enum type. * Allow URL whenever a property is Thing or Enum type, /as long as/ the URL is a schema.org ID of an appropriate thing or enum. https://schema.org/docs/gs.html#schemaorg_expected Change-Id: I72edef99f705c64838f09829de6c34058b10b860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144401Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#758367}
-
Thomas Guilbert authored
This CL renames the video.requestAnimationFrame into the video.requestVideoFrameCallback API. It also updates non WPTs to use the new API. WPTs will updated in their own CL. Bug: 1012063 Change-Id: Id41c3979e1f74df51ab10bbff68a9a0b39b7ccd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144625 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#758366}
-
Andrew Comminos authored
Adds performance tests for both |includeContinuous: true| as well as the default event set. Removes existing test suppression. Bug: 1069468 Change-Id: I42ca33dfc07a9fdd97011aa81d05c430d4fbd204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146098Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
-
