GitLab

Start the animation a bit earlier, invoke the Assistant a bit later.
(see the bug for details).

Bug: 751752
Change-Id: Ic141fc6a1955f49fd26a7eab9e7128d0c1197fd0
Reviewed-on: https://chromium-review.googlesource.com/598774Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491553}

This change modifies the MojoInterfaceInterceptor so that the
'interfacerequest' event, fired when a request for the intercepted
interface is made, is dispatched in a new microtask instead of
synchronously.

This has the benefit of not reentering JavaScript to execute event
handlers synchronously which is both different from the usual case for
binding interfaces that are provided by other processes and avoids the
possibilty of attempting to dispatch this event to JavaScript from a
scope where script is forbidden.

Change-Id: I08b8c25a04da047381a3786af08b62979ca7b837
Reviewed-on: https://chromium-review.googlesource.com/594716Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491552}

In a previous CL: https://chromium-review.googlesource.com/c/579690 where
we refactor the Canvas2DLayerBridge, we did not null check before passing
calling the ReleaseMailboxImageResource.

This CL does the null check.

Bug: 751445
Change-Id: I86f59e8176a44ef53d591a560a4c0c4b6cad2676
Reviewed-on: https://chromium-review.googlesource.com/597226
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491551}

This change lets other test files avoid using the
DiscoveryNetworkMonitor singleton and converts TestBrowserThreadBundle
to ScopedTaskEnvironment.

Bug: 698943
Change-Id: Ib69cd42901b739e651a87cafa2ca4a2e214c48e2
Reviewed-on: https://chromium-review.googlesource.com/595017
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491550}

This change removes the deprecated SetBooleanWithoutPathExpansion from
base::Value. Existing usages are replaced by SetKey(key, Value(bool)).

Bug: 646113
Change-Id: I4d7f1a60909765ec6a956360312c11b32173429f
Reviewed-on: https://chromium-review.googlesource.com/590448
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491549}

This was added to prevent crashes. Let's remove it
now to see if those crashes were fixed, and to uncover
more failure cases, which may shed light on similar crash
bugs we cannot reproduce.

Bug: 708372
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1e89c3fcc859af65d82c9945a14cbf5aac8ef8c8
Reviewed-on: https://chromium-review.googlesource.com/598452Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491548}

Network statuses in network list were not updated after language change.
This CL fixes it.

Bug: 750988
Change-Id: Iff30dae38e8f9e7331606550f229ddbdf3faf5fc
Reviewed-on: https://chromium-review.googlesource.com/594952
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491547}

This CL changes the way ForcedSigninProcess is triggered by replacing
AccountsChangedReceiver observer with AccountManagerFacade one.

Bug: 698258
Change-Id: Ifc06392ea55aacfc7bf32b91f03eb930ac026f76
Reviewed-on: https://chromium-review.googlesource.com/598467Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491546}

In this patch, we move the hit test result scrollbar check for mouse
cursor from SelectAutoCursor to SelectCursor to ensure it does not
override by the scrollbar's owner element.

Bug: 290466
Change-Id: I72f721deadde3da9329c43f9e216b2ac3db08e7e
Reviewed-on: https://chromium-review.googlesource.com/598887
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491545}

Implements HitTestDataProvider for Mus and wire it to
ClientLayerTreeFrameSink. HitTestDataProviderMus makes use of
refactored WindowTargeter::GetHitTestData() to get the hit test
rectangles from a window and associates those with the window ID
and transform before passing it to compositor.

Bug: 732395
Test: aura_unittests --gtest_filter=*HitTestDataProviderMusTest*
Change-Id: Id492e53527387e9e91bf474cfb2bdea7548063ad
Reviewed-on: https://chromium-review.googlesource.com/574882Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Valery Arkhangorodsky <varkha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491544}

This CL changes the chromeos login welcome page (and welcome dialog) to
use i18nDynamic rather than i18n-content and i18n-values.

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4c871e9b9e9f8dce8aa5c5da05972936e73e2a48
Reviewed-on: https://chromium-review.googlesource.com/596778
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491543}

Bug: 
Change-Id: I845d5c0eaf79d6f932a7193b3742a00a797ed2c4
Reviewed-on: https://chromium-review.googlesource.com/598237Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491542}

Change-Id: Ib1058007a2557ed7e3e36bff3909485220bc118a
Reviewed-on: https://chromium-review.googlesource.com/598232Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491541}

This CL Removes the use of IDC_SHOW_HISTORY and uses the dispatcher
instead.

Bug: 738881
Change-Id: Ia33b0303a19e2fe5e72d9e336f42c3c6faa2f81f
Reviewed-on: https://chromium-review.googlesource.com/596921Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491540}

Set up the GTest and Mocha-based a11y testing framework for Chrome WebUI
by defining an accessibility_browsertest.js file for a11y test fixtures
and including this file in the BUILD.gn.

The passwords section now fires an event when the settings section has
expanded--an event that is responded to in the added a11y test.

The tests are disabled and will be enabled in followup CL for easier
review.

Bug: 737739
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ief6b002d8ce17950203c917a9baee05e3ac9136c
Reviewed-on: https://chromium-review.googlesource.com/598638
Commit-Queue: Tina Quach <quacht@google.com>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491539}

We have a similar issue to crbug.com/746931 on Chromecast Ultra.
Disable the feature temporarily while root cause is determined.

BUG=internal b/63101386

Change-Id: I125b9867ef033cc1c65a5fef5a51882da619b338
Reviewed-on: https://chromium-review.googlesource.com/598641Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491538}

It will be one of the default ARC apps, but we don't want it to show
up in the launcher.

BUG=744719
TEST=Install a new image build with the new PAI apk, and make sure
Clock don't show up in the launcher, yet it is installed from the
play store.

Change-Id: I9994c740f4bad64515a4b88c6d6734684f9f6ec2
Reviewed-on: https://chromium-review.googlesource.com/594664Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491537}

BUG=b:64029031
TEST=None

Change-Id: I3b14f8f6f2fc3867548578937334a288b33e06ed
Reviewed-on: https://chromium-review.googlesource.com/597169Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491536}

Bug: 747596
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I28e93a4b0be176718df12048fed66e4d696bd4de
Reviewed-on: https://chromium-review.googlesource.com/597111Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491535}

When playstore search is enabled, disable webstore search.

Bug: 751834
Change-Id: Ibcdcf7b90ae1c96debdc66854dfbc71f80c21421
Reviewed-on: https://chromium-review.googlesource.com/599067Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491534}

We receive a 1x1 frame when the shared window is minimized and will replace it
with a blackframe to avaoid video freezing at last frame. But due to frame size
rounding added later, the 1x1 frame will be dropped. Let's fix it again by
replacing it with a 2x2 black frame.

Bug: 568835
Change-Id: Ifd9a37b62e4f179318c8b30bee4687494d976ab1
Reviewed-on: https://chromium-review.googlesource.com/596920Reviewed-by: Zijie He <zijiehe@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491533}

Fuchsia is initially trying to get a headless build up and
running so gpu methods are unnecessary.

Bug: 743296
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5acc71a1be7b2058538a9e0d8d2bef4ba3ca4a52
Reviewed-on: https://chromium-review.googlesource.com/596506Reviewed-by: John Bauman <jbauman@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491532}

TBR=nednguyen@google.com

Bug: 713222
Change-Id: Icc17c0d1b782f1c553ff2995dfddad422086e821
Reviewed-on: https://chromium-review.googlesource.com/598191Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491531}

BUG=chromium:22532

Change-Id: If7b0f874fd75de0827df5b0d4edd24d4abca6834
Reviewed-on: https://chromium-review.googlesource.com/577635
Commit-Queue: Zentaro Kavanagh <zentaro@google.com>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491530}

This can return nullptr if the gpu process has failed to launch, or if
the browser main message loop has exited.

The other calls to GpuProcessHost::GetFromId do not dereference their
result without first checking against nullptr.

TBR=zmo (revied at https://codereview.chromium.org/2963433002/)

Bug: 723698
Change-Id: I556b8c937d9aaea8806902003209543b85823fb7
Reviewed-on: https://chromium-review.googlesource.com/595037Reviewed-by: ccameron chromium <ccameron@chromium.org>
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491529}

This applies only to code running under D3DVsync experiment.

My experiments show that increasing the GPU V-sync worker thread priority has 
a noticeable impact on latency on the GPU process side, even before the v-sync
signal is sent over IPC to the browser.

The tables below show the deltas (in us) between the adjusted DWM v-blank timestamp
and the now() time when on the thread wakeup on v-blank.
This was tested on a consumer grade DELL XPS laptop with 4 cores.

With the current DISPLAY priority the distribution looks like this:
< 0       9.8%
0-99      78.7%
100-199   4.8%
200-499   1.7%
500-999   2.2%
1000-1999 1.4%
2000-4999 1.0%
5000-9999 0.4%
10000+    <0.1%

With the higher REALTIME_AUDIO priority the distribution looks much improved
with a much steeper drop after 200 us:
< 0       8.6%
0-99      82.4%
100-199   8.5%
200-499   0.2%
500-999   0.2%
1000-1999 <0.1%

Bug: 751340
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I082d4561e6b27fc23e2242a9023c19d6787492fd
Reviewed-on: https://chromium-review.googlesource.com/596625Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Stanislav Chiknavaryan <stanisc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491528}

When firing the completion event make sure the document exists before
we try to get the rendered buffer that needs to be returned.

Bug: 751377
Change-Id: Id956f5a287b6b91b7bad04d85b6c8f3c32c9470d
Reviewed-on: https://chromium-review.googlesource.com/598727Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491527}

This CL moves SubresourceIntegrity calls to Resource, just before
CheckNotify(), where Resource::Data() is always available.
This makes
- SubresourceIntegrity always checked if integrity metadata is set, and
- SubresourceIntegrity and ResourceIntegrityDisposition control
  not depend on ResourceClients (ClassicPendingScript and LinkStyle).
  This removes Resource::SetIntegrityDisposition(), and
  and unblocks https://chromium-review.googlesource.com/c/562859/.

This CL also makes Resource cache SubresourceIntegrity::ReportInfo
in Resource, and thus outputs SRI console error messages and update
UseCounters for every classic script and stylesheet that shares
a Resource, not only for the first use (Issue 585267).

Bug: 746115, 701943, 585267, 653502
Change-Id: I03e7c22319980bd297cb5d9fb58589966a0b2f71
Reviewed-on: https://chromium-review.googlesource.com/576950Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491526}

BUG=750917

Change-Id: Ia6a2f446a6ae8ec0228c12f587756561df0e6051
Reviewed-on: https://chromium-review.googlesource.com/597376
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491525}

BUG=751783

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifefe73dbc4039201f32fef25fa48f04541d6af20
Reviewed-on: https://chromium-review.googlesource.com/598436Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491524}

BUG=751812
R=thestig@chromium.org

Change-Id: Ied009e9839bffced122137616b6bc3bcc7b337f0
Reviewed-on: https://chromium-review.googlesource.com/598945
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491523}

Update the ExtensionDownloader class to use the new task scheduling API,
as well as the dedicated Extensions-related file task runner.

Bug: 689520
Bug: 750122

Change-Id: I201adece7ae5d5f7a24f535faa86958d4fcff632
Reviewed-on: https://chromium-review.googlesource.com/594833Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491522}

This reverts commit 875aa3d7b80dd3d6a2f0a265d4ca1875b502abc6.

Reason for revert:

Breaks the M61 branch build

cc -o obj/ash/ash/voice_interaction_overlay.o
../../ash/shelf/voice_interaction_overlay.cc:170:43: error: no member named 'since_origin' in 'base::TimeTicks'
    uint64_t now = base::TimeTicks::Now().since_origin().InMilliseconds();

Original change's description:
> Add animated voice interaction icon.
> 
> BUG=b:62276007
> TEST=build flash locally, see animation as spec
> TBR=xiaohuic@google.com
> 
> (cherry picked from commit cc92f7ae)
> 
> Change-Id: I5542b68e084fe465c2f8b424b521c8faef51f686
> Reviewed-on: https://chromium-review.googlesource.com/585245
> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#490447}
> Reviewed-on: https://chromium-review.googlesource.com/595143
> Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3163@{#198}
> Cr-Branched-From: ff259bab-refs/heads/master@{#488528}

TBR=kaznacheev@chromium.org,oshima@chromium.org,xiaohuic@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:62276007
Change-Id: Ie8e554ca79f054e0e4d18621402123455950aa9c
Reviewed-on: https://chromium-review.googlesource.com/597071Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Original-Commit-Position: refs/branch-heads/3163@{#229}
Cr-Original-Branched-From: ff259bab-refs/heads/master@{#488528}(cherry picked from commit 020cdf35035e30942aa34ca571fce561bff18cf6)
Reviewed-on: https://chromium-review.googlesource.com/598507
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491521}

This is part of the TaskScheduler migration, see the linked
bug and various messages on chromium-dev for context.

Bug: 689520
Test: flashed to Chromebook, plugged in braille display.

Change-Id: Id7f196ba58d5e013c516e63266d47f9307e4d2d1
Reviewed-on: https://chromium-review.googlesource.com/589776
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491520}

When rotating the screen on iPad with the keyboard showing, for some
reason the host view will become improperly laid out. Part of the view
gets overlaid by the keyboard.

My suspicion is the view frame becomes inconsistent when the rotation
happens.

This CL fixes the problem by reworking the keyboard layout using
constraints. It also makes GLRenderer cache the view size before the
canvas is created.

Bug: 751273
Change-Id: I5146ff6bf602eef1857259e5e50ca6be1d952a68
Reviewed-on: https://chromium-review.googlesource.com/596913
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491519}

Currently creation of DiscardableSharedMemoryManager is controlled by whether
the ServiceManager is remote. Rather than have content make this decision this
patch adds a parameter that lets the consumer of content control if
DiscardableSharedMemoryManager should be created.

This control is important for a config of ChromeOS where we want
content to create DiscardableSharedMemoryManager. This is needed to
avoid shutdown races as the implementation details of
DiscardableSharedMemoryManager assume DiscardableSharedMemoryManager
is shutdown shortly before process exit.

I'm doing this as a precursor to having ServiceManager run in process
in a config of ChromeOS (ash and chrome in same process), but this is
the source of some existing flakiness.

BUG=750390
TEST=covered by tests

Change-Id: Ia16e27b2cf85e7129819602e5acb889a21ac0a46
Reviewed-on: https://chromium-review.googlesource.com/595209
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491518}

BUG=598931
R=thestig@chromium.org

Change-Id: I0469f7a8e047556d23e387bd7193a4c529195b20
Reviewed-on: https://chromium-review.googlesource.com/598941
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491517}

TBR=ajwong@chromium.org

Change-Id: I9e4ea0a25c9dbf39dce5e07148b177aea8dd64b9
Reviewed-on: https://chromium-review.googlesource.com/598736
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491516}

Update the echoPrivate API to use the new task scheduling API, as well
as the dedicated Extensions-related file task runner.

Bug: 689520
Bug: 750122
Change-Id: Ie6d403cb700c71bc9faabd828b2f40f0826f85bd
Reviewed-on: https://chromium-review.googlesource.com/598464
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491515}

We do not compute a mask layer's draw transform because the target is
amubiguous for a mask layer. However when we compute mask layer's
occlusion in PictureLayerImpl::AppendQuads, the code treats mask layer
as a normal picture layer and uses default transform instead of the real
transform.

This CL makes PictureLayerImpl::AppendQuads use mask layer's render
target's draw transform when computing occlusion.

Bug: 747883
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Idc0de7674084df04df1f77e8726d3753f6877bf9
Reviewed-on: https://chromium-review.googlesource.com/594680Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491514}