- 23 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/08af1c80188f..88a99e4382c1 git log 08af1c80188f..88a99e4382c1 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 tobine@google.com Vulkan:Roll Loader 2019-10-23 tobine@google.com OES_depth32 is for render buffer capability Created with: gclient setdep -r src/third_party/angle@88a99e4382c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: Ie62667ad86bd376e1c668cd0c066c6392d56359e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875652Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708812}
-
Sammie Quon authored
It's an edge case when moving the divider either in portrait mode, or like in the video in the attached bug. Test: manual Fixed: 1017370 Change-Id: I78e11fc1785cf9d39363aa90c52a851243b9736e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877190Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#708811}
-
Mason Freed authored
Prior to this CL, the HTML Imports deprecation message would only be shown if HTML Imports was enabled directly by a command line flag. It would not show if the page being visited was participating in the Web Components v0 origin trial, and enabled the feature that way. Bug: 911943 Change-Id: I8884ea755fdcdd69e2af57c6f131eed83f76b4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876799 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#708810}
-
Natalie Chouinard authored
Bug: 1016957 Change-Id: I5baf2577d2df7fd37827811102bbcba746280542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876877Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#708809}
-
Sebastien Marchand authored
Most frames won't set a freeze origin trial policy and so making kDefault the default state when a frame gets created will reduce the number of IPC calls. This could cause pages to be frozen before all their frames have reported their policy, a following CL will unfreeze frozen pages that receive an opt-out OT token. Change-Id: I3059b57e44f9bbdb9fb9bdd8b860bebda36329a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872637Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#708808}
-
Evan Stade authored
Bug: 268984 Change-Id: I703e5a294a7c51d02a19cfd504cb8e0f2dfbd97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875270Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#708807}
-
Evan Stade authored
Bug: 268984 Change-Id: I49aa469198d7fe48d7d3cf10cc742499489decfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876912Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#708806}
-
Mathieu Binette authored
Following up on change https://crrev.com/i/2022512. Change-Id: I5cdb19e71d9999aa7a4bc90d866f06668ed53648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876788Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Mathieu Binette <mbinette@google.com> Cr-Commit-Position: refs/heads/master@{#708805}
-
Jia authored
This cl adds more logging into sys report so that we can help users better when they file a bug report. Bug: 881215 Change-Id: Iea0f1ef052d68ee608f64fed25e1a727b1c50c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871719 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#708804}
-
Anastasia Helfinstein authored
Bug: None Change-Id: I10a3685214f10695de897510199450d687b1ab8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874053 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#708803}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/577977ad233c..376ccc06cd30 git log 577977ad233c..376ccc06cd30 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 sadrul@chromium.org trace-viewer: Make some style changes for the toolbar. Created with: gclient setdep -r src/third_party/catapult@376ccc06cd30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1017326 Change-Id: I5baadf45053f51c4b61d1b5f21caa0a8c20fe24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876915Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708802}
-
Peter Kotwicz authored
This CL daggerizes WebappActivity. BUG=1016650 Change-Id: I06f75fdce90985bfb6a59efca0ce268032821375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873276 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#708801}
-
Ricardo Quesada authored
This CL adds the "installPWAForCurrentURL" function into private_autotest. This functionality is needed for some Tast tests. BUG=chromium:1015520 TEST=locally tested using a Tast test that is WIP. Change-Id: I710fb788142d3c3984394aceca1311d7f3652dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866851 Commit-Queue: Ricardo Quesada <ricardoq@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708800}
-
Etienne Bergeron authored
A recent change in RenderText caused a regression while showing command accelerators on MAC (see: http://crbug.com/1016676). The change in RenderText is replacing the embedded control characters with their equivalent unicode visual pictures. This change should not cause that regression. By digging into the code, we found that some strings are incorrectly providing string with embedded nul character. These controls characters doesn't have 'glyphs' in font and will triggers expensive font fallbacks before faling to find the appropriate font. This CL is removing the leading \0 character from Accelerator::KeyCodeToMacSymbol(...) R=robliao@chromium.org,ellyjones@chromium.org CC=thomasanderson@chromium.org Bug: 1016676 Change-Id: Iaf3de8e5aec4de4e63e09f1071bf27768d0762d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876468Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708799}
-
Christopher Cameron authored
As part of the investigation of the hangs in the Metal shader compiler, we will be running some Metal code in the browser process. Create a stand-alone component for Metal utility functions that will be used in the browser process and also in the gpu process. For the moment this functionality includes the C++ Metal types and the function to select the default Metal device (low-power if available). Functionality to compile a test shader to determine if it hangs will also be moved there (and called from the browser process). Bug: 974219 Change-Id: Ic6a696686e0c438ec339c6cc40b8200be6b0a689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869127 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#708798}
-
Garrett Beaty authored
Bug: 922150 Change-Id: I77a1e390bdcef85cd538b204ee6274cc52fe2a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859636 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#708797}
-
Dave Tapuska authored
In order to use cc::TouchAction on the blink mojom API we require it the definition to move to somewhere blink can depend on (not content). Being that touch_action is defined in CC it seems natural to introduce it there. BUG=1008432 Change-Id: I62ab198a169bd242d36e27a5357636800e296593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867036Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#708796}
-
Alexei Svitkine authored
Some small fixes and Py3 compatibility. Bug: None Change-Id: I09855299135799527dbcf4d0070a2ce9d9147d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872564 Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#708795}
-
Avi Drissman authored
It's ignored by the Mac codesigning apparatus nowadays, anyway, so this simplifies things. Bug: 913074 Change-Id: I1aff929788171821a835bd5a4eed5514fe2df1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876764Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708794}
-
Daniel Libby authored
Revert the code changes from crrev.com/c/1590960 and mark the histogram as obsolete. We were investigating how modifying the slop region affected this metric, and have seen data showing that, as expected, the metric goes proportional to the decrease in slop distance. Bug: 988762 Change-Id: I802aad4f80b718d163f4b536f3ee66e7a90b3526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875367Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#708793}
-
Christopher Cameron authored
In order to do this, we will need to know whether or not a PWA is installed for a given profile, without actually loading that profile. The suggested mechanism for this is to check the for the presence of a Extensions/app_id subdirectory of the profile path. Add a profile_menu_items_ member to ExtensionAppShimHandler that lists all profiles in the AvatarMenu. Add a installed_profiles member to ExtensionAppShimHandler::AppState that lists all profiles for which a given app is installed (this is a subset of the profiles in ExtensionAppShimHandler:: profile_menu_items_). Add a ExtensionAppShimHandler::Delegate::GetProfilesForAppAsync method to do the aforementioned path check. Update ExtensionAppShimHandler::UpdateAppProfileMenu to sort menu items by |menu_index| and to send an empty list if just one profile would have appeared in the menu. Add tests. Restructure tests such that ExtensionAppShimHandler takes its delegate as a constructor argument (instead of having it be set-able). R=dominickn TBR=skuhne Bug: 1001215 Change-Id: I10bb7128c6f775759f1d1f381000eb7b33960eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864098Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#708792}
-
Matt Menke authored
This sets what field trials are enabled by default when running tests, and is needed before the option can be enabled on beta. The option is added to the pre-existing experiment PartitionConnectionsByNetworkIsolationKey to mirror the server-side configuration. Bug: 963480 Change-Id: Ib1a6ca42b997658f2b66658b9ba2713f1669545d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873959Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#708791}
-
Natalie Chouinard authored
Add a generic isManagedPreference method to PrefServiceBridge, making use of the prefs.h enums. Migrate Java usages of prefs::kSearchSuggestEnabled to use the generic methods as a sample (more to follow). Bug: 1016957 Change-Id: Ib13181fd9ed6c2e2265b08c141985899bfbabe0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874719Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#708790}
-
Ian Clelland authored
This macro had apparently not been effective at detecting removed origin trials since the OT/RTEF bindings were refactored earlier this year. WebVR was removed from OT without triggering an assertion failure. This CL fixes that now by testing for a method which is only generated if the feature is part of a trial. Bug: 960132 Change-Id: I1a8d8542d3c2513170ac5fc57411991e3988d938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874191 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#708789}
-
Brian White authored
Adds expires_after attribute for 7 histograms that do not already have one. The date will get pushed out automatically if significant use is detected. Change-Id: I8d2c670e6619a8e2d3477b982fcedfe4a7a9892e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876751Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@google.com> Cr-Commit-Position: refs/heads/master@{#708788}
-
Michael Ludwig authored
This relaxes the requirements for tiled draw quads that can bypass a RenderPass. Previously, the content quad had to have an identity transform and fill the RenderPass's layer. With this change, the geometry and transform constraints go away, and the RPDQ params struct is updated to remember the additional transform that has to be applied to draw the content correctly. The base transform and the new transform are kept separate because the image filters of the render pass have to be processed in the base transform's coordinate space. However, we also don't want to just draw the base geometry with the content quad's textures because the texture coordinates may not map to a gfx::Rect anymore. Storing separate transforms cleanly handles both of these challenges. Bug: 1013735 Change-Id: I0a05d2aa318238dae093899c697fac6a84e5c261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860302 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#708787}
-
Matt Menke authored
The NetworkService only considers redirects to certain schemes it's familiar with unsafe. Now that it no longer handles data or file URLs, there's no such scheme. As a result, allowing redirects to unsafe URLs doesn't actually do anything. The same mechanism was also being used to preserve the (lack of) a fragment on redirects injected by extensions, rather than copying over the fragment like a normal redirect, so in its place, add a concept of a URL that, if redirected to, keeps its frament. Unfortunately, the unsafe URL concept is still used for redirects to chrome URLs on iOS (which doesn't allow that to be overridden), so this CL does not completely remove the concept of unsafe redirects. Bug: 934009 Change-Id: I366156d94aed9067ff18dc14bfd7bf9142817123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869727 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#708786}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6adb0a26846c..d7bf5c56b69b git log 6adb0a26846c..d7bf5c56b69b --date=short --no-merges --format='%ad %ae %s' 2019-10-23 mbonadei@webrtc.org Revert "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." 2019-10-23 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." 2019-10-23 danilchap@webrtc.org change PacketBuffer to return it's result rather that use callback 2019-10-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6dc3a51e..b5030084 (708537:708640) Created with: gclient setdep -r src/third_party/webrtc@d7bf5c56b69b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: I7bd0d1650c7147745e0b051076aba23c45aa9a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876968Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708785}
-
Stephen McGruer authored
This reverts commit 29a875e1. Reason for revert: Strong suspect for compile failure blocking the tree: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8898774375244271360/+/steps/compile/0/stdout Original change's description: > Add underflow duration to our media UKM reporting. > > This associates a completed underflow count and total underflow duration > with each segment of watch time reported to UKM. > > Generally the completion will always fall within a given segment of > watch time, however it is possible that a completion can happen after a > resolution change or other secondary property update and thus end up in > a subsequent segment. > > We impose impose a maximum value of 1 minute for rebuffer durations to > avoid noise from rebuffers which may cross a suspend/resume boundary. > > BUG=994021 > TEST=new unittests > R=sandersd > > Change-Id: I1b4386845e21ec17472cbf8c85bf62185e28eb25 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869023 > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708778} TBR=dalecurtis@chromium.org,meacer@chromium.org,sandersd@chromium.org,holte@chromium.org Change-Id: I6bdff8dee0fb365eabee3bea8501a22155059d0d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 994021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877192Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708784}
-
Martin Barbella authored
This was not an issue in release builds, but it's causing failures in libFuzzer debug builds. Change-Id: Ic4297a97c3cd6361e778b19f66aa8779bbb89e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875516 Auto-Submit: Martin Barbella <mbarbella@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#708783}
-
Daniel Rubery authored
The stable_eset tag was deprecated August 22, but Omaha is still reporting many users still using the stable_eset tag. It's possible something is pulling tag values from fieldtrial_testing_config, so add a unique value for those tags. Fixed: 1017200 Change-Id: Icc8dd004cf84e6f3af05e03d0eb7a9ce03719617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876026Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#708782}
-
Sinan Sahin authored
This CL adds the plumbing to have separate top and bottom shown ratios. Having separate ratios is required for the upcoming CLs as we ultimately want to be able to animate the top and the bottom controls independently. Bug: 989148 Change-Id: I874cf7f6fa0380cb9a1497d3804969b82bd419c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827951 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#708781}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e9462dd2dac4..cba64462d266 git log e9462dd2dac4..cba64462d266 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 mtklein@google.com hide color filters from blitters 2019-10-23 bsalomon@google.com Rewrite ReadPixels_Gpu test to be more exhaustive and share code. Created with: gclient setdep -r src/third_party/skia@cba64462d266 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: Ie0a193841f0a5eeb75030ff940ac53e6f7d6e9d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876080Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708780}
-
Ben Kelly authored
Bug: 1016901,925035 Change-Id: Iaec42b329c4b8a84011a999181ed4d89cf976c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876491Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#708779}
-
Dale Curtis authored
This associates a completed underflow count and total underflow duration with each segment of watch time reported to UKM. Generally the completion will always fall within a given segment of watch time, however it is possible that a completion can happen after a resolution change or other secondary property update and thus end up in a subsequent segment. We impose impose a maximum value of 1 minute for rebuffer durations to avoid noise from rebuffers which may cross a suspend/resume boundary. BUG=994021 TEST=new unittests R=sandersd Change-Id: I1b4386845e21ec17472cbf8c85bf62185e28eb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869023Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#708778}
-
Mason Freed authored
This flag was on by default but only took effect if HTML Imports was also enabled. The [1] commit disabled Custom Elements v0 and Shadow DOM v0, but it also disabled the HTMLImportsStyleApplication flag. This broke some sites (notably Youtube) that use HTML Imports with imported style sheets. This CL fixes that breakage, and removes this unnecessary flag. [1] https://chromium.googlesource.com/chromium/src/+/f52dff0d3c5bc52ba608920f843162832f2da6b1 Bug: 1017069 Change-Id: I0f806635185932abab8d675fdb0814ede1fb8465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876744Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#708777}
-
Yulun Wu authored
Bug: 1016946 Change-Id: Ib9bb97271e18eb1428eded141068a4c0526a8096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872481Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708776}
-
Evan Stade authored
This is relatively easy because every WebContentsDelegate that overrides LoadProgressChanged is also a WebContentsObserver (aside from a few thunks which are easily updated). This fixes a TODO and makes upcoming changes to WebLayer APIs more natural. While we're at it, convert Clank from using integer progress in [0,100] range to float progress in [0,1] range. Change-Id: I3020aaa1848361d134f7422cc226f838f624dacc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872740 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#708775}
-
Wei-Yin Chen (陳威尹) authored
- All thumbnails shown can be released after GTS is gone. - No thumbnails are loaded before GTS becomes visible. Bug: 983170 Change-Id: Ib7b38909625033c82213f728b6d2e9d4a33e7b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868844 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#708774}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4900f195bb83..9709599c10ff Created with: gclient setdep -r src-internal@9709599c10ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic97ea5e1ed4574cbca38d0d2f12725461368591f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876079Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708773}
-