- 16 Mar, 2020 5 commits
-
-
Kunihiko Sakamoto authored
TBR=jbudorick@chromium.org Bug: 1061624 Change-Id: I37032590b3ab08ecf56da3a33987b6da6142cd02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104569Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#750450}
-
nancy authored
When Playstore is removed, OnAppStatesChanged is called, and then OnAppRemoved is called. 1: Playstore removed 2: OnAppStatesChanged 3: OnAppRemoved When OnAppStatesChanged is called, ArcApps updates the icon key, so AppServiceAppItem and AppServiceAppIconLoader reload icon with mojom. 1: Playstore removed 2: OnAppStatesChanged -> AppServiceAppItem::LoadIcon -> AppServiceAppIconLoader::LoadIcon Before ArcApps receives the load calls, ArcIconOnceLoader's OnAppRemoved has clear the ArcAppIcon. So when ArcIconOnceLoader receives the load icon calls from AppServiceAppItem and AppServiceAppIconLoader, ArcIconOnceLoader won't clear the ArcAppIcon again, and ArcIconOnceLoader still calls ArcIconOnceLoader to load icon. 1: Playstore removed 2: OnAppStatesChanged -> AppServiceAppItem::LoadIcon -> AppServiceAppIconLoader::LoadIcon 3: OnAppRemoved -> ArcIconOnceLoader::OnAppRemoved 4: ArcIconOnceLoader::LoadIcon -> Create ArcAppIcon to load icon However, the ARC apps have been removed, so ArcAppIcon can't load the icon, and ArcIconOnceLoader and IconCoalescer just keep waiting the icon load result. Modify ArcApps, when the app has been removed, don't call ArcIconOnceLoader to load the icon. Tried to update ArcAppIcon to return result when time out, but that method doesn't work. Because when Playstore is re-enabled, MaybeRequestIcon should be called to ask Arc pref to reload the icon, but ArcIconOnceLoader doesn't know when the app is re-installed, so it can't call MaybeRequestIcon to reload the icon, so when Playstore is re-enabled, it still can't load the icon. b:149229735 Change-Id: I2ac61fe598f9e9d0314a248150f8897c3eb57e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072337 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#750449}
-
Luciano Pacheco authored
This reverts commit ea497580. Reason for revert: Feature moved from M-82 to M-83. Original change's description: > Files app: Enable flag files-ng by default > > Add files-ng classes and attribute to main.html so files-ng styles are > applied during app startup (to avoid a FOUC flash of non-files-ng blue > color). > > Enable file-ng by default in FilesApp and its browser test harness. > > Bug: 992818 > Change-Id: If437271c5604d36b4b0908abb663a84e52b6ae35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087308 > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Commit-Queue: Alex Danilo <adanilo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747421} TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org Bug: 992818 Change-Id: I8b1c770e2c43823eff9a2a9aceae650fcb25a3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103992Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#750448}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/869e901ad7dd..a4a42e6d0baa git log 869e901ad7dd..a4a42e6d0baa --date=short --first-parent --format='%ad %ae %s' 2020-03-15 jmadill@chromium.org Format perf_test.cc. Created with: gclient setdep -r src/third_party/angle@a4a42e6d0baa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I5be1cccb70bd6a5a88f06c9189788fe4aa121dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103663Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750447}
-
Caleb Rouleau authored
Some of the reimaging to android M didn't work. Do not revert this change if it appears to cause a perf regression. That regression was likely caused by upgrading the devices from Android version K to Android version M. DO NOT REVERT this change. TBR=johnchen@chromium.org Bug: 1041944 Change-Id: Idbcc6de3bd69dfe2724e146dfee1b25e32518f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104453 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#750446}
-
- 15 Mar, 2020 29 commits
-
-
Gyuyoung Kim authored
Below flaky tests were fixed by converting BlinkTestHostMsg_PrintMessage. So, this CL unmarks the flaky tests again. fast/forms/file/file-input-webkitdirectory-key-enter.html fast/forms/file/file-input-webkitdirectory-click.html fast/forms/file/file-input-webkitdirectory-key-space.html fast/forms/file/file-input-click.html Bug: 1059322 Change-Id: I1bff2cfbafe264a04612c06ffd089cdf2fe62173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102991 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#750445}
-
Jing Wang authored
Change-Id: Ic4e881dd93cf1041cef95db75f3f9cd9ba3c05af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087881Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750444}
-
Caleb Rouleau authored
This should not be checked in until the Nexus 5s are reimaged. R=johnchen@chromium.org, wenbinzhang@google.com Bug: 1041944 Change-Id: Icec71e1ff43f69412be185df7725a508a921afcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103441Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#750443}
-
Andreas Haas authored
The indirection over DOMTypedArray::View is not necessary, DOMTypedArray can be used directly. This CL works towards removing ArrayBufferView and TypedArray. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: Ib4ab7844b4a10339b4aefd9add4637890e1ce09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102653Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#750442}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c9eced71. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" 79933afe "Reland "[ScrollTimeline] Support composited scroll-linked Web Animation"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I22de63f3651dea52f410c2c170b2c06b5745971d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104123Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750441}
-
Alexey Baskakov authored
TwoClientWebAppsSyncTest.Basic TwoClientWebAppsSyncTest.AppFieldsChangeDoesNotSync tests were failing because we don't sync description and scope in the new web apps system: we get these data fields only during full post-sync install. TwoClientWebAppsSyncTest should test a common subset for Bookmark Apps and Web Apps: let's parametrize by ProviderType. SingleClientAppsSyncTest and TwoClientExtensionAppsSyncTest should also be parametrized against ProviderType: we want to be sure that we don't regress hosted apps and platform apps. In next CLs: - We will create brand new two_client_web_apps_bmo_sync_test.cc file to test the new web apps BMO sync system. We will test full post-sync install there. - We will rename single_client_apps_sync_test.cc to single_client_extension_apps_sync_test.cc Bug: 1025156 Change-Id: Id30424cd974f091954cbfd3a493f1c45e9a2f19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096402Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#750440}
-
Darren Shen authored
Show should be 200ms, and hide should be 100ms according to UX. Bug: 1030814 Change-Id: I2858aeb5c713c356a3ba427b2e2de8a59110e547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098181Reviewed-by:
-
David Munro authored
Needs some polish but works end-to-end, all the functionality is there. This is still behind a flag. Screenshots: * Loading: https://drive.google.com/file/d/1-F7R0fd2FHiTcoOxyWwoFy_W23J7vY_R/view?usp=sharing * Resize: https://drive.google.com/file/d/1-7VtbZd2j2fAAYVtB5anV_Ayk6Xty5xx/view?usp=sharing * Settings page to open dialogue: https://drive.google.com/file/d/1-HqyovNWKWz4j-l21RkV0aWIUmKRjCko/view?usp=sharing Test: Browser, unit, manual Bug: chromium:858815 Change-Id: I2967402d2bcd1ebb66e83a5298adedda769deb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096155Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#750438}
-
Rouslan Solomakhin authored
Before this patch, MicrotransactionRenderTest.java resided in the repository, but was not included in the build, because it was removed in https://crrev.com/c/1828291 due to build bot failure and then was accidentally added back in https://crrev.com/c/1826875 without adding it back to the build. This patch removes MicrotransactionRenderTest.java file. After this patch, the repository does not contain the unused file MicrotransactionRenderTest.java. Bug: 1005076 Change-Id: Ie143f174ddecacd53449b423bae82b570370f731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093165 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#750437}
-
Charlie Hu authored
This CL implements the support for report-to param in Document-Policy/ Document-Policy-Report-Only header according to https://w3c.github.io/webappsec-feature-policy/document-policy.html#reporting. Bug: 993790 Change-Id: I54314077f19d2d57a1d5fbc820fd754fd3ff46da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090370 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#750436}
-
Bence Béky authored
In RecordConnectionCloseErrorCode(): * Add new histograms for recording wire values of received IETF CONNECTION_CLOSE frames. * Use existing "Server" histograms only when protocol is Google QUIC. * Use extracted_error_code instead of quic_error_code for client frames regardless of protocol. In rest of QuicChromiumClientSession::OnConnectionClosed(), use extracted_error_code instead of quic_error_code. extracted_error_code is guaranteed to be the correct QuicErrorCode for locally created frames, and for frames received from servers running QUICHE regardless of whether the protocol is Google QUIC or IETF QUIC (via parsing the error description). Bug: 1060736 Change-Id: Iaa8914722c35af7706d234addadb25c9a1ee927b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098962Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
This reverts commit b2882c21. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1061766 Original change's description: > [WebLayer] Move browserservices.Origin to //components/embedder_support > > browserservices.Origin is used by Chrome's site settings page, which > is being componentized so it can be used by WebLayer. This CL moves > the class to //components/embedder_support. > > Bug: 1058597 > Change-Id: Ic47da47f372d1c27238efd2fee8d7bdcba6eb63d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090875 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750294} TBR=jam@chromium.org,boliu@chromium.org,twellington@chromium.org,jdoerrie@chromium.org,rmcelrath@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1058597, 1061766 Change-Id: I90a44c5f6168133d90efb254649e776f4e395e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104367Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I6a0034de57731890e021eb4a3e19dfcce5ce6295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103270Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750433}
-
Wei Lee authored
The deploy function is broken due to the following changes: https://crrev.com/c/2076710 https://crrev.com/c/2098849 Bug: 1061414 Test: cca deploy works normally Change-Id: I5584047bfb3b64e3a4f8c92aaa396ce69cdcbd19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102304Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#750432}
-
Alexander Timin authored
Replace a custom GetMainFrame implementation in components/page_load_metrics with RenderFrameHost::GetMainFrame. Also stop comparing it with web_contents->GetMainFrame() and use IsCurrent() instead. Also update RenderFrameHost::GetParent comments to be more accurate around "is_current" expectations. R=sreejakshetty@chromium.org,alexmos@chromium.org,csharrison@chromium.org CC=lukasza@chromium.org,hajimehoshi@chromium.org BUG=1059903 Change-Id: Ib05ea482d1ef1ea40a9b3d7690f81626698b5d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100847 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#750431}
-
Xianzhu Wang authored
Previously, if feature A implies B, suppose both are disabled by default, in the following situation: ScopedAForTest a; ScopedBForTest b; feature B will be left enabled after the scope. Now let Scoped*ForTest use the data field of the feature instead of calling *Enabled() and Set*Enabled() (which are asymmetric when the feature is implied). RuntimeEnabledFeature backup and restore had the similar issue. Also let them use data field instead of calling the methods. Bug: 1061443 Change-Id: I28bfee510bf3e4491c11887d7f8c992d433b9702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103317Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#750430}
-
Alexander Timin authored
Remove the ability to reach out to WebContents directly from a FrameServiceBase subclasses. This makes it possible to track WebContents access on behalf of a non-current frame. R=alexmos@chromium.org TBR=sergeyu@chromium.org BUG=1059903 Change-Id: I5a8594741b22b5c0b0ff5bc886c244b33fb31b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095716Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Nico Weber authored
No intended behavior change. Bug: 346399 Change-Id: I9c231054c065054f110c025ebc83159a92ec6694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104212Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#750428}
-
Rouslan Solomakhin authored
Before this patch, Chrome dimmed the screen after the user has payment in minimal UI, because the reconciler was not aware that a bottom sheet was being displayed. This patch applies the same bottom sheet logic from reconciler to both expandable payment handler UI and minimal UI. After this patch, Chrome UI is not dimmed after user confirms payment in minimal UI. Bug: 1005076 Change-Id: Id9e5f220cb8ba7bef4bb06c6f72e725e971ce9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097415 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch has no behavior changes. TBR=wangxianzhu@chromium.org, yosin@chromium.org Bug: 1025341 Change-Id: I254f3dbe4624b9f6bc7f0c5af870e7e4f60d754c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103828Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#750426}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ibeab6f65af9e3a216ddd5eed7cba18b2b1c1bff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104097Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8578f9bc732f..222b156b486b git log 8578f9bc732f..222b156b486b --date=short --first-parent --format='%ad %ae %s' 2020-03-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@222b156b486b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie912c0091ed4ce0eca1350d32f0886479be1904f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104135Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/db3f042bb8f2..869e901ad7dd git log db3f042bb8f2..869e901ad7dd --date=short --first-parent --format='%ad %ae %s' 2020-03-15 jmadill@chromium.org Temporarily disable optimizations in angle_perftests. Created with: gclient setdep -r src/third_party/angle@869e901ad7dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Id7f7824287d32128792532ba598abba38fc7bb4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104134Reviewed-by:
-
Xianzhu Wang authored
The runtime feature TransferableStreams is implied by RTCInsertableStreams which is in origin trial which means the enabled status can depend on the execution context, which requires TransferableStreams also to be in origin trial in order to be execution context aware. The problem was that RTCInsertableStreams could be enabled for some particular execution context, while REF::TransferableStreamsEnabled() didn't know that and might return false in the execution context, breaking the "implied_by" rule defined in runtime_enabled_features.json5. A followup CL will add rules checking such wrong definition in runtime_enabled_features.json5. Bug: 954679 Change-Id: Id1e0a430f5bff6bf05944cb91cb570116ea5bac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104014 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#750422}
-
Nico Weber authored
The code causes a new compile warning, and it's unused. So stop building it. (See also https://github.com/aappleby/smhasher/pull/81 failing to get traction.) Bug: 1054220,1058381 Change-Id: I68758e94cd2728df70e78c60e9be0bb4006a847a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103719 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#750421}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1b512b2a65c5..8578f9bc732f git log 1b512b2a65c5..8578f9bc732f --date=short --first-parent --format='%ad %ae %s' 2020-03-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@8578f9bc732f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I32b242fa6ea8f94454af73113c19ae1c37e57767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104132Reviewed-by:
-
Julie Jeongeun Kim authored
This is a reland of 9321f32f Original change's description: > a11y: Use more g_return_val_if_fail in AXPlatformNodeAuraLinux > > These macros are used when implementing GObject interfaces to help > mitigate accidental misuse of the API. We were using them, but not > consistently in the AuraLinux accessibility implementation. This change > makes their use more consistent. > > The original author of this CL is Martin Robinson<mrobinson@igalia.com> > > Bug: 1032019 > Change-Id: I75ee57eea79ab11202924f9b04bd1def78dd5fc6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096167 > Commit-Queue: Julie Kim <jkim@igalia.com> > Reviewed-by: Martin Robinson <mrobinson@igalia.com> > Cr-Commit-Position: refs/heads/master@{#749059} Bug: 1032019 Change-Id: I750767f3ed9c370b1dee942015db203f1e913a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100366Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#750419}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a3cf06ac1718..db3f042bb8f2 git log a3cf06ac1718..db3f042bb8f2 --date=short --first-parent --format='%ad %ae %s' 2020-03-15 jmadill@chromium.org Trace Tests: Rebase path to relative dir. Created with: gclient setdep -r src/third_party/angle@db3f042bb8f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Ic8ba470901793aae21cb64bc79585e6a3bb50523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104131Reviewed-by:
-
Nico Weber authored
This reverts commit c7fc8475. Reason for revert: breaks tot bots, see e.g. https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8885810891742311184/+/steps/gclient_runhooks/0/stdout Original change's description: > Change to download and build zlib every time, in case a bot happens to die during a build > > Change-Id: I04e3bfcf520eef8b7fe41cfa1cb04e87de413363 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052585 > Commit-Queue: Amy Huang <akhuang@google.com> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750365} TBR=thakis@chromium.org,hans@chromium.org,akhuang@google.com Change-Id: I753aaa490176448d2a78a8ea540de3066ac78b39 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104210Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#750417}
-
- 14 Mar, 2020 6 commits
-
-
Arthur Eubanks authored
The warning was changed to be emitted under -Wpointer-to-int-cast in https://reviews.llvm.org/rG51d7f645448b49c7d3b029a60532bac019da1348. Since -Wno-microsoft-cast is on right now with the pinned Clang, I think it makes sense to not add this under llvm_force_head_revision. We can remove -Wno-microsoft-cast after the pinned Clang contains the LLVM change above. Bug: 1054220 Change-Id: I2b989cbe4936fa237e7cfb2f725d14873d5abaf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104127Reviewed-by:
-
Toni Barzic authored
Fixes an oversight from CL:2099591 - the drag handle nudge should not be hidden just because ShouldShowNudge returns false. The nudge is automatically shown once a day, so just showing the nudge would cause ShouldShowNudge return false (so the next shelf state change, for example extending hotseat, might cause the nudge to get hidden). BUG=1060462 Change-Id: I8024031dc319105dc7f56b8e42e41886222cdf63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104128 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#750415}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 82-4072.0-1583746630-benchmark-82.0.4082.0-r1 to 82-4072.0-1583746630-benchmark-82.0.4084.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I713dea2dacb72b22495fbade085e0f60ab87c1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104093Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4072.0-1583751487-benchmark-82.0.4082.0-r1 to 82-4072.0-1583751487-benchmark-82.0.4084.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I286d641e9961a6b75e0a466e45d0d244cbc0716f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104094Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ia1e2cc4a0d85bf5790ae3109fc7bf772b1e03011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103900Reviewed-by:
-
Piotr Bialecki authored
Add test case for the DOM overlay and hit test API interaction - hit test results should be suppressed if the input source is interacting with cross-origin content. Change-Id: Ib7af656c19177ef725205e8bd27bac57b81b9cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103302Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#750411}
-
