- 29 Sep, 2020 40 commits
-
-
Michael Ershov authored
Enable the check that AttestationEnabledForUser policy is configured from cloud and the level is "Mandatory". This CL reverts https://crrev.com/c/1865340 because the values in the corp policies were fixed. Bug: 1000589 Test: *TpmChallenge* Change-Id: I17058e673100673023c3e8f0f759e0b4b92afac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436822 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#811663}
-
Mohamed Heikal authored
Also: - updates build/protoc_java.py to use argparse instead of optparse. - removes deprecated references to proto nano Bug: 1114836 Change-Id: I184e6e262159ecb79cdf980a8c48e9d7f28c7d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434908 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#811662}
-
Bartek Nowierski authored
There are a couple reasons for this change: 1. Avoid copying a struct larger than a pointer. 2. If the pointer in the struct gets replaced by CheckedPtr with a non-trivial constructor, the compiler will complain. See go/miracleptr for more details on the experimental CheckedPtr project. Bug: 1080832 Change-Id: I520614995dcbae3bdab69a1423d288b2eeea9189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437991 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#811661}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e96cdd18ac5f..842805ced156 2020-09-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 8563523f to 339e4ec2 (471 revisions) 2020-09-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ed2b465f8607 to b2a4e87ad274 (8 revisions) 2020-09-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b94db86cf9b3 to 44be0942f9a8 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I8ffc2738d595e9c71d305c40e39f236f3d915bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438149Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811660}
-
Dominik Röttsches authored
Speculative fix for issue 1128434. The mac-arm64 build may be built without DCHECK on, which could be the explanations for why these tests are not actually failing. Bug: 1128434 Change-Id: I1ca705c1429847dde587e6f69e66f22cbbdad59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438050 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#811659}
-
My Nguyen authored
This makes sure line is wrapped appropriately for other languages when the words flow over. No change in view for English: http://screen/5eTsrhmsRX7X4nP Bug: 1113439 Change-Id: Ib8252a4b2f589ddefd4ba7a0ad8e26e16fad0584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437310 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811658}
-
Paula Vidas authored
If UseSyncInvalidations feature flag is enabled, we don't subscribe to old invalidations for any data types besides Wallet and Offer. And if UseSyncInvalidationsForWalletAndOffer is enabled, we don't register for old invalidations at all. Bug: 1082115, 1050970 Change-Id: Ifbda4e29c4ed22a1469f1482ba7be8f8cccbd881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435224 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#811657}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/62139fcca727..b2a4e87ad274 2020-09-28 enga@chromium.org Un-skip WriteTexture test on Swiftshader 2020-09-28 enga@chromium.org Roll third_party/swiftshader/ e8dd233c7..2014e7b92 (79 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I1a60ad81c61a443fba512b8a70a0052931871aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437933Reviewed-by:
-
Mohammed Abdon authored
The saml user will be forced to re-authenticate through online flow in the lockscreen. This feature is enable by setting kDefaultSamlLockScreenReauthenticationEnabled to true. Bug: 1113295 Change-Id: I7f89408aca31de9137006d5cbb96cfc91ee708d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339359Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Mohammed Abdon <mohammedabdon@chromium.org> Cr-Commit-Position: refs/heads/master@{#811655}
-
Christoph Schwering authored
This reverts commit b622082c. Reason for revert: The CL seems to cause flakiness of VariationsHttpHeadersBrowserTestWithRestrictedVisibility.TestRestrictGoogleWebVisibilityInThirdPartyContexts, crbug.com/1133291 Original change's description: > Prevent deadlock by checking kRestrictGoogleWebVisibility sooner. > > More specifically, check the feature's state after field trials have > been created from the variations seed and before the variations > header is updated. > > Checking the state for the first time in > VariationsIdsProvider::GenerateBase64EncodedProto() could cause a > deadlock. > > Bug: 1094303 > Change-Id: I53fe3446e3a4567d4b9122b54642b5744eb8b46e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431556 > Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811566} TBR=jwd@chromium.org,asvitkine@chromium.org,caitlinfischer@google.com Change-Id: I8cbc093f9bd9d978a13eb881d7dc319309a808fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1094303, 1133291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438057Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#811654}
-
edchin authored
Handles synchronous localObject drops differently from asynchronous drops from another app. Bug: 1128531, 1128656 Change-Id: I45b124f1f8bb887a465a753e40a9fa5cc74c5e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438011 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#811653}
-
sandromaggi authored
This allows the SetFormFieldValueAction to use a value from a previously selected profile. If the profile is not available the action will terminate with an error. If the value expression cannot be resolved the action will terminate with an error. Bug: b/169521597 Change-Id: Id2502d366d42a085103261bb35e30b0e701410fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435084 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#811652}
-
Ravjit Singh Uppal authored
Extending the expiry time of these histograms until M89, to give us extra time to decide about them. Bug: 1125795, 1125794, 1125793, 1125792, 1125657 Change-Id: If2da7f73bdbbebdda596dc7d16974dc2c9143193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435306Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#811651}
-
Henrik Boström authored
The pixel buffer pool is a light-weight wrapper for CVPixelBufferPool. It takes care of configuring the pool, which avoids working with some cumbersome Core Foundation objects. This CL also adds tests to make sure the pool is behaving as expected, since the Apple documentation is rather poor in details. The intent is to use the PixelBufferPool in future CLs in order to use the VTPixelTransferSession for more efficient (hopefully) scaling and pixel format conversions. // Guido is OOO today so TBR-landing for BUILD.gn changes. TBR=guidou@chromium.org Bug: chromium:1132299 Change-Id: I28ffa7d75dbffd4fcf44c7fb2b22e89e19d6a0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431427Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#811650}
-
Jochen Eisinger authored
Bug: 1131759 Change-Id: Ic46050d835b76a9f972c262fb8f9e3958412541f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436336Reviewed-by:
-
Kent Tamura authored
from LayoutTextControlSingleLine to PasswordInputType. LayoutObject should not store such a UI state. This CL will help LayoutNG transition. * Moves the followings from LayoutTextControlSingleLine to PasswordInputType: - should_draw_caps_lock_indicator_ flag - CapsLockStateMayHaveChanged() - ShouldDrawCapsLockIndicator() * Moves CapsLockStateMayHaveChanged() calsites in TextFieldInputType to PasswordInputType. Make TextFieldInputType::ForwardEvent() protected for this. This CL has no behavior changes. Bug: 1040826 Change-Id: I47df60b4e38184ad81b75a52ce8835e9af4ed3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437077 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#811648}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Iaf46f81d987f049093a8bae7454ac9e3bd1ddc53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437931Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4b07d50cd9a0..c6ca885c0b4a 2020-09-28 dj2@everburning.com [spirv-dis] Add some context comments to disassembly. (#3847) 2020-09-28 emaxx@google.com Fix use-after-move in val/validate.cpp (#3848) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I46cd20df34235f25daf78025e6565d34ae6f5dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438109Reviewed-by:
-
Maksim Sisov (GMT+3) authored
This reverts commit aa21781d. Reason for revert: results in not visually focused browser window on ozone/linux + mouse highlights no longer work. Also, client view area doesn't show any contents. See https://crbug.com/1133195. Original change's description: > [ozone/wayland] Use 4x4 opaque background and stack underlay correctly > > Using a 4x4 sized opaque background will not regress performance in > underlay cases because the root surface is still opaque. The background > will be stretched out by wayland viewporter extension. > > This is 6/? CL for overlay forwarding using wl_subsurface. > > Change-Id: I59b0d4cdbfbb6727d578e286c9d19cf69a9bff32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352523 > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#810527} TBR=rjkroege@chromium.org,msisov@igalia.com,fangzhoug@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1133195 Change-Id: I4d2e7d7e7b94743bf29a932bd37264ccff45b585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438129Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#811645}
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Restrict maxFileSize to 10GB. Add tests. Bug: b:162051831 Change-Id: Ia011da2289e1808e2bd828ddd9bb82573ed73d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401340 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#811644}
-
Mariia Shvedchenko authored
Applying negative matching, adding finch flag, using vector<MatchingPattern> instead of single matching pattern in FormField::ParseField, and FormField::ParseFieldSpecifics. Change-Id: Id3213ab070267df1c670002effcada174cc85dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431515Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I2756db28b9f5e78d580c7de94263b651d842d900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435719Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#811642}
-
Alan Cutter authored
This CL adds a "launch_query_params" field to default web app JSON configs that causes the web app to launch with the specified query params appended to the app's start_url. Bug: 1045537 Change-Id: Ib6025ae39eac7a6f710b2817a0f2ad30437e29c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377044Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#811641}
-
Jiawei Shao authored
This patch replaces the "unknown" buffer map async status with two more detailed ones (destroyed_before_callback and ummapped_before_callback) to provide more information about these abnormal buffer may async statuses. BUG=dawn:533 Change-Id: I17480eb87b7af5ef131e37843ad37097ad4f5026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434110 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#811640}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: Ibb6fd1bcea8aae9878051fa4b50bcbff87ba3ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436549Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#811639}
-
Kevin McNee authored
This is an upcast which can be done by implicit conversion, as other methods in this class do. Bug: None Change-Id: I89d2c4958ddc0c822d8a22ea561bc49f5f7499a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435745 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#811638}
-
Esmael El-Moslimany authored
cl/333509607 Bug: 1076506 Change-Id: I265b7655678d0af4b46a72ed715152e531d11b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433998 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
-
Richard Knoll authored
Notifications should use the proper background color so the text on them is readable. This also derives the inline settings, actions row and large image background colors from that native background color so light and dark themes work correctly. Screenshots: https://imgur.com/rxq48G7 Bug: 1113313,1065604 Change-Id: I20b833a3a157eabc0c7b03385a4ed88651cffa08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396297Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#811636}
-
Sylvain Defresne authored
Bug: 1018739 Change-Id: Idbdb1544c64e673a1138d3d9af825e135a680fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437812 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#811635}
-
Alex Rudenko authored
If a constructed stylesheet contains rules with 'background-clip:text;', InspectorStyleSheet won't be able to parse them properly, causing the rule diffing algorithm to run. When the number of rules to diff is high, it causes performance problems when opening DevTools. This CL skips the diffing for constructed stylesheets, because the order of rules for constructed stylesheets is known. Ultimately, this workaround would not be needed when InspectorStyleSheet can parse the CSS rules properly. See crbug.com/1132778, crbug.com/604023. Fixed: 1131113 Change-Id: I5c38a52bfb2b04334530c292cd8b4e15c9f6c2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435304Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#811634}
-
Daniel Vogelheim authored
The current code only enables/disables eval (& Function constructors) in workers wholesale, and never registers a callback. This means that the functionality that relies on the callback doesn't work in workers. This patch registers the callback, and removes two assertions that are now no longer true. Bug: 1126472 Change-Id: I3996431acd97fd6f62e8e09ed44732e8eaa438f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426645Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#811633}
-
Javier Ernesto Flores Robles authored
Bug: 1130571 Change-Id: Id3f2ed7e38c1e6863755730c7e02a3380221e336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435094Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#811632}
-
My Nguyen authored
Because of the presence of iron-list, there's a horizontal line separating the buttons from the list, making the padding difference look very obvious. Update all to 20px. Spec has the padding left and right at 24px but current dialog body padding is 20px, so sticking to that. Spec: http://go/cros-lang-settings-figma Current view: http://screen/4EAq4TaqjwEyuTq Bug: 1113439 Change-Id: Ief84905331ba8965854b34252308161cd3bf6eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437069 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
This doesn't make a lot of difference to the NG layout engine (except that consumed block-size may now be larger than the block-size of the preceding fragments combined). The reason for this change is so that we'll write the correct offsets back to the legacy tree. This was wrong for overflowing content whose containing block ended in an earlier fragmentatainer, and that caused trouble for things like offsetTop. This change requires us to replace some logic in the fieldset layout algorithm that calculates the amount of space that a legend "eats" from its containing fieldset. It's actually slightly simpler now. :) Bug: 829028 Change-Id: I84c6188e61ee3e9eaff80f595935768fa68412bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429027 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#811630}
-
Kuo Jen Wei authored
Bug: 1123750 Test: Manually Change-Id: I30ed85248a8985f27ecf51b2a9a88a8108320a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437542 Commit-Queue: Inker Kuo <inker@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#811629}
-
Christian Biesinger authored
Unfortunately this required adding *another* parameter to ComputeOutOfFlowInlineDimensions because we now need two different MinMaxSizes. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1098475 Change-Id: If2c05ce09292bc856e04c7a18950fbdd35579572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430828 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#811628}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0d33d0e062db..bd99a610db07 2020-09-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1714fd3ee16592580b660c26ee03686da195a604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437942Reviewed-by:
-
tby authored
This CL contains a handful of fixes that prevent chip results appearing. - On login, query ItemSuggest once, so we have results ready to display the first time the launcher is opened. This is mostly copied from drive_quick_access_provider. - Change some display and result type enums for chip results, needed to rank and display them correctly. - Use a separate schema for chip results, which prevents them being deduplicated with list results. Bug: 1034842 Change-Id: I4da6cc219e19ad05383acdd2f98f64c6b4451a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434111 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#811626}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601337561-307983a438d89a0d060ed0a79e008eada61629c3.profdata to chrome-linux-master-1601358844-b8defbe977309018021c72a700e18c84f94d16d4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I08e04fc681663258e9743b996aad99d33029c88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438110Reviewed-by:
-
Mirko Bonadei authored
No-Try: True Bug: None Change-Id: I8f9f2fa4c83b6764710725026af0e61e0480d807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436811Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#811624}
-
