- 21 Jan, 2011 40 commits
-
-
jknotten@chromium.org authored
WebKit change http://trac.webkit.org/changeset/76291 may have affected this test. TBR=brettw BUG=70408 TEST=BrowserTest: RenderViewTest.OnNavStateChanged Review URL: http://codereview.chromium.org/6330006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72142 0039d316-1c4b-4281-b951-d872f2087c98
-
jknotten@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/6353012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72141 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
BUG=70388,70389 TBR=glider TEST=DrM/FYI should go green on printing Review URL: http://codereview.chromium.org/6270005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72140 0039d316-1c4b-4281-b951-d872f2087c98
-
jknotten@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/6245009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72139 0039d316-1c4b-4281-b951-d872f2087c98
-
caseq@google.com authored
- do not strip User-Agent while flattening headers in renderer - do not override User-Agent header in the network stack if one is already supplied by higher level; - added RequestHeaders::SetHeaderIfMissing TEST=URLRequestTestHTTP.OverrideUserAgent BUG=http://crbug.com/67063 Review URL=http://codereview.chromium.org/6065008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72131 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
This was initially a way to try to prevent prerendering non-idempotent GETs. A large number of pages were unable to prerender effectively this way due to short max-age's or other cache directives. BUG=None TEST=unit_tests --gtest_filter="*PrerenderResourceHandler*" Review URL: http://codereview.chromium.org/6312008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72130 0039d316-1c4b-4281-b951-d872f2087c98
-
gavinp@chromium.org authored
BUG=70231 TEST=LoginPromptBrowserTest.PrefetchAuthCancels Review URL: http://codereview.chromium.org/6321013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72129 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
Move it from standard_layout.h and rename to just CreatePanel. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6384002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72128 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
BUG=http://code.google.com/p/drmemory/issues/detail?id=275 TBR=glider TEST=DrM/FYI should go greener Review URL: http://codereview.chromium.org/6303015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72126 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
Update the suppression for a race on bool in HistoryURLProvider; ignore a function where TSan doesn't understand a shared memory lock TBR=glider BUG=45083,66994 TEST=TSan/interactive_ui tests should become greener Review URL: http://codereview.chromium.org/6354012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72125 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
TBR=glider TEST=DrM/FYI bot should go greener BUG=70225 Review URL: http://codereview.chromium.org/6380009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72124 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
Also, Add some browser tests for clearing plugin data and enable npapi_test_plugin on 64-bit Linux; apparently it's been fixed. BUG=58235, 18337, 26625 TEST=PluginDataRemoverTest.* Review URL: http://codereview.chromium.org/6308001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72123 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
This causes feeds from Twitter searches to break because the hash sign (%23) gets decoded before passed to Twitter. BUG=70226 TEST=ExtensionBrowserTest.ParseFeedInvalidFeed4 Review URL: http://codereview.chromium.org/6332008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72122 0039d316-1c4b-4281-b951-d872f2087c98
-
altimofeev@chromium.org authored
Fix http://src.chromium.org/viewvc/chrome?view=rev&revision=71785 revealed possible flow, when active downloads list contains non-existing downloads. This fix removes redundant method call, which is also dangerous. BUG=none TEST=cancel dangerous download, notice that Chromium is alive. Review URL: http://codereview.chromium.org/6372003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72121 0039d316-1c4b-4281-b951-d872f2087c98
-
yusukes@google.com authored
Add GetScreenMode() to status_area_host.h, and remove IsBrowserMode() and IsScreenLockerMode() APIs. The old APIs seem to be a bit confusing since only 3 combinations out of 2^2 are valid. (I mean, IsBrowserMode() == true and IsScreenLockerMode() == true is invalid.) BUG=chromium-os:8386 TEST=manually, try bot. Review URL: http://codereview.chromium.org/6378008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72120 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
As a result, memcheck_analyze was waiting for dead Valgrind processes for 3 extra minutes. D'oh. BUG=17453,44545 TEST=trybots, experiments by eugenis@ Review URL: http://codereview.chromium.org/6258010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72119 0039d316-1c4b-4281-b951-d872f2087c98
-
jknotten@chromium.org authored
BUG=69965 TEST=GeolocationBrowserTest.TabDestroyed,GeolocationPermissionContextTests.TabDestroyed Review URL: http://codereview.chromium.org/6340011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72118 0039d316-1c4b-4281-b951-d872f2087c98
-
yusukes@google.com authored
http://git.chromium.org/gitweb/?p=cros.git;a=commit;h=34a0e132afad573f7595c1c813ae03d9d5ff6eec BUG=chromium-os:11101 TEST=try Review URL: http://codereview.chromium.org/6364003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72117 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6293007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72116 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
The feature is now behind --enable-in-browser-thumbnailing flag. The in-browser thumbnailing works as follows: - The scroll offset is sent from the renderer to the browser. - The thumbnail is taken when the page info is sent from the renderer process. - Since thumbnails are generated in the browser, we can avoid the generation when unnecessary (ex. off-the-record mode, or New Tab Page). - The quality of thumbnails is as good as before, as the patch doesn't change timing heuristics. - The drawback is that we cannot take thumbnails from background tabs. New functions are added to ThumbnailGenerator for clipping thumbnails, with tests. BUG=65936 TEST=add unit tests for thumbnail_generator. confirmed that the thumbnails are updated with and without --enable-in-browser-thumbnailing Review URL: http://codereview.chromium.org/6246007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72115 0039d316-1c4b-4281-b951-d872f2087c98
-
kochi@chromium.org authored
The CL ifdef'ed out for some parts of HTML, but it did not touch the corresponding JS code that modifies the part. BUG=chromium-os:11142 TEST=manually open chrome://settings Review URL: http://codereview.chromium.org/6342013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72114 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@google.com authored
This is based on GTK implementation. Please see the header file for features that are not implemented yet. Textfield changes (files under views/controls/textfield) are being reviewed by Ben in separate CL (http://codereview.chromium.org/6314012/), so you don't have to review them (but you're welcome to do so). * Updated factory method in AutocompleteEditViewGtk to return views-implementation when TextfieldViews is enabled. * Added new option to FillLayout so that it lays out its child inside border. * Added missing GD_PK_Delete to keycode conversion. * Enabled tests in autodomplete_edit_view_browsertests for views-implementation as well. I moved the test body to the class and then called them from each test class to avoid having another test configuration on bots. Let me know if there is better way. BUG=none TEST=Enabled autocomplete_edit_view_browsertest for views-implementation. Review URL: http://codereview.chromium.org/6245003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72113 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6346011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72112 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6265018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72111 0039d316-1c4b-4281-b951-d872f2087c98
-
amit@chromium.org authored
return value as a bool BUG=none TEST=none Review URL: http://codereview.chromium.org/6346010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72110 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6360010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72109 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6336010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72108 0039d316-1c4b-4281-b951-d872f2087c98
-
cevans@chromium.org authored
few annoying cases where someone has been monitoring Chrome under windbg, which can skip over __debugbreak() and then show them a scary-looking access violation. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6372008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72107 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=47955,69883 TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72095 Review URL: http://codereview.chromium.org/6383002 Patch from James Weatherall <wez@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72105 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
BUG=69755 TEST=Throbber works properly when settings page is scaled. Review URL: http://codereview.chromium.org/6378006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72104 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
preparation for experimenting with them to gpu-accelerate various aspects of chrome's drawing. In this initial patch, the files will be built, but not called. Now with dependency on gpu lib for sharedlib build on linux TEST=be sure that page rendering, and <canvas> rendering, look the same as before Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71998 Review URL: http://codereview.chromium.org/6357006 Patch from Mike Reed <reed@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72103 0039d316-1c4b-4281-b951-d872f2087c98
-
nfullagar@google.com authored
a NaCl page reload / surf-away regression. BUG=NaCl ppapi audio proxy TEST=native_client/tests/ppapi_example_audio Review URL: http://codereview.chromium.org/6300011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72099 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=70327 TEST=none Review URL: http://codereview.chromium.org/6268009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72098 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=47955,69883 TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total. Review URL: http://codereview.chromium.org/6383002 Patch from James Weatherall <wez@chromium.org>. TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/6341006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72096 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=47955,69883 TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total. Review URL: http://codereview.chromium.org/6383002 Patch from James Weatherall <wez@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72095 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
A NULL |result| should DCHECK, but not crash. This is a short term solution to the top-crasher, will still DCHECK for devs while a longer term fix is determined. BUG=68783, 69833 TEST=none Review URL: http://codereview.chromium.org/6275011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72094 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/6352003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72093 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
being notified after the object has been destroyed. BUG=69441 TEST=none Review URL: http://codereview.chromium.org/6299014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72092 0039d316-1c4b-4281-b951-d872f2087c98
-
noelallen@google.com authored
grep --include="*.gyp*" -nr -F "ppapi_egl" . However this library causes NaCl to require third_party/mesa which relative to NaCl is large. This CL moves the definition of this static library from ppapi to the lib/gl directory under ppapi so that PPAPI users are not forced to DEPS in mesa. Review URL: http://codereview.chromium.org/6342012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72090 0039d316-1c4b-4281-b951-d872f2087c98
-