- 05 Jun, 2019 40 commits
-
-
Manuel Rego Casasnovas authored
Elements with "contain: size" should be treated as having no contents, that's not happening for <select> elements. To fix this we add a check for size containment in LayoutMenuList::UpdateOptionsWidth(). BUG=966673 TEST=external/wpt/css/css-contain/contain-size-select-001.html Change-Id: Ie71a16e113d7bef4fd5c7b62e1838feba9b15cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643872Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#666210}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie7542b3984f0344583a6ecd1fec831d60b2dc779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645253Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666209}
-
Yi Su authored
This CL removes CRWWebController.abortLoad since it has only 2 lines and is ambiguous to co-exist with CRWWebController.stopLoading, CRWWKNavigationHandler.stopLoading, WKWebView.stopLoading and CRWLegacyNativeContentController.stopLoading. Bug: 956511 Change-Id: Ib0d6b38b66f8f21be7f4234893b132641b0f81ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641244 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#666208}
-
Sylvain Defresne authored
This reverts commit 8b51a44e. Reason for revert: the original CL broke downstream, but the fix landed before this revert landed. Thus the revert is *causing* the build failure. Reverting it. Original change's description: > Revert "Delete GaiaCookieManagerServiceObserver in favor of callbacks." > > This reverts commit 58fe1e69. > > Reason for revert: This looks like it breaks an ios internal trybot https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/ios-internal-chromium-tot > > Original change's description: > > Delete GaiaCookieManagerServiceObserver in favor of callbacks. > > > > This CL replaces GaiaCookieManagerServiceObserver with vanilla > > callbacks. Now that GCMS is owned by IdentityManager, and cannot have > > multiple observers, a callback interface seems more natural than an > > Observer class. > > > > This also has the nice side effect of removing transitive includes of > > gaia_cookie_manager_service.h via identity_manager.h. > > > > Change-Id: I9cdac56c8237c9a09eb2c2ce87f41f48872a9fb6 > > Bug: 939372 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630162 > > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > > Reviewed-by: Colin Blundell <blundell@chromium.org> > > Commit-Queue: Lowell Manners <lowell@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#665616} > > TBR=blundell@chromium.org,msarda@chromium.org,lowell@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 939372 > Change-Id: I777df13eb9bc5eddeea46640b973c287d6622061 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642232 > Reviewed-by: Lowell Manners <lowell@chromium.org> > Commit-Queue: Lowell Manners <lowell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666007} TBR=blundell@chromium.org,msarda@chromium.org,lowell@chromium.org Change-Id: I02604da8703d681033ea7a0d53252eb8b264065d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 939372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645357Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#666207}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/899f7e5389c4..d944a1a52fef git log 899f7e5389c4..d944a1a52fef --date=short --no-merges --format='%ad %ae %s' 2019-06-05 perezju@chromium.org [Telemetry] Fix reporting of tracing errors during DumpMemory Created with: gclient setdep -r src/third_party/catapult@d944a1a52fef The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:964960 TBR=skyostil@google.com Change-Id: Iccc56453013f2111608eebd2ffd558037ae9a923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645058Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/23fce88da7cf..fbfc92ef1538 Created with: gclient setdep -r src-internal@fbfc92ef1538 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: Ie66c23537bc7b12499000423a29a5e3136018b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645254Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666205}
-
Yi Su authored
CRWWKNavigationHandler. This CL moves CRWWebController._certVerificationErrors into CRWWKNavigationHandler since it's only used there. Bug: 956511 Change-Id: Iaa7225a2181b720b0184f80243ff1f945a72e032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639390 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Etienne Pierre-doray authored
This CL replaces ScopedNestableTaskAllower with kNestableTasksAllowed passed as argument to the RunLoop involved if any. Only native nested loops should use ScopedNestableTaskAllower (soon to be deprecated). For more details, see: https://cs.chromium.org/chromium/src/base/message_loop/message_loop_current.h?sq=package:chromium&dr=CSs&g=0&l=159 A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1635819 Please CQ if LGTY! This CL was uploaded by git cl split. R=tommi@chromium.org Bug: 766678 Change-Id: I5169a00876479db55907237bc3b7dc339f463bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635825 Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#666203}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/620197bd6535..4a00a80c4048 git log 620197bd6535..4a00a80c4048 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 afdx@google.com Add fuzzer pass to add dead breaks. (#2654) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@4a00a80c4048 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I9de44bf6c2f734d31e1ca21874b04c2bc18d23e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645115Reviewed-by:
-
Mihai Sardarescu authored
This CL enables Unified Consent feature by default. It removes a few earl grey tests that were only used for pre-Unity flows. It also removes the unified consent test suite as it is no longer relevant and this significantly reduces the bots build time. Bug: 960260 Change-Id: Iff7972e3b6533dc8f547562e2aae854b6f6b1833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617444Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Yi Su authored
This CL moves remaining navigation helper methods from CRWWebController into CRWWKNavigationHandler. Bug: 956511 Change-Id: I272a8e8247a104df1559b56c0bca06935f7a2e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640550 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
This is the client change required to allow scripters to override the default state of the third party terms&conditions checkbox. Bug: b/131588758 Change-Id: I3e6a970b3e972405a76e0fc8bf505939bc2459ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605202 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#666199}
-
Anand K. Mistry authored
This change adds the restore path, but usernames are not currently saved. BUG=891462 Change-Id: I045fa9d1624a84dd95892e7b3c45d8b303992ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644321 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#666198}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 887407 Change-Id: Ia9dc2635bcaf61cfec8134f381260e9d19d70752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632240 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#666197}
-
Victor Hugo Vianna Silva authored
Previously, FaviconSource used {kFavicon} as an IconTypeSet in its FaviconService queries. We propose to use every possible icon type for both mobile and desktop, so as to avoid platform specific code. Change-Id: I7a57f81300552b8f25007ac408616fb353572b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642668 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#666196}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I74645fc7d7b9a17727e409ce998af7882e2af32e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645057Reviewed-by:
-
Matthew Cary authored
Use an UnsafeSharedMemoryRegion instead of the existing handle. The shared memory on the host side is used read-only, but because a writable region needs to be shipped to the other side of the proxy, an unsafe region needs to be used. Host | Other side of proxy -----------------------------+--------------------------------- | Request SHM Create SHM <-----------------------/ Reply with SHM Handle | | \-------------------------> Receive SHM Save SHM by ID | | | Fill SHM with video to decode | (write to SHM) | Send SHM ID to Host Receive decode request <-----------/ Look up buffer by ID | Decode what's in the SHM | (read-only SHM access) The host-side could use a read-only region only by adding an additional round-trip, with the other side of the proxy either converting to read-only after mapping writable, and shipping back to the host, or the other side of the proxy mapping, shipping back a writable handle, and then the host converting to read-only. This has not been done in this CL. Bug: 849207 Change-Id: I3e50f9ff9c65e51c21c7e4d72b3aed2402c03196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615021 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:Chris Palmer <palmer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#666194}
-
Javier Ernesto Flores Robles authored
Animates the move of the alert with the new safe areas when the keyboard appears. This animations has the same curve and duration of the keyboard one. R=kkhorimoto@chromium.org Bug: 959737, 951300 Change-Id: Ie447fc5a76744f954fe57c4aa176edb4be0e07fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611820Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#666193}
-
Shu Chen authored
Bug: 965908 Change-Id: Iaa18ea0308e189def61cee1cc460221d456bb7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627835 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#666192}
-
Roman Sorokin authored
* Implemented initial enrollment logic in the policy test server * Added tests for normal enrollment and for zero touch Bug: 968123 Change-Id: Id3efe97e629db0a0daf95a8c35304c6daf8c1f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643470 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#666191}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/10dea84f..82e7e7a3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com NOTRY=true Change-Id: I2974ca16a9812cfa4fcb020ef3617d36be795b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644832 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666190}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/63ab5ac95373..7425820dcc76 git log 63ab5ac95373..7425820dcc76 --date=short --no-merges --format='%ad %ae %s' 2019-06-04 dneto@google.com Start v2019.1-dev 2019-06-04 dneto@google.com Finish v2019.0 2019-06-04 dneto@google.com Update CHANGES Created with: gclient setdep -r src/third_party/shaderc/src@7425820dcc76 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: I7b298883a7c5672b89125263ad50965003819e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644653Reviewed-by:
-
Takuto Ikuta authored
This reverts commit 2aef1e3c. Reason for revert: crbug.com/971133 Original change's description: > trusty -> xenial for linux try/ci builders > > This will be submitted after > https://chrome-internal-review.googlesource.com/c/infradata/config/+/1358390 > > But test for linux-ozone-rel is still configured to use trusty due to > https://ci.chromium.org/p/chromium/builders/try/linux-ozone-rel/283303 > > Bug: 954450 > Change-Id: Ie2d93ccc409dbc494b15fdb4039aa1e7a44660c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642851 > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666172} TBR=yyanagisawa@chromium.org,tikuta@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: Ia1e79e2b720b928c6d84cde954b5eb112113e3c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 954450, 971133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645136Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#666188}
-
Michael Lippautz authored
- Use observer pattern to notify interested components about heap sizing updates. - Only send deltas of reasonable kUpdateThreshold sizes. - Send positive as well as negative increments to allow observers to take different action on them. Change-Id: Id5a83b5b140e25e5eec07b402396eb4f2fc9062c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631708 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#666187}
-
Nancy Li authored
Added a new function to initialize a descriptor panel, which includes create a new panel object and binding click actions. Changed unnecessary id attribute to class. Bug: 928923 Change-Id: Ic352befdc512738bad5928485e3c4c048e09f263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639739Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Nancy Li <nancyly@google.com> Cr-Commit-Position: refs/heads/master@{#666186}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/002d0e113a3b..23fce88da7cf Created with: gclient setdep -r src-internal@23fce88da7cf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harringtond@google.com,orphis@google.com,shend@google.com Change-Id: I9783e5c942217f95efe1ea677d0c3cbb38036e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644614Reviewed-by:
-
Sheng-Hao Tsao authored
This CL fixes the bug where data studio filters out empty strings and make us unable to draw pie chart effectively. Bug: 969647 Test: Capture some photos Change-Id: Ie8714b0709a5d040408905df3bb4c62459fd8b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640933 Commit-Queue: Sheng-hao Tsao <shenghao@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#666184}
-
Wei-Yin Chen (陳威尹) authored
http://crrev.com/c/1595128 (Release thumbnail when TabGridView is recycled) tried to fix the memory leak in TabGridView, but http://crrev.com/c/1595292 (Fix memory leak in RoundedCornerImageView) didn't fully fix the memory leak in RoundedCornerImageView (see issue 969245), so the memory leak issue in Grid Tab Switcher (GTS) turned out to be still there. This CL avoids using setImageResource(0) in GTS, and uses setImageDrawable(null) along with specified fill color instead. TBR=dtrainor@chromium.org Bug: 970073 Change-Id: Iec97ea2b9ec2925f34a4077e4a7069973e2a2b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642161 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666183}
-
Takashi Toyoshima authored
Bug: 905971 Change-Id: Ife1b1c5dcb6ecd8a4163e8a8b16c04d9736b378b Tbr: yhirano@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644772Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#666182}
-
Manuel Rego Casasnovas authored
Layout containment suppress baseline, so buttons with "contain: layout" should use the same baseline than an empty inline block. This means that it should use the margin box and not the content box. Spec (https://www.w3.org/TR/CSS2/visudet.html#propdef-vertical-align): "If the box does not have a baseline, align the bottom margin edge with the parent's baseline." Modified LayoutButton::BaselinePosition() to take into account layout containment. BUG=965740 TEST=external/wpt/css/css-contain/contain-layout-button-001.html Change-Id: I8752aa4f5aec00dbec2a6c93c16734b47d286c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643536Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#666181}
-
Yoav Weiss authored
Bug: 969761 Change-Id: I78fed0dee2f7b820f67a075f144064b2cdcfbde6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643576 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#666180}
-
Yoav Weiss authored
Change-Id: I54c65ebbd2f252a8050503e809f835c3b23ec4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643472Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#666179}
-
Kinuko Yasuda authored
This reverts commit 869062d9. Reason for revert: Msan crashing due to uninitialized value: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8911533900209194848/+/steps/browser_tests/0/logs/Deterministic_failure:_FeedbackTest.SubmissionTest__status_CRASH_/0 5:21315:0604/180329.553111:INFO:CONSOLE(193)] "Feedback: Sending report", source: chrome-extension://gfdkimpbcpahaombhbimeihdjnejgicl/js/feedback.js (193) ==21315==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x565429d9374f in Value ./../../base/values.cc:197:7 #1 0x565429d9374f in make_unique<base::Value, double &> ./../../buildtools/third_party/libc++/trunk/include/memory:3131:0 #2 0x565429d9374f in base::Value::SetDoubleKey(base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, double) ./../../base/values.cc:435:0 #3 0x565429afadea in base::HistogramBase::WriteJSON(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, base::JSONVerbosityLevel) const ./../../base/metrics/histogram_base.cc:157:8 #4 0x565429b2e4dc in base::StatisticsRecorder::ToJSON(base::JSONVerbosityLevel) ./../../base/metrics/statistics_recorder.cc:170:16 #5 0x565422ce3e07 in extensions::FeedbackPrivateSendFeedbackFunction::OnAllLogsFetched(bool, bool, scoped_refptr<feedback::FeedbackData>) ./../../extensions/browser/api/feedback_private/feedback_private_api.cc:363:9 Original change's description: > Add browsertest for complete process of sending feedback report > > This adds a new browsertest which adds a hook into the feedback uploader > to catch it right before it does the actual report upload. This ensures > that clicking on the button to send a feedback report actually results > in the report getting queued to be sent. This covers a regression case > which is in crbug.com/954563. > > Bug: 955039, 954563 > Test: Browser tests pass, fail if prior regression was put back > Change-Id: I92762c1b6741ad057e78c8cafeb924f93995b249 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632534 > Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666036} TBR=afakhry@chromium.org,jkardatzke@google.com Change-Id: I004940a9156698865fddd6152e298c49797aa3bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955039, 954563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644855Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#666178}
-
Jeevan Shikaram authored
This is a reland of 2fd01309 Original change's description: > [App Management] Enable App Management by default. > > Enable App Management by default. Current entry points are about:settings > and about:app-management. > > Bug: 906508 > Change-Id: I0118a4b51eda6e65bc72186e771fc2ede2acb45f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610658 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659341} Bug: 906508 Change-Id: I0fb9ced91a975afa7d0b94e0a863dccaca4bb247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642491Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#666177}
-
Dale Curtis authored
Now that AVDA is deleted, time to rename and remove lots of stuff! We no longer need synchronous codec creation w/o AVDA! BUG=none TEST=compiles R=liberato Change-Id: Iba492149c2e395c45d76a67b752916560ff8ad25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644161 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#666176}
-
Kinuko Yasuda authored
Its test expectation was changed recently by https://crrev.com/c/1642031 but it looks it just keeps failing on Mac. Sample failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Mac10.13%20%28retina%29/15149 http://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/23650 http://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/23644 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/14224 TBR=szager@chromium.org Bug: 971031 Change-Id: Icf49dcfaaa6492d36725fd62b3e5e59ee904f884 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644913 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Alexei Svitkine authored
This allows capturing much more execution during browser start up. This CL is based on the following earlier CL which was reverted: https://chromium-review.googlesource.com/c/chromium/src/+/691239 Some changes from that previous CL: - Enables this for browser process only for now. - MainThreadStackSamplingProfiler added to chrome/common so it can be used from InProcessBrowserTest, as it does not run the code in chrome_main.cc. - Made thread_profiler.cc keep track of the main thread instance so that the task runner could be registered on it, as chrome_browser_main.cc otherwise doesn't have access to the object created in chrome_main.cc. Bug: 700083 Change-Id: Ifbff01eaa6e48e6e1daea8be381890337cab387d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618566 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#666174}
-
rajendrant authored
Redirect cycle tests are in browser test with NetworkService. Bug: 968214 Change-Id: I27f6d659789fceaf3dc37ffe13204a5925573212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644322Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#666173}
-
Takuto Ikuta authored
This will be submitted after https://chrome-internal-review.googlesource.com/c/infradata/config/+/1358390 But test for linux-ozone-rel is still configured to use trusty due to https://ci.chromium.org/p/chromium/builders/try/linux-ozone-rel/283303 Bug: 954450 Change-Id: Ie2d93ccc409dbc494b15fdb4039aa1e7a44660c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642851 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Dominick Ng authored
This CL adds a new method on app.mojom that allows Chrome OS to query ARC for whether a given package name is currently installable. BUG=969560 Change-Id: Ia525a92944b9b4afb4fd5f6a1ccb150e931a22ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640917Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#666171}
-
