- 22 Jan, 2019 40 commits
-
-
Z Duong Nguyen-Huu authored
The tests are related to ownkeys with duplicates entries. The tests will be re-enabled once the test expectations are updated. Bug: v8:6776 Change-Id: I6a65f1f8085c2339e9e385b6716ea23a203ac79e Reviewed-on: https://chromium-review.googlesource.com/c/1427459 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#624900}
-
kylechar authored
ui::Compositor expects that calling LayerTreeFrameSink::BindToClient() will always be successful. However, BindToClient() can fail if the worker context provider has encountered a GL error. Even if we check the worker context provider hasn't encountered an error before passing it to ui::Compositor, it's possible the error happens after the check but before BindToClient() is called. GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash is failing flakily on mac due to this. With OOP-D there are multiple message pipes between the browser and GPU process which all get notified of the GPU process crashing. This sets up the perfect conditions for the race to occur. Stop checking if the worker context provider has been lost in BindToCurrentThread(). Instead, ensure that observers will always get the OnContextLost() call even if AddObserver() was called after context is lost. We make OnContextLost() call happens in a new callstack to avoid re-entrancy. This should be safe because the posted task has a reference to context provider and we check that the observer is still observing in the posted task. Bug: 878258 Change-Id: If0db2fead55f86d86892db7a5dc257154590fe98 Reviewed-on: https://chromium-review.googlesource.com/c/1403323Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#624899}
-
agrieve authored
This reverts commit 2dc440a1. Reason for revert: Broke downstream test (see bug) Original change's description: > Reland "Android: Replace desugar with d8 and r8 for debug" > > Previous reland: https://crrev.com/c/1393466 > > Bug: 906803, 922638 > Change-Id: I8aa0382aaa822ad37b299a9737411130e0c75b63 > Reviewed-on: https://chromium-review.googlesource.com/c/1415699 > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624309} TBR=wnwen@chromium.org,smaier@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 906803, 922638, 923862 Change-Id: Ib2003e0e9da279ac586d039e50bb779a0365fb0c Reviewed-on: https://chromium-review.googlesource.com/c/1427222Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#624898}
-
Rohit Rao authored
This observer was added to the WebStateList by code in TabModel's constructor, but it should be part of the snapshot feature. Instead, use TabModelListObserver to listen for changes to the TabModelList and register the snapshot observer that way. SnapshotCache is shared between the normal and OTR browser states, so the new SnapshotCacheTabModelListObserver listens for changes to either browser state. BUG=783777 Change-Id: I646611a74be5538e1f3a55c0c1d05eaaeb1207ae Reviewed-on: https://chromium-review.googlesource.com/c/1425791Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#624897}
-
Takumi Fujimoto authored
Clear issues shown in the Views dialog by sending explicit ClearIssue() calls, instead of doing so by sending invalid CreateRoute() requests. Bug: 923172 Change-Id: I79edc224505fec1debc06d782d1fda0acd6ccaf3 Reviewed-on: https://chromium-review.googlesource.com/c/1419201 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#624896}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5881c603. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 33a49f0d "[WebLocks]: Modifying weblocks algos to be O(1)" 8e4e5d72 "Fix preload tests failing on wpt.fyi dashboard" f643497e "[resource-timing] Modify is_secure_context_ based on resource" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox dgrogan@chromium.org: external/wpt/css/css-tables foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure guidou@chromium.org: external/wpt/mediacapture-streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc jsbell@chromium.org: external/wpt/encoding ksakamoto@chromium.org: external/wpt/resource-timing mstensho@chromium.org: external/wpt/css/css-multicol panicker@chromium.org: external/wpt/longtask-timing external/wpt/user-timing panicker@chromium.org, tdresser@chromium.org: external/wpt/paint-timing rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request skobes@chromium.org: external/wpt/css/css-scroll-anchoring tdresser@chromium.org: external/wpt/navigation-timing yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I0439dfda11920f7f9810f89d79211194204c3dd9 Reviewed-on: https://chromium-review.googlesource.com/c/1426921Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624895}
-
Tatiana Buldina authored
Bug: chromedriver:2736 Change-Id: I7d48e7706f980eaf9941f501e3b5fda43577ae63 Reviewed-on: https://chromium-review.googlesource.com/c/1427461Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#624894}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8dbd0e26da72..c26730d4e1ad git log 8dbd0e26da72..c26730d4e1ad --date=short --no-merges --format='%ad %ae %s' 2019-01-22 tsepez@chromium.org Let CJX_Object subclasses communicate typename to jse_define.h macros. 2019-01-19 thestig@chromium.org Roll v8/ ec2203e1f..817547547 (485 commits) 2019-01-19 thestig@chromium.org Roll third_party/icu/ 23de01679..07e7295d9 (2 commits) 2019-01-19 thestig@chromium.org Roll third_party/zlib/ 2aafd9d33..e080c76be (3 commits) 2019-01-19 thestig@chromium.org Remove a TODO in the DEPS file. Created with: gclient setdep -r src/third_party/pdfium@c26730d4e1ad The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iedd406fa9810e7c179ccfe1bf1b10cedaec52801 Reviewed-on: https://chromium-review.googlesource.com/c/1427219Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624893}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ebc22e0030e4..6af1edccbf23 git log ebc22e0030e4..6af1edccbf23 --date=short --no-merges --format='%ad %ae %s' 2019-01-22 nigeltao@google.com Update Wuffs version 2019-01-22 csmartdalton@google.com ccpr: Add explicit fmas to vertex placement code Created with: gclient setdep -r src/third_party/skia@6af1edccbf23 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I4319f38485aa33207d29feae90aa837638fb2c5a Reviewed-on: https://chromium-review.googlesource.com/c/1426722Reviewed-by:
-
Rayan Kanso authored
TBR=dgozman@chromium.org Change-Id: I46da7eaa5f58d180da8612d27bc64932b61c5227 Reviewed-on: https://chromium-review.googlesource.com/c/1425606 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#624891}
-
Mihai Sardarescu authored
Bug: 923903 Change-Id: I13c89d3c2fa3bc2726cd838030bcf1413f263ffb Reviewed-on: https://chromium-review.googlesource.com/c/1424800Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#624890}
-
Dale Curtis authored
Adds standard media/OWNERS + mlamouri@ + lethalantidote@ for the following files: blink/public/platform/web_surface_layer_bridge.h blink/public/platform/web_video_frame_submitter.h blink/renderer/platform/graphics/surface_layer_bridge.cc blink/renderer/platform/graphics/surface_layer_bridge.h blink/renderer/platform/graphics/video_frame_submitter_test.cc blink/renderer/platform/graphics/video_frame_submitter.cc blink/renderer/platform/graphics/video_frame_submitter.h blink/renderer/platform/graphics/video_frame_resource_provider.cc blink/renderer/platform/graphics/video_frame_resource_provider.h BUG=746182 Change-Id: I4612c011421fcf7ba3ee33b96e51dd03c7acc1b6 Reviewed-on: https://chromium-review.googlesource.com/c/1423086 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#624889}
-
edchin authored
CoreGraphics should not be a dependency in web\. This CL replaces CGRect with gfx::Rect in web_state.h. Change-Id: Ibe716953d52a252d089c33b5217863fa3a33fae8 Reviewed-on: https://chromium-review.googlesource.com/c/1423922Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#624888}
-
Dan Beam authored
The spec was a little hard to read, but I think this is correct. Screenshots: https://imgur.com/a/SqOdxgO Specs: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g471d243f08_0_869 R=dpapad@chromium.org BUG=883049 Change-Id: Ie377f7c4ba52a3a4540497b15b8a7bb8ad67853a Reviewed-on: https://chromium-review.googlesource.com/c/1426157Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#624887}
-
James Cook authored
It's flaky in debug. Bug: 923090 Change-Id: Ia76f5aed90338cff927274fc7fa80967240d259a Reviewed-on: https://chromium-review.googlesource.com/c/1427460 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#624886}
-
Shivani Sharma authored
This Cl makes NavigationController::CanGoBack() return false if all entries are marked to be skipped on back/forward UI. On desktop this leads to the back button being disabled. On Android, it will close the current tab and a previous tab could be shown as it usually happens on Android when you press back from the first entry of a tab. browser_tests --gtest_filter=*SkippableBackButton* content_browsertests --gtest_filter= *NoUserActivationSetSkippableMultipleGoBack Test: Bug: 907167 Change-Id: Icda3cbe0e87f7ae8033ed2d9650c0372316ab12d Reviewed-on: https://chromium-review.googlesource.com/c/1388811Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#624885}
-
Sergey Ulanov authored
1. Renamed was_activated flag to user_activated. 2. Updated flag description to make its purpose clearer. Change-Id: I4fdec2ea38f1d422c0e3685a627ab3585fe03387 Reviewed-on: https://chromium-review.googlesource.com/c/1422219 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#624884}
-
Eric Karl authored
As we transition to SharedImage, certain places in code need to know whether a mailbox they receive should be used with the SharedImage system or legacy mailbox system. This CL adds a flag to Mailbox to identify SharedImage usage, and converts existing clients to check this flag. Bug: 922834 Change-Id: I20900e302e2620d216377edc5d6f0017270c23d6 Reviewed-on: https://chromium-review.googlesource.com/c/1416836 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#624883}
-
Danyao Wang authored
Visible item can be a pending brower-initiated navigation, and it may come into existence before the previous navigation is finished. So HistoryTabHelper should not assume that the visible item corresponds to the just finished navigation. Bug: 922973 Change-Id: If59dad6610b92daba14e8a11490aac16e3726e68 Reviewed-on: https://chromium-review.googlesource.com/c/1419537Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Robert Sesek authored
The histograms already exist on Linux, CrOS, and Android, so this simply wires up the values for macOS. In addition, this enables the FD count column in the Task Manager, since the data are now readily available. Bug: 714614 Change-Id: I05f8063e8d89d3c6cdc68062bf4e591d3af9559c Reviewed-on: https://chromium-review.googlesource.com/c/1423339Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#624881}
-
Tommy Steimel authored
This CL fixes an issue where the controls were relying on the panel element to receive keypress events to reset the hide timer. Instead, we want to reset the timer when the button panel receives keypress events, because the button panel will stop propagation of keypress events before the panel sees them. Bug: 924019 Change-Id: Ic85c023047c20cafe91da419a77c827ad619d632 Reviewed-on: https://chromium-review.googlesource.com/c/1426899Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#624880}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2a95ada9ce63..0df3edc9d973 git log 2a95ada9ce63..0df3edc9d973 --date=short --no-merges --format='%ad %ae %s' 2019-01-22 hjd@google.com Merge "perfetto-ui: Stop unowned threads being grouped under process 0" 2019-01-22 hjd@google.com Merge "perfetto-ui: Re-enable summary tracks" Created with: gclient setdep -r src/third_party/perfetto@0df3edc9d973 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I927a65541f0a6105ec85a4eaf802a1e4c4cdba56 Reviewed-on: https://chromium-review.googlesource.com/c/1426040Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f62d967f..5aaff41a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ied49f2916ed42ae060445b236d19f8038aec109f Reviewed-on: https://chromium-review.googlesource.com/c/1427043Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624878}
-
Eric Aleshire authored
I found that a handful of sites will deflake by running twice in succession on the same simulator (NOT twice in a row, one time per fresh simulator). The failure on the first try is caused by a deeply embedded issue with JS execution specifically under WPR, so I feel this cheap workaround is a preferable solution. This only affects the autofill tests, in any case, so I think this is worth a try. Though it is not too testable as-is in test_runner_test (as that class mostly exercises the run_wpr_test method itself), I did confirm through manual temporary changes to test_runner_test that this block of code only runs when tests actually fail. Change-Id: I311f3fccd9e97a1fb21b8f9814b5fdecc67c046e Reviewed-on: https://chromium-review.googlesource.com/c/1419897Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#624877}
-
Natalie Chouinard authored
Implement the Set- and GetAllTokenMappings functions for UsageStatsDatabase. Bug: 902570 Change-Id: I619f1bf152566792f6046001ea14022b69e1aad5 Reviewed-on: https://chromium-review.googlesource.com/c/1423622 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#624876}
-
Nathaniel Steinbock authored
This test is failing on Android Things because the returned estimate is slightly lower than the straight free-memory value checked against. Bug: internal 122977999 Change-Id: Ie3c3d4d95636d0e77021d02cbb5d5797bfa4d0be Reviewed-on: https://chromium-review.googlesource.com/c/1416136 Commit-Queue: Nate Steinbock <steinbock@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#624875}
-
Dmitry Gozman authored
There are no users of this information left. Originally, some CSP error messages used it, but those moved to the browser process. Bug: none Change-Id: I1fa29e49fe61b6a3c1fbf3a57906c327dbc8b1a5 Reviewed-on: https://chromium-review.googlesource.com/c/1424421Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#624874}
-
liberato@chromium.org authored
This CL adds a lookup-table learner that's very similar to the one used today by mediacapabilities. There are two goals: - Since the existing implementation saves data between runs, the training data used by the learners and the database will be different. The lookup table learner will let us quantify how much this actually affects us, by comparing to the existing database implementation. - Since both the table learner and ExtraTrees use the same training data, we will be able to directly compare the learning algorithms and (later) the effect of adding new features. Change-Id: I3738e6fa964930bc8c1b579e9a0137d48574329d Reviewed-on: https://chromium-review.googlesource.com/c/1379184Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#624873}
-
Kehuang Li authored
ExperimentalAgc is by default created as enabled, and thus gain_control() will return a pointer to ExperimentalAgc anyway no matter if the google_experimental_auto_gain_control is set or not. Explicitly disable ExperimentalAgc in WebRTC config when the flag is false. We only fix this bug on Chromecast build, since other applications may already, by default, be using the adaptive gain control of ExperimentalAgc, which has better performance. Bug: 918677 Test: Add print log and see the correct instance is referenced. Change-Id: I73f512f03bb8296053d93f1f9d1294dc087f231e Reviewed-on: https://chromium-review.googlesource.com/c/1393340 Commit-Queue: Kehuang Li <kehuangli@chromium.org> Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#624872}
-
Lowell Manners authored
Follow up from https://crrev.com/c/1392943. Change-Id: Iee519d102f787b59d79dc146680bc8baf99ce1e3 Reviewed-on: https://chromium-review.googlesource.com/c/1424838Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#624871}
-
Dan Beam authored
Changes the background color of the "dev mode" bar to match spec (GM2 GG800) and removes bottom border (not in spec mocks). Also changes the loading shell to match. Screenshots: https://imgur.com/a/nbQBRik Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g481b97d74a_0_359 R=dpapad@chromium.org BUG=883049 Change-Id: I16aef0496775fd9b6b678085d26077c6525483a1 Reviewed-on: https://chromium-review.googlesource.com/c/1426158Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#624870}
-
David Tseng authored
AXNode::data() returns a const AXNodeData& (lvalue), which triggers a copy constructor when called in the context of std::map::insert. The previous code triggered both a copy and move internal to std::map because it used AXNode::data(). In the current change, (by tracing all of the constructors of AXNodeData), there are now two move operations (via the move constructor) in AXNodeData when calling std::map::insert on AXNode::TakeData(). This ensures no unnecessary copies are triggered. Bug: 923344 Change-Id: I53c7a8b8804e70fda93c44ee111162111287e268 Reviewed-on: https://chromium-review.googlesource.com/c/1423460Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#624869}
-
Becca Hughes authored
Fixes when default actions are not available when the routed service is nullptr. BUG=894255 Change-Id: I2d396ffbf5eeb46b18b30d489ee43533d0cb2f1f Reviewed-on: https://chromium-review.googlesource.com/c/1418510 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#624868}
-
Lukasz Anforowicz authored
This CL adds crash keys that should hopefully make it easier to understand the kills that were apparently introduced by r623505. Bug: 910287 Change-Id: Ia70fb4d89bb9a6b7b414bb44602e2f86160bb544 Reviewed-on: https://chromium-review.googlesource.com/c/1418391 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#624867}
-
Dan Beam authored
Also moves some duplicate color styles into cr-toast itself (and uses ::slotted(*) to apply). Screenshots: https://imgur.com/a/JXx291d Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g48a476f4a5_2_63 R=dpapad@chromium.org BUG=883049 Change-Id: I983b7cf9d6b63b5b45a2f8897f7a9cdf6d1de244 Reviewed-on: https://chromium-review.googlesource.com/c/1425967 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
-
Yulun Wu authored
Bug: 122108419 Change-Id: I85bf1dcd4d5ed6760fe46a33be6b8d492b8486b7 Reviewed-on: https://chromium-review.googlesource.com/c/1412934Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#624865}
-
kyle Ju authored
Change-Id: I98e76d9d578aba6c2c3d3d5f60bc5299fba0e489 Reviewed-on: https://chromium-review.googlesource.com/c/1426159 Commit-Queue: Kyle Ju <kyleju@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#624864}
-
Robert Ogden authored
This isn't being done in previews decider, so take of it in the NavThrottle. Bug: 923464 Change-Id: I45b0f33e21ff54fc89b1a3ec79fa0fc5029c9c0a Reviewed-on: https://chromium-review.googlesource.com/c/1423933Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#624863}
-
Andrew Grieve authored
Read-only symbols are more memory-efficient than mutable ones. There have been a couple of past audits to fix these up, but catching them with a trybot is much nicer! TBR=agrieve # Trivial adding of "const" Bug: 888863 Change-Id: Ica73a420fe6099d63e094274d71129a9cf5c85ef Reviewed-on: https://chromium-review.googlesource.com/c/1423669 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#624862}
-
Boris Sazonov authored
This CL removes NOTREACHED() from ProfileSyncService::OnPreferredDataTypesPrefChange. This check was triggered if setChosenDataTypes is invoked soon after requestStart. Bug: 923886 Change-Id: I1a826ba3b5e1ee64aa0ecba6107e420d0551a7ee Reviewed-on: https://chromium-review.googlesource.com/c/1426940Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#624861}
-
