GitLab

This is one noted in the bug as potentially interesting.

It looks like a progression to me as on Windows we go from FAIL->PASS,
and can remove the platform-specific baselines.

R=dpranke@chromium.org
BUG=348800

Review URL: https://codereview.chromium.org/177353008

git-svn-id: svn://svn.chromium.org/blink/trunk@168401 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Confirming that I can infact rebaseline tests.

TBR=dpranke@chromium.org
BUG=348800

Review URL: https://codereview.chromium.org/180633011

git-svn-id: svn://svn.chromium.org/blink/trunk@168400 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/186283003

git-svn-id: svn://svn.chromium.org/blink/trunk@168399 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also handle zero frame width correctly (happens occasionally per crbug.com/340987), and simplify the LayoutScope interface.

BUG=347384
NOTRY=true

Review URL: https://codereview.chromium.org/180743004

git-svn-id: svn://svn.chromium.org/blink/trunk@168397 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=caseq@chromium.org

Review URL: https://codereview.chromium.org/180273023

git-svn-id: svn://svn.chromium.org/blink/trunk@168396 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The code path resulting in a NULL here currently segfaults, but will return
NULL after the Chromium-side patch https://codereview.chromium.org/185653006/

BUG=347901

Review URL: https://codereview.chromium.org/183833014

git-svn-id: svn://svn.chromium.org/blink/trunk@168395 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Non-renderer-based elements such as optGroup do not have renderers.
BUG=348330
R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/185293011

git-svn-id: svn://svn.chromium.org/blink/trunk@168394 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since there is always root inline box, InlineBox::root() should return
reference.

BUG=

Review URL: https://codereview.chromium.org/182413005

git-svn-id: svn://svn.chromium.org/blink/trunk@168391 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=304341

Review URL: https://codereview.chromium.org/184043011

git-svn-id: svn://svn.chromium.org/blink/trunk@168390 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=eustas@chromium.org, eustas, pfeldman
BUG=348297

Review URL: https://codereview.chromium.org/183803018

git-svn-id: svn://svn.chromium.org/blink/trunk@168389 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=lushnikov@chromium.org, pfeldman

Review URL: https://codereview.chromium.org/177963004

git-svn-id: svn://svn.chromium.org/blink/trunk@168388 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/186553002

git-svn-id: svn://svn.chromium.org/blink/trunk@168387 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The HeapVector was put in a normal Vector of pairs on the stack
which is not traced.

This issue was found with the ASAN build on layout tests.

R=erik.corry@gmail.com, haraken@chromium.org, wibling@chromium.org, zerny@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/180273021

git-svn-id: svn://svn.chromium.org/blink/trunk@168386 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Workaround for crash on quora and geek-and-poke. There is a finalization issue that we need to resolve in CSSCursorImageValue.

R=erik.corry@gmail.com, haraken@chromium.org, wibling@chromium.org
BUG=347943
NOTRY=true

Review URL: https://codereview.chromium.org/185723006

git-svn-id: svn://svn.chromium.org/blink/trunk@168385 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org, vegorov@chromium.org
BUG=348629
NOTRY=true

Review URL: https://codereview.chromium.org/183683017

git-svn-id: svn://svn.chromium.org/blink/trunk@168384 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Design document: https://docs.google.com/a/google.com/document/d/1yeHTCHhulVIlrKyx9_gCguAhLfcefVOa9uxxfW2LVG0/edit

Intent-to-ship-and-implement in blink-dev: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/t0XiZuMey7M/9-5AuhoFyisJ

This CL moves DOM attributes used in Dromaeo to prototype chains. When I landed the CL two months ago (https://codereview.chromium.org/94403002), it caused 20+% regression in benchmarks. However, now that a V8 side fix is landed, there should be no overhead in moving DOM attributes to prototype chains in theory.

Dromaeo/dom-attr 1086 runs/sec => 1077 runs/sec (-0.8%)
Dromaeo/dom-modify 522 runs/sec => 525 runs/sec (+0.5%)
Dromaeo/dom-query 26150 runs/sec => 26200 runs/sec (+0.2%)
Dromaeo/dom-traverse 564 runs/sec => 544 runs/sec (-3.6%)

I don't understand the regression in dom-traverse. The regression is reproducible but I cannot reproduce the regression in a super-micro benchmark that just repeats accessing div.firstChild. Probably the regression might be a noise.

I'm going to land this CL and see how much regression is observed in perf bots (I'll email to perf-sheriff@). If I find the regression is unacceptable, I'll revert the CL.

See the design document and the Intent-to-ship email for justification for the regression.

BUG=43394

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167680

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/158713002

git-svn-id: svn://svn.chromium.org/blink/trunk@168383 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=eseidel

Review URL: https://codereview.chromium.org/185533013

git-svn-id: svn://svn.chromium.org/blink/trunk@168382 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=338654
R=apavlov
NOTRY=true

Review URL: https://codereview.chromium.org/178543014

git-svn-id: svn://svn.chromium.org/blink/trunk@168381 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dongseong.hwang@chromium.org
BUG=348549

Review URL: https://codereview.chromium.org/183003012

git-svn-id: svn://svn.chromium.org/blink/trunk@168380 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=eae

Review URL: https://codereview.chromium.org/183883014

git-svn-id: svn://svn.chromium.org/blink/trunk@168379 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Oilpan: Use the OilpanExpectations for oilpan specific test expectations. (https://codereview.chromium.org/183683012/)

Reason for revert:
Only the release oilpan layout tests are run with the --additional-expectations flag. Reverting back to using TestExpectations for now.

Original issue's description:
> Oilpan: Use the OilpanExpectations for oilpan specific test expectations.
> 
> R=erik.corry@gmail.com, haraken@chromium.org
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168366

TBR=erik.corry@gmail.com,haraken@chromium.org,wibling@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/186403004

git-svn-id: svn://svn.chromium.org/blink/trunk@168378 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=pfeldman

Review URL: https://codereview.chromium.org/186563002

git-svn-id: svn://svn.chromium.org/blink/trunk@168377 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently DOMWrapperWorld can be 0 in some tests. This is problematic since I want to make DOMWrapperWorld::current() callable from anywhere. Thus this CL adds DOMWrapperWorld to all webkit_unit_tests.

- It's verbose to initialize v8::HandleScope, v8::Context, v8::Context::Scope, V8PerContextData and DOMWrapperWorld in each test. So this CL adds a helper class (V8BindingTestScope) that does all the initialization work.

- This CL also fixes indentation of V8Binding.h.

BUG=341032

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168355

R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/180743013

git-svn-id: svn://svn.chromium.org/blink/trunk@168376 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- This CL moves extractTransferables() from V8Utilities to SerializedScriptValue, since the method is related to SerializedScriptValue.

- Then removes V8Utilities.{h,cpp}

BUG=339037
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/141893007

git-svn-id: svn://svn.chromium.org/blink/trunk@168375 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We observe crashes in fast/dom/css-delete-doc.html.
The cause is that ~CSSGroupingRule() touches m_childRuleCSSOMWrappers.
~CSSGroupingRule() shouldn't touch m_childRuleCSSOMWrappers because the wrappers are on the heap.

NOTRY=true
R=ager@chromium.org, wibling@chromium.org

Review URL: https://codereview.chromium.org/185423009

git-svn-id: svn://svn.chromium.org/blink/trunk@168374 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The m_childRuleCSSOMWrappers vector is in the heap and we should not
touch it. Not even to get its size.

R=haraken@chromium.org, kouhei@chromium.org, wibling@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/183833017

git-svn-id: svn://svn.chromium.org/blink/trunk@168373 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=348911
TBR=eae

Review URL: https://codereview.chromium.org/183743017

git-svn-id: svn://svn.chromium.org/blink/trunk@168372 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=258421

Review URL: https://codereview.chromium.org/18132024

git-svn-id: svn://svn.chromium.org/blink/trunk@168371 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=lushnikov@chromium.org, lushnikov, pfeldman

Review URL: https://codereview.chromium.org/183663014

git-svn-id: svn://svn.chromium.org/blink/trunk@168370 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Ensure DOMWrapperWorld always exists in all webkit_unit_tests (https://codereview.chromium.org/180743013/)

Reason for revert:
A few inspector tests are crashing:
WebCore::DOMWrapperWorld::ensureIsolatedWorld(int, int) [DOMWrapperWorld.cpp : 124 + 0x33]

Original issue's description:
> Ensure DOMWrapperWorld always exists in all webkit_unit_tests
> 
> Currently DOMWrapperWorld can be 0 in some tests. This is problematic since I want to make DOMWrapperWorld::current() callable from anywhere. Thus this CL adds DOMWrapperWorld to all webkit_unit_tests.
> 
> - It's verbose to initialize v8::HandleScope, v8::Context, v8::Context::Scope, V8PerContextData and DOMWrapperWorld in each test. So this CL adds a helper class (V8BindingTestScope) that does all the initialization work.
> 
> - This CL also fixes indentation of V8Binding.h.
> 
> BUG=341032
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168355

TBR=jochen@chromium.org,dcarney@chromium.org,haraken@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=341032

Review URL: https://codereview.chromium.org/183803017

git-svn-id: svn://svn.chromium.org/blink/trunk@168369 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This moves 8200 lines out of BisonCSSParser leaving only 1700 lines left. :)

When I split CSSPropertyParser from BisonCSSParser I left
all the code in BisonCSSParser-in.cpp to make the diff
small and to avoid conflicting with others changes.

Now I'm moving (almost) all of CSSPropertyParser into the
correct .cpp file.

The only bit left is some transform parsing code which uses
the -in.cpp preprocessor bits of BisonCSSParser. Its
the only code which uses this fancy SWITCH/CASE preprocessor
and should just be moved out into its own file.

BUG=330389

Review URL: https://codereview.chromium.org/185293006

git-svn-id: svn://svn.chromium.org/blink/trunk@168368 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1) Selected window doesn't slide while recording. Why: there used to be a call for _updateWindow from _update method.
2) No overview for Events mode. Why: raw records may have no valid endTime.
3) The window selection is dropping by recording timeline. Why: earlier overview pane saved the selected time range at _onWindowChanged.

BUG=
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/185543012

git-svn-id: svn://svn.chromium.org/blink/trunk@168367 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=erik.corry@gmail.com, haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/183683012

git-svn-id: svn://svn.chromium.org/blink/trunk@168366 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This should have been removed in https://codereview.chromium.org/184693003/

Review URL: https://codereview.chromium.org/178543008

git-svn-id: svn://svn.chromium.org/blink/trunk@168365 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=347562
R=pfeldman
NOTRY=true

Review URL: https://codereview.chromium.org/178473018

git-svn-id: svn://svn.chromium.org/blink/trunk@168364 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These strings need to be copied along with the event. We only used to
support static strings so far.

BUG=

Review URL: https://codereview.chromium.org/184303002

git-svn-id: svn://svn.chromium.org/blink/trunk@168363 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, it was possible that DatabaseThread held the last
references of DatabaseBackend objects and it was released in the
database thread.
We must destruct objects in the originator thread in Oilpan.

Implementation:
DatabaseThread::recordDatabaseClosed doesn't remove a RefPtr<
DatabaseBackend>, and we release RefPtr<DatabaseBackend> objects
in ~DatabaseThread, which is executed in the main/worker thread.
Note that there are no ways to close a database explicitly, and
DatabaseBackend objects are never destructed before their
DatabaseContext is stopped. DatabaseThread::recordDatabaseClosed
is actually unnecessary.

DatabaseThread doesn't know DatabaseBackend open status any longer.
We remove DatabaseThread::isDatabaseOpen, and its existing
callsites use DatabaseBackend::open() instead.

BUG=347902
TEST=none; no visible behavior changes hopefully.
R=michaeln@chromium.org

Review URL: https://codereview.chromium.org/183883005

git-svn-id: svn://svn.chromium.org/blink/trunk@168362 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/185533004

git-svn-id: svn://svn.chromium.org/blink/trunk@168361 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL moves the early out to the top of the function, which lets us merge the
two stacking node iterations.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/183973017

git-svn-id: svn://svn.chromium.org/blink/trunk@168360 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Prior to this CL, we were incorrectlyd dirtying
RenderLayer::hasVisibleContent() when removing a RenderLayer from the layer
tree. This caused us to incorrectly believe that the parent layer lacked
visible content.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/185653011

git-svn-id: svn://svn.chromium.org/blink/trunk@168359 bbb929c8-8fbe-4397-9dbb-9b2b20218538