GitLab

According to the IA2 spec here:
https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes
"If an attribute is not specified and if the table shows that there is a default value, the default value should be assumed."

This makes the a11y tree less noisy, smaller and easier to debug, and is similar to how Firefox works.

Bug: 844147
Change-Id: I3f7827d10d9659e5e758827a806da0b7f6598e41
Reviewed-on: https://chromium-review.googlesource.com/1066112Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560318}

Mojo doesn't allow removing an uncalled mojo callback while the message pipe is
still open.

On Android, SpellCheckerSessionBridge::DisconnectSession() can discard pending
requests while the message pipe is still open, violating the requirement. This
patch fixes it by running the callbacks with empty result before removing them.

Bug: 843845
Change-Id: I2ab4d51eeb43e63d9715eb42187d51656886fea5
Reviewed-on: https://chromium-review.googlesource.com/1065148Reviewed-by: Rachel Blum <groby@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560317}

Bug: 818331
Change-Id: Ifcaa7adcb25fe099047d5f9d73d6b0bd78d7fff8
Reviewed-on: https://chromium-review.googlesource.com/1067508Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560316}

Bug: 837241
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8f4db54b6b1e0df50c54cbc13a47e574497b2c6a
Reviewed-on: https://chromium-review.googlesource.com/1036482Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560315}

Change-Id: I0643ca9e2d4e5d75cad3a76d8d005a6916c2fd13
Reviewed-on: https://chromium-review.googlesource.com/1063250
Commit-Queue: Hidy Han <hidyhan@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560314}

We would skip style recalc for <content> fallback descendants because
<content> elements are not part of the flat tree, hence they will not
have a ParentComputedStyle() and we would think it's because it's
display:none. Instead traverse into <content> children when <content>
needs reattachment.

Bug: 843520
Change-Id: I2b7f6b44c600371422e86750308231b60e2f5abd
Reviewed-on: https://chromium-review.googlesource.com/1065682Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560313}

When WebRTC sets timestamp to zero for the remote video, it indicates that we
want to skip render smoothness algorithm and render asap. This CL covers this
case by skipping setting REFERENCE_TIME when timestamp is zero.

Bug: webrtc:9135
Change-Id: Ie6cf7a3a7c07cae400541f222611a6efb2ecd943
Reviewed-on: https://chromium-review.googlesource.com/1066915Reviewed-by: Qiang Chen <qiangchen@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560312}

There is a case where no benchmarks could be uploading perf results
from a shard (ie they are all disabled).

Bug: 842145
Change-Id: Iea52461dee8e8a7c4475396d9af9f0339cdfaf3e
Reviewed-on: https://chromium-review.googlesource.com/1066080Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#560311}

This refactors the chromedriver unit tests, particularly those in net_util_unittest,
sync_websocket_unittest, and websocket_unittest, as well as the TestHttpServer class,
to use the network service's HttpServer class (instead of the one in net/).

Bug: 821000
Change-Id: Icc4479b656936f38e86d104004d1dd703d845dda
Reviewed-on: https://chromium-review.googlesource.com/1038544
Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560310}

Bug: None
Change-Id: Ibb2e05e68dce90a0cc41a8e6e88b497fd4f683c0
Reviewed-on: https://chromium-review.googlesource.com/1066918Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560309}

Merge internal change: 197190958

R=rch@chromium.org

Change-Id: Ic0a737873c63d26b9831e5f00e72737eba209bd3
Reviewed-on: https://chromium-review.googlesource.com/1067359Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Fan Yang <fayang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560308}

https://chromium.googlesource.com/catapult.git/+log/7ca7a59f0202..421df92ae3d4

$ git log 7ca7a59f0..421df92ae --date=short --no-merges --format='%ad %ae %s'
2018-05-21 nednguyen Improve error handling when browser cannot be found in serially_executed_browser_test_case

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:845147


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I8be4845e37314ec28da9d60ed848ddaeacb54626
Reviewed-on: https://chromium-review.googlesource.com/1067438Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560307}

Currently, hovering the mouse over the Picture-in-Picture window sets
the opacity of the layer used to darken the video to 0.2,
which is not particularly noticeable.

With this change, the opacity of the used layer has been adjusted
to .4 to create a more distinct effect.

Bug: 843219
Change-Id: I8b39e62dec60c142c3b72309e3df526ee370d901
Reviewed-on: https://chromium-review.googlesource.com/1060476Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Steven Sawtelle <sawtelle@google.com>
Cr-Commit-Position: refs/heads/master@{#560306}

CL:1056647 invalidated inline items in LayoutNGText when
LayoutObjects are moved without full notifications.

However, it did not handle when LayoutInline is moved and it
has LayoutNGText descendants. In such cases, InsertChildNode
is called only for the LayoutInline. This patch supports the
case as well.

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I9aaefec24f3dd67f9d3b257af35e079d07418b71
Reviewed-on: https://chromium-review.googlesource.com/1065540Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560305}

Boilerplate for getting settled background fetches that have been
persisted to disk.

TBR=avi@chromium.org

Bug: 826257
Change-Id: I8a49663df9841fc736af3edad3c946c84da8443c
Reviewed-on: https://chromium-review.googlesource.com/1057623
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560304}

A pending request could get added to LazyBackgroundTaskQueue while the
extension is not enabled (e.g. if it crashed and is waiting to be
reloaded). This appears to be by design. In such a case we do not
attempt to create the background host. The request (and subsequent
requests) could become stuck if the background host does not get
created.

This patch changes LazyBackgroundTaskQueue to listen for extension
loaded, and creates a background host if there are pending requests.

This patch also makes sure we only create a PendingTasksList entry if
we are enqueueing a request to it.

Bug: 835017
Change-Id: Ie2aff8cfb620a1867b033c3474a3277a283fb258
Reviewed-on: https://chromium-review.googlesource.com/1058083Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560303}

Removes adding of "smb" as a standard scheme and removes SmbUrl from
SmbService

Bug: chromium:757625
Change-Id: Icbb0ec7d7563f8196e134167b02b199a48cecf9e
Reviewed-on: https://chromium-review.googlesource.com/1067507Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560302}

Ensures no EDK dependencies get introduced into mojo/public (non-test),
and cleans up some other incorrect DEPS allowances.

TBR=jcivelli@chromium.org

Bug: None
Change-Id: I60030b0734ff73869442d5880b50d1b2289721af
Reviewed-on: https://chromium-review.googlesource.com/1067489Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560301}

Since we reassociate the SVGResource synchronously, we need to also make
sure that the associated SVGResources object is updated, else it could
end up pointing to the old <pattern> LayoutObject.

Bug: 845040
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I026b46abcd510485ddfe33622cb5f5aa1bab9610
Reviewed-on: https://chromium-review.googlesource.com/1065779Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#560300}

BUG=844787

Change-Id: I966b385a928075c25eebdb7abfbdbbfb0ab2db95
Reviewed-on: https://chromium-review.googlesource.com/1067477Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560299}

Preparation for turning the new mojo app implementation on by default.
Change the switch to a base::Feature so we can trivially change the
default (or turn it off via Finch) if necessary.

Bug: 840380
Test: ash_unittests, unit_tests for about:flags
Change-Id: Ia1c2cf5d3bb2ae77dc01e9c26c5941e1643b54cb
Reviewed-on: https://chromium-review.googlesource.com/1066826Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560298}

Bug: 830810
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9abf680f5ac7007654ec8054150a85b49ce10a6d
Reviewed-on: https://chromium-review.googlesource.com/1066308
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560297}

Update the ManifestTest class to use the new base::Value API and
movable types, rather than base::DictionaryValues and unique_ptrs.

Bug: None

Change-Id: Id1cd42dc1842957db5600e36e0bae75b10b71247
Reviewed-on: https://chromium-review.googlesource.com/1039780
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560296}

merge aura_non_clang_gtests into aura_gtests, run linux_and_mac_specific_chromium_gtests on asan bots too

This adds keyboard_unittests and snapshot_unittests to the *san bots, where
they were omitted unintentionally. It also adds keyboard_unittests to the
clang and fyi bots.

This is part of an effort to reduce the number of test configurations.
Originally reviewed as part of https://chromium-review.googlesource.com/1061795,
which I'm now landing in smaller pieces.

TBR=kbr

Bug: 843511
Change-Id: I11d8982c26888d56834c18a5f83ad57c4c29126c
Reviewed-on: https://chromium-review.googlesource.com/1067167
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560295}

BUG=837684
TEST=test only changes

Change-Id: I34a2d9327d9a3771bfc953383e3551ebbcba33aa
Reviewed-on: https://chromium-review.googlesource.com/1067437
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560294}

The Cocoa global pasteboard behavior only updated the find bar if the
find bar was empty and there was new find text. This change copies the
similar behavior to the views find bar by ignoring empty find text.

This fixes browser_tests
FindInPageControllerTest.NavigateClearsOrdinal
FindInPageControllerTest.IncognitoFindNextShared

BUG=844305

Change-Id: Idd50476a7368079ec54221513a76bdfa0a272559
Reviewed-on: https://chromium-review.googlesource.com/1065500Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560293}

This patch removes the force stacking of tabs when touch optimized
chrome is enabled and restores the old approach.

Bug: 844193
Change-Id: Icf591860d06afe4698817291f70d619343237a82
Component: Touchable chrome, tabstrip, tab stacking
Reviewed-on: https://chromium-review.googlesource.com/1066864
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560292}

Due to ink drop effects on the caption buttons, they're painted to
layers. This doesn't work in immersive fullscreen mode and causes
the buttons to disappear. This CL fixes them by adding them temporarily
as children of the TopContainerView which is already painting to
layer in immersive mode, and is resposible for painting its sibling
BrowserNonClientFrameViewAsh.

BUG=840242,787640
TEST=Added two new browser tests

Change-Id: Ia953fa0d742366540855b6e4b0655b76b3c823cd
Reviewed-on: https://chromium-review.googlesource.com/1065020
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560291}

This is a speculative fix for the bug associated. The following is the
scenario of potential NULL-deference:

1. BaseAudioContext.audioWorklet.addModule('some.url');
2. BaseAudioContext is destroyed.
3. The callback originated from the module loading arrives, but the
   associated context is already gone.
4. Crash with NULL deference, because the callback touches the
   destination node of the AudioContext.

This CL fixes the issue by keeping track of WorkletPendingTasks until
module loading tasks are resolved.

Bug: 839642
Change-Id: I154bb8c56f0fa95d6708c642047c7b05acf83eb2
Reviewed-on: https://chromium-review.googlesource.com/1062795Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560290}

Bug: 843639
Change-Id: I71a393ecf295958a14e5bbae4ca52025b3c153a5
Reviewed-on: https://chromium-review.googlesource.com/1064555
Commit-Queue: Daniel Park <danielpark@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560289}

https://skia.googlesource.com/skia.git/+log/037be4e032ef..435282162ed6

$ git log 037be4e03..435282162 --date=short --no-merges --format='%ad %ae %s'
2018-05-21 skia-recreate-skps Update SKP version
2018-05-21 herb Add SkMakeUnique to gn
2018-05-21 jvanverth Disable perspective for emoji fallback
2018-05-21 fmalita Roll third_party/rapidjson to af223d44f4e8d3772cb1ac0ce8bc2a132b51717f

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=allanmac@chromium.org

Change-Id: I43517e46b8f089284cbe707b03b967b3a62e2ea0
Reviewed-on: https://chromium-review.googlesource.com/1066081Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560288}

This incorporats with dgozman's comments in crrev.com/c/1004890
- Change "from SignedExchange" to "from signed-exchange" in NetworkRequestNode.
- Show the signed exchagne url as the initiator of certificate request.
- Show "from signed-exchange" in the headers tab of the inner request.
- Add "View request" link in the preview tab of signed exchange to show the inner request.
- Add "Learn more" link in the preview tab of signed exchange.

Bug: 830505
Change-Id: Ica7ae52e563efb283c600c812be196951a12a336
Reviewed-on: https://chromium-review.googlesource.com/1065558
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560287}

The viewport scrollbars can be hoisted above the layout view's
graphics layer so they are not affected by page scale or overflow
elasticity. To ensure all layers are collected, we start from the paint
root which is an ancestor layer of both the content and the scrollbars.

This fixes a bug where non-hoisted scrollbars were collected twice: once
through the main recursive walk, and a second time for just the
scrollbars.

With this change, overlay scrollbar layers are now collected which
requires a property tree state. VisualViewport::InitializeScrollbars
has been temporarily updated to initialize the property tree state.

Making all painting (not just BlinkGenPropertyTrees) go through this
codepath is difficult because WebViewImpl manages special layers (e.g.,
devtools page overlay, popup layers) which are painted and updated
separately. With BlinkGenPropertyTrees, all painting will start at the
root.

Bug: 841423
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I97bcb40a0242b3f07ce2ca93d432c81dcf3220b6
Reviewed-on: https://chromium-review.googlesource.com/1054777Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560286}

- Added codec_picture.cc because the constructor and destructor are
  now "complex".
- The DecryptConfig describes the decryption config of the input
  stream for this picture

Bug: 838673
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I84f202faae6a1dde2e3fec5f0535d349c2ec3d96
Reviewed-on: https://chromium-review.googlesource.com/1038157Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560285}

- Add -wt/--web-tests argument for running run_web_tests.py with
  custom arguments. Special configuration is needed such as
  --no-sandbox, etc, so this automatically does that.
- Add assert to prevent users from incorrectly running
  run_web_tests.py.
- Add _GetFullPath helper that resolves symbolic links. This
  prevent infinite loop with 'parent_dir == SRC_ROOT_PATH'.
- Make _ExecuteCommand, _ExecuteIOSCommand write stdout, stderr
  to file, so that execution can be monitored.

R=mmoroz@chromium.org,liaoyuke@chromium.org

Bug: 842851
Change-Id: I2eb1744cee34c3d367ec1ddf418879417064c808
Reviewed-on: https://chromium-review.googlesource.com/1067021
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560284}

This is a rough prototype of the proposal described at go/layoutjank.

Bug: 581518
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id212437c0f187c54ad4725cf0b71ddee28288dac
Reviewed-on: https://chromium-review.googlesource.com/1046155
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560283}

This histogram will help us to understand if Chrome for iOS should
support application/x-apple-aspen-config downloads.

Bug: 781770
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4507c19ea7a11aa6bcb014228c7ed94781393acd
Reviewed-on: https://chromium-review.googlesource.com/1058276
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560282}

BUG=837684
TEST=test only change

Change-Id: I206ed5e1bae668285638fde7aff56f70c75c3cec
Reviewed-on: https://chromium-review.googlesource.com/1066786Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560281}

This change is guarded behind a finch trial. This CL would need
to be merged back to M-67, and makes it possible for
third-party origins to receive the DPR, Device-Memory
and viewport-width client hints.

The plan is to enable the finch trial only on Android.

Change-Id: I67596e3f210e623464721210dec85d3e22497bd0
Bug: 845074
Reviewed-on: https://chromium-review.googlesource.com/1066776Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560280}

I forgot to do this in the previous patch for issue 782407.

Looks like the only caller that passed it really wants the new behavior, plus
before the original patch for issue 782407 it was already kinda broken with
custom properties...

No new tests, since there's no behavior change.

Bug: 782407
Change-Id: I410ed1481256b18886c5804f4cbecde9846f2a26
Reviewed-on: https://chromium-review.googlesource.com/1066062Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560279}