- 15 Nov, 2019 40 commits
-
-
Jesse Schettler authored
The flag is being set to on by default for the first time in M80. Extending the flag's expiry milestone to M82 to ensure it can be used in M80 and M81. Change-Id: Ie5f6dff0c539141ef21a1c2e220a175ce286752b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918028 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#715694}
-
Tina Wang authored
Bug: 1025213,1025220 Tbr: xiyuan@chromium.org Change-Id: If2ecef3066504dc40eefe25b5d0c8add170b8b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917964 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715693}
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=tsepez@chromium.org Bug: 1024981 Change-Id: I99d14551e388b435c67dea3eb6aa2b0a0d4efe8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918147 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715692}
-
Mikhail Khokhlov authored
Tracing agents like atrace produce traces with the '.txt' extension. We need to aggregate them together with all other TBMv2 traces. Bug: 1025037 Change-Id: I2d150a338e42f183f086122d3a49335efa085717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917373Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#715691}
-
Gauthier Ambard authored
This CL changes the use of PrefBackBoolean (using a BooleanPrefMember as the backing ivar) to using the Preference directly. This is because the value of the Preference has to be checked when the preference is updated. As PrefMember is also observing the Preference, in some cases the PrefMember is updated after the call in ContentSuggestions. Changing it to Preference directly prevent this issue. Bug: 1023791 Change-Id: Iaa8293d270640007f2e0b1f68b23d76712186752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913255 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#715690}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dad08eab03cc..ad0250cefb22 git log dad08eab03cc..ad0250cefb22 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 lalitm@google.com Merge "ui: switch UI to use track id instead of ref/ref_type" Created with: gclient setdep -r src/third_party/perfetto@ad0250cefb22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I1561b6138eb931b51d29cf0b51ab9ba5f8251d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919262Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715689}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6e5f1021ae2c..86e9f140ce37 git log 6e5f1021ae2c..86e9f140ce37 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 alexclarke@chromium.org Allow --webview-embedder-apk to be specified multiple times Created with: gclient setdep -r src/third_party/catapult@86e9f140ce37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1022812 Change-Id: I41d9638fd8d6d9659ffc611a10e22ee98cfaad61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919261Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715688}
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=odejesush@chromium.org Bug: 1024981 Change-Id: I24b8ae005c530c473b32745f398319db3fe39dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918320 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715687}
-
Natalie Chouinard authored
Change-Id: Ib700829caf0a1e200a7fd8358e8f8f332a7393cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918652 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#715686}
-
Brian Osman authored
Bug: chromium:985500 Change-Id: I0f2c00ac5aac0a939d87a5c0d1e53fd6f53d8313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917621Reviewed-by:
Michael Ludwig <michaelludwig@google.com> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#715685}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3fafc831bc15..7b55818248cc git log 3fafc831bc15..7b55818248cc --date=short --no-merges --format='%ad %ae %s' 2019-11-15 jvanverth@google.com Add flag to Viewer to trigger continuous redraw. 2019-11-15 robertphillips@google.com Revert "Reland "Reland "Reland "Implement sample mask and sample locations support in Vulkan"""" 2019-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1b52f05868c9..5f4db6a76640 (9 commits) 2019-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 7ca6de3a..69610187 (8341 commits) 2019-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b2407dd746de..102fd19c65f4 (4 commits) 2019-11-15 csmartdalton@google.com Reland "Reland "Reland "Implement sample mask and sample locations support in Vulkan""" Created with: gclient setdep -r src/third_party/skia@7b55818248cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I1cfe2ee7fbbfb46ae9817d8ebcc54328a800677c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715684}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8415d24c..96915046 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3129a8101bc491669038024a2536f207dbadb952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917094Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715683}
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=rmcilroy@chromium.org Bug: 1024981 Change-Id: Id9096057c47c70ad94e97ddb42984c71e0ab078e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918319 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715682}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4207870bcd60..86f651198df2 git log 4207870bcd60..86f651198df2 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 jiawei.shao@intel.com Add android_ndk and catapult to .gitignore Created with: gclient setdep -r src/third_party/angle@86f651198df2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: None Change-Id: I64943acf5dbe1c9bf96c82432dd3472b6b7a912e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918018Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715681}
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=morlovich@chromium.org Bug: 1024981 Change-Id: Ib65acd19bcf2ce1b2cbb4b167c89a08b3287f494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918323 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715680}
-
Olivier Robin authored
One of the mocked method is only call in a DCHECK. Tbr: rohitrao Bug: 1024962 Change-Id: I80ee5bd19a7427f9c8362230135d63d72514e8cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917374Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715679}
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=zmo@chromium.org Bug: 1024981 Change-Id: Ia08fdf19c190da94edeaaaaa2d8811f91fa1b58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918152 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715678}
-
Javier Ernesto Flores Robles authored
Bug: 1024310 Change-Id: I0a30dc9fe583988b3fcefe5805fc916483a37888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913416 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#715677}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c30a003c. With Chromium commits locally applied on WPT: 788a3004 "Fix failing Fetch Metadata WPT" b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode." e83dd93c "Limit backtracking on regexp called from blink." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mlamouri@chromium.org: external/wpt/screen-orientation NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I98ba9afb2b88ac9126ec57e9dbca157e5cdf38a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917047Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715676}
-
Anatoliy Potapchuk authored
We should notify SessionManager before we actually create a new browser window. This is needed to cover one of the bugs related to the splash screen. Bug: 1006230, 939674 Change-Id: I3e7e8b5b639dd1bfec2483869959a50b0acb2053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912360Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#715675}
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=tbarzic@chromium.org Bug: 1024981 Change-Id: I89753d009772b07bfa017c57155211e4242200be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918155 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715674}
-
Tobias Sargeant authored
Also rearrange directory structure slightly to group crash-related source files. Change-Id: Iae6bb34c9cb708ac4297cbbeb99be38f1481220a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916826Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#715673}
-
Michael van Ouwerkerk authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1903203 TBR=mastiz,mkwst,huangdarwin Bug: 1018138, 1018132, 1020582 Change-Id: Ic1a8f7798a9bb47932ff867c7b857bb485afbae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903203Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#714193} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919099 Cr-Commit-Position: refs/heads/master@{#715672}
-
Alex Chau authored
- We only want to apply renaming for sign-in only devices, which has client_name == model - Android and Chrome OS also has client_name == model, so we should avoid renaming them Bug: 1024864 Change-Id: If7ab84308a3f76cf24c32982462703c8eed0aeb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917759 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#715671}
-
Anatoliy Potapchuk authored
This one looks scary, but it should be approved soon by the privacy team. Bug: 1006230 Change-Id: I5e949d87f5032c3e354199865e9a22e152114115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910227 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#715670}
-
Ioana Pandele authored
Bug: 835234 Change-Id: I060fed8d3ccd9b97a6375c644ff0f7b0cae7e570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919100 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#715669}
-
Mikhail Khokhlov authored
JSON traces contain clock domain information in the metadata section that applies to the whole file. So we have to write traces with different clock domains to different files. Bug: 990304 Change-Id: If0c2445080ff93b04a037b1d8708ca426ef513b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917371 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#715668}
-
Rohit Rao authored
This test fails on smaller form factors because the test is looking for results that are no longer visible on screen after ranking changes bumped them down in the results list. BUG=1025199 Change-Id: I41df71ccaee252f9cc80e3c47b6884adeeb8cb61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918266 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715667}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/88de31e0..8415d24c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I02e9f4fb57b9a3b9f18afd41a7fdac7a11cb5dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917046Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715666}
-
Oriol Brufau authored
Currently GridTrackSizingAlgorithmStrategy::GetCachedGridTrackSize and GridTrack::CachedTrackSize don't return the GridTrackSize by reference. This means that some code like const GridLength& length = track.CachedTrackSize().MaxTrackBreadth(); DCHECK(length.IsFlex()); has a stack-use-after-scope issue, since GridTrackSize::MaxTrackBreadth returns a GridLength by reference, which will point to the temporary object returned by CachedTrackSize. To avoid this problem, this patch makes GetCachedGridTrackSize and CachedTrackSize return a const reference instead of a temporary copy. Change-Id: I3e43bf88a475b30747a101195705a22d93cc52a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919140Reviewed-by:
Sergio Villar <svillar@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#715665}
-
Yifan Luo authored
See https://github.com/whatwg/fetch/pull/948 . Bug: 1011724 Change-Id: I546752f3d0120f71cc810bfb17f960789e6c53dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917259Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yifan Luo <lyf@google.com> Cr-Commit-Position: refs/heads/master@{#715664}
-
Liviu Rau authored
Land only after a confirmation of successful run of devtools_frontend_linux_blink_light_rel bot. https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1916899 Bug: chromium:1018204 Change-Id: I42bde537652bdf445d74788fb5e6764cabe5d960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916466 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#715663}
-
Rasmus Brandt authored
Bug: 1025166 Change-Id: I482cedef1cb489384e896e5d8ff8b70f0ecd496e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913409Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Rasmus Brandt <brandtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#715662}
-
Dan Elphick authored
Instead of passing a using base::ThreadTaskRunnerHandle::Get(), which can fail if it's not set up yet, pass nullptr, which causes it to just run on a background thread. This is fine for the shared memory API as it is not tied to any particular Isolate. Additionally this moves registration into the V8SharedMemoryDumpProvider constructor which itself is created as a Singleton after the first V8 Isolate is created. This ensures that the shared memory is actually set up before the first dump is provided. Bug: v8:7464, 1023644 Change-Id: I18fde2c388c3b4c01191b00b4ec441d6964b473b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912205 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#715661}
-
Alex Ilin authored
This is a reland of 131762ce This also contains a fix for the bug causing shared memory creation failures on ARC++N and ARC++P devices. Original change's description: > ARC: upgrade protected buffers to new shared memory api > > This change wraps the FD-based protected buffers in a > base::subtle::PlatformSharedMemoryRegion rather than the legacy > SharedMemoryHandle. Aside from a couple of new validation checks, > functionality is unchanged. > > Bug: 849207 > > Change-Id: I2df619dc58c6313393e41eef7e4807edf340875e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697183 > Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> > Reviewed-by: Matthew Cary (CET) <mattcary@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686169} TBR: rsesek@chromium.org Bug: 849207 Change-Id: Ibd3ccc02edb21b54ec6eb701afaac0ab5783a138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916463 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#715660}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/36fbe6029343..4207870bcd60 git log 36fbe6029343..4207870bcd60 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 3da910d55f20..c3f22f7cba60 (2 commits) Created with: gclient setdep -r src/third_party/angle@4207870bcd60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:None Change-Id: Idbc8ce29a41683f6c339ef96ed10df3b2eb9e87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918973Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715659}
-
sandromaggi authored
This tests that adding a profile manually and listening to outside profile change works. Bug: b/143265578 Change-Id: I6e3aeb963eb5038b21db7aac0ff4dca6eff2eaff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917203 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#715658}
-
Chih-Yu Huang authored
Originally DmabufVideoFramePool allocates frames by VideoFrameLayout, which mainly contains VideoPixelFormat and frame size. VideoPixelFormat is a enum that lists well-known pixel formats. However, we might need buffers with proprietary format during hardware-accelerated video decoding. To support that, we should use fourcc, which could also list proprietary formats, to indicate pixel format. This CL changes DmabufVideoFramePool to allocate frames by Fourcc instead of VideoPixelFormat. Bug: 1004727 Test: Run video_decode_accelerator_tests on Kevin and Eve Test: media_unittests --gtest_filter=FourccTest.* Test: media_unittests --gtest_filter=PlatformVideoFramePoolTest.* Change-Id: Ibebea0a93589d26c8c892585789301ca11dfb5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895251 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#715657}
-
Alex Ilin authored
This CL removes deprecated RenderThread::HostAllocateSharedMemoryBuffer since it's no longer used. Bug: 795291 Change-Id: Ia0d4e3824d48a83ed2295351e62e4d518eb085af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916873Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715656}
-
Marc Treib authored
Still required, thus extended to M83: enable-sync-device-info-in-transport-mode enable-sync-uss-nigori enable-sync-uss-passwords Flags already removed, thus removing metadata entries: enable-sync-uss-bookmarks sync-support-secondary-account Bug: none Change-Id: I05426ec0909a3b24c856aa4ce79200f42123901c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917769 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#715655}
-