- 14 Jan, 2016 40 commits
-
-
ellyjones authored
Implement the modifications to the accessible name computation algorithm described by the SVG AAM, and change the default role of SVG roots from "unknown" to "group". TEST=layout BUG=566252 Review URL: https://codereview.chromium.org/1525793002 Cr-Commit-Position: refs/heads/master@{#369410}
-
sebsg authored
The type HTML_TYPE_UNKNOWN was changed to HTML_TYPE_UNSPECIFIED to avoid confusion with the new type HTML_TYPE_UNRECOGNIZED. BUG=576853 Review URL: https://codereview.chromium.org/1583563003 Cr-Commit-Position: refs/heads/master@{#369409}
-
sadrul authored
BUG=none Review URL: https://codereview.chromium.org/1585723002 Cr-Commit-Position: refs/heads/master@{#369408}
-
grt authored
BUG=504370 Review URL: https://codereview.chromium.org/1546673002 Cr-Commit-Position: refs/heads/master@{#369407}
-
wnwen authored
BUG=392656 Review URL: https://codereview.chromium.org/1583593002 Cr-Commit-Position: refs/heads/master@{#369406}
-
charliea authored
This meant that only 20 retries were allowed total, instead of 20 retries being allowed for each read. TBR=nednguyen@google.com BUG=542837 Review URL: https://codereview.chromium.org/1589583002 Cr-Commit-Position: refs/heads/master@{#369405}
-
dyen authored
Reland of Added unit test for stack traces in telemetry crashes. (patchset #1 id:1 of https://codereview.chromium.org/1580313002/ ) Reason for revert: Try again disabling 10.6 Original issue's description: > Revert of Added unit test for stack traces in telemetry crashes. (patchset #17 id:320001 of https://codereview.chromium.org/1498633003/ ) > > Reason for revert: > Test fails on some bots. > > Original issue's description: > > Added unit test for stack traces in telemetry crashes. > > > > This CL also fixes an issue on Mac where telemetry does not > > know how to locate chromium_framework for the symbols. > > > > R=nednguyen@google.com > > BUG=563716 > > TEST=ran unit test locally > > > > Committed: https://crrev.com/a20e03ee6906c50bdfaf8fb34fe684b4a89db852 > > Cr-Commit-Position: refs/heads/master@{#368997} > > TBR=nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=563716 > > Committed: https://crrev.com/f0cb0bf2dd7f677423318d2318902311e635538d > Cr-Commit-Position: refs/heads/master@{#369056} R=nednguyen@google.com BUG=563716 Review URL: https://codereview.chromium.org/1581143002 Cr-Commit-Position: refs/heads/master@{#369404}
-
tfarina authored
This seems to be a more appropriate place for this function, than the generic net_util.h header file, which will soon be gone. BUG=488531 TEST=net_unittests R=eroman@chromium.org Review URL: https://codereview.chromium.org/1582083002 Cr-Commit-Position: refs/heads/master@{#369403}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/05c6728a..2bf1fb9f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1585113002 Cr-Commit-Position: refs/heads/master@{#369402}
-
primiano authored
crrev.com/1421053002 introduced a TraceLog::AddMetadataEvent method. This method has a little race, unveiled by crbug.com/559117. The race happens only when a ConvertableToTraceFormat is passed to AddMetadataEvent. Explanation of the race: - AddMetadataEvent takes optional ConvertableToTraceFormat args. - ConvertableToTraceFormat is RefCounted but not RCThreadSafe. - AddMetadataEvent acquires the global TraceLog lock_ (which is good) but does that only after having initialized the trace_event. - CTTF args are copied into the TraceEvent outside of the TraceLog lock. The underlying CTTF AddRef/Deref happen outside the lock. - Later, when we get to AddMetadataEventsWhileLocked we try to re-AddRef the CTTF args. At this point TSAN barks because the CTTF refcount is written both ouside and inside the lock. The fix is trivial, just anticipate the lock of AddMetadataEvent by one statement. BUG=559117 TBR=oysteine@chromium.org Review URL: https://codereview.chromium.org/1588563004 Cr-Commit-Position: refs/heads/master@{#369401}
-
vasilii authored
Revert of RenderWidgetCompositor should be decoupled from RenderWidget. (patchset #7 id:120001 of https://codereview.chromium.org/1587743002/ ) Reason for revert: Broke browser_tests on Mac10.6 Tests https://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.6%20Tests&number=10945 [ RUN ] PlatformAppBrowserTest.AppWindowRestoreState [40491:263:0114/023453:ERROR:display_scheduler.cc(158)] Not implemented reached in virtual void cc::DisplayScheduler::OnBeginFrameSourcePausedChanged(bool) [40491:26115:0114/023453:WARNING:message_in_transit_queue.cc(17)] Destroying nonempty message queue [40498:263:0114/023453:FATAL:render_widget_compositor.cc(933)] Failed to create a fallback OutputSurface. 0 Chromium Framework 0x0000000101587c13 _ZN4base5debug10StackTraceC1Ev + 19 1 Chromium Framework 0x000000010159ff19 _ZN7logging10LogMessageD2Ev + 73 2 Chromium Framework 0x00000001053393ee _ZN7content22RenderWidgetCompositor32DidFailToInitializeOutputSurfaceEv + 110 3 Chromium Framework 0x00000001053392ab _ZN7content22RenderWidgetCompositor23RequestNewOutputSurfaceEv + 107 4 Chromium Framework 0x000000010158812a _ZN4base5debug13TaskAnnotator7RunTaskEPKcRKNS_11PendingTaskE + 202 5 Chromium Framework 0x00000001052d6600 _ZN9scheduler16TaskQueueManager24ProcessTaskFromWorkQueueEPNS_8internal9WorkQueueEPNS1_13TaskQueueImpl4TaskE + 688 6 Chromium Framework 0x00000001052d542e _ZN9scheduler16TaskQueueManager6DoWorkEN4base9TimeTicksEb + 286 7 Chromium Framework 0x000000010158812a _ZN4base5debug13TaskAnnotator7RunTaskEPKcRKNS_11PendingTaskE + 202 8 Chromium Framework 0x00000001015aac29 _ZN4base11MessageLoop7RunTaskERKNS_11PendingTaskE + 489 9 Chromium Framework 0x00000001015ab168 _ZN4base11MessageLoop6DoWorkEv + 632 10 Chromium Framework 0x000000010157d041 _ZN4base24MessagePumpCFRunLoopBase7RunWorkEv + 49 11 Chromium Framework 0x00000001015a102a _ZN4base3mac15CallWithEHFrameEU13block_pointerFvvE + 10 12 Chromium Framework 0x000000010157ca44 _ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv + 68 13 CoreFoundation 0x00007fff83c433d1 __CFRunLoopDoSources0 + 1361 14 CoreFoundation 0x00007fff83c415c9 __CFRunLoopRun + 873 15 CoreFoundation 0x00007fff83c40d8f CFRunLoopRunSpecific + 575 16 Foundation 0x00007fff86fbdb74 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 270 17 Chromium Framework 0x000000010157d6fe _ZN4base20MessagePumpNSRunLoop5DoRunEPNS_11MessagePump8DelegateE + 126 18 Chromium Framework 0x000000010157ce94 _ZN4base24MessagePumpCFRunLoopBase3RunEPNS_11MessagePump8DelegateE + 100 19 Chromium Framework 0x00000001015bd553 _ZN4base7RunLoop3RunEv + 99 20 Chromium Framework 0x00000001015aa3cd _ZN4base11MessageLoop3RunEv + 29 21 Chromium Framework 0x00000001053bc287 _ZN7content12RendererMainERKNS_18MainFunctionParamsE + 1175 22 Chromium Framework 0x000000010153d26c _ZN7content21ContentMainRunnerImpl3RunEv + 92 23 Chromium Framework 0x000000010153c736 _ZN7content11ContentMainERKNS_17ContentMainParamsE + 54 24 Chromium Framework 0x0000000101003192 ChromeMain + 66 25 Chromium Helper 0x000000019ede9d62 main + 530 26 Chromium Helper 0x000000019ede9b44 start + 52 27 ??? 0x0000000000000017 0x0 + 23 BrowserTestBase signal handler received SIGTERM. Backtrace: 0 browser_tests 0x0000000118bff553 _ZN4base5debug10StackTraceC1Ev + 19 1 browser_tests 0x000000011d087271 _ZN7content12_GLOBAL__N_1L27DumpStackTraceSignalHandlerEi + 65 2 libSystem.B.dylib 0x00007fff8a4291ba _sigtramp + 26 3 ??? 0x00007fff5fbfc208 0x0 + 140734799790600 4 CoreFoundation 0x00007fff83c41902 __CFRunLoopRun + 1698 5 CoreFoundation 0x00007fff83c40d8f CFRunLoopRunSpecific + 575 6 HIToolbox 0x00007fff815e57ee RunCurrentEventLoopInMode + 333 7 HIToolbox 0x00007fff815e55f3 ReceiveNextEventCommon + 310 8 HIToolbox 0x00007fff815e54ac BlockUntilNextEventMatchingListInMode + 59 9 AppKit 0x00007fff899d5eb2 _DPSNextEvent + 708 10 AppKit 0x00007fff899d5801 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 155 11 AppKit 0x00007fff8999b68f -[NSApplication run] + 395 12 browser_tests 0x0000000118bf528f _ZN4base24MessagePumpNSApplication5DoRunEPNS_11MessagePump8DelegateE + 351 13 browser_tests 0x0000000118bf4844 _ZN4base24MessagePumpCFRunLoopBase3RunEPNS_11MessagePump8DelegateE + 100 14 browser_tests 0x0000000118c33b03 _ZN4base7RunLoop3RunEv + 99 15 browser_tests 0x000000011d0d474f _ZN7content14RunThisRunLoopEPN4base7RunLoopE + 79 16 browser_tests 0x000000011d1d86aa _ZN10extensions13ResultCatcher13GetNextResultEv + 90 17 browser_tests 0x000000011858ccaa _ZN16ExtensionApiTest20RunExtensionTestImplERKNSt3__112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEES8_PKci + 682 18 browser_tests 0x000000011858cf8e _ZN16ExtensionApiTest18RunPlatformAppTestERKNSt3__112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEE + 46 19 browser_tests 0x0000000117b5f430 _ZN10extensions49PlatformAppBrowserTest_AppWindowRestoreState_Test19RunTestOnMainThreadEv + 64 20 browser_tests 0x0000000118bed328 _ZN20InProcessBrowserTest23RunTestOnMainThreadLoopEv + 232 21 browser_tests 0x000000011d087034 _ZN7content15BrowserTestBase28ProxyRunTestOnMainThreadLoopEv + 244 22 browser_tests 0x0000000118759233 _ZN22ChromeBrowserMainParts25PreMainMessageLoopRunImplEv + 4067 23 browser_tests 0x000000011875812a _ZN22ChromeBrowserMainParts21PreMainMessageLoopRunEv + 122 24 browser_tests 0x000000011bd1202a _ZN7content15BrowserMainLoop21PreMainMessageLoopRunEv + 138 25 browser_tests 0x000000011bfbfc77 _ZN7content17StartupTaskRunner14RunAllTasksNowEv + 39 26 browser_tests 0x000000011bd106bf _ZN7content15BrowserMainLoop18CreateStartupTasksEv + 671 27 browser_tests 0x000000011bd146d0 _ZN7content21BrowserMainRunnerImpl10InitializeERKNS_18MainFunctionParamsE + 544 28 browser_tests 0x000000011bd0dfc5 _ZN7content11BrowserMainERKNS_18MainFunctionParamsE + 149 29 browser_tests 0x000000011d085ccc _ZN7content21ContentMainRunnerImpl3RunEv + 92 30 browser_tests 0x000000011d085196 _ZN7content11ContentMainERKNS_17ContentMainParamsE + 54 31 browser_tests 0x000000011d086d95 _ZN7content15BrowserTestBase5SetUpEv + 869 32 browser_tests 0x0000000118bec74e _ZN20InProcessBrowserTest5SetUpEv + 222 33 browser_tests 0x000000011908206b _ZN7testing4Test3RunEv + 299 34 browser_tests 0x0000000119082cba _ZN7testing8TestInfo3RunEv + 410 35 browser_tests 0x0000000119083283 _ZN7testing8TestCase3RunEv + 451 36 browser_tests 0x0000000119089949 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 825 37 browser_tests 0x00000001190895dd _ZN7testing8UnitTest3RunEv + 269 38 browser_tests 0x0000000118c94149 _ZN4base9TestSuite3RunEv + 217 39 browser_tests 0x000000011859342f _ZN28ChromeBrowserTestSuiteRunner12RunTestSuiteEiPPc + 31 40 browser_tests 0x000000011d0d1d51 _ZN7content11LaunchTestsEPNS_20TestLauncherDelegateEiiPPc + 321 41 browser_tests 0x0000000118bd2846 _Z17LaunchChromeTestsiP21ChromeTestSuiteRunneriPPc + 70 42 browser_tests 0x0000000118593401 main + 65 43 browser_tests 0x0000000117a9d734 start + 52 44 ??? 0x0000000000000008 0x0 + 8 [27/437] PlatformAppBrowserTest.AppWindowRestoreState (TIMED OUT) Original issue's description: > RenderWidgetCompositor should be decoupled from RenderWidget. > > This is a mechanical refactor of RenderWidgetCompositor and > RenderWidget. At this point it removes references for > routing ID, and RenderWidget from RenderWidgetCompositor's > implementation. This is likely not the final refactor as I > am still in the process of detangling WebWidgetClient's > implementation from RenderWidget. Once that happens, I > might have some simplifications. > > BUG=577321 > > Committed: https://crrev.com/40b2fccfc256dccfdda03cc99e5b1d5b75d24751 > Cr-Commit-Position: refs/heads/master@{#369383} TBR=piman@chromium.org,danakj@chromium.org,chrishtr@chromium.org,fsamuel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=577321 Review URL: https://codereview.chromium.org/1586523004 Cr-Commit-Position: refs/heads/master@{#369400}
-
sadrul authored
BUG=none Review URL: https://codereview.chromium.org/1582613006 Cr-Commit-Position: refs/heads/master@{#369399}
-
skyostil authored
Turn expensive task blocking into a feature (finch trial) which is disabled by default. BUG=574343 Review URL: https://codereview.chromium.org/1587663003 Cr-Commit-Position: refs/heads/master@{#369398}
-
perezju authored
BUG=286315 TBR=boliu@chromium.org,qinmin@chromium.org,dfalcantara@chromium.org Review URL: https://codereview.chromium.org/1578313006 Cr-Commit-Position: refs/heads/master@{#369397}
-
andrewhayden authored
When the translate client was refactored to be managed by the translate driver and to use a RenderFrameHost instead of a RenderViewHost, it accidentally broke non-static CLD initialization because the IPC messages being received by the translate driver were not being passed into the CLD data provider. This change moves the relevant code from the translate client into the translate driver and restores functionality. BUG=571016 TBR=droger@chromium.org Review URL: https://codereview.chromium.org/1543533002 Cr-Commit-Position: refs/heads/master@{#369396}
-
dvadym authored
BUG=359315 Review URL: https://codereview.chromium.org/1586613003 Cr-Commit-Position: refs/heads/master@{#369395}
-
ruuda authored
BUG=577575 TBR=digit@chromium.org Review URL: https://codereview.chromium.org/1586033002 Cr-Commit-Position: refs/heads/master@{#369394}
-
fukino authored
To re-render the track-list element, the metadata change needs to be notified to the track-list element explicitly. BUG=575151 TEST=manual test Review URL: https://codereview.chromium.org/1581573004 Cr-Commit-Position: refs/heads/master@{#369393}
-
charliea authored
Here's the offending CL: http://crrev.com/1577343004 Moving the control types caused the "reset" command to move to 0x01. That means that it now needs escaping in messages, but I forgot to update the unit tests to reflect this. Thinking this was a trivial change, I also didn't run the unit tests before submitting. Lesson learned. BUG=542837 Review URL: https://codereview.chromium.org/1582983002 Cr-Commit-Position: refs/heads/master@{#369392}
-
fs authored
Don't move the 'out' variable |cursor| until a valid number has been parsed (disregarding the leading whitespace). This will allow generating better error messages in some cases (the cursor will not "stop" randomly within the number upon encountering overflows etc.). It also enables "re-parsing" although currently no call-sites require that. Code size virtually unaffected (-7 for LChar, +2 for UChar.) BUG=231612 Review URL: https://codereview.chromium.org/1588453006 Cr-Commit-Position: refs/heads/master@{#369391}
-
mvanouwerkerk authored
* This shrinks the settings button to its contents so there is also no blank space to tap that button * Screenshots: http://imgur.com/a/zrPta BUG=577161 Review URL: https://codereview.chromium.org/1580283004 Cr-Commit-Position: refs/heads/master@{#369390}
-
amistry authored
These are: 1. Change RemoveInvalidHandle to SignalHandleError to mirror SignalHandleReady. 2. Use SignalHandleError wherever handler->OnHandleError is called. Review URL: https://codereview.chromium.org/1573383002 Cr-Commit-Position: refs/heads/master@{#369389}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4b380419..05c6728a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1582843004 Cr-Commit-Position: refs/heads/master@{#369388}
-
nhiroki authored
Before this patch, there is no way to gracefully cancel the start sequence when the worker is requested to stop. Therefore, both start and stop sequences can be interleaved. To be more specific, process allocation information can be left in ServiceWorkerProcessManager even after the start sequence is canceled, and the process manager sometimes behaves strangely when attempting to restart the worker. This patch provides a way to cancel the start sequence. <Details of this patch> Roughly speaking, the start sequence consists of two phases: (1) process allocation involving thread hops, and (2) IPC messaging between the browser process and a worker process. We need to make it cancelable in either phase. To achieve that, this patch introduces... * StartTask that is a cancelable task to allocate a worker process and to send a start worker message. * WorkerProcessHandle that is a handle for a worker process managed by ServiceWorkerProcessManager. Its dtor makes sure to release a process. The handle is created by StartTask when a process is allocated, and then passed to EmbeddedWorkerInstance. When the start sequence is aborted during the phase (1), StartTask releases a process on its dtor. When the start sequence is aborted during the phase (2), EmbeddedWorkerInstance releases the process by destroying the process handle. BUG=568915,568465 Review URL: https://codereview.chromium.org/1569773002 Cr-Commit-Position: refs/heads/master@{#369387}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/701b2443d668..1200798cc253 $ git log 701b2443d..1200798cc --date=short --no-merges --format='%ad %ae %s' CQ_INCLUDE_TRYBOTS= TBR=catapult-sheriff@chromium.org Review URL: https://codereview.chromium.org/1582263002 Cr-Commit-Position: refs/heads/master@{#369386}
-
hashimoto authored
To handle incoming transactions: Add CommandStream::IncomingCommandHandler::OnTransaction. Add CommandBroker::OnTransaction. To implement test: Add CommandBroker::EnterLooper, ExitLooper, PollCommands. Add Thread. Add TestService. Add BinderEndToEndTest. BUG=563282 Review URL: https://codereview.chromium.org/1575313002 Cr-Commit-Position: refs/heads/master@{#369385}
-
treib authored
If we're showing offline-available indications, then "file://" links should be treated as available BUG=565219 Review URL: https://codereview.chromium.org/1579153002 Cr-Commit-Position: refs/heads/master@{#369384}
-
fsamuel authored
This is a mechanical refactor of RenderWidgetCompositor and RenderWidget. At this point it removes references for routing ID, and RenderWidget from RenderWidgetCompositor's implementation. This is likely not the final refactor as I am still in the process of detangling WebWidgetClient's implementation from RenderWidget. Once that happens, I might have some simplifications. BUG=577321 Review URL: https://codereview.chromium.org/1587743002 Cr-Commit-Position: refs/heads/master@{#369383}
-
vasilii authored
Revert of NaCl: Update revision in DEPS, 26c7e6a -> c4c237c (patchset #1 id:1 of https://codereview.chromium.org/1580293003/ ) Reason for revert: Broke nacl_integration on Mac10.6 Tests. https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/10932 dyld: Library not loaded: /usr/lib/libc++.1.dylib Referenced from: /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang Reason: image not found /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang -m64 -std=gnu99 -O2 -g -fomit-frame-pointer -fasynchronous-unwind-tables -Wall -Wundef -fdiagnostics-show-option -Werror -Wno-variadic-macros -Wno-language-extension-token -integrated-as -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86 -DNACL_BUILD_SUBARCH=64 -Iscons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi/native_client/scons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi -c -o scons-out/nacl-x86-64/obj/src/untrusted/nacl/stubs/socket.o src/untrusted/nacl/stubs/socket.c scons: *** [scons-out/nacl-x86-64/obj/src/untrusted/nacl/sigprocmask.o] Error -5 ... scons-out/nacl-x86-64/obj/src/untrusted/nacl/sigprocmask.o failed: Error -5 And many similar messages Original issue's description: > NaCl: Update revision in DEPS, 26c7e6a -> c4c237c > > This pulls in the following Native Client changes: > > 95163bf: (stichnot@chromium.org) Update revision for PNaCl > abee7c9: (petarj@mips.com) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS > b44e8dc: (petarj@mips.com) [MIPS] Make $t8 point to the address of TLS pointers > 11ff949: (thakis@chromium.org) clang/win: Fix -Wsign-compare warning in platform_impl.cc > f39aa44: (mseaborn@chromium.org) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS: add ConvertToPSO > aebc3c4: (mcgrathr@chromium.org) Update chrome_rev > c4c237c: (erikchen@chromium.org) Back dynamic text regions with a Mach memory region. > > Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/26c7e6ae1327a43c948f4666fef9e84fe351ab7c..c4c237c0567cbe1c7de664a4d81673c3403cf55b > > BUG=none > TEST=browser_tests and nacl_integration > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build > > Committed: https://crrev.com/97c9eecf2e7a5857d6dc6ddb22eb27251f9eefc4 > Cr-Commit-Position: refs/heads/master@{#369294} TBR=mcgrathr@chromium.org,mseaborn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/1586683003 Cr-Commit-Position: refs/heads/master@{#369382}
-
dgn authored
When the local player thinks it's currently seeking, it skips some tasks, including updating the progress bar. See the linked bug. This change forces notifying the local player that seek is completed when starting cast. BUG=568161 Review URL: https://codereview.chromium.org/1580733002 Cr-Commit-Position: refs/heads/master@{#369381}
-
davve authored
BUG=415074 Review URL: https://codereview.chromium.org/1586623002 Cr-Commit-Position: refs/heads/master@{#369380}
-
rob authored
Connecting to the same frame does not make sense because onMessage should not be triggered for the same frame. BUG=479425,575234 Review URL: https://codereview.chromium.org/1588533002 Cr-Commit-Position: refs/heads/master@{#369379}
-
stip authored
BUG=525873 R=jbudorick@chromium.org,maruel@chromium.org,miguelg@chromium.org TBR=miguelg@chromium.org Review URL: https://codereview.chromium.org/1585573002 Cr-Commit-Position: refs/heads/master@{#369378}
-
bauerb authored
BUG=483615 Review URL: https://codereview.chromium.org/1585643002 Cr-Commit-Position: refs/heads/master@{#369377}
-
oshima authored
This also remove WebView::deviceScaleFactor() and moved to RenderView because it's no longer necessary in Blink. BUG=485650 Review URL: https://codereview.chromium.org/1572703002 Cr-Commit-Position: refs/heads/master@{#369376}
-
szager authored
BUG=577478,576797,577028 R=haraken@chromium.org,dcheng@chromium.org Review URL: https://codereview.chromium.org/1583173002 Cr-Commit-Position: refs/heads/master@{#369375}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cb9210d4..4b380419 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1587003002 Cr-Commit-Position: refs/heads/master@{#369374}
-
alshabalin authored
BUG=419656 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/1578363004 Cr-Commit-Position: refs/heads/master@{#369373}
-
dongseong.hwang authored
The test crashes on ozone GBM, because GBM doesn't support software rendering mode. This CL makes the test gracefully done, instead of crash. [ RUN ] SoftwareOutputDeviceOzoneTest.CheckCorrectResizeBehavior [9442:9442:0111/131957:8760142320:FATAL:gbm_surface_factory.cc(88)] Software rendering mode is not supported with GBM platform TEST=content_unittests --gtest_filter=SoftwareOutputDeviceOzoneTest* --ozone-platform=gbm --ozone-use-surfaceless --single-process-tests Review URL: https://codereview.chromium.org/1575943002 Cr-Commit-Position: refs/heads/master@{#369372}
-
horo authored
BUG=540493 Review URL: https://codereview.chromium.org/1571633002 Cr-Commit-Position: refs/heads/master@{#369371}
-