- 28 Sep, 2018 20 commits
-
-
Christopher Cameron authored
This was accidentally dropped from crrev.com/594134 Bug: 859152 Change-Id: I159af36686ce07300969f2eaf79796be85f012e5 Reviewed-on: https://chromium-review.googlesource.com/1244886 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#594941}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I6aef4b11f6610e2edff6e4e9a685a360ba3e314e Reviewed-on: https://chromium-review.googlesource.com/1250110Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594940}
-
Dan Sanders authored
If a GPU channel cannot be established, a WebMediaPlayerImpl can be constructed without a |context_provider_|. Handle that case correctly in CopyVideoTextureToPlatformTexture(). Bug: 819914 Change-Id: I620b602ee0c092cc31273b4f513133bf8af7e1d0 Reviewed-on: https://chromium-review.googlesource.com/1250137 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#594939}
-
Anand K. Mistry authored
BUG=889703 Change-Id: I901c546c8329ea7082e11eaaae0bced60f376bf4 Reviewed-on: https://chromium-review.googlesource.com/1242763 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594938}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0e1056a6c8e..de84e41c85f9 Created with: gclient setdep -r src-internal@de84e41c85f9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4bf04887e364c799a01818399939c4e27f7ff5a2 Reviewed-on: https://chromium-review.googlesource.com/1250107Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594937}
-
Wenzhao (Colin) Zang authored
This reverts commit 35b382aa. Reason for revert: crbug.com/890100 Original change's description: > [css-flexbox] Apply min-height: auto to nested flexboxes again > > To avoid the previous regression (see analysis in bug), we force > layout in the case where we otherwise would get an outdated result. > > Bug: 596743 > Change-Id: I9cf47675f7fcd88f94b2fe76b46bceae17e36756 > Reviewed-on: https://chromium-review.googlesource.com/1246730 > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594752} TBR=cbiesinger@chromium.org,eae@chromium.org,mstensho@chromium.org Change-Id: I8ef1e6a3e5f191c495c0b36d32366de3f0323a39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 596743 Reviewed-on: https://chromium-review.googlesource.com/1250207Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594936}
-
Sergei Datsenko authored
Cloud queries are being retried indefinetely in drivefs backend when offline, which is a separate bug, but at least we shouldn't even try if we know that it won't work. BUG=chromium:854481 Change-Id: I5b1f182bf532864d01fc2c47740e72af0feddad4 Reviewed-on: https://chromium-review.googlesource.com/1249425Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#594935}
-
Lambros Lambrou authored
This adds the VP8/9 frame quantizer to the stats for each frame. This will enable the website to show a graph of these values over time. This also adds new FrameStats unittests, and fixes a capturer_id initialization bug discovered by the unittest. Bug: 888833 Change-Id: I2c48f9c024a0e64a6a5756a3371717d3491a8474 Reviewed-on: https://chromium-review.googlesource.com/1242398 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#594934}
-
Karan Bhatia authored
Declarative Net Request API requires extensions to have access to both the request url and initiator to block/redirect a request. Currently any requests with an opaque origin as the initiator can't be intercepted by extensions. Correct this. BUG=889713 Change-Id: Ie86bf745da652d6f076e9d3076e06ec0c202f4d1 Reviewed-on: https://chromium-review.googlesource.com/1248541 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#594933}
-
Katie D authored
This will make Select-to-Speak appear more reactive when the page updates during speech. Bug: 830887 Change-Id: Iffd09d486686fa39d34f9188a6238719e71e92c7 Reviewed-on: https://chromium-review.googlesource.com/1248134Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#594932}
-
Tim Haloun authored
Add QWAVE/DSCP support for unconnected sockets. Create a helper class for maintaining remote addresses that have been configured for dscp. Adapted from cl 682456. Bug: webrtc:5836 Change-Id: I2ded915e82a7e967962ff3b1f4027b422d055157 Reviewed-on: https://chromium-review.googlesource.com/1191925 Commit-Queue: Tim Haloun <thaloun@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#594931}
-
Carlos IL authored
Change-Id: I01bd0c17fffd5160ab0c6d82201cf43221821744 Reviewed-on: https://chromium-review.googlesource.com/1250099 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594930}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8e0212945b13..920acc565706 git log 8e0212945b13..920acc565706 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 mattm@chromium.org netlog_viewer: Apply chromium changes up to 6d4874c7 Created with: gclient setdep -r src/third_party/catapult@920acc565706 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I236df94bd38152f14b03350f6f03552903da6844 Reviewed-on: https://chromium-review.googlesource.com/1250105Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/377b26ec65be..b5c6dd434907 git log 377b26ec65be..b5c6dd434907 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 buildbot@webrtc.org Roll chromium_revision f87ef787..2985a247 (594716:594820) Created with: gclient setdep -r src/third_party/webrtc@b5c6dd434907 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I27730f1fe896c5df01bcb50a704ff2001229043f Reviewed-on: https://chromium-review.googlesource.com/1250104Reviewed-by:
-
Jonathan Metzman authored
/OPT:REF is currently stripping the constructors needed by sancov clients (such as libFuzzer). Disable it for fuzzing builds until this issue is resolved on the Clang/libFuzzer side. Bug: 884545 Change-Id: I9c12295020e6a2efc2ade268b25a555975e71c85 Reviewed-on: https://chromium-review.googlesource.com/1249151 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594927}
-
Kyle Horimoto authored
This CL adds a page for the MultiDevice setup flow to OOBE when associated flags are enabled. Currently, page is a placeholder with no content except for two buttons which move the user to the next page in the OOBE/login flow. A follow-up CL will integrate the actual page logic into OOBE. Bug: 884061 Change-Id: Ie3bafefc736c25484e9b421648a090e9c1aa6906 Reviewed-on: https://chromium-review.googlesource.com/1223028 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#594926}
-
Stephen Martinis authored
Use swarming mixins for webrtc experimental bots. Bug: 880973 Change-Id: I51e386a78f8616a94c9c8a0d67de5bdf096dfe2b Reviewed-on: https://chromium-review.googlesource.com/1246946 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#594925}
-
Owen Min authored
Five extnesions are whitelisted for enterprise.rerpotingPrivate permission. Bug: 882461 Change-Id: Ic81d5dbdd45110225ebcbe2fcfac5e8827a58fc5 Reviewed-on: https://chromium-review.googlesource.com/1216843Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594924}
-
Kyle Horimoto authored
The tag had already been closed, so the extra tag was unneeded. Change-Id: Ia933f018873167fa201c2d4fc3a1d2b4a0d39053 Reviewed-on: https://chromium-review.googlesource.com/1250056Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#594923}
-
Anand K. Mistry authored
BUG=889703 Change-Id: I3280a573a6d13c9dc386758b1c177e07bec84e7c Reviewed-on: https://chromium-review.googlesource.com/1247603 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
-
- 27 Sep, 2018 20 commits
-
-
Shakti Sahu authored
This is a reland of e6f5eba3 Addresses a case of null handling and an incorrect check. Original change's description: > Download Shelf : Connect OfflineItem to the shelf > > This CL connects offline item with the download shelf. Some of > the OfflineItemModel methods are still not implemented. > > Bug: 881499 > Change-Id: I2f0cd71815a08bcddfca753378543749389d78db > Reviewed-on: https://chromium-review.googlesource.com/1239875 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594471} TBR=carlosk@chromium.org Bug: 881499 Change-Id: I313f0b34e95c4761fe54d5aa4296fd60643ab888 Reviewed-on: https://chromium-review.googlesource.com/1250100 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594921}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ad0232dee5f5..6ff2f64702dc git log ad0232dee5f5..6ff2f64702dc --date=short --no-merges --format='%ad %ae %s' 2018-09-27 webmaster@khronos.org Update LICENSE Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@6ff2f64702dc The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I889399d2353f7face54ebb634845bdb87ad5d28d Reviewed-on: https://chromium-review.googlesource.com/1249516Reviewed-by:
-
Anand K. Mistry authored
The zip archiver component extension already handles lazy loading of the NaCl module, but it was also unnecessarily loading it on startup. BUG=889703 Change-Id: I7346a13d4a317cd62e6b7a0f3e41870b723be28e Reviewed-on: https://chromium-review.googlesource.com/1248343Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#594919}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1814174dbc2e..c0e1056a6c8e Created with: gclient setdep -r src-internal@c0e1056a6c8e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia00ea5654a91c7e5dee53583509bad22fdba581b Reviewed-on: https://chromium-review.googlesource.com/1249520Reviewed-by:
-
Joshua Peraza authored
This reverts commit dbca191e. Reason for revert: It broke the build. Original change's description: > Package Crashpad's handler into various APKs > > For Chromecast, Content Shell, and non-monochrome Clank/Webview: > > The Crashpad handler is a standalone executable, packaged like a > loadable module and named libcrashpad_handler.so in order to not be > ignored by Android's APK installer. > > For Monochrome: > > The Crashpad handler is linked into libmonochrome.so. At crash-time > /system/bin/app_process{32,64} is exec-ed, running CrashpadMain.java > which loads libmonochrome.so and runs the native HandlerMain(). > > This strategy is not used for non-monochrome APKs (i.e. pre-N) because > on L, Android's loader is not yet capable of loading native libraries > from the APK. This is normally performed by the Chromium linker which > can't be used by CrashpadMain.java because /system/bin/app_process > doesn't initialize the process like a normal Android application > (specifically, no ContextImpl has been created, so any calls to e.g. > appContext.getApplicationInfo() will segfault). > > Binary-Size: MonochromePublic.apk increases in size by 100 KB. > ChromeModernPublic.apk increases in size by 203KB (587 KB > increase in install size because libcrashpad_handler.so is extracted > from the APK). Possible mitigations for this increase are TODO: > > For J, K: We could link the handler directly into libchrome.so and let > that be our handler executable. This would de-dup portions of libbase > that are currently linked into both libchrome.so and > libcrashpad_handler.so. > > For L, M: It might be possible to get the chromium linker (or Bionic's > linker on M) to dlopen libchrome.so from the APK for a trampoline > libcrashpad_handler.so to de-dup libbase. > > Bug: crashpad:30 > Change-Id: If5b3752f26455e5c7aef3278b4bd2076ef1b7b65 > Reviewed-on: https://chromium-review.googlesource.com/1150774 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594853} TBR=boliu@chromium.org,torne@chromium.org,agrieve@chromium.org,halliwell@chromium.org,jperaza@chromium.org,mark@chromium.org Change-Id: I585aea87e7d52fa51097ae9b00a38eddf3a25679 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: crashpad:30 Reviewed-on: https://chromium-review.googlesource.com/1250134Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#594917}
-
edchin authored
The TabGridConsumer API makes no guarantee that an |-insertItem:| is called before a |-replaceItem:| is called. In cases where |-replaceItem:| is called with an unknown identifier, the consumer should ignore the call. When |-insertItem:| is called later, it is guaranteed to have the latest information. Bug: 889685 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I56cfde3d400b8d6f93296bd9a0e21060dc3e9aa7 Reviewed-on: https://chromium-review.googlesource.com/1247424 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#594916}
-
Xiaocheng Hu authored
The test was converted into testharness.js test in crrev.com/c/1246902, but its LayoutNG text dump expectation was left unremoved, causing failure. This CL removes it. Bug: 887148 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia2cef89f1097519991e1638b0972d3b930030b60 Reviewed-on: https://chromium-review.googlesource.com/1249517 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#594915}
-
Alex Moshchuk authored
ChildProcessSecurityPolicy::CanCommitURL() is a security check that's supposed to tell whether a given renderer process is allowed to commit a given URL. It is currently used to validate (1) blob and filesystem URL creation, and (2) Origin headers. Currently, it has scheme-based checks that disallow things like web renderers creating blob/filesystem URLs in chrome-extension: origins, but it cannot stop one web origin from creating those URLs for another origin. This CL locks down its use for (1) to also consult CanAccessDataForOrigin(). With site isolation, this will check origin locks and ensure that foo.com cannot create blob/filesystem URLs for other origins. For now, this CL does not provide the same enforcements for (2), Origin header validation, which has additional constraints that need to be solved first (see https://crbug.com/515309). Bug: 886976, 888001 Change-Id: I743ef05469e4000b2c0bee840022162600cc237f Reviewed-on: https://chromium-review.googlesource.com/1235343 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594914}
-
Vladimir Levin authored
R=zmo@chromium.org, kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I66f54c28838b8935e250c6c42d5dfaff74df960a Reviewed-on: https://chromium-review.googlesource.com/1250050Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594913}
-
erikchen authored
The test depends on ordering of IPCs across unassociated Mojo channels. This ordering is not deterministic. Bug: 889952 Change-Id: I23f9d69a5b2fc3e43eefe4241a151ccf1f20cfc1 Reviewed-on: https://chromium-review.googlesource.com/1250008Reviewed-by:
-
Nasko Oskov authored
This CL is part of adding precursor origin support to url::Origin which nick@ started in https://crrev.com/c/1028985. It changes the Mojo representation of url::Origin to use the nonce as an indicator for whether the origin is opaque or not instead of keeping a boolean. Bug: 882053 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: If260a09a66cf62b870f15d52f5aabc27a3f73823 Reviewed-on: https://chromium-review.googlesource.com/1227393 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#594911}
-
Sarah Hu authored
Currently button and eol states are pulled from C++ side. In some broken state, c++ does not provide any information and about page end up showing all 3 buttons and eol state at the same time. Bug: 883900 Change-Id: I70788e3c3634dd11586c515c89ef499409d155e5 Reviewed-on: https://chromium-review.googlesource.com/1247185 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594910}
-
Kyle Milka authored
Prevent two focus indicators on the back arrow by making the grey circle the tabbable element. Bug: 878341 Change-Id: Ib18aa4669d3f8ea39754bb2ecadafaf718fe3143 Reviewed-on: https://chromium-review.googlesource.com/1249834Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#594909}
-
Jun Choi authored
Replace the current string "To see your security key, it needs to be in pairing mode. Press the button on your key for at least 5 seconds." with the string "If your security key isn't listed, press the key's button for at least 5 seconds". Bug: 890004 Change-Id: Idef5ef4c390236079f261bc9bf23b9ebdca6d21e Reviewed-on: https://chromium-review.googlesource.com/1249490Reviewed-by:
-
Devlin Cronin authored
In practice, Extension objects are pretty much always const. Update the native bindings unit tests to use const Extension objects, rather than mutable ones. This makes the tests consistent (and removes the need for a "mutable_extension" hack), and gets these ready for ExtensionBuilder returning a const Extension. Bug: 889925 Change-Id: I44e1100515b055f5452f3ef90871a23d587b3f07 Reviewed-on: https://chromium-review.googlesource.com/1249528Reviewed-by:
-
David Benjamin authored
We're only shipping the final version in Chrome 70. The vast majority of incompatibilities will have been dealt with by then, but give some extra time for any non-compliance that only showed up then. Bug: none Change-Id: Icdfd6a4190813a77276b40c1b167d97e69532a6a Reviewed-on: https://chromium-review.googlesource.com/1244165 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#594906}
-
Wenzhao Zang authored
This is a workaround. The bug should keep open until a better solution is found. Verified on both eve (high PPI) and paine (low PPI). Also, "margin-bottom" is a no-op so it's removed. Bug: 889655 Change-Id: I424d1c15ba2ee15a62b098f5bffc28037707ef97 Reviewed-on: https://chromium-review.googlesource.com/1247193Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594905}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/beb0c946de6d..e8dd07969872 git log beb0c946de6d..e8dd07969872 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 jmadill@chromium.org Vulkan: Make vk::FramebufferHelper the graph resource. 2018-09-27 jmadill@chromium.org Vulkan: Make Buffer/Image be CommandGraphResources. 2018-09-27 jmadill@chromium.org Vulkan: Move LineLoopHelper graph work into BufferVk. Created with: gclient setdep -r src/third_party/angle@e8dd07969872 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Ic8baae6546c11c0bdcf3decb003fad8f6f9dee4e Reviewed-on: https://chromium-review.googlesource.com/1249515Reviewed-by:
-
Peter Kotwicz authored
This CL: - changes Context#startActivity() to use the app context. - sets the Intent.FLAG_ACTIVITY_NEW_TASK flag on the launch intent in order to address error when using app context Change-Id: Ie3091e9aafd50e95c1081376ac7ba4a51c1b1a7c Reviewed-on: https://chromium-review.googlesource.com/1244072 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594903}
-
kylechar authored
InProcessCommandBuffer is being used for the display compositor with OOP-D. Add trace events for key functions, similar to the existing traces in CommandBufferProxyImpl and [GLES2]CommandBufferStub, to help diagnose performance issues. Bug: 832243, 890013 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I34b962b48ad4eb10b112a9c979056993868637a4 Reviewed-on: https://chromium-review.googlesource.com/1250043 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#594902}
-
