- 07 Jul, 2020 40 commits
-
-
Reilly Grant authored
This change converts callback types in BluetoothTaskManagerWin from base::Callback to base::OnceCallback. There should be no behavioral change from this patch. Bug: 834319 Change-Id: Iaf22099ed65b64681c5787c074d22de9c6c043e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283951 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#785957}
-
Peng Huang authored
As my test, With AMD GPU, import semaphore to GL costs 60us. It is costy if we import several semaphores per frame. So Add several UMA for measuring semaphore related cost. Bug: None Change-Id: I6358c198201d9ac69be6ac955a19f705af2ca1b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281035 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#785956}
-
James Cook authored
The Lacros browser runs on Chrome OS, but reports a special OS name to differentiate itself from the built-in ash browser + window manager binary. See bug for link to discussion thread. Bug: 1096268 Test: added to components_unittests Change-Id: I37fd53c956b69c991732f58c69a20331addfcbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284228Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#785955}
-
Evan Stade authored
Cancel JS dialogs when a WebContents's delegate is set to null, as the dialog can't show without a WebContentsDelegate. Bug: 1060986 Change-Id: I5272faa23d5461fc8251887d9bc02f03c54e37e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283388Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#785954}
-
Wenyu Fu authored
This reverts commit c41c5c46. Reason for revert: Changed to a different implementation, and fix the flaky test failed on M+ bots. Original change's description: > Revert "[HomepagePromo] Add finch param supressing_sign_in_promo" > > This reverts commit 25269f24. > > Reason for revert: test testSetUp_SuppressingSignInPromo fails constantly in android-arm64-proguard-rel (and fyi builder android-marshmallow-x86-fyi-rel) since > * https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2020 > * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-fyi-rel/767 > > Original change's description: > > [HomepagePromo] Add finch param supressing_sign_in_promo > > > > Adding the option for homepage promo to suppress the sign in promo when > > user is not signed in. > > > > Bug: 1068831 > > Change-Id: I854109c4623c47f98aab1faa34f94f2d55961474 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252379 > > Commit-Queue: Wenyu Fu <wenyufu@chromium.org> > > Reviewed-by: Theresa <twellington@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#781109} > > TBR=twellington@chromium.org,wenyufu@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1068831 > Change-Id: I97f226e93962469cc8a705e922a3db72d7e84cd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265398 > Reviewed-by: Haiyang Pan <hypan@google.com> > Reviewed-by: Wenyu Fu <wenyufu@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#782189} TBR=twellington@chromium.org,hypan@google.com,wenyufu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1068831 Change-Id: Id652d450f84f44f4d15b2409c61c3cf84fa7c48e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269484 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#785953}
-
Jan Wilken Dörrie authored
This change adds a focusConfig for the Password Check button to passwords_section.js, allowing for the proper highlighting when navigating from chrome://settings/passwords/check to chrome://settings/passwords. Since the Password Check button is not an immediate child of the parent autofill page, but rather embedded within the passwords section, a single query selector string is not sufficient, and executing our own handler is required. Fixed: 1101298 Change-Id: I76a23778461880e38f23a25f2b9f4d2ca5328dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275455 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#785952}
-
Rohit Rao authored
BUG=None Change-Id: I13c7aeee67a7e72b665f23a4b1c4b942452db9b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284058 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#785951}
-
Philip Rogers authored
Change-Id: I379af4d45d9815de894670e4d602263a48f21d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284054 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#785950}
-
Kevin Babbitt authored
The caret-color property was using a one-off StyleAutoColor class which stores similar information to StyleColor with an extra affordance for the |auto| keyword. This CL makes StyleAutoColor a lightweight derived class of StyleColor to allow caret-color to store system color keywords more cleanly. Bug: 1081945 Change-Id: I8f3097471950d96999437f7d6b82ab1b56acc7c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274588 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#785949}
-
Zentaro Kavanagh authored
- Use push_back instead of emplace_back where appropriate - See abseil.io/tips/112 Bug: None Test: manual Change-Id: I10538be7fd33b4a66da7409f54ac526b18ee6479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283765 Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#785948}
-
Xiaoqian Dai authored
The changes in this CL: - Remove kRed from base layer. - Add Alert, Warning, Positive to control layer, text and icons content layer. - Rename kButtonIconColorProminent to kIconColorProminent to detach it from the button usage only. - Add kButtonLabelPrimary in content layer. Bug: 972162 Change-Id: I9e185186fda651bc022e4cadf457032df59cdb01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284216 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#785947}
-
Anastasia Helfinstein authored
If the user navigates to a modal or system menu (other than by focus automatically jumping there), we should still use the custom behavior for modals. AX-Relnotes: n/a. Bug: None. Change-Id: Ie0b963f1540568cdd8f249ee016e787de45c0b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270468 Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#785946}
-
Jonah Chin authored
When making a subset of an image, the original PaintImage's dimensions were set to those of the subset. This caused confusion when accessing the width() and height() PaintImage() APIs, as it was not always clear which dimensions were being returned. This change removes all uses of subrect in PaintImage and forwards the subrect size to where the actual draw calls are done. More details about overall PaintImage effort: crbug.com/1023259 Info about the OOPR-Canvas2D project: crbug.com/1018894 Bug: 1031050 Change-Id: Ia57aa5868f671676e3ecc17dd5f0278ec662c366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258574Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#785945}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib9415d1430f3894279eae8ea78b26d74ae238134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785944}
-
Daniel Nicoara authored
This will be used to turn off the display when the device is in idle state. Turning off the display has significant power savings. BUG=b/156411764 TEST=Manually verified that disabling the displays turns off the LCD. Change-Id: I70e9c0cf9db473e143c92a88b888de9a73b8bff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273478Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#785943}
-
Oriol Brufau authored
With this patch, legacy layout supports setting the 'content' property of a ::marker to something different than 'normal' or 'none'. Bug: 457718 TEST=external/wpt/css/css-pseudo/marker-computed-size.html TEST=external/wpt/css/css-pseudo/marker-content-002.html TEST=external/wpt/css/css-pseudo/marker-content-003.html TEST=external/wpt/css/css-pseudo/marker-content-003b.html TEST=external/wpt/css/css-pseudo/marker-content-004.html TEST=external/wpt/css/css-pseudo/marker-content-005.html TEST=external/wpt/css/css-pseudo/marker-content-006.html TEST=external/wpt/css/css-pseudo/marker-content-012.html TEST=external/wpt/css/css-pseudo/marker-content-015.html TEST=external/wpt/css/css-pseudo/marker-content-017.html TEST=external/wpt/css/css-pseudo/marker-content-021.html TEST=external/wpt/css/css-pseudo/marker-hit-testing.html TEST=external/wpt/css/css-pseudo/marker-intrinsic-contribution-001.html TEST=fast/css/counters/counterValueForElementById.html Change-Id: Ib4b9d5661ed2ae0b99e9489c5ce4595f5715f83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246573 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594123101-dfa27c4a1c98aa42fbcdd14d71d9320361fd45b4.profdata to chrome-mac-master-1594144798-4412d96600585fe82074f31d0a98a25618a2d017.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,jeffyoon@google.com Change-Id: I3aab5b25427c7023aaf0b6f1a7471f43c063f230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285304Reviewed-by:
-
Peter Kasting authored
Also replaces ButtonController::OnStateChanged() with a property change callback. This will allow removing ButtonObserver entirely in a future CL, and potentially all Button::StateChanged() overrides as well. Bug: none Change-Id: I143a6e7d0668d8bee7535f3d57bbf04430685428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284218 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#785940}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e8c9fd602f11..29c9135d06f1 2020-07-07 johnkslang@users.noreply.github.com Merge pull request #2328 from zoddicus/fixBUILDgn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: If52c8ec20337ef3d657b9af01f1d81d8d06b6682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285205Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/509812647060..db0d1b0d2459 2020-07-07 fmayer@google.com Merge "Check for valid slice in UpdateThreadDeltasForSliceId." 2020-07-07 fmayer@google.com Disable PollBehavesProperly. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:158484911 Tbr: perfetto-bugs@google.com Change-Id: I7b843b283b07056e6f37ed1fe69da011f59bb857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285203Reviewed-by:
-
Collin Baker authored
Bug: 1102655 Change-Id: I52a3f2095ef1bbd07d69fd4c89d16fb94e52369c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284222Reviewed-by:
-
Dylan Cutler authored
Instrument navigator.[appVersion|platform|userAgent] using web IDL bindings for identifiability study. HighEntropy=Direct was introduced for numeric, simple fingerprinting surfaces in: https://chromium-review.googlesource.com/c/chromium/src/+/2245048 This CL adds support for DOMString attributes by adding an overload to Dactyloscoper::RecordDirectSurface. Bug: 973801 Change-Id: I34af7fb4b928f2bd1ae894704d0dc72c31c5884f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276401 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#785936}
-
Jeffrey Young authored
Assistant processing v2 introduced a situation that allowed multiple error messages to flush to the screen due to AssistantInteractionControllerImpl::OnTtsStarted being called multiple times. Add AssistantResponse::ContainsUiElement to check if duplicate error elements already exist before adding more. Bug: b/158499400 Change-Id: Ia90199ef8b733132fd5433ca47bb7905926b2f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258196 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#785935}
-
Steven Bennetts authored
This test is intended to ensure that no errors are logged to DeviceEventLog under normal conditions. Currently this will only run on linux-chromeos. A similar Tast test will also be added to cover running on a device. Bug: 550539 Change-Id: I2f100cefb396d074c448c862d3a8908e11b07243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284072 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#785934}
-
Rainhard Findling authored
Bug: 1087263,1101737 Change-Id: I46e5cb8be86350cf54f0aec2b61fc45f76aa47d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283594Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#785933}
-
Xida Chen authored
This is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: Ib94c3d8dcd81437d351132dadd62adc6851db084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278631 Auto-Submit: Xida Chen <xidachen@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#785932}
-
Tommy Steimel authored
This CL adds two public Polymer wrappers to keep Kaleidoscope's cr_elements/ usage in the public repo. This CL adds a new CSS var used to set a background color on a CrDrawerElement. Bug: b:157737119 Change-Id: Ibc15f4cf2f497142c68b73a0b20f85ed0a1cc719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254452 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#785931}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/92554d75f354..b72434f3d312 2020-07-07 cwallez@chromium.org Rolling 2 dependencies 2020-07-07 cwallez@chromium.org Implement GPUBufferDescriptor.mappedAtCreation. 2020-07-07 cwallez@chromium.org Roll third_party/swiftshader/ d25ce8725..f6f11215c (155 commits) 2020-07-07 tommek@google.com Rephrasing CopyBufferToTexture validation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib8a70c467f10daa805fcdbb9d9ffe50e8a161904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284956Reviewed-by:
-
Domenic Denicola authored
Bug: 1042415 Change-Id: I5842aa32abc0b23e492c84ba0dc0e5906283a805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199550 Auto-Submit: Domenic Denicola <domenic@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#785929}
-
Darwin Huang authored
This reverts commit d8496278. Reason for revert: Breaks Linux Tests (dbg)(1) bots (2 runs) https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/90122 Failed tests are in http/tests/devtools Original change's description: > Roll DevTools Frontend from 0b6df3ba1a45 to 8bf8ca6dc7f2 (6 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0b6df3ba1a45..8bf8ca6dc7f2 > > 2020-07-07 aerotwist@chromium.org Fix tsconfig generation paths > 2020-07-07 tvanderlippe@chromium.org Migrate IdentityFormatter to TypeScript > 2020-07-07 tvanderlippe@chromium.org Add OWNERS for test/conductor > 2020-07-07 alexrudenko@chromium.org Fix stylelint-config-standard issues in sources/javaScriptBreakpointsSidebarPane.css > 2020-07-07 tvanderlippe@chromium.org Extract copy to resources into separate template > 2020-07-07 alexrudenko@chromium.org Fix snippet saving and search > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: chromium:1011811,chromium:1066415,chromium:1083142,chromium:1098730 > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: I2ed9710ec2ea19cb56e4a5a03066a9764b5bcde8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284793 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#785749} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6f47a424997d78770754159a4470762fc8513390 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1011811, chromium:1066415, chromium:1083142, chromium:1098730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285311Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785928}
-
Darwin Huang authored
This reverts commit 751e24d3. Reason for revert: Reason for revert: Breaks Linux Tests (dbg)(1) bots (2 runs) https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/90122 Original change's description: > Roll DevTools Frontend from 8bf8ca6dc7f2 to 8c03d5d9bcc5 (14 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8bf8ca6dc7f2..8c03d5d9bcc5 > > 2020-07-07 sigurds@chromium.org Update heavy ads issue strings > 2020-07-07 tvanderlippe@chromium.org Fix stylelint errors in networkPanel.css > 2020-07-07 tvanderlippe@chromium.org Fix stylelint errors in media/playerPropertiesView.css > 2020-07-07 aerotwist@chromium.org [CSS Overview] Adds checks for null / undefined > 2020-07-07 tvanderlippe@chromium.org Fix stylelint errors in network/networkLogView.css > 2020-07-07 jacktfranklin@chromium.org Fix component _bridges generation for TypeScript 4 > 2020-07-07 petermarshall@chromium.org Revert "Add E2E tests for Breakpoint test cases" > 2020-07-07 leese@chromium.org Add helpers for debugging and snippet tests > 2020-07-07 jacktfranklin@chromium.org Fix test_helpers on Python 3 > 2020-07-07 pfaffe@chromium.org [wasm debugging] Add a js_type to evaluator results > 2020-07-07 tvanderlippe@chromium.org Remove e2e-test build files from .gitignore > 2020-07-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. > 2020-07-07 tvanderlippe@chromium.org Fix stylelint reports in inline_editor/cssShadowEditor.css > 2020-07-07 johanbay@gmail.com Fix stylelint-config-standard issues in color_picker/spectrum.css > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: chromium:1083142,chromium:1083146,chromium:1088463,chromium:1094436,chromium:1095617,chromium:1102704 > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: Id88b50084ed4c7ee17b34047eeb2fcc769afa10c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284949 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#785858} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I61a751350b187f86f2cd7093f1fb1976f6cc0258 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1083142, chromium:1083146, chromium:1088463, chromium:1094436, chromium:1095617, chromium:1102704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285173Reviewed-by:
-
danakj authored
Remove some async callbacks that are not needed in the renderer side test completion path. This is toward pushing test completion code up to the browser so we don't depend on keeping a stable renderer main frame across navigations, which RenderDocument changes. R=avi@chromium.org Bug: 866140, 1069111 Change-Id: Ia73ab3ec79ec2a226fc26a92c65962355ff6e1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284373Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1b96bb59d41..233c2d8fa4c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huangdarwin@google.com,mcnee@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1033067,chromium:1093065 Tbr: huangdarwin@google.com,mcnee@google.com Change-Id: I0d787e992ab08199852d526cd0ba85b81517bfe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284953Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785925}
-
Fredrik Söderqvist authored
Remove some includes of headers from public/web/ which are not used. Change-Id: Ie88abc87e3d09a06608494a8578c1c816a3ec51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285222 Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#785924}
-
Matt Reynolds authored
base::BindToCurrentLoop already uses Once/RepeatingCallbacks but the file-level comment still refers to base::Bind. This CL updates the comment to refer to the new types. BUG=1007799 Change-Id: Ib8005e301f6d3d729570dda8102673d636fb61d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283060Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#785923}
-
Ted Choc authored
Replaces Criteria.equals usage as part of the migration. See https://groups.google.com/a/chromium.org/g/java/c/ZSj5TANUy8Q/m/gFL8BCVmBgAJ for more details. BUG=1071247 Change-Id: I7069517051e847f4c55ab13408bfbb61540470bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158245 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#785922}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5dc283c9f491bc37ead1bcf9fe7a78ff024dcae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285070Reviewed-by:
-
Tom Anderson authored
BUG=1066670 R=sky Change-Id: I944c8a78da49ed0a42e8f60ae5914503be1a5fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278356Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#785920}
-
David Bienvenu authored
This warning spams every browser test log. Change-Id: Iae5b9a84caf1b17e20e37fd3b59fb2165cd07525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284048Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#785919}
-
sauski authored
Access Context Auditing relies on the concept of an origin in numerous places. These were previously represented as GURLs, this change moves all uses to use url::Origin instead. Bug: 1101675 Change-Id: Ibfef15789c598c3ce492eac359f3d807908942bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279887 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#785918}
-
