GitLab

BUG=374349

Review URL: https://codereview.chromium.org/284223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271473 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a couple of issues with the installer script regarding
installing on machines that don't have both 2010 and 2012 installed.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/290013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=144491

Review URL: https://codereview.chromium.org/282153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271470 0039d316-1c4b-4281-b951-d872f2087c98

Fix the flaky KioskAppManageTest::RemoveApp and UpdateAndRemove tests flaky issue caused by file deletion racing condition.

BUG=373473

Review URL: https://codereview.chromium.org/290023005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271469 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Refactor] Consolidate the logic for whether a widget can be activated. (https://codereview.chromium.org/286733002/)

Reason for revert:
This CL was causing problems when the value of views::Widget::CanActivate() changes crbug.com/374095

I also need to audit the code to find out whether there are any 'non-activatable' widgets which were intended to be activatable

Original issue's description:
> [Refactor] Consolidate the logic for whether a widget can be activated.
>
> This is a first step towards giving tooltips their own WindowTreeHosts on Linux.
>
> BUG=353533
> TEST=None
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270597

Review URL: https://codereview.chromium.org/297503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271468 0039d316-1c4b-4281-b951-d872f2087c98

R=tim@chromium.org

Review URL: https://codereview.chromium.org/285333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271467 0039d316-1c4b-4281-b951-d872f2087c98

Echo the config's version in uploads based on the config, so the server
can judge what frequency/type of reports to expect.

BUG=356791

Review URL: https://codereview.chromium.org/290473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271466 0039d316-1c4b-4281-b951-d872f2087c98

This broke Android:
http://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds/30310
FAILED: /mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/Android_Builder/build/src/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.8/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -MMD -MF obj/content/shell/app/content_shell_lib.shell_main_delegate.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_CONFIGURATION_POLICY -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DENABLE_EGLIMAGE=1 -DENABLE_AUTOFILL_DIALOG=1 -DCLD_VERSION=1 -DENABLE_PRINTING=1 -DENABLE_MANAGED_USERS=1 -DVIDEO_HOLE=1 '-DCONTENT_SHELL_VERSION="19.77.34.5"' -DMOJO_USE_SYSTEM_IMPL -DLIBPEERCONNECTION_LIB=1 -DGTEST_HAS_POSIX_RE=0 -DMEDIA_DISABLE_LIBVPX -DPOSIX_AVOID_MMAP -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_GETTOPDEVICE -DSK_SUPPORT_LEGACY_N32_NAME -DSK_SUPPORT_LEGACY_BUILDMIPMAP -DSK_SUPPORT_LEGACY_SHADER_LOCALMATRIX -DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_BUILD_FOR_ANDROID -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DSK_IGNORE_UNDERLINE_POSITION_FIX -DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DCHROME_PNG_READ_PACK_SUPPORT -DMESA_EGL_NO_X11_HEADERS -DAPPCACHE_USE_SIMPLE_CACHE -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DANDROID -D__GNU_SOURCE=1 -DUSE_STLPORT=1 -D_STLP_USE_PTR_SPECIALIZATIONS=1 '-DCHROME_BUILD_ID=""' -DHAVE_SYS_UIO_H -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -I../.. -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../third_party/WebKit/Source -Igen -I../../third_party/WebKit -Igen/content -Igen/net -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/WebKit -I../../third_party/icu/source/common -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/libwebp -I../../third_party/ots/include -I../../third_party/qcms/src -I../../third_party/iccjpeg -I../../third_party/libjpeg_turbo -I../../third_party/icu/source/i18n -Igen/ui/gl -I../../third_party/mesa/src/include -I../../v8/include -Igen/webkit -Igen/content/shell -fstack-protector --param=ssp-buffer-size=4 -Werror -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-unused-local-typedefs -march=armv7-a -mtune=generic-armv7-a -mfpu=vfpv3-d16 -mfloat-abi=softfp -mthumb -fno-tree-sra -fno-partial-inlining -fno-early-inlining -fno-tree-copy-prop -fno-tree-loop-optimize -fno-move-loop-invariants -fno-caller-saves -Wno-psabi -mthumb-interwork -ffunction-sections -funwind-tables -g -fstack-protector -fno-short-enums -finline-limit=64 -Wa,--noexecstack --sysroot=/mnt/data/b/build/slave/Android_Builder/build/src/third_party/android_tools/ndk//platforms/android-14/arch-arm -I/mnt/data/b/build/slave/Android_Builder/build/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/stlport -Os -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -funwind-tables -g1 -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -Wno-abi  -c ../../content/shell/app/shell_main_delegate.cc -o obj/content/shell/app/content_shell_lib.shell_main_delegate.o
../../content/shell/app/shell_main_delegate.cc: In static member function 'static void content::ShellMainDelegate::InitializeResourceBundle()':
../../content/shell/app/shell_main_delegate.cc:265:17: error: 'kInvalidPlatformFileValue' is not a member of 'base'
   if (pak_fd != base::kInvalidPlatformFileValue) {
                 ^

> Remove stray platform_file.h from webkit
> 
> BUG=322664
> 
> Review URL: https://codereview.chromium.org/289003006

TBR=rvargas@chromium.org

Review URL: https://codereview.chromium.org/293743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271464 0039d316-1c4b-4281-b951-d872f2087c98

If SharedWorkerHost's closed flag is true SharedWorkerServiceImpl::FindSharedWorkerHost() doesn't match the host.
So two SharedWorkerHosts of same SharedWorkerInstance could be created.
But EmbeddedWorkerDevToolsManager can't handle two SharedWorkerHosts of same SharedWorkerInstance.
So we have to remove instance from EmbeddedWorkerDevToolsManager when WorkerContextClosed is called.

BUG=374387

Review URL: https://codereview.chromium.org/287303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/291843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271462 0039d316-1c4b-4281-b951-d872f2087c98

The RenderViewHost creation today takes a CrossProcessFrameConnector pointer, which it uses to decide whether to create a top-level or child frame view. Replace this with a boolean and associate the CrossProcessFrameConnector with the view at a later point in time.

BUG=357747

Review URL: https://codereview.chromium.org/270883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271461 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350242

Review URL: https://codereview.chromium.org/286093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271460 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/289003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271459 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271457 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371805
TBR=mcasas@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/291923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271456 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271455 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271454 0039d316-1c4b-4281-b951-d872f2087c98

We recently switch to using glibc hooks for interception on glibc.
Where in the past calls like ki_accept and accept could be assumed to be the
same, now they rely on wrapping.

Changing inconsistent use of ki_ vs not in socket_test.

BUG=None
TEST=nacl_io_socket_test
R=binji@chromium.org

Review URL: https://codereview.chromium.org/290953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271453 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Gamepad list lookup causes a startup crash on Ice Cream Sandwich devices.  Please reland after adding the appropriate version check and testing locally (note: you don't need to get OWNERS approval a second time when relanding if you reupload to this codereview entry instead of creating a new one).

TBR=feng@chromium.org
NOTRY=true

Original issue's description:
> Gamepad API support for chrome on android
> 
> This change adds code to get gamepad data from java objects and
> provide these updates to the GamepadProvider which then writes to
> GamepadHardwareBuffer which in turn is read by SharedMemoryReader and
> later returned by JS to the web page.
> 
> Added singleton class GamepadsReader which is responsible for
> communication with java class and accessing gamepad data. It adds
> methods for communication with singleton java GamepadList class to
> get gamepads data.
> 
> This also adds new framework classes/methods required for Gamepad API
> support. Frameworks changes are responsible for :
>   - Identifying gamepad devices and their capabilities.
>   - Managing connected gamepad devices
>   - Map the connected gamepad devices to standard Gamepad format.
>   - Keeping gamepads axes/buttons data up-to-date and returning it to
>     native whenever requested. In android we cannot get gamepad data
>     directly from sources, so framework is modified to capture
>     gamepad key and motion events and extract gamepad data from these
>     events.
> 
> * Class GamepadPlatformDataFetcherAndroid : Android specific
>   implementation of gamepad data fetcher.
> 
> * Class ContentViewCore : Manages gamepad list and notifies of new
>   key/motion event for gamepads.
> 
> * Class GamepadList : A new class to manage connected gamepad devices
> 
> * Class GamepadDevice : A new class to manage information related to
>   each gamepad device.
> 
> * Class GamepadMappings : This class is responsible for mapping of
>   known gamepads to the standard gamepad.
> 
> This change enables gamepad API by default.
> 
> Adds support for parsing float array return type in JNI generator.
> 
> NVIDIA Shield and XBox360 gamepads are mapped to the standard gamepad
> 
> BUG=330094
> 
> TEST=http://www.html5rocks.com/en/tutorials/doodles/gamepad/gamepad-tester/tester.html
> 
> R=tsepez@chromium.org
> R=darin@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270620

Review URL: https://codereview.chromium.org/298483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271452 0039d316-1c4b-4281-b951-d872f2087c98

The attempted fix only locked one side of the race, which isn't effective.

BUG=370244
TBR=ernstm@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/297493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271451 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271450 0039d316-1c4b-4281-b951-d872f2087c98

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/284203012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271449 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add default options for ThreadSanitizer on Linux. Enable deadlock detection by default. (https://codereview.chromium.org/272763005/)

Reason for revert:
The linux_clan_tsan trybot caught a few deadlock reports that break memory bots after this change. 

e.g. http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28TSan%20v2%29%281%29/builds/9705/steps/media_unittests/logs/stdio


Original issue's description:
> Add default options for ThreadSanitizer on Linux. Enable deadlock detection by default.
> 
> BUG=372754,302040
> R=earthdok@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271412

TBR=earthdok@chromium.org,glider@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=372754,302040

Review URL: https://codereview.chromium.org/287373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271447 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Unconditionally include <string> and <iostream> in json_reader.cpp (https://codereview.chromium.org/291803003/)

Reason for revert:
This adds a static initializer.

Original issue's description:
> Unconditionally include <string> and <iostream> in json_reader.cpp
> Non-PNaCl builds that use libc++ also require these headers.
> 
> BUG=None
> R=mallinath@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271429

TBR=mallinath@chromium.org,ronghuawu@chromium.org,glider@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/290923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271446 0039d316-1c4b-4281-b951-d872f2087c98

- Added APIs for trackpad scroll begin/change/end events.
- Modified the API for momentum scroll begin to take additional parameters to
specify the deltaX and deltaY. Added the function MouseMomentumBegin2 to
accomplish this. This will be replaced by MouseMomentumBegin once the blink
change is landed.

BUG=330887

Review URL: https://codereview.chromium.org/283713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271445 0039d316-1c4b-4281-b951-d872f2087c98

The V8 team signed off on removing this as well.

BUG=361460
TEST=none

Review URL: https://codereview.chromium.org/289393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271444 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94925
TBR=erg@chromium.org

Review URL: https://codereview.chromium.org/282093014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271442 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374215
TEST=compiles
R=asvitkine@chromium.org, xiyuan@chromium.org

Review URL: https://codereview.chromium.org/289303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271441 0039d316-1c4b-4281-b951-d872f2087c98

BUG=310373
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/253333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271440 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374871
TBR=rtenneti@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/292693006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271439 0039d316-1c4b-4281-b951-d872f2087c98

This CL addresses a potential problem due to a race: 
|suspend_observer_| [1] could have been deallocated in 
~AVFoundationMonitorImpl while still being in use 
in Device Thread [2]. This race didn't show up in normal
circumstances since it needed the Device Thread to
be active for a very short time; xians@ stumbled upon
it during some unrelated code activities that made a
browser_test fail.

This CL then cleans up the management of 
|suspend_observer_| from the  AVFoundationMonitorImpl
to a new class SuspendObserverDelegate, the former 
living exclusively in UI thread, the latter in Device 
Thread. SuspendObserverDelegate gets the Device
Thread parts of AVFoundationMonitorImpl.

The new class sits between AVFoundationMonitorImpl
and the Objective-C++ CrAVFoundationDeviceObserver.

[1] https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/device_monitor_mac.mm&sq=package:chromium&type=cs&l=259
[2] https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/device_monitor_mac.mm&sq=package:chromium&type=cs&l=336

BUG=288562, 372418

Review URL: https://codereview.chromium.org/276573009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271438 0039d316-1c4b-4281-b951-d872f2087c98

aura_unittests should run on linux and windows (including mac)
ash_unittests should run on chromeos and windows.

BUG=none
TEST=none
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/282363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271430 0039d316-1c4b-4281-b951-d872f2087c98

Non-PNaCl builds that use libc++ also require these headers.

BUG=None
R=mallinath@chromium.org

Review URL: https://codereview.chromium.org/291803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271429 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94925
TBR=erg@chromium.org

Review URL: https://codereview.chromium.org/292763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271428 0039d316-1c4b-4281-b951-d872f2087c98

Since narrowing conversion in the `{}` is ill-formed in C++11, it raises
compile error with G++ 4.8.2.

BUG=

Review URL: https://codereview.chromium.org/294523007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271427 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371822

Review URL: https://codereview.chromium.org/295643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271426 0039d316-1c4b-4281-b951-d872f2087c98

This is so I can introduce a new way to do PPP interfaces that are
passed to a related PPB interface, instead of using PPP_GetInterface.

Note this doesn't add support for the PNaCl shim yet, although it should
at least make it compile.

BUG=367896

Review URL: https://codereview.chromium.org/281203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271425 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves the UserContext from user.[cc|h] to its own header and
implementation files.

BUG=367847
TEST=Updated unit and browser tests

TBR=nkostylev (chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc)
TBR=nkostylev (chrome/browser/chromeos/chrome_browser_main_chromeos.cc)
TBR=pamg (chrome/browser/managed_mode/chromeos/manager_password_service.[cc|h])

Review URL: https://codereview.chromium.org/290513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271424 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374297
TBR=mpearson@chromium.org,jhawkins@chromium.org

Review URL: https://codereview.chromium.org/286063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271423 0039d316-1c4b-4281-b951-d872f2087c98

This is needed to provide a ContextFactory to the Compositor so that
we can create Compositors on multiple threads.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/284233009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271422 0039d316-1c4b-4281-b951-d872f2087c98