- 25 Sep, 2019 40 commits
-
-
Carlos Caballero authored
Remove references in /device/bluetooth/bluez MessageLoopForIO is going away soon. Use SingleThreadTaskExecutor for main functions and SingleThreadTaskEnvironment for tests instead. Both are no op changes. This CL was uploaded by git cl split. R=mcchou@chromium.org Bug: 891670 Change-Id: I4b67ceda2cf508e5f5d76493c5d2aa05e3619924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780738 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#699662}
-
Piotr Tworek authored
This not visible in default chromium setup since it disables exceptions by default. The code does however fail to compile if one enables them: ../../base/containers/intrusive_heap.h:717:48: error: 'operator=' is missing exception specification 'noexcept' IntrusiveHeap<T, Compare, HeapHandleAccessor>::operator=( ^ ../../base/containers/intrusive_heap.h:290:18: note: previous declaration is here IntrusiveHeap& operator=(IntrusiveHeap&&) noexcept; Change-Id: I8c633333ae17002ba0b643e6c88e463d28de0086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815862Reviewed-by:Daniel Cheng <dcheng@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/master@{#699661}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3731bd7ab054..6abaff3041a3 git log 3731bd7ab054..6abaff3041a3 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6d625bfe6e8a..ba04be8c9ef9 (9 commits) 2019-09-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a76152f4..fb8fbb18 (434 commits) Created with: gclient setdep -r src/third_party/skia@6abaff3041a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:None,chromium:None Change-Id: If64c9b4ab6a61a43d460b17da2ce5818af6379ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824839Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699660}
-
Keith Lee authored
Change-Id: Ie48fac3c75f6825eca8372abe09afa2696586333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816340 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Auto-Submit: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#699659}
-
Carlos Caballero authored
MessageLoop is going away. Also had to fix a lot of includes as a bunch of files were not directly including their dependencies. Bug: 891670 Change-Id: I1b962b9513596b399175498278ad526fba2240f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807504 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#699658}
-
Sergio Villar Senin authored
It's currently returning a double. As part of the process of rewriting the animation engine we're replacing doubles by base::Time* alternatives. Bug: 737867 Change-Id: I9d6cca66354ec22f5387ce7328b92c5c396ce283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819243Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#699657}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a130294887fc..f2723363e181 Created with: gclient setdep -r src-internal@f2723363e181 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I97aa9f3b4fc7455ef41451c9cb540bebe020d944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823810Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699656}
-
Koji Ishii authored
32 can avoid most of memory allocations, by consuming 512 bytes on stack ((4+4+8) * 32) on 64 bits. Most major sites are up to 8 or so, such as Google SRP, facebook, twitter, MDN, youtube, etc. Wikipedia is up to 21. Change-Id: I7f06f0ce01b5d2960becf99e0b453d92723e5253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821501 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#699655}
-
Maksim Sisov authored
This moves IsVisible impl from DWTHX11 to DWTHPlatform and adds IsVisible() method to PlatformWindow. Scenic and Windows implementations are not implemented and return true. Drm's implementation is set to NOTREACHED as it is not expected that the DrmWindowHost::IsVisible is ever called. X11 and Wayland implementations return visibility for unminimized windows and mapped windows (in case of Wayland, it means that either xdg_surface or xdg_popup exist). Bug: 990756 Change-Id: I09ff60a9064ea5bef674d202c5bee994e238c496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807239Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#699654}
-
Dominick Ng authored
This moves ownership of the AppServiceImpl directly into the browser's AppServiceProxy, rather than having indirect ownership through Service Manager and Connector. In the original, multi-process aware App Service design, there would be N App Service Proxies connecting to 1 App Service, where N is the number of processes. Now that out-of-process ash is not being worked on, N:1 in theory will remain 1:1 in practice for the foreseeable future, so the browser process App Service Proxy can itself own the service implementation. Bug: 977637 Change-Id: I8320dd5b642b82940f6b8697df5cb06ca5226d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819283 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#699653}
-
Jeevan Shikaram authored
This CL adds the ability to search the main app view. Old view: https://bugs.chromium.org/p/chromium/issues/attachment?aid=413193&signed_aid=1gM1GYp3LKjfA-MDmtDCnA==&inline=1 New view: https://bugs.chromium.org/p/chromium/issues/attachment?aid=413194&signed_aid=AUs-pUuL34V1dT9wVQZICg==&inline=1 Search Active: https://bugs.chromium.org/p/chromium/issues/attachment?aid=413195&signed_aid=3vKsZHA49w1-eKdDzCFMAg==&inline=1 Search No Results: https://bugs.chromium.org/p/chromium/issues/attachment?aid=413196&signed_aid=apBMFLJ_YL0728Ah9Pv5Iw==&inline=1 Bug: 979531, 1001941 Change-Id: Ie70439c334d76f61497a512f7fd1270843210aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775648 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#699652}
-
Koji Ishii authored
Zero-length text item was added in r652199 (crrev.com/c/1571113) so that |NGLineBreaker| can call |ClearNeedsLayout()| for fully-collapsed |LayoutText|. This patch fixes such zero-length text items not to require re-shaping when re-using existing |ShapeResult|. Found when debugging crbug.com/963521. Change-Id: I3d5a78463a1754daf8c9602ce1dcb855d603ade9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824759Reviewed-by:
-
Darwin Huang authored
Before this CL, navigator.clipboard.read image/png encoding used fZLibLevel = 6. Use fZLibLevel = 1 instead of the default fZLibLevel = 6. fZLibLevel = 6 is slower, and inconsistent with DataTransfer[1], which already uses fZLibLevel = 1. When testing using https://www.photopea.com/clipboard_img.html , which provides a 8000x4000 px bitmap of random pixels, navigator.clipboard.read took: * 4.10 (4.07 to 4.13) seconds over 3 trials with fZLibLevel = 6 * 3.98 (3.95 to 4.00) seconds over 3 trials with fZLibLevel = 1 * 1.53 (1.50 to 1.56) seconds over 3 trials with fZLibLevel = 0 Switching from fZLibLevel 6 to fZLibLevel 1 should enable a 3% speed-up in Async Clipboard performance, and not cause any change in behavior for DataTransfer (which would occur with fZLibLevel 0). The trade off is that this may cause encoded image/png images to be slightly larger, but this should be acceptable for clipboard content. [1]: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/clipboard/data_object_item.cc?l=141 Bug: 1004867 Change-Id: Ie557b211bbe70e19009c5d67fca310cc970101cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824063 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#699650}
-
Rika Fujimaki authored
Now that we replaced ScriptValue::script_state_ with ScriptValue::isolate_, we can pass isolate instead of script_state to ScriptValue's ctor. Bug: 998994 Change-Id: Ibe5c004cf2f1ec598e2df548d32b3a187395b160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824038Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Rika Fujimaki <rikaf@google.com> Cr-Commit-Position: refs/heads/master@{#699649}
-
Victor-Gabriel Savu authored
InstallAttributesUsage uses InstallAttributesUsageEvent, the wrong enum was used in the previous CL. CL that added the two entries: https://chromium-review.googlesource.com/c/chromium/src/+/1800751 Bug: 1000305 Change-Id: Ia40c026511ecdc6cf4656673ca4660de9e2130c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817880Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#699648}
-
Emil A Eklund authored
Change-Id: I0dd9816618b396214cbb12d118327e44bdd6cad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824044 Auto-Submit: Emil A Eklund <eae@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#699647}
-
Toni Barzic authored
During app list drag, the app list background shield is gradually translated up so it ends up with rounded corners above the display in the full screen state. The translation is currently applied during drag between peeking and fullscreen state. Given that kHalf state (i.e. extended peeking state for search results UI) is above peeking state, starting drag from kHalf state would immediately apply non-identity transform on the background shield, causing the app list view to jump up. This CL changes the starting height at which the background shield starts getting translated up at the larger, kHalf height, thus avoiding the background shield jump when drag starts. BUG=None Change-Id: I47ea834f87cfd2836058a91954a7aad5bda36a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824077 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699646}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fc604aa990d5..84004c441c75 git log fc604aa990d5..84004c441c75 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f24b5ede..b3fb292c (699513:699622) Created with: gclient setdep -r src/third_party/webrtc@84004c441c75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ic41dd456a39dab588a775415f190abbf1a111266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824613Reviewed-by:
-
Chris Blume authored
This CL runs pixel_skia_gold_test on the 'Android FYI SkiaRenderer GL (Nexus 5X)' bot with SkiaRenderer, the GLES backend, and OOP rasterization. Bug: 969855 Change-Id: Icde25c694e22c89e2547def673340607afc897b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786871 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#699644}
-
Peter Kotwicz authored
This CL: - Adds UKM recording for WebAPK.Uninstall In particular: - recording how long a WebAPK has been installed - recording how many times a WebAPK which has been uninstalled has been launched. - Changes WebappDataStorage#updateFromShortcutIntent() to take in WebappInfo as input instead of an intent - Adds new fields to WebappDataStorage: - Web Manifest URL - WebAPK version code - WebAPK install timestamp - WebAPK uninstall timestamp - Removes now unused macless webapp shortcut intent creation Privacy doc: https://docs.google.com/document/d/10m4NwkTFVjQ7uboJP9rUQM0Yh7ULD6dVvGlL3eQtD3g/edit?usp=sharing BUG=982362 TEST=WebappDataStorageTest.testWebApkInfoUpdate NOPRESUBMIT=true (To surpress new function ordering requirements) Change-Id: Ie47ef125f6bc60d5fad7f58597d09b4a41648982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781664 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:Theresa <twellington@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#699643}
-
Giovanni Ortuño Urquidi authored
This reverts commit a40589ab. Reason for revert: The flag is used for testing new versions of QuickOffice. Removing the flag makes testing harder. Original change's description: > flags: remove disable-office-editing-component-app > > Bug: None > Change-Id: I2cc23a37cc16724e0056aaec13363483f5d3934e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582230 > Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#654013} Bug: None Change-Id: I89c2c857b1aea5e2d08ea7161cc570b9feb11d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824299 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2137f90b9d98..3731bd7ab054 git log 2137f90b9d98..3731bd7ab054 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e3a5983705da..cc3f09861685 (5 commits) Created with: gclient setdep -r src/third_party/skia@3731bd7ab054 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:None Change-Id: Ia2618af5e6a8b5da160e04b952cd6034c8ee6b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824184Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3232fd81..942786e2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icd7bafc70831ac5b9ecc765edcaa39f338bc5991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823905Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699640}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b079ab860152..6730faf618f8 git log b079ab860152..6730faf618f8 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 ntfschr@google.com Devil: document python3 work and fix CONTRIBUTING link Created with: gclient setdep -r src/third_party/catapult@6730faf618f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1007101 Change-Id: I75c8a2a9a8d20f38dc0e535e66e8cc9509975cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823807Reviewed-by:
-
Kunihiko Sakamoto authored
We already use version b3 in the tests. Change-Id: Iadcf6b0a1057d6af01884f524ece0394bf244625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824499 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Auto-Submit: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699638}
-
Alex Keng authored
This CL implements new looks for <input type=range>, <meter>, and <progress>. NativeThemeAura::PaintProgressBar is added for <progress>. New css rules are added in controls_refresh.css for <meter>. NativeThemeAura::PaintSliderTrack is updated for <input type=range>. Several constants (ex width/radius) are updated per design and cleaned up. AlignSliderTrack is updated to use float instead of int to better align the thumb and the track. The high contrast test, range.html, is replaced with range_meter_progress.html to better visualize the three related controls. Note for some reason NativeThemeAura::PaintProgressBar is not called in webtest mode when ForcedColors flag is enabled (The progress bar in range_meter_progress-expected.png shows some old rendering) The issue will be addressed in a separate CL. Bug: 1001563 Change-Id: I9e6da39caf86c2b12187f5c56e0ef99989e3c0f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817151Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alex Keng <shihken@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699637}
-
Anand K. Mistry authored
This causes the input and dropdown text elements to be aligned together. BUG=977313 Change-Id: I5eca12ab5a5f2b600a1e419309f68d0c1ccc6bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819093 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#699636}
-
Jan Scheffler authored
This patch adds a createTextLink method to create text links and uses it in the security > origin view to link to the network pane. It also adds "show more" and "show less" classes for to the text link. Bug: chromium:977423 Change-Id: If5ff95e5d26af3a20680e93e23e110b912a41de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789531 Commit-Queue: Jan Scheffler <janscheffler@google.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699635}
-
Mohamed Amir Yosef authored
No need to pass the complete PasswordForm since it's already stored in the password manager. TBR=vasilii@chromium.org Change-Id: I7eb41dc2db89e2c223198e5666f7fdad75395a3a Bug: 949519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821357 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#699634}
-
Jay Harris authored
Enables file handling in non-extension based web apps. Bug: 938103 Change-Id: I2610e5712c556f03104c95d27a06cfd137b801db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824525Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#699633}
-
John Z Wu authored
Change-Id: Id5d181754a143a2688b63812842d719cb12bc9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817022Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#699632}
-
John Z Wu authored
Change-Id: I37c0dfe768d60b4306c0c1745517936425047ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817291Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8b16ac056b1a..edb189d40cb2 git log 8b16ac056b1a..edb189d40cb2 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 seanabraham@chromium.org Add jrosenth to chromite OWNERS Created with: gclient setdep -r src/third_party/chromite@edb189d40cb2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3b08858cc662092e97df400a879450b1fac2572f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824677Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d077f984. With Chromium commits locally applied on WPT: d4ca0e6e "Add missing worklet referrer tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I27b07c71fc3e8f9c70af132145d3c1df13ac6424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823632Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699629}
-
Hiroki Nakagawa authored
Bug: 1007616 Change-Id: I8f9d11ec78dd43210b3b3d5293f0b69b1a992fad Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824526Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#699628}
-
Malay Keshav authored
Fragment shader was never initialized in case of StreamVideoQuads thus resulting in them never having a rounded corner. This patch initializes the shader with the correct parameters and fixes the issue. This also fixes direct composition which does not support rounded corners. pixel tests. Bug: 999678 TEST: Manually tested on android with repro steps on bug and added gpu Change-Id: I49767b3f3feeb016f0e39baed1ebe10db1cb24a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812357 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#699627}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/92a0888e..3232fd81 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic441ff4fed5c0a2490581f64bc8146aa33762351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823635Reviewed-by:
-
rajendrant authored
This is a first pass of removal of client and sever LoFi code in blink LoFi feature is deprecated now. Bug: 998691, 944286 Change-Id: Iadeb1ed215de45cf3ee86bc917a847656b88a77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777051 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#699625}
-
Darren Shen authored
For some reason we use unique_ptr to store CandidateWindow. There's not much benefit apart from saving 1 ptr size. Bug: 1005619 Change-Id: Icd0305135257af3762f67798ab3b04d64c9aa2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815806 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/273175cdf44e..ba04be8c9ef9 git log 273175cdf44e..ba04be8c9ef9 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 jmadill@chromium.org GN: Refactor angle_test and remove angle_test_main. Created with: gclient setdep -r src/third_party/angle@ba04be8c9ef9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I5ae964663c1bdc0d990eaa96acda277694a79a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824283Reviewed-by:
-
