- 30 Oct, 2018 40 commits
-
-
Christopher Lam authored
As a temporary measure, make System PWAs update on every Chrome launch. This allows developers to see changes when they update manifests. This will be replaced with a lighter, more robust system before consumer launch. Bug: 836128 Change-Id: I04e65a4a060a6e91c0f7d32bd44be51492e2fd4e Reviewed-on: https://chromium-review.googlesource.com/c/1282503 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#603800}
-
Anand K. Mistry authored
BUG=889703 Change-Id: I06284ea5d72359ea9d6950b65aa891e86b20550e Reviewed-on: https://chromium-review.googlesource.com/c/1307016Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#603799}
-
Alexander Alekseev authored
This cl ensures Powerwash screen will ask for restart if user has already logged in. Bug: 899050 Change-Id: I003f4e323e59995767f882ca4f529674f3e07e76 Reviewed-on: https://chromium-review.googlesource.com/c/1307066Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#603798}
-
Yuri Wiitala authored
Adds the implementation to support gamma-aware scaling: It uses half- floats to increase the precision of the color values, and adds an "import stage" to linearize the color values before any texture sampling or scaling occurs. Added a pixel test to prove the gamma-aware versus non-gamma-aware configuration of GLScaler produces the expected results. Bug: 870036, 810131 Change-Id: Ie68121add789169dbda0a578f03a257d089d4f6c Reviewed-on: https://chromium-review.googlesource.com/c/1297540 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#603797}
-
Tsuyoshi Horo authored
This test is flaky. See the flakiness dashboard. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=network_service_browser_tests&tests=SettingsBasicPageBrowserTest.Load https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=SettingsBasicPageBrowserTest.Load TBR=dpapad@chromium.org Bug: 738146, 860069 Change-Id: I1d9b16d944a21c47e91d9aee76a6c95f3be701fe Reviewed-on: https://chromium-review.googlesource.com/c/1307017Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#603796}
-
Xida Chen authored
Right now pinch events are evaluated at GestureScrollBegin, if a gesture is allowed at GSB, then the entire gesture is allowed. This cause a problem in the following scenario. We have a div with pan-y, user starts with scrolling along the y-direction, and then the second finger touches the screen and generates a pinch zoom gesture. In this case, the pinch zoom gesture is allowed because the user starts with scrolling along the y-axis which is allowed. This CL fixes the problem by re-evaluating the gesture event at GesturePinchBegin. There are few cases to consider 1. The above described case. We will allow scrolling on the y-axis but disallow the pinch zoom when the second finger is touched. 2. It should work with certain embedded map case such as the demo here: http://mustaqahmed.github.io/web/image-panning.html If a user starts with two finger panning the embedded map, then the gesture will be evaluated at GestureScrollBegin and will be disallowed, which means the page will handle the pointer events and manipulate the map. 3. It should work with double-tap-drag-zoom case. In this case, there is no GSB, and when GesturePinchBegin arrives, we evaluate that. Bug: 771330 Change-Id: Ibeaeace11bc017384317f61aabc0f23008ad2b5f Reviewed-on: https://chromium-review.googlesource.com/c/1297070Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#603795}
-
Victor Costan authored
Auto-increment keys represent a challenge in implementations where a central browser process owns the databases' metadata, and multiple renderer processes can access the same database. Specifically, IndexedDB allows application code to start a transaction and queue requests synchronously. So, there is no opportunity for the browser process to pass the current autoincrement key to a renderer process before the renderer processes requests. This situation can be handled by queueing requests, which is complex, or by lazy key injection, which looks easy and thus is quite popular, but has many edge cases. The tests here attempt to exercise all the code paths in lazy key injection that work reasonably well today. The tests do not cover compound indexes that include the primary (autoincrement) key, because that is not handled well in any browser. Bug: 701972 Change-Id: Ibbe38fd173d0821d329cafed449be359e2b33f6e Reviewed-on: https://chromium-review.googlesource.com/c/1304067 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#603794}
-
Sheng-Hao Tsao authored
This CL fixes 2 bugs: 1. Users might pin the internal app to the shelf. Clicking on it would launch a real camera app, causing 2 camera icons shown on the shelf. 2. Users might pin the currently running camera app on the shelf. If the users click on it afterward, it will bypass the internal app deciding logic and always launch that specific app. pinned the internal camera app icon, and launching camera app from it does not show 2 camera icons on shelf. Bug: b:117909556 Test: Tested on eve that pinning camera app on launcher or on shelf both Change-Id: I0300456595e6c4c00c1a47f7a3bc7309d1230553 Reviewed-on: https://chromium-review.googlesource.com/c/1303327 Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#603793}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4a7631f5..16df7066 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0876e0229540bac06da5db94db5050361d96e7ee Reviewed-on: https://chromium-review.googlesource.com/c/1307060Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603792}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f182be28903f..5a5616f3bb3b git log f182be28903f..5a5616f3bb3b --date=short --no-merges --format='%ad %ae %s' 2018-10-29 derat@chromium.org chromeos_config: Run Tast tests on betty-arc64 builders. 2018-10-29 dgarrett@google.com chromeos_config: Simplfy release branch handling. Created with: gclient setdep -r src/third_party/chromite@5a5616f3bb3b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2aba13d8c9d9c9f0f3ab5376da991e8fa6bb70da Reviewed-on: https://chromium-review.googlesource.com/c/1306757Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603791}
-
Tsuyoshi Horo authored
TBR=masonfreed@chromium.org Bug: 891427 Change-Id: Ifaf011a3dcde7f6a0fd4a9f2e5828285c2e08f46 Reviewed-on: https://chromium-review.googlesource.com/c/1306940Reviewed-by:
-
Tsuyoshi Horo authored
TBR=maxmorin@chromium.org Bug: 761214 Change-Id: I73ba6ab6b92ed20349397aa8c6f9c55a5d95ca10 Reviewed-on: https://chromium-review.googlesource.com/c/1307021Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/32abeea1737e..60ca212330e5 Created with: gclient setdep -r src-internal@60ca212330e5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:803846 TBR=mmoss@chromium.org Change-Id: I2ccdb00bb06ae32c68529c01e5402e9cbeb0457c Reviewed-on: https://chromium-review.googlesource.com/c/1306758Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603788}
-
Xiaocheng Hu authored
The two functions are just wrappers of their non-canonical variants. This patch removes them to decrease the usage of VisiblePosition. Bug: 657237 Change-Id: If5e98e66724d45b2b02682f5a1a7d54b09ab73dd Reviewed-on: https://chromium-review.googlesource.com/c/1306838Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#603787}
-
Collin Baker authored
ReopenTabInProductHelp will manage the reopen tab in-product help. It will aggregate user events and kick off the IPH flow at a good time. Bug: 887991 Change-Id: I2b245851bdb6af852cd458a378f3325289922b4c Reviewed-on: https://chromium-review.googlesource.com/c/1299918 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#603786}
-
Steve Kobes authored
Bug: 581518 Change-Id: Ib3f64e7a3d05d9f13b6693361bafc355e4290006 Reviewed-on: https://chromium-review.googlesource.com/c/1294695Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#603785}
-
Tatsuhisa Yamaguchi authored
This change updates tooltip for the latest design spec. The tooltips describe either the number of notifications or being in DnD mode, so that these should work well for a11y label as well. Bug: 888072 Change-Id: Ifed382eca722c6948cf14a9f834ad0bb314c1629 Reviewed-on: https://chromium-review.googlesource.com/c/1306935Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#603784}
-
Amos Lim authored
legend.focus() should not delegate focus. Bug: https://github.com/whatwg/html/issues/3950 Bug: 880026 Change-Id: I35e046e45bbc45628f148383eaa77f12245e9e98 Reviewed-on: https://chromium-review.googlesource.com/c/1304180Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#603783}
-
Xianzhu Wang authored
- Replace EXPECT_DISPLAY_LIST with EXPECT_THAT(display_item_list, ElementsAre(IsSameId(...))) - Define operator<< for DisplayItemClient, DisplayItem::Type, etc. - Let operator<<(const LayoutObject*) output the address to distinguish different objects - Use EXPECT_THAT(paint_chunks, ElementsAre(IsPaintChunk(...), ...))) Change-Id: I4b1d83ca27f218eae110bd3e91fb955e8ac1f656 Reviewed-on: https://chromium-review.googlesource.com/c/1303338Reviewed-by:Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603782}
-
Siddhartha authored
BUG=859260 Change-Id: I23044240996b52cc532de618fa0fef7164713d30 Reviewed-on: https://chromium-review.googlesource.com/c/1233233 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603781}
-
Jazz Xu authored
Change-Id: I9c2ca23a845a17b33d0fd4acb66a28f7f7ddfa5e Reviewed-on: https://chromium-review.googlesource.com/c/1306238Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603780}
-
Findit authored
This reverts commit 133164fc. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 603776 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzEzMzE2NGZjZjQ5MjdkYmU0N2FiMjAwMzc1OGM2ZDM4YmFiODE5MmIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Builder%20%28dbg%29/133426 Sample Failed Step: compile Original change's description: > Convert WebOriginTrials namepsace to a static-only class > > https://www.chromium.org/blink/public-c-api#TOC-Naming > > All public Blink API types and classes are in the namespace blink and > have the prefix Web. > Namespace name should be lower-case but we can't make 'namespace > WebOriginTrials' lower-case because of this naming rule. So we convert > WebOriginTrials to a static-only class. > > Bug: 889726 > Change-Id: Ia2fe9888da297b965d891287f05fb99d45d802f5 > Reviewed-on: https://chromium-review.googlesource.com/c/1304185 > Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603776} Change-Id: I121b4217ed4132d9f739c400950b57b6746e70f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 889726 Reviewed-on: https://chromium-review.googlesource.com/c/1307064 Cr-Commit-Position: refs/heads/master@{#603779}
-
Evan Stade authored
aura::client::kImmersiveFullscreenKey is folded into ash::kImmersiveIsActive No bug here currently, but it's confusing to have two different properties that are both meant to indicate immersive mode is active. Also removed some unnecessary ash:: prefixes from //ash. Change-Id: I0c43873fa8f128c3799d32f2c479a1f2caa9a7cf Reviewed-on: https://chromium-review.googlesource.com/c/1298493Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#603778}
-
Yuzu Saijo authored
Add a new group config name for experiments. Change-Id: I4d522dd54be964958b9e32916523a11322543693 Reviewed-on: https://chromium-review.googlesource.com/c/1303318Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#603777}
-
Zhuoyu Qian authored
https://www.chromium.org/blink/public-c-api#TOC-Naming > All public Blink API types and classes are in the namespace blink and have the prefix Web. Namespace name should be lower-case but we can't make 'namespace WebOriginTrials' lower-case because of this naming rule. So we convert WebOriginTrials to a static-only class. Bug: 889726 Change-Id: Ia2fe9888da297b965d891287f05fb99d45d802f5 Reviewed-on: https://chromium-review.googlesource.com/c/1304185 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: Iddfa7b6912a753878bef0a85510f9b5f4dcc6e4c Reviewed-on: https://chromium-review.googlesource.com/c/1306956Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#603775}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/06305f5d71c7..05e43638cd37 git log 06305f5d71c7..05e43638cd37 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 tsepez@chromium.org Rename two more CJS_PublicMethods methods. Created with: gclient setdep -r src/third_party/pdfium@05e43638cd37 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2eb7c27b45d8ca89236d0fba97228666eb54160c Reviewed-on: https://chromium-review.googlesource.com/c/1307114Reviewed-by:
-
Tetsui Ohkubo authored
This CL removes NotificationTray because now it's replaced by UnifiedSystemTray. This is the part 3 of removing old System Tray (+Notification Tray) code. (1) Removing the flag (2) Removing references to IsSystemTrayUnifiedEnabled() (3) Removing classes that are only used in old System Tray I'll try to keep the number of CLs as small as possible to make the history clean, but there can be multiple CLs for both part 2 and part 3 because some of them requires nontrivial refactoring to remove the dependency to the old code. TEST=trybot pass BUG=898419 Change-Id: I90f2904161aa453a0048947bf22bf31158d9442f Reviewed-on: https://chromium-review.googlesource.com/c/1304184 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/06a4ef497ff1..14768f64fba3 git log 06a4ef497ff1..14768f64fba3 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 caryclark@skia.org update docs for new/changed textblob apis 2018-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4a22f4b04619..3420dcb0cff1 (7 commits) 2018-10-29 brianosman@google.com Keep paint color range/precision into ops and GPs (using GrColor4h) Created with: gclient setdep -r src/third_party/skia@14768f64fba3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I0f05efd8a4977f500acccf8fb18277af6e6775e5 Reviewed-on: https://chromium-review.googlesource.com/c/1306756Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6cf33fa7deb4..32abeea1737e Created with: gclient setdep -r src-internal@32abeea1737e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic257f570a844ecfb2afebd13eff76efc7a5eb72d Reviewed-on: https://chromium-review.googlesource.com/c/1307115Reviewed-by:
-
Toni Barzic authored
This was intended to enable auto-filling network credentials during Chromecast setup, but never actually caught on (i.e. it has not been actually used). BUG=846971 Change-Id: I66e5e316ec91eac0c286f82aa4aad1573ed931f8 Reviewed-on: https://chromium-review.googlesource.com/c/1297407 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
This reverts commit 7b97163e. Reason for revert: Failed ios-device build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-device/103715 Original change's description: > [ios] Drop iOS10 support, move deployment target to iOS11. > > Bug: 894099 > Change-Id: I638bd439a96e105cd33aa858cfd1209ed2ceabc9 > Reviewed-on: https://chromium-review.googlesource.com/c/1297250 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Peter Lee <pkl@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603758} TBR=dpranke@chromium.org,marq@chromium.org,justincohen@chromium.org,pkl@chromium.org,scottmg@chromium.org,jbudorick@chromium.org Change-Id: Id78ea18cc5a77fa7a967867a890dd81a6af5eea6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894099 Reviewed-on: https://chromium-review.googlesource.com/c/1306936Reviewed-by:
-
Oystein Eftevaag authored
The broad strokes behind this CL is that TracedValue now can be supplied with a factory function, which is used to override its backing implementation. When Perfetto is enabled, this is used to let TracedValue write directly to a proto which can then be memcpy'd into the Perfetto shared buffer, rather than being written into a base::Pickle which is then serialized as a JSON strong. Dependent on these CLs landing and rolled into //third_party/perfetto: https://android-review.googlesource.com/c/platform/external/perfetto/+/792813 https://android-review.googlesource.com/c/platform/external/perfetto/+/792814 TBR=csharrison@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2bfa0cd7398a0ac4788c56d5be13fe951dc56770 Reviewed-on: https://chromium-review.googlesource.com/c/1263354Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#603768}
-
Scott Chen authored
Bug: 874122 Change-Id: Ic25e7cf5b0c2d37af4d9ba2af311f9ce0c12e08b Reviewed-on: https://chromium-review.googlesource.com/c/1298616 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#603767}
-
Scott Chen authored
This CL adds the boilerplate codes for browser-testing the onboarding welcome UI, and one simple test to verify it works. There will be follow-up CLs to add more browser tests to all onboarding welcome elements. Bug: 881937 Change-Id: I1c1d33411ad55eff5fd4ab43bd3cc1b93a257d3e Reviewed-on: https://chromium-review.googlesource.com/c/1300673 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ied5535100c5612069aeae967095b2c732f68c159 Reviewed-on: https://chromium-review.googlesource.com/c/1306642Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#603765}
-
Tetsui Ohkubo authored
According to UX spec, check icon shown on the right side of a11y detailed view is 28994F. This change is important in terms of color contrast. TEST=manual BUG=899162 Change-Id: Idd32cbf94d974355a6229ef7bb88e9ae714ab97c Reviewed-on: https://chromium-review.googlesource.com/c/1304284Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#603764}
-
Bailey Berro authored
This is the first in a series of changes to create a freeform dialog for adding an SMB share in addition to the dialog existing in settings. - Moves add_smb_share dialog to cr_components - Switches $i18n{} to i18n() - Updates BUILD files Bug: chromium:887135 Test: verified on test device Change-Id: I1133d9e45ee7ac63e338e22e4e69e3e000a3ee02 Reviewed-on: https://chromium-review.googlesource.com/c/1281868 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#603763}
-
Yuri Wiitala authored
Adds the implementation that determines which shader programs to use, and in what order, to execute scaling and format conversion. Also, adds pixel tests to check all the various features provided by GLScaler (via its Parameters). Bug: 870036 Change-Id: I7cb1d64d6df79a3a6221c2ab6cdf4b504b26c5b1 Reviewed-on: https://chromium-review.googlesource.com/c/1298737 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
Hector Carmona authored
Both the email and google app modules will show the bookmark bar. This change makes it so that the state of the bookmark bar is returned to the way it was before it was shown if no bookmarks are added. R=scottchen@chromium.org Bug: 881937 Change-Id: I64d0a03f6747589d594720dad406e14ee4483ca8 Reviewed-on: https://chromium-review.googlesource.com/c/1302316 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#603761}
-
