GitLab

This forces WeakPtrs to be invalidated before other members' destructors run.
See the bug or the documentation of WeakPtrFactory for more information. I'm
in the process of trying to turn on a clang check for this (see the bug).

BUG=303818
TBR=qinmin@chromium.org

Review URL: https://codereview.chromium.org/841453006

Cr-Commit-Position: refs/heads/master@{#311506}

BUG=401598
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/806693009

Cr-Commit-Position: refs/heads/master@{#311505}

Set max_num_reorder_frames to allow the decoder to output pictures early.

BUG=446627
TEST=video_encode_accelerator_unittest

Review URL: https://codereview.chromium.org/794433005

Cr-Commit-Position: refs/heads/master@{#311504}

This will allow to re-create gesture provider with different configs,
as requested by the user.

BUG=425586

Review URL: https://codereview.chromium.org/820053002

Cr-Commit-Position: refs/heads/master@{#311503}

BUG=137652, 146944
R=jschuh@chromium.org

Review URL: https://codereview.chromium.org/854503002

Cr-Commit-Position: refs/heads/master@{#311502}

BUG=447695
TEST=NONE

Review URL: https://codereview.chromium.org/846663003

Cr-Commit-Position: refs/heads/master@{#311501}

This to prevent click-jacking using an option popup list that becomes persistent.

BUG=448008

Review URL: https://codereview.chromium.org/839573002

Cr-Commit-Position: refs/heads/master@{#311500}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8018e68..b47bba7

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/852773002

Cr-Commit-Position: refs/heads/master@{#311499}

The ImportTask appears to be firing a final progress event after the success event has been fired; this is causing the UI to pop up a zombie import-related progress notification that never goes away.  Fix by preventing the task from emitting further notifications once it's successfully completed.

BUG=420680

Review URL: https://codereview.chromium.org/839473006

Cr-Commit-Position: refs/heads/master@{#311498}

Some initial messages may get routed to main thread. Once we get
our first message on io, send it to main to ensure all prior main
thread operations are finished before we continue on io.

BUG=446184

Review URL: https://codereview.chromium.org/801233003

Cr-Commit-Position: refs/heads/master@{#311497}

BUG=

Review URL: https://codereview.chromium.org/834173006

Cr-Commit-Position: refs/heads/master@{#311496}

Revert of NaCl: Remove reliance on "init_done" SRPC call in the non-PNaCl case (patchset #4 id:60001 of https://codereview.chromium.org/849523002/)

Reason for revert:
The change appears to cause NaClBrowserTestNewlib.Bad to become flaky.

The flakiness was reported in:
BUG=448596

Original change description:
> NaCl: Remove reliance on "init_done" SRPC call in the non-PNaCl case
>
> We can remove Plugin::NexeFileDidOpenContinuation(), which gets called
> via the "init_done" SRPC call (which calls
> StartupInitializationComplete() in plugin/service_runtime.cc).
>
> Its work gets done by the newer
> ManifestServiceProxy::StartupInitializationComplete() in
> components/nacl/renderer/ppb_nacl_private_impl.cc, which gets called
> via Chrome IPC (by the "PpapiHostMsg_StartupInitializationComplete"
> message).
>
> ppapi_dispatcher.cc: In order to keep the error handling tests in
> NaClBrowserTestNewlib.Bad passing, send the
> StartupInitializationComplete message earlier, before we call
> PPP_InitializeModule().  This ensures that crashes in
> PPP_InitializeModule() are reported properly.
>
> Note that PNaCl still relies on "init_done" for now.
>
> BUG=428030
> BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864
>
> Committed: https://crrev.com/4c03d4d0964b0b69f5741aac6c78557b415617e1
> Cr-Commit-Position: refs/heads/master@{#311298}

BUG=428030
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864

Review URL: https://codereview.chromium.org/793723006

Cr-Commit-Position: refs/heads/master@{#311495}

http://www.reactiongifs.com/r/kerm.gif

BUG=NONE

Review URL: https://codereview.chromium.org/810453005

Cr-Commit-Position: refs/heads/master@{#311494}

In preparation of moving the clang/win bots to recipes.

This list is intended to match win_clang_tests in
masters/master.chromium.fyi/master.cfg

BUG=446368
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/854523002

Cr-Commit-Position: refs/heads/master@{#311493}

BUG=448707

Review URL: https://codereview.chromium.org/818773005

Cr-Commit-Position: refs/heads/master@{#311492}

This allows PictureImageLayers to be rendered when running with
--enable-slimming-paint.

BUG=448447

Review URL: https://codereview.chromium.org/853463004

Cr-Commit-Position: refs/heads/master@{#311491}

- Produce nacl_helper_nonsfi binary in out/{Debug,Release}
- Enable all transitional non-SFI browser tests on ARM

BUG=433201, 372049
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_arm

Review URL: https://codereview.chromium.org/794573002

Cr-Commit-Position: refs/heads/master@{#311490}

Pulls in the following changes:

 f731837 - Fix v8 external snapshot code for Windows.
 7900739 - Merge to master: Fix include paths for pdfium_unittests under chromium checkout
 476cd69 - Add APIs for getting bookmarks and named destinations.

BUG=421063, 439661

Review URL: https://codereview.chromium.org/850043003

Cr-Commit-Position: refs/heads/master@{#311489}

embedded webview.  The length of the string was not correctly calculated.

BUG=None

Review URL: https://codereview.chromium.org/848943003

Cr-Commit-Position: refs/heads/master@{#311488}

This code was leading to a crash:
scoped_nsobject<MyClass> a([[MyClass alloc] init]);
scoped_nsobject<NSObject> b(a);

Because |a| is converted to raw pointer, and |b| is constructed with the
raw pointer, without calling retain. This creates a subtle crash later on
when the scoped_nsobject are destroyed.

This code however, was not crashing:
scoped_nsobject<MyClass> b(a);
Because in that case the copy constructor is used.

This was somewhat inconsistent and bug prone, especially if the type of
|a| is changed. In that case the type of |b| must be changed at the same
time, or it causes a crash.

This CL introduces a new constructor for the scoped_nsobject variants
that allows passing a scoped_nsobject of a different type.
It is consistent with scoped_refptr which also has this constructor.

Review URL: https://codereview.chromium.org/848033006

Cr-Commit-Position: refs/heads/master@{#311487}

BUG=

Review URL: https://codereview.chromium.org/816833006

Cr-Commit-Position: refs/heads/master@{#311486}

Replaces the outdated Kittens tutorial with a new getting started tutorial that uses the Google Image search API.

BUG=383385
NOTRY=true
R=kalman@chromium.org,mkearney@chromium.org

Review URL: https://codereview.chromium.org/732943002

Cr-Commit-Position: refs/heads/master@{#311485}

In the past Chrome for Android developers have excluded this directory using
src/.git/info/exclude or simply ignored it.

It's time to add it to .gitignore, since we already have
/third_party/android_tools_internal in there, and the codename isn't public
(https://plus.google.com/+FrancoisBeaufort/posts/AJwwscC1KxN).

Review URL: https://codereview.chromium.org/815353004

Cr-Commit-Position: refs/heads/master@{#311484}

Review URL: https://codereview.chromium.org/796063005

Cr-Commit-Position: refs/heads/master@{#311483}

The patch is to be reverted a few days later when we have a crash report with the new stack trace.

BUG=396900

Review URL: https://codereview.chromium.org/854593002

Cr-Commit-Position: refs/heads/master@{#311482}

BUG=446607

Review URL: https://codereview.chromium.org/839063003

Cr-Commit-Position: refs/heads/master@{#311481}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/26a00de..8018e68

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/817793005

Cr-Commit-Position: refs/heads/master@{#311480}

Update the AOSP prebuilts/ndk target to include fixes necessary to use
libc++ <atomic> on Android.

BUG=427718

Review URL: https://codereview.chromium.org/846633003

Cr-Commit-Position: refs/heads/master@{#311479}

Review URL: https://codereview.chromium.org/850923002

Cr-Commit-Position: refs/heads/master@{#311478}

None of these changes should change the behaviour of the
scripts with the exception of rst_index.py which now takes
both output and input as positional parameters since they
are both required.

TEST=./test_all.py

Review URL: https://codereview.chromium.org/720233003

Cr-Commit-Position: refs/heads/master@{#311477}

The deletions-only check is causing a lot of issues with the upstreaming
effort, so I'm disabling it temporarily.

BUG=

Review URL: https://codereview.chromium.org/820053003

Cr-Commit-Position: refs/heads/master@{#311476}

BUG=366349

Review URL: https://codereview.chromium.org/829133009

Cr-Commit-Position: refs/heads/master@{#311475}

BUG=443613
R=sergiyb@chromium.org

Review URL: https://codereview.chromium.org/844263005

Cr-Commit-Position: refs/heads/master@{#311474}

Add a virtual destructor since all class with a virtual method should
have a virtual destructor.

Disable copy constructor and assignment operator using the macro
DISALLOW_COPY_AND_ASSIGN since you don't want to do slicing when
using a class with virtual methods.

BUG=None

Review URL: https://codereview.chromium.org/853643003

Cr-Commit-Position: refs/heads/master@{#311473}

Blink team is planning to move DOM attributes into prototype chains.
DOM attributes will no longer be accessible as Object properties, e.g.
JSON.stringify will not see DOM attributes.  So WebRTC tests shouldn't
expect that they can stringify DOM attributes.

Fixes tests not to directly stringify DOM objects.

BUG=43394

Review URL: https://codereview.chromium.org/811653007

Cr-Commit-Position: refs/heads/master@{#311472}

This patch updates the Chromium side of the Blink platform changes,
removing method variants we no longer use, and converting the whole
thing to work on hostnames rather than WebURL/WebSecurityOrigin.

Patch 1 - Blink:    https://codereview.chromium.org/845303003
Patch 2 - Chromium: [THIS PATCH]

BUG=378566
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/852573002

Cr-Commit-Position: refs/heads/master@{#311471}

Cr-Commit-Position: refs/heads/master@{#311470}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5736df6..33868e6

TBR=zmo@chromium.org,yutak@chromium.org

Review URL: https://codereview.chromium.org/853673002

Cr-Commit-Position: refs/heads/master@{#311469}

SkCanvasVideoRenderer assumes that the VideoFrames belonging to one WebRTC
video are always either software VideoFrame or hardware VideoFrame.
However, it's not true. VideoFrame can be changed each frame.

TEST=content_browsertests WebRtcBrowserTest.CallAndVerify* on Nexus5
BUG=448014

Review URL: https://codereview.chromium.org/848683003

Cr-Commit-Position: refs/heads/master@{#311468}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/853663002

Cr-Commit-Position: refs/heads/master@{#311467}