GitLab

Previously, text output for time intervals always was rounded
down. For example, a time interval of 1 min 59 sec was
displayed as "1 min", which was confusing users in some cases.
This CL implements rounding to nearest integer. Some example
outputs are given below.

0.49 sec --> "0 secs"
0.5  sec --> "1 sec"
59.4 sec --> "59 secs"
59.5 sec --> "1 min"
89.9 sec --> "1 min"
90.0 sec --> "2 mins"
59 min   --> "59 mins"
60 min   --> "1 hour"
89 min   --> "1 hour"
90 min   --> "2 hours"
...

BUG=338631
TEST=unit tests updated

Review URL: https://codereview.chromium.org/143633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247948 0039d316-1c4b-4281-b951-d872f2087c98

Simplify and combine Dispatch{,Fabricated}KeyEventPostIME methods into one method.

TEST=Run unit_tests, ui_unittests, views_unittests.
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/142043006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247947 0039d316-1c4b-4281-b951-d872f2087c98

Previously DriveSyncHandler#updateItem_ is called for 'in_progress' events and
DriveSyncHandler#removeItem_ is called for 'completed' events.

We should do updateItem_ and removeItem_ in this order but sometimes removeItem_
calls before updateItem_ is done becuase updateItem_ needs asynchronous
opeartion.

This CL serializes function calls of updateItem_ and removeItem_ by using
Promise.

BUG=339046
TEST=manually

Review URL: https://codereview.chromium.org/136783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247946 0039d316-1c4b-4281-b951-d872f2087c98

Removed preferences include:
- flag for incognito mode -- hotwording is now always off in incognito
- flag for 5 minute timeout -- hotwording now always times out after 5 minutes

Cleanup includes:
- Moved the pref from Search to Privacy
- Added confirm bubble for clicking the pref which adds hotword_confirm_overlay.{html,css}
- Changed the wording for the description (also added strings for the confirm/cancel buttons)


BUG=325439, 289023

Review URL: https://codereview.chromium.org/136693013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247945 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247944 0039d316-1c4b-4281-b951-d872f2087c98

Chromium base revision: 247811 / e5fca450
Old Skia revision: 13227
New Skia revision: 13235
Control CL: https://codereview.chromium.org/148383016

This CL was created by Skia's roll_deps.py script.

Bypassing commit queue trybots:
NOTRY=true
R=rmistry@google.com

Review URL: https://codereview.chromium.org/149053007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247943 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247942 0039d316-1c4b-4281-b951-d872f2087c98

A newly initialized media player must enter fullscreen if there is a
pending request sent by a previous media player.

BUG=338670

Review URL: https://codereview.chromium.org/136113015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247941 0039d316-1c4b-4281-b951-d872f2087c98

It's already part of history items, so we should persist it.

BUG=334125
R=marja@chromium.org

Review URL: https://codereview.chromium.org/134813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247940 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dglazkov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/148223017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247939 0039d316-1c4b-4281-b951-d872f2087c98

Currently Guest mode always uses default value of
Preferences.PreferredInputMethod = "" (empty string) that
always leads to "us" keyboard layout (compiled-in default).

Guest sessions should have the following input methods/keyboards readily
available:
 - the VPD value (assuming the latin keyboard representing the underlying
   hardware; should be the default; e.g. French chromebook => azerty)
 - the additional input method/keyboard based on the locale (e.g. Japanese
   locale => should also add the Japanese IME; there are existing rules for
   this)


BUG=329018
TEST=unittest

Review URL: https://codereview.chromium.org/133273032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247938 0039d316-1c4b-4281-b951-d872f2087c98

This cl rename MediaStreamSourceExtraData to MediaStreamSource. This class is used as a common base class for MediaStreamAudioSource and MediaStreamVideoSource.

Further more it adds a specialization MediaStreamVideoSource called MediaStreamVideoCaptureDeviceSource. This is used for 
local video source such that can be created used GetUserMedia.

The cl hooks up the above classes to MediaStreamImpl to make sure they are used when gUM i used from JS.

BUG=334241

TBR jam for content_renderer.gypi
TBR=jam

Review URL: https://codereview.chromium.org/131763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247937 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313751
R=glider@chromium.org

Review URL: https://codereview.chromium.org/149433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247936 0039d316-1c4b-4281-b951-d872f2087c98

Breaks CrOS buildbots

http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28daisy%29&number=16073
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28amd64%29&number=13917
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Chromium%20OS%20%28x86%29%20ASAN&number=8064

> HID backend
> 
> BUG=290428
> 
> Review URL: https://codereview.chromium.org/143883005

TBR=ikarienator@chromium.org

Review URL: https://codereview.chromium.org/148183015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247934 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326023

Review URL: https://codereview.chromium.org/149463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247933 0039d316-1c4b-4281-b951-d872f2087c98

Split LoaderController from ChangeListLoader.
SearchOperation obeys LoaderController.

BUG=260539
TEST=unit_tests

Review URL: https://codereview.chromium.org/150113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247932 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331988

Review URL: https://codereview.chromium.org/150043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247931 0039d316-1c4b-4281-b951-d872f2087c98

This prevents us getting stuck in smoothness mode if the embedding application
inhibits the View.computeScroll callback.

BUG=339245

Review URL: https://codereview.chromium.org/149963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247930 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247929 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/149413009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247928 0039d316-1c4b-4281-b951-d872f2087c98

The plan:
- mojo/public/{subdir} contains public headers and scripts (if any).
- mojo/public/{subdir}/lib contains private headers and .cc files (if any).
- mojo/public/{subdir}/tests contains test files.

Also, as part of this CL:

1- I simplified the TLS implementation in utility and hid it as an internal API. I'm not happy providing the API to third-parties as is. It was really intended to be used with LazyInstance, etc. Without that there is some subtlety with setup and teardown of the TLS slot. Hiding it avoids having to deal with this for now.

2- Deleted thread_local_unittest.cc as that was still coded against base/threading/thread_local.h (oops)! Besides that this test has a large dependency on base threading and synchronization primitives. It also isn't that useful to test our wrappers for TLS as they are such thin wrappers around the OS provided APIs.

3- Renamed environment/standalone to environment/lib for consistency. From the point of view of a third-party, lib is the better name for this directory.

Review URL: https://codereview.chromium.org/148013006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247927 0039d316-1c4b-4281-b951-d872f2087c98

BUG=290428

Review URL: https://codereview.chromium.org/143883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247926 0039d316-1c4b-4281-b951-d872f2087c98

It is necessary that the context created by copyCGLContextForPixelFormat
have a pixel format compatible with the one created by
copyCGLPixelFormatForDisplayMask. In particular, make
copyCGLPixelFormatForDisplayMask create the CGL equivalent of the pixel
format created in CompositingIOSurfaceContext.

BUG=338925

Review URL: https://codereview.chromium.org/142413008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247925 0039d316-1c4b-4281-b951-d872f2087c98

Its okay for a trace to come back with no data in it. Right now,
this actually causes catastrophic failure.

R=tonyg

Review URL: https://codereview.chromium.org/141553009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247924 0039d316-1c4b-4281-b951-d872f2087c98

[Hotword] Set up hotwording to be externally loaded component extension. Only load if the field trial is correct and if they use "en" language since it is only available for English at this time.

BUG=325439, 289023

Review URL: https://codereview.chromium.org/141013015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247923 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586
TBR=finnur, ajuma, thakis, atwilson

Review URL: https://codereview.chromium.org/131503015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247922 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247921 0039d316-1c4b-4281-b951-d872f2087c98

As part of effort to support multiple fonts, this CL changes methods which are now taking gfx::Font so they will take gfx::FontList instead.

See https://docs.google.com/a/chromium.org/document/d/1D_25fp9B8b9aZJORfAjDIFq61NWvUquZ5xmKH-VcC4k/view

BUG=265485
TEST=Run unit_tests, ui_unittests, views_unittests.

Review URL: https://codereview.chromium.org/149383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247920 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=166036:166074&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/149213007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247919 0039d316-1c4b-4281-b951-d872f2087c98

BUG=337998

Review URL: https://codereview.chromium.org/148273010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247918 0039d316-1c4b-4281-b951-d872f2087c98

WebContentsImpl's dtor calls End() but it may not cause
set_listener(NULL) in some case, which may cause a use-after-free.

This CL always reset them at End(). This would mean
DidEndColorChooser() may be called twice, so web_contents_
has to be reset to NULL once DidEndColorChooser() is called.

BUG=338464
R=keishi@chromium.org

Review URL: https://codereview.chromium.org/148223009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247917 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/144633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247915 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/148283009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247913 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330567
TEST=TBD

Review URL: https://codereview.chromium.org/144423006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247912 0039d316-1c4b-4281-b951-d872f2087c98

When parsing tracing data into timeline model, also find the browser
process and save it into timeline model. This is to support querying
async slices starting in browser process.

BUG=246034
TEST=Run telemetry smoothness test and make sure input latency trace
     can be retrieved from querying async slices on browser process.

Review URL: https://codereview.chromium.org/144423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247911 0039d316-1c4b-4281-b951-d872f2087c98

- the bottom options buttons get a blue background when hovered over
- corrected the spacing between a button's image and its title.
- s/makeAccountButtonWithRect/accountButtonWithRect/g to be 
consistent with the other control-making methods.

Screenshot: https://drive.google.com/file/d/0B1B1Up4p2NRMeERscUNleHNMWWc/edit?usp=sharing

BUG=324036

Review URL: https://codereview.chromium.org/132903016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247910 0039d316-1c4b-4281-b951-d872f2087c98

This cl is pure style-targeted refactoring. 
No functional changes were made. 

BUG=339176

Review URL: https://codereview.chromium.org/149093008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247909 0039d316-1c4b-4281-b951-d872f2087c98

This cl is pure style-targeted refactoring.
No functional changes were made.

BUG=339176

Review URL: https://codereview.chromium.org/149703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247908 0039d316-1c4b-4281-b951-d872f2087c98

This cl is pure style-targeted refactoring. 
No functional changes were made. 

BUG=339176

Review URL: https://codereview.chromium.org/149253008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247907 0039d316-1c4b-4281-b951-d872f2087c98

When relaunching from Metro there is a lengthier time-window where
BrowserProcess::IsShuttingDown() is false, but 
browser_shutdown::IsTryingToQuit() is true. If the app launcher delayed
warmup (and the non-delayed asynchronous profile load it triggers) is
unlucky enough to get scheduled here, then it can create a window after
Widget::CloseAllSecondaryWidgets() has been called on the shutdown path,
which otherwise would have mopped up the app launcher resources.

Checking browser_shutdown::IsTryingToQuit ensures the app launcher
window won't be created after Widget::CloseAllSecondaryWidgets() would
have been called during shutdown.

BUG=333350

Review URL: https://codereview.chromium.org/149323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247906 0039d316-1c4b-4281-b951-d872f2087c98