- 20 Aug, 2020 40 commits
-
-
Harald Alvestrand authored
Bug: chromium:1115080 Change-Id: Ide2eceb4240d1e6bdf0fa9beaf1058428fab510d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367077Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#800226}
-
Eric Orth authored
This config option controls behavior that doesn't really match the name or description, and nothing ever sets the option to non-default (false), making half the controlled behavior dead code. Bug: 1116579 Change-Id: Ic4c1d4e45b5cb4de74ff5b9cec788e3a1855d0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357930 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#800225}
-
Fred Mello authored
The Clank team is reviewing the ownership of all `/android` directories and adding/updating OWNERS as part of an effort to normalize code health metrics across different data sources. https://docs.google.com/document/d/1wNj7dGIbSyISw1cyVSEnzt7woRydU2CBqVmWvUGTT44 Bug: 1112872 Change-Id: I4d211238862c74c79a897d8d28210fc17df33413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367433 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#800224}
-
Alexander Dunaev authored
Ozone/X11 already initialises the touch device list in OzonePlatformX11::InitializeUI(), where it does the same call as StartupBrowserCreator::ProcessCmdLineImpl(), but the latter had an UNIMPLEMENTED_LOG_ONCE macro and a TODO for supporting the feature on Ozone. This CL cleans the code a bit. Bug: 1097696 Change-Id: I74c67be4d6f6ef8e1f9379463c0cb96187f1b0f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367058 Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#800223}
-
Nicolas Ouellet-Payeur authored
The unique_id_hash_code field did not match the annotation's unique_id, which caused some issues for our buildbots. TBR=rhalavati@chromium.org Bug: 1119509 Change-Id: I224b57669717782352c2192416c5fdc817db718e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367493 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#800222}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/93a9d19d4eb5..6a9a910fd2c3 2020-08-20 handellm@webrtc.org AudioDeviceWindowsCore: fix mutex recursion. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I50a3dace0368ed0c20e067620f737941e258fbcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367175Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800221}
-
Peter E Conn authored
Android service calls propagate exceptions, so an exception in the TWA client would be passed over and thrown in Chrome. We don't want a broken client to be able to crash Chrome, so catch any and all exceptions. Change-Id: I06025d32505fcc7bd96da70b19ca50b0ddebe54a Bug: 1096428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367066 Commit-Queue: Peter Conn <peconn@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Auto-Submit: Peter Conn <peconn@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#800220}
-
Dana Fried authored
See bug for details. This was causing e.g. Zoom bubble to display hanging off the side of the screen and/or partially occluded. Bug: 1117361 Change-Id: If5f56c29cf96c021934679649a1ec058c33acc19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365917Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#800219}
-
Dan Harrington authored
Bug: b/165288064, 1117571 Change-Id: Id7d98858484644044c5ac6da8714541a0eae0d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363388Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#800218}
-
Jana Grill authored
When the DeviceReleaseLtsTag policy is set, display a different text in Chrome OS settings to tell the user that they are currently using a long-term support (LTS) build. Additonally add the LTS-specific text to "Channel" entry when Build Details are copied to clipboard. Note: For the LTS pilot, we only check whether the DeviceReleaseLtsTag policy is set and do not consider the value it is set to. This will change for future LTS releases once the exact value is decided on. Bug: 1105495 Change-Id: Ic1c11e14e690de8ab900337c81487d931ba9fd32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355925Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Victor-Gabriel Savu <vsavu@google.com> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#800217}
-
sczs authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios.git/+log/70d7a73cb4be..915bc063fbbf $ git log 70d7a73cb..915bc063f --date=short --no-merges --format='%ad %ae %s' 2020-08-18 afweiss Update accessibility logic when switching selected view controllers so that VoiceOver will always switch to a new element visible on screen 2020-08-17 yar Bumped version number to 113.1.0. 2020-08-17 yar Hand-modified CHANGELOG.md API diff. 2020-08-17 yar Automatic changelog preparation for release. 2020-08-17 no-reply [MDCBottomDrawerViewController] Adds shouldDisplayMobileLandscapeFullscreen property to MDCBottomDrawerViewController. 2020-08-17 yar [TabBarView] Adds Large Content Viewer support to MDCTabBarView. 2020-08-17 no-reply [ButtonBar] Removes nullability modifiers from file. 2020-08-17 featherless [Snackbar] Deprecate remaining class methods on MDCSnackbarManager. 2020-08-17 yar [ButtonBar] Fall back to accessibilityLabel for UILargeContentView when there is an image and no title. 2020-08-14 featherless [BottomAppBar] Fix bug where FAB shadow would "bounce" when the position changed. 2020-08-14 andrewoverton [BottomNavigation] Move MDCBottomNavigationBarController to main podspec 2020-08-14 featherless [TabBarView] Animate text and icon colors when switching tabs. 2020-08-14 yar [ButtonBar] Adds Large Content Viewer support to MDCButtonBar, MDCNavigationBar, and MDCAppBar. Created with: roll-dep src/ios/third_party/material_components_ios/src Change-Id: I7dce6b1dc0b038f74df2b2ed1df642c572ec415c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364660 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#800216}
-
Sergey Ulanov authored
On some devices MojoVideoCapture feature may need to be disabled in order to save the memory required by the video_capture process. The new test allows to verify that this configuration works as expected. Bug: fuchsia:53041 Change-Id: Ie72bc03da4429fd070649b85d62e63493b470caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363690 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#800215}
-
Sahel Sharify authored
skipped_payment_request_ui_ should be false for SPC since Chrome's UI is shown for the payment request. Bug: 1117042 Change-Id: I1c7c4ff612e112d792ffc50ef9b161405c46ac12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365979Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#800214}
-
Henrique Ferreiro authored
This CL adds the equivalent to k{Min,Max}Value from the C++ bindings to the Java bindings as {MIN,MAX}_VALUE, and ports ReferrerPolicy to use it allowing the removal of kLast in referrer_policy.mojom. Bug: 1114575 Change-Id: Ie9321f6a251b352e57e27d8a17d565c70c3a8d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343028Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#800213}
-
Alice Wang authored
This CL sets up the UI for sign-in auth error in the web sign-in bottom sheet. The specific strings and auth error handling will be added in the subsequent CLs. Bug: 1116952 Change-Id: Ib9160d251f6c0e516af2805b2e346e08320bda96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366722Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#800212}
-
Moe Ahmadi authored
Invalid duplicates are those search terms extracted from search query URLs which are identical or nearly identical to the original search query URL and issued too closely to it. They are typically recorded as a result of back/forward navigations or user interactions in the search result page and are likely not newly initiated searches. With frecency ranking, these duplicates must be ignored or they will erroneously boost those queries. For the purpose of local history ZPS, a duplicated query issued within 5 minutes of the original query is considered an invalid duplicate. Bug: 1108531,1096615 Change-Id: I7855c0b72ee47d7a55bc77315734e7e48c2df355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337676Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#800211}
-
chrome://nearby-internalsRyan Hansberry authored
Also add necessary doc header to ../logging.h. Change-Id: I0ce55ea6804296e8bb1b66f47b91bbb16e1f198a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364578Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#800210}
-
yilkal authored
This cl enabled EDUCoexistence for ARC++ by default. Bug: 1101622 Change-Id: I975c20da5ed73e058f1bb7903fc675df27faabaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366155Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#800209}
-
dpapad authored
Fixed: 1114268 Change-Id: I9e9c81e53696ff6436c2ce7999067cd213a40191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366673 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#800208}
-
Daniel Nicoara authored
Each WebContents can have an arbitrary number of RenderViewHosts. Since each RenderViewHost would re-configure their WebPreferences, cast webviews need to cache the user-configured preferences such that they can be applied to new RenderViewHosts. Bug: b/163595220 Test: On device load page with autoplay video. Change-Id: I546f80a7271204aa2c5ee5939054bc949044d977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366474Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#800207}
-
Caleb Raitto authored
Bug: 973801 Change-Id: I737230362b82edd24616197f540ffe330b72c66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363814Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#800206}
-
Xianzhu Wang authored
This is like we avoid reraster for scale change during pinch gesture unless the scale is too different. Also allow recreation of high res tiling if it doesn't contain any tile or we are going to invalidate the tiles. This fixes performance regression of pinch perf tests caused by crrev.com/c/2351164. Bug: 1117479 Change-Id: Ifc7979af81aa76b0214fda7dc2340be76ae63046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364583Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800205}
-
Eleonora Rocchi authored
This CL add the update of the status header if the compromised credentials shown have been updated. Bug: 1117543, 1092444 Change-Id: I8dbf4210385bfc3c0842c55b65913fe15be1e3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366725 Commit-Queue: Eleonora Rocchi <erocchi@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#800204}
-
Andrew Grieve authored
#1 - Ignore XML namespaces when sorting See https://chromium-review.googlesource.com/c/chromium/src/+/2321522 for an example of where this was causing them to change order. #2 - Prefer to sort by android:name when present Prevents order change when attributes are added/removed. #3 - Don't sort top-level nodes reversed (other than <application>) Bug: 1064151 Change-Id: If552c2c2baa1f538a00d9ddfa3ead6feb19ce6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366038 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#800203}
-
Alice Wang authored
This CL destroys the WebSigninBridge object when signin failed and adds tests for it. Bug: 1117471 Change-Id: I5f8ead25dd03f6f863782ec039b7d84abae3e46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366933Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#800202}
-
Lan Wei authored
When we are using PerformActions from ChromeDriver to simulate three mouse click, it only set the click count to 2, not 3, so this test fails third_party/blink/web_tests/external/wpt/webdriver/tests/perform_actions /pointer_tripleclick.py. PerformActions should keep the mouse click count and decide if we should increase the count or set to 1 when we have a mouse press based on the interval of two mouse presses and difference between the current mouse positions and the last one. Bug: 1119679 Change-Id: I2b941c5d295cdd457109c8866c55e02bb2360555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366655Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#800201}
-
Tina Wang authored
The condition of showing the secondary message was set incorrectly. Bug: 1119859 Change-Id: Ifddaa442877f5219571b0fac0971a370be4e7303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366116 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#800200}
-
Ella Ge authored
It should be "Digital asset link". TBR=peconn@chromium.org Bug: 1109609 Change-Id: I59b5eb75493bdf884308ea98fcd7404ade060e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366285Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Auto-Submit: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#800199}
-
Caroline Rising authored
Create new mojom API to communicate between web ui and the browser process. Add ReadLaterPage handler which implements the read_later.mojom interface and ReadLaterUI. Bug: 1109316 Change-Id: Icc9b567bc7b1486f9a295c6e8f66a843190ee912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349981 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#800198}
-
Russ Hamilton authored
This method is needed so that we can leverage the filter for rate-limiting and deduplicating metrics on a per-report basis. Bug: 1112787 Change-Id: I230f06eff4c00479387ad1dcc88bf51a3a2034e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363688Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/master@{#800197}
-
Lei Zhang authored
OS_APPLE means OS_MAC or OS_IOS. Since OS_IOS is disallowed in chrome/, it makes more sense to use OS_MAC in chrome/ instead of OS_APPLE. Replace existing OS_APPLE usage with OS_MAC, and add a presubmit to check for OS_APPLE usage. Change-Id: I539f062f5f82a93dcbd861501421977e4f027517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365434Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#800196}
-
Evan Stade authored
Regressed in f0fc9ffb. activity_bar_activity_bg.xml can be removed completely as it only existed for a pre-K workaround. Bug: 1119675 Change-Id: I9c22de1e769c743600afe4fa1a8de8cd9913ea19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366573 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#800195}
-
Garrett Beaty authored
Bug: 1109276 Change-Id: I29c127303dfd816f5237bf3ea05cb4bb9a40cf87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364821Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#800194}
-
Liviu Tinta authored
During ScrollUnification, scrolling was moved to the compositor thread. CompositedScrollingMetricTest tests need to be updated to reflect this so they pass when the ScrollUnification flag is on. Bug: 1086625 Change-Id: Ib70f4830d8007463228f9dd9b1ac41318b4bada9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364055 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800193}
-
Tanmoy Mollik authored
This cl creates the SyncErrorCardPreference and resources that will be used by ManageSyncSettings. The onClickListeners for the buttons in the preference will be added on a separate cl. The button clicks will be handled by ManageSyncSettings. Screenshot: https://crbug.com/1107420#c2 Bug: 1107420 Change-Id: I13b22baefee474051cbb779c6eecfe4c40e3cb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339323 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#800192}
-
Yifan Luo authored
This CL intends to create a prototyping Sanitizer API (https://github.com/WICG/sanitizer-api) at very beginning level. Change-Id: I7327a3440d544b61becd81f4c9b058ee4823ffc4 Bug: 1116418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346252 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#800191}
-
Jose Dapena Paz authored
These operators fail to build in GCC as the mojo StructPtr operator-> is not constexpr either: ../../components/performance_manager/v8_memory/v8_per_frame_memory_decorator.cc:60:13: error: call to non-‘constexpr’ function ‘mojo::StructPtr<S>::Struct* mojo::StructPtr<S>::operator->() const [with S = blink::mojom::PerFrameV8MemoryUsageData; mojo::StructPtr<S>::Struct = blink::mojom::PerFrameV8MemoryUsageData]’ 60 | return a->frame_token < b->frame_token; | ^~ ../../components/performance_manager/v8_memory/v8_per_frame_memory_decorator.cc: In member function ‘constexpr bool performance_manager::v8_memory::{anonymous}::SortByToken::operator()(const PerFrameUsagePtr&, const LocalFrameToken&)’: ../../components/performance_manager/v8_memory/v8_per_frame_memory_decorator.cc:65:13: error: call to non-‘constexpr’ function ‘mojo::StructPtr<S>::Struct* mojo::StructPtr<S>::operator->() const [with S = blink::mojom::PerFrameV8MemoryUsageData; mojo::StructPtr<S>::Struct = blink::mojom::PerFrameV8MemoryUsageData]’ 65 | return a->frame_token < b.value(); | ^~ Bug: 819294 Change-Id: I4dbd8ee5f1f4b00b19a21777c4c8c93fdd7f6f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367038Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#800190}
-
Mason Freed authored
This previously had no use counter. I'm adding NOTRY here because branch day seems to be an impossible day to land changes to enums.xml. Hopefully this sails through. Feel free to revert if this breaks something. NOTRY=true Bug: 905922 Change-Id: I613782dc839a9afc9bce93406200557e4f81c024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363361 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#800189}
-
bttk authored
Bug: 1067118 Change-Id: Ieaa8deb577c0b7bfc55c3d6999b4ebcabfe96808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363223Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Auto-Submit: who/bttk <bttk@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#800188}
-
Tao Wu authored
Change-Id: I2928f064f9948975d4b54e25d461ebefbbecf924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367114Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#800187}
-