GitLab

Adds `gn format` command. Currently accepts one //path/to/BUILD.gn and
attempts to reformat it (to stdout). Handles the basics, but does not
handle all constructs yet, and doesn't attempt any rewrites.

R=brettw@chromium.org
BUG=348474

Review URL: https://codereview.chromium.org/591373002

Cr-Commit-Position: refs/heads/master@{#296876}

For some USB drives, writes on Mac are much slower than using the old image
creator. This is most likely because the implementation in Chrome uses
/dev/disk# whereas the old implementation used /dev/rdisk# whenever
possible.

The main requirement is that writes are in multiples of the block size, but
since ImageWriter::WriteChunk always writes in multiples of
kMemoryAlignment (4096), it should be fine to always use the raw disk.

My brief tests using a Lexar JumpDrive 16GB and a 1.6GB image:
before: ~6.5 minutes to write, same to verify
after: ~5 minutes to write, ~1.5 minutes to verify

BUG=415891

Review URL: https://codereview.chromium.org/599853002

Cr-Commit-Position: refs/heads/master@{#296875}

r296008 regressed TooltipAura vertical placement.
(that change removed vertical centering of multi-line text)
(TooltipAura implicitly used this for vertical padding)

Add an actual border and explicit Label sizing instead.
(this allocates space for the padding in the Label border)
(it also base-line centers the text in the correct bounds)

See before/after pics at http://crbug.com/417602#c5

BUG=417602
TEST=Chrome OS and "Windows 8 mode" Chrome tooltips look good.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/602313002

Cr-Commit-Position: refs/heads/master@{#296874}

For answers prefetching, Chrome needs to know what the top search history
result for the current input is - _before_ issuing a search engine query
for that same input

BUG=406588

Review URL: https://codereview.chromium.org/470313004

Cr-Commit-Position: refs/heads/master@{#296873}

BUG=413488
TEST=components_unittests
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/585743004

Cr-Commit-Position: refs/heads/master@{#296872}

In some case ChannelMojo outlives ChannelMojoHost because
two objects are living in diffent thread.
Instead of using lifecycle callbacks, this CL relies on
WeakPtr. See comment on ipc_channel_mojo_host.h for
more details.

This CL also fixes a crash on --single-process mode.

R=viettrungluu@chromium.org
TBR=jam@chromium.org
TEST=content_browsertests (with --enable-renderer-mojo-channel on)
BUG=377980

Review URL: https://codereview.chromium.org/599333002

Cr-Commit-Position: refs/heads/master@{#296871}

Also make the script revert local changes before 'svn co'
rather than afterwards to avoid merge conflicts if a previously
patched file changes upstream.

BUG=410810

Review URL: https://codereview.chromium.org/587433002

Cr-Commit-Position: refs/heads/master@{#296870}

This change consolidates all of the existing media indicator UI into a
new MediaIndicatorButton class.  When the indicator is transitioned to
the audio playing or muting state, the button functionality activates;
and, when clicked, will toggle tab-wide audio muting.  Otherwise, the
view only serves to paint the indicator icon with all mouse/gesture
events handled by Tab (its parent View).

Added UMA's to detect usage of the feature, attempted usage of the
disabled feature, and possible close button mis-clicks.

This new feature is off by default.  The plan is to run a UI experiment
and gather the data needed to drive later launch decisions.

Note: This change depends on: https://codereview.chromium.org/586303004/

BUG=360372,384179
TEST=With --enable-tab-audio-muting, user can click audio indicator to toggle tab muting, or use the tab context menu to toggle muting of one or more selected tabs.

Review URL: https://codereview.chromium.org/591963002

Cr-Commit-Position: refs/heads/master@{#296869}

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708

Review URL: https://codereview.chromium.org/604753002

Cr-Commit-Position: refs/heads/master@{#296868}

machine) in prefs persistent store.

It is temporarily saved under kDummyHostname
(quic.global.props). Will change the code to save it in
globals in the next CL.

R=rch@chromium.org

Review URL: https://codereview.chromium.org/602763004

Cr-Commit-Position: refs/heads/master@{#296867}

Fixes the Ozone builder where udev isn't available.

BUG=none

Review URL: https://codereview.chromium.org/604143002

Cr-Commit-Position: refs/heads/master@{#296866}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5be896b..81a8a76

TBR=ager@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/602303002

Cr-Commit-Position: refs/heads/master@{#296865}

They don't seem to be flaky for me locally.

BUG=173621

Review URL: https://codereview.chromium.org/603853002

Cr-Commit-Position: refs/heads/master@{#296864}

BUG=N/A
TEST=N/A

Review URL: https://codereview.chromium.org/603863002

Cr-Commit-Position: refs/heads/master@{#296863}

Simplifies code as TimingFunction has no logical reason to inherit from AnimationCurve (apart from sharing a few method names). Make code more clear.

BUG=

Review URL: https://codereview.chromium.org/606543002

Cr-Commit-Position: refs/heads/master@{#296862}

Breakage caused by this case can be found in http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus4%20Perf/builds/1416/steps/page_cycler.bloat/logs/stdio

BUG=

Review URL: https://codereview.chromium.org/610483002

Cr-Commit-Position: refs/heads/master@{#296861}

Update FFmpeg with MIPS config files.

BUG= regression build issue
TEST= build Chromium for MIPS Linux

Review URL: https://codereview.chromium.org/590373004

Cr-Commit-Position: refs/heads/master@{#296860}

This regressed recently with the change to query the device scale factor to see if it needs to be scaled back to 1.0 for
display scales equal to or under 125%. user32/gdi32 API's crash or fail with the Win32K lockdown process mitigation.

Fix is to ensure that the device scale factor is queried from the one set via the command line. The other change is to move
the code in ContentMainRunner::Initialize which sets the global device scale factor for the process to before the content client
initialization. This is because the ShellContentRendererClient in its ctor calls the ShouldUseDirectWrite function which relies on
the GetDPIScale function to decide whether or not directwrite should be enabled. This causes a DCHECK in content_browsertests.

To ensure that the win32k lockdown does not regress I added a simple content browsertest RendererWin32KLockdownNavigationTest which runs
this on Windows 8+.

The accessibility fixes are to get the browser tests to run
on Windows 8. There were special cases to always enable
accessibility on Windows 8 for historical reasons. These are
no longer necessary as we don't rely on accessibility to display the virtual keyboard.

BUG=417147

Review URL: https://codereview.chromium.org/600263002

Cr-Commit-Position: refs/heads/master@{#296859}

Add histograms.xml info for the SRTPrompt, and don't create a browser if we are not going to prompt the user.

TBR=noelutz
For a simple histogram string rename in chrome\browser\safe_browsing\srt_global_error_win.cc

Review URL: https://codereview.chromium.org/607573002

Cr-Commit-Position: refs/heads/master@{#296858}

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/604443002

Cr-Commit-Position: refs/heads/master@{#296857}

Without this, it's hard to know what will be spoken due to the new category
flush queueing mode.

BUG=none

Review URL: https://codereview.chromium.org/593283002

Cr-Commit-Position: refs/heads/master@{#296856}

In RenderPass use ListContainer for generating DrawQuads and acting as
QuadList.

BUG=344962

Review URL: https://codereview.chromium.org/448303002

Cr-Commit-Position: refs/heads/master@{#296855}

 I'll fix issues and add them back.

BUG=414340

Review URL: https://codereview.chromium.org/607603002

Cr-Commit-Position: refs/heads/master@{#296854}

BUG=417871

Review URL: https://codereview.chromium.org/608473004

Cr-Commit-Position: refs/heads/master@{#296853}

A CL was recently introduced that prevented unnecessary tab-strip relayouts.
(https://codereview.chromium.org/593223002/). That CL had a minor error where
it failed to relayout the tab strip when the left and right indentations
changed. This CL corrects that oversight.

This CL also refactors the browser_window_controller tab strip layout logic
into browser_window_layout. There is no intended behavioral change. The tab
strip layout logic now has test coverage.

BUG=415093

Review URL: https://codereview.chromium.org/603243002

Cr-Commit-Position: refs/heads/master@{#296852}

This change is needed to handle new location of
PNaCl libs/include.

I've also switched naclports from svn to git as
the svn repo is no longer recieving new commits.

This brings is 391 new revisions: 87f43d3->99f2417

TEST=build_sdk.py --build-ports
R=binji@chromium.org

Review URL: https://codereview.chromium.org/608673002

Cr-Commit-Position: refs/heads/master@{#296851}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f1db071..5be896b

TBR=ager@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/609573003

Cr-Commit-Position: refs/heads/master@{#296850}

The big changes here are:
1) Allow injecting of a target toolchain via args for os==chromeos.
2) For ARM builds, allow injecting -mtune and -mfloat-abi settings.
3) Allow injecting a pkg-config wrapper that correctly handles the
   CrOS build environment. This is how pkg-config is handled for
   all other packages in the build.
4) Create libmojo_sdk target, a static library of public Mojo code
   suitable for distribution.
5) Added testonly = true to a few targets under mojo/ that are not
   meant to be used in production.

BUG=388412
TEST=Create a target that builds //mojo/public, build with os==chromeos

Review URL: https://codereview.chromium.org/549453004

Cr-Commit-Position: refs/heads/master@{#296849}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/603983003

Cr-Commit-Position: refs/heads/master@{#296848}

The purpose of this is to continue gathering all the related code together, and to make it easier to run pylint/tests for the main module which still contains most of the code.

After doing this, pylint and the tests caught a couple of things -- one unused variable name, and after the script changed directory, some of the paths had to be modified as well.

BUG=

Review URL: https://codereview.chromium.org/564663002

Cr-Commit-Position: refs/heads/master@{#296847}

Rather than talking to X11, in headless mode, the native viewport service just
drops requests on the floor. This configuration is useful for writing
integration tests for the Mojo system that don't need to interact with X11.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/606883002

Cr-Commit-Position: refs/heads/master@{#296846}

This reverts commit 7fb8b995.

BUG=417939
TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/609633002

Cr-Commit-Position: refs/heads/master@{#296845}

BUG=417399

Review URL: https://codereview.chromium.org/601783004

Cr-Commit-Position: refs/heads/master@{#296844}

BUG=none

Review URL: https://codereview.chromium.org/608573003

Cr-Commit-Position: refs/heads/master@{#296843}

This permission is used by whitelisted apps and extensions to access all
FIDO Alliance Universal 2nd Factor devices without a hard-coded list of
all present and future vendor and product IDs.

BUG=374307

Review URL: https://codereview.chromium.org/601423002

Cr-Commit-Position: refs/heads/master@{#296842}

This brings in the following changes:

01fe820 Add tests for client version negotiation and session resumption.
30ddb43 Handle session resumption in SSLv23_client_method.
b0c8db7 runner: don't resume sessions if SessionTicketsDisabled is true.
7f520db Remove OPENSSL_NO_TLS1_2_CLIENT and OPENSSL_NO_DTLS1.
37d9246 Disallow all special operators once groups are used.
2a5ea98 Remove redundant check in cipher rule parsing.
bb0a17c Add a set of tests for cipher string parsing.
e113608 Switch the reason code check to a compile-time assert.
5127db3 Provide compatibility functions for PKCS#12 parsing.
588d252 Don't try to setup CPUID if NO_ASM.
bed8ce7 Add misc functions for easier porting.
d7c5368 Add missing errors codes for alerts.
fc7b086 Test that ALPN is preferred over NPN.
ae2888f Add tests for ALPN support.
fa055a2 Implement ALPN in runner.go.
812152a Don't deadlock if a resume test fails the first half.
e78bfde Improve test coverage for server_name extension.
594a58e Remove remnants of export cipher suite selection.
d633d63 Remove indirection in loading ciphers.
172fc2c Fix some OPENSSL_PUT_ERROR calls.

BUG=417134

Review URL: https://codereview.chromium.org/604103003

Cr-Commit-Position: refs/heads/master@{#296841}

HTML5FS (PPAPI) does not provide an INO so it is impossible to determine
a files uniqueness.  In addition, node information does not persist in
memory since nodes could be transparently destroyed from JavaScript, thus
creating leaks.  Because of this the current stack based INO allocation
causes sequentially accesed file handles to report the same INO.

HTML5FS (including media galleries) does not traverse links.  This implies
that all paths normalized to the mount are unique.  We use this property
to generate a 64 bit hash.

R=binji@chromium.org
BUG=414938

Review URL: https://codereview.chromium.org/605513002

Cr-Commit-Position: refs/heads/master@{#296840}

Revert of Changes NineImagePainter to snap to (enclosed) pixel boundaries (patchset #2 id:20001 of https://codereview.chromium.org/604463003/)

Reason for revert:
I'm reverting this as there are two issues:
1. Translate isn't being set correctly.
2. Even with 1 fixed there are problems with scrollbars. I'll investigate after the revert.

Original issue's description:
> Changes NineImagePainter to snap to (enclosed) pixel boundaries
>
> Otherwise the sides may be clipped out.
>
> BUG=417493
> TEST=see bug
> R=ananta@chromium.org
>
> Committed: https://crrev.com/d1ab0241ee29c70bd08531d1f038964664b124b6
> Cr-Commit-Position: refs/heads/master@{#296608}

TBR=ananta@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=417493

Review URL: https://codereview.chromium.org/605893002

Cr-Commit-Position: refs/heads/master@{#296839}

To support CDM_6, make the following changes:
- add SetServerCertificate
- add GetUsableKeyIds
- rename ReleaseSession to CloseSession
- add RemoveSession
- add SessionKeysChange event
- add SessionExpirationChange event

This gets the new functionality up to the blink boundary. Changes to
use these new interfaces in blink in a future CL.

For backwards compatibility with existing prefixed EME code, calls
to CancelKeyRequest() call RemoveSession() instead of CloseSession().

BUG=358271,417481
TEST=existing EME tests still pass + manual testing

Review URL: https://codereview.chromium.org/555223004

Cr-Commit-Position: refs/heads/master@{#296838}

R=darin@chromium.org

Review URL: https://codereview.chromium.org/596363003

Cr-Commit-Position: refs/heads/master@{#296837}