- 26 Aug, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ee3d26b3cdc2..53daab94768a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC estade@google.com,sahel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1004848,chromium:1102196,chromium:1121776,chromium:912681 Tbr: estade@google.com,sahel@google.com Change-Id: Ia8114a5c2e268314aa55afe961a2325d5a8cc687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377622Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801995}
-
My Nguyen authored
Add blank dialog for now. Both Action and Cancel buttons currently close the dialog. Current view: http://screen/3NCtVAFiCFdFYcx Strings are being finalised by UX writing so keeping them as translateable=false and no screenshots required. Bug: 1113439 Change-Id: I0128a8bf1c3989c691f0ca5a1a3701c1faea171a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367254 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#801994}
-
Garrett Beaty authored
A generator ensures that all builders for bucket ci that have an associated scheduler job actually have a scheduler job both with and without the ci prefix, so it's unnecessary for it to be set for builders in the ci bucket. Not setting it means that we won't unnecessarily add the property to builders when we move builders from master-only/ci.star. Bug: 1119446 Change-Id: I2575cb34f3f9ac97dce30545dafbe40e5ff96cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378717Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#801993}
-
Meredith Lane authored
This change moves the ValueDescription serialization from BlinkAXTreeSource to AXObject to remove extra interfaces from WebAXObject. This patch should have no functional difference, it is just a refactor. Bug: 1068668 AX-Relnotes: N/A Change-Id: Ifb36e2c812a81a8cb105c948b3be0630de3e9b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325532 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#801992}
-
Stefan Zager authored
BUG=1119493 Change-Id: I1315670f4a0ee550960ba6bc308500939577f349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367806Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#801991}
-
Rakina Zata Amni authored
GetFrameScheduler() might return null and cause crashes. Bug: 1121988 Change-Id: I4ce91ccc4b73e7404394adc96da33d44916a59dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377335Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#801990}
-
Mohamed Heikal authored
The protobuf runtime and protoc are being autorolled downstream, we should make sure the upstream versions are close behind. Change-Id: I2fd06a43d5d24e53e5a6034f44921caab1c50d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374286 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#801989}
-
Chris Lu authored
This button will be used by DefaultBrowserPromoViewController as the dismiss button. Bug: 1107489 Change-Id: If6190223bafe3b459f66a10ee48d5afb5475d3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376032 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#801988}
-
Megan Jablonski authored
This fixes a discrepancy between navigator.languages and Accept-Languages in Incognito. Bug: 1077547 Change-Id: Iefc8192f1f9a6d9bfe3c65faf26a29b8edf03b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370123 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#801987}
-
dpapad authored
Fixed: 1081827 Change-Id: Icb6c244bb9f3c01e4848d66c7ed412657065da92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378137Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#801986}
-
Mohamed Heikal authored
android_resources targets should no longer create their own R.java files, this responsibility should be instead moved to android_library targets. Separating out the java source files from system_webview_shell_apk into their own android_library ensures a consistent R.java package name regardless of the apk package name itself which could change. Switch statements turned into if/else blocks since switch requires constants and intermediate R.java files do not use constants (so they are not inlined by javac) and are only replaced with constants in the final apk target. Bug: 1121790,1073476 Change-Id: I0cfa22b398c6370d46b99e9976cec350c3c12a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376881 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#801985}
-
Christopher Cameron authored
The following function exists but is not documented in any spec: [RuntimeEnabled=CanvasColorManagement, RaisesException] ImageData createImageData( ImageDataArray data, unsigned long sw, unsigned long sh, ImageDataColorSettings imageDataColorSettings); Remove it. Bug: 1119507 Change-Id: Ic3bd46c30e9ff2937a4edf817d8002ef97b57c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364758Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#801984}
-
Kalvin Lee authored
This change implements PpdMetadataManager::GetUsbManufacturerName(), allowing the caller to find an unlocalized manufacturer name for a given vendor ID. Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdMetadataManagerTest.*' Change-Id: Ieb0105202f47d5d0fe3528f0ee319594cf73183b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341412 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#801983}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8e24b3cc2f00..8178c8db6335 2020-08-26 agrieve@chromium.org Use gsutil.py in update_dependencies.py instead of gsutil If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I91d4eed51396607ace7e8d4afdf77e944dee0015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377621Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801982}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/03cde5f9997d..64f3530dc37e 2020-08-26 fmalita@chromium.org [canvaskit] Update GM:skottie_setcolor 2020-08-26 herb@google.com Reland "change atlas uv encoding" 2020-08-26 reed@google.com Always (pre)compute path bounds when using a builder 2020-08-26 egdaniel@google.com Remove renderable flag from texture createLazyProxy. 2020-08-26 johnstiles@google.com Add the inline keyword to top-level FPs that use an explicit return. 2020-08-26 jlavrova@google.com Reland "Reland "ICU: SkShaper (bidi iterator only)"" 2020-08-26 reed@google.com Revert "Revert "use pathbuilder"" 2020-08-26 johnstiles@google.com Allow .fp files to return a color from main(). 2020-08-26 johnstiles@google.com Add unit tests for early-return detection. 2020-08-26 reed@google.com Revert "use pathbuilder" 2020-08-26 egdaniel@google.com Remove GrRenderTargetProxyPriv class and setGLRTFBOIDIs0 call. 2020-08-26 rmistry@google.com Add Retries to Canaries 2020-08-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2020-08-26 reed@google.com use pathbuilder 2020-08-26 brianosman@google.com Remove legacy runtime effect main signature 2020-08-26 adlai@google.com Revert "Simplify the Metal Compiler wrapper code" 2020-08-26 fmalita@chromium.org [skottie] Assorted shape repeater fixes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ib287ca34dc511c7ced7f3aa15f545031722c7174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378571Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801981}
-
Adam Langley authored
The previous change said that there aren't non-compilation tests. But there are now! Thus move the commented test into a nocompile test. Change-Id: I29d92a8208c1f523295833a264cbfb442d070873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378537 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#801980}
-
Yuri Wiitala authored
This reverts commit 69d49837. Reason for revert: The test actually works. It only fails on LACROS. The disable #define's should have used BUILDFLAG(IS_LACROS) to isolate that. Original change's description: > Reland "[Sheriff] Disable the test" > > This reverts commit ef0ab61f. > > Reason for revert: The test still fails: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/1158 > > Original change's description: > > Revert "[Sheriff] Disable the test" > > > > This reverts commit af48c8e6. > > > > Reason for revert: Test works now. > > > > Original change's description: > > > [Sheriff] Disable the test > > > > > > Disable the failing test on Linux. > > > > > > Bug=1108205 > > > TBR=miu@chromium.org > > > > > > Change-Id: Ie388ca75a2fadce937d613994847217e7f9579fc > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310271 > > > Reviewed-by: Hayato Ito <hayato@chromium.org> > > > Commit-Queue: Hayato Ito <hayato@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#790745} > > > > TBR=miu@chromium.org,hayato@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Change-Id: I4c43284f7d4a0fec1cd4c05fc375f1f4d406526b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361023 > > Reviewed-by: Yuri Wiitala <miu@chromium.org> > > Commit-Queue: Yuri Wiitala <miu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#799428} > > TBR=miu@chromium.org,hayato@chromium.org > > # Not skipping CQ checks because this is a reland. > > Change-Id: Ibc06b68b65131cc9f3220ec36084f89eaf08ce59 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362494 > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799504} TBR=miu@chromium.org,hayato@chromium.org,hajimehoshi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I9576e8790e444f2741642eb392bbd26c889d2a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375997Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801979}
-
Sahel Sharify authored
The test is flakily crashing on multiple platforms, flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=TranslateLanguageBrowserTestWithTranslateRecentTarget.RecentTargetLanguage TBR=anthonyvd@chromium.org Bug: 1122170 Change-Id: I93ce49a5051b9302962f336bb24cf266a07130bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378399Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#801978}
-
Brandon Wylie authored
This reverts commit e69f63a3. Reason for revert: Causing infra failures on chrome/ci/android-internal-chromium-tot, see crbug.com/1122206. Original change's description: > Temporary add verify_file_exists to check files downloaded. > > R=bsheedy@chromium.org > > Context: to make sure those wprarchive files are downloaded properly. > Bug: 1096656 > Change-Id: Id0197c39f1a260bf9356269f41c12a46deecbf17 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378386 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Arthur Wang <wuwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801957} TBR=dpranke@google.com,bsheedy@chromium.org,wuwang@chromium.org Change-Id: I4d7f023d4e4d8f441d2cbdc33788e17f859377ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1096656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378541Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#801977}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /gpu/ipc/common/gpu_memory_buffer_support.cc This CL was uploaded by git cl split. R=dcastagna@chromium.org Bug: 1110266 Change-Id: I705cdbdfdafafc7a8aeb77a5c9f6ea0a4e171ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371297Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#801976}
-
Daniel Classon authored
Adds deep links to the Search and Assistant page, inclusind the Google assistant subpage. Bug: 1084154 Change-Id: I151f03ab0160921afaf0037b319d9c8f95dd813b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378391Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Daniel Classon <dclasson@google.com> Cr-Commit-Position: refs/heads/master@{#801975}
-
Daniil Lunev authored
Bug: 1108065 Change-Id: I70cfde9f24a9fd4efe7b1c81df4d17a7a3718fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373726Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Daniil Lunev <dlunev@chromium.org> Cr-Commit-Position: refs/heads/master@{#801974}
-
Andrew Grieve authored
As far as I can tell these were never used... Bug: 1121713 Change-Id: Ie81d7bfa72e40b48a775442684aae025a55259f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376125 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#801973}
-
Kalvin Lee authored
This change brings the variants of the metadata type enum (internal to the PpdMetadataManager class) in line with the style guide's guidance. Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdMetadataManagerTest.*' Change-Id: I9b87932b187c95f600db4caa3f945f9a9d6af5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340634 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#801972}
-
David Tseng authored
R=akihiroota@chromium.org Bug: 111985 AX-Relnotes: ChromeVox provides feedback when entering or leaving an audio or video tag. Test: browser_tests --gtest_filter=ChromeVox*.AudioVideo Change-Id: Ia0b38a5dde6f7554ad476dc61ccf910fd11d5658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377110Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#801971}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0fdfdcf61cd4..14a9bffb3e9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia95f3c88911f272c8172b55997b99b88a9fe3523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377663Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801970}
-
danakj authored
Disable flaky external/wpt/webvtt/rendering/cues-with-video/processing-model/dom_override_remove_cue_while_paused.html TBR=mlamouri@google.com Bug: 1084378 Change-Id: I9846988c3f3c065dc89962552ea11b6d621fb30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377661Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#801969}
-
Sahel Sharify authored
The test is flaky on multiple platforms. TBR=jiakl@google.com,mcrouse@chromium.org Bug: 1122160 Change-Id: I0d6a7354fc5969a9e01efefb17c7c6fd1c67b018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378396Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#801968}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7c5a76596198c2b33442cf8092dfcdbaad442615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378218Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801967}
-
Ben Kelly authored
The trial showed that this is neutral in top level metrics like FCP. This is somewhat expected as the throttling is intended as an additional protection against a site contending with itself. The trial also showed that install takes longer. At the median installs are ~10ms slower and at P99 are 2 to 5 seconds slower. The P99 for install is still less than 30 seconds, however, which places it well under the 5 minute timeout threshold. UMA also showed that while timeouts increased slightly they still only occurred around ~0.1% of the time. Bug: 1035448 Change-Id: I40dbe69e363997725b29a282041e9e27aee9c712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376368 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#801966}
-
Haiyang Pan authored
This reverts commit f160a626. Reason for revert: Very likely the cause for the test failure android.webkit.cts.WebViewTest#testPauseResumeTimers in the following builders: * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1975 * Android Webview dbg builders like * https://ci.chromium.org/p/chromium/builders/ci/Android%20WebView%20L%20(dbg)/14498 * https://ci.chromium.org/p/chromium/builders/ci/Android%20WebView%20M%20(dbg)/12523 Verified on local emulator builder Original change's description: > [scheduling] Removing QueueClass. > > QueueClass is currently used for high-level policy decisions in the > main thread. For the most part, the policies applied to each queue > class are largely the same. This change removes QueueClass entirely > and adds bits on the policy for pausing and deferring task queues as > well as whether or not virtual time is enabled. > > > Change-Id: Iae28c5d7d2ad4c9deb7dad2e1c3294e7ac6b9470 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365315 > Commit-Queue: Katie Dillon <kdillon@chromium.org> > Reviewed-by: Scott Haseley <shaseley@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801591} TBR=altimin@chromium.org,kdillon@chromium.org,shaseley@chromium.org Change-Id: Ibb78ad6245a2f28c1d8b60c6abbad32669213911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377890Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#801965}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/983698bb34ec..517f39eee46f 2020-08-26 johnkslang@users.noreply.github.com Merge pull request #2380 from null77/suppress-override-warnings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC courtneygo@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: courtneygo@google.com,radial-bots+chrome-roll@google.com Change-Id: I67d304e2cd3d61b71439807203e39866df669909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378215Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801964}
-
Marijn Kruisselbrink authored
This API isn't supported and doesn't ship on android. Bug: 1122082 Change-Id: Ia26074459d9cff45b6f0201303607f7c21f6a9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378385 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801963}
-
Jeffrey Young authored
Add new histogram "Ash.AmbientMode.Activation" to record number of times Ambient Mode activates. BUG=b:163529319 Change-Id: I056a607e061f305fd225ce52568d007ccc369c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362440 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#801962}
-
danakj authored
R=mek@chromium.org Bug: 1092048 Change-Id: I4274397d965468cab0e1277ea1382e4215035b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377660Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#801961}
-
Lei Zhang authored
These performance metrics should remain stable over time and alert should fire if they deviate significantly. As such, set them to never expire. Also add a secondary owner. Bug: 1109836,1109875 Change-Id: Id1e31973f40d38ef54c5229df789a1c7258062ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376318Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#801960}
-
Martin Kreichgauer authored
Enumerate the relevant fields in MakeCredentialRequestHandler::Options rather than pass in the entire AuthenticatorSelectionCriteria to simplify things a little. No functional changes intended. Bug: 1117630 Change-Id: I252d6a091b5b8f68d2558489ce1d528f5e5d5416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365134 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#801959}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b8e8ad564da3..661b3a4411c6 2020-08-26 petermueller@chromium.org Device preview: replace PNG icons with SVGs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I87b998f4040395ecc952211943b02a5eca3a234f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377363Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801958}
-
Arthur Wang authored
R=bsheedy@chromium.org Context: to make sure those wprarchive files are downloaded properly. Bug: 1096656 Change-Id: Id0197c39f1a260bf9356269f41c12a46deecbf17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378386Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801957}
-
Adam Langley authored
This reverts commit 9e3a51f1. I believe that 087d4503 fixes the underlying issues in the code that this change originally surfaced. Thus this is a simple revert of the original change. The only updates are to reflect the use of a std::vector for the QR data. Original change's description: > qr: add support for selecting the mask. > > The QR standard says that the mask should be auto-selected, not fixed to > three, and specifies a fitness function for choosing the best mask for > each QR code. > > This change adds support for that and lets the caller specify a mask if > it really wants … say if it wanted to cycle through a series of QR codes > for the same data with a dancing dinosaur on top. Change-Id: I1f247baad727648be1f070c11753758edde47512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377611 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#801956}
-