GitLab

Just a refactoring of test classes. This extracts a
FakeScatteredBuffer class out of the existing unittest. This
class will be reused by other unittests added in
upcoming CLs.

BUG=608719
TEST=components_unittests --gtest_filter=ScatteredStreamWriterTest.*

Review-Url: https://codereview.chromium.org/2138903002
Cr-Commit-Position: refs/heads/master@{#405119}

BUG=626736
R=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2143353003
Cr-Commit-Position: refs/heads/master@{#405118}

Unable to find gfx::NumberOfPlanesForBufferFormat symbol :

media/gpu/vaapi_wrapper.cc:634: error: undefined reference to 'gfx::NumberOfPlanesForBufferFormat(gfx::BufferFormat)'

BUG=none
TEST=verify that video_encode_accelerator_unittest links successfully

Review-Url: https://codereview.chromium.org/2134633002
Cr-Commit-Position: refs/heads/master@{#405117}

The migration code had some unnecessarily complicated parts which made
https://codereview.chromium.org/2127533003/ harder than needed.

This CL pulls common database tasks related to table scheme migration
and creation into a separate class, SQLTableBuilder. During that the code
is also cleaned up and made safer by using transactions.

The CL also fixes two typos in the test files.

BUG=413020

Review-Url: https://codereview.chromium.org/2126713006
Cr-Commit-Position: refs/heads/master@{#405116}

BUG=623168
R=mkwst@chromium.org

Review-Url: https://codereview.chromium.org/2145873003
Cr-Commit-Position: refs/heads/master@{#405115}

Password manager uses a switch to allow the user to override the
auto-detection of the appropriate password store. OSCrypt should
respect this switch as well.

The switch value is read and passed to OSCrypt at a very early
point in Chrome's start, before any of OSCrypt's dependents
use it.

I also reworked OSCrypt's build to make it simpler for chrome to
deduce whether the linux implementation of OSCrypt will be used.
 - Previously, os_crypt_linux was used only if we also decided to
   link at least one linux backend. Otherwise we used os_crypt_posix.
 + Now, we always use the linux implementation for linux. If no
   KeyStorage is linked, the linux implementation defaults to the
   same behavior as for posix.

BUG=602624

Review-Url: https://codereview.chromium.org/2118443002
Cr-Commit-Position: refs/heads/master@{#405114}

https://chromium.googlesource.com/chromium/src/+/a1d6a0e73

BUG=490511
TBR=kochi@chromium.org

Review URL: https://codereview.chromium.org/2145943002 .

Cr-Commit-Position: refs/heads/master@{#405113}

This patch adds null-check for focusable view.

BUG=625357
TEST=crash doesn't happen

Review-Url: https://codereview.chromium.org/2124093003
Cr-Commit-Position: refs/heads/master@{#405112}

Revert of [gin] Unify snapshot loading on Windows and other platforms. (patchset #2 id:20001 of https://codereview.chromium.org/2103903002/ )

Reason for revert:
Investigate effect on Win7 startup.cold.blank_page metrics.

BUG=501799,625516

Original issue's description:
> [gin] Unify snapshot loading on Windows and other platforms.
>
> Removes extra v8 snapshot and natives validation on Windows. All platforms
> have the same validation henceforth.
>
> BUG=501799
>
> Committed: https://crrev.com/10b5a96b363a6ff23176d27a2e7fb1bba300f089
> Cr-Commit-Position: refs/heads/master@{#403430}

TBR=jochen@chromium.org,ben@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=501799

Review-Url: https://codereview.chromium.org/2141043002
Cr-Commit-Position: refs/heads/master@{#405111}

Add a new variable "multi_arch_target_cpus" that can be defined by the
user via "gn args" to build for more than one architecture. It should
be set to a list of two or more architectures supported by gn build.

Add support for multi-architectures application to the "ios_app_bundle"
template. The template expands to a simple "executable" target if the
toolchain is not the default toolchain. For the default toolchain the
real executable is generated by assembling all single architecture
binaries using "lipo" tool.

BUG=603180

Review-Url: https://codereview.chromium.org/2123253004
Cr-Commit-Position: refs/heads/master@{#405110}

virtual/scalefactor150/fast/hidpi/static/calendar-picker-appearance.html
virtual/scalefactor150/fast/hidpi/static/data-suggestion-picker-appearance.html

BUG=627754,593567
TBR=bsep@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2139293003
Cr-Commit-Position: refs/heads/master@{#405109}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3d24ece9..fe6d66c4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2149503002
Cr-Commit-Position: refs/heads/master@{#405108}

- Remove |allowMultipleSelection| arguemnt of optionSelectedByUser().
  It's always false.

- Remove |shift| argument of listBoxSelectItem().
  It's always false.

Also, make optionSelectedByUser() private.

This CL has no behaivor changes.

Review-Url: https://codereview.chromium.org/2147683003
Cr-Commit-Position: refs/heads/master@{#405107}

BUG=627747

Review-Url: https://codereview.chromium.org/2147483002
Cr-Commit-Position: refs/heads/master@{#405106}

Displays a feature notification informing the user about quick unlock.
Upon clicking the notification the user is taken to the settings page.

The UI strings used in the notification are still TODO and not final.

BUG=626079
COMPONENT=Chrome OS, Quick Unlock, Preferences, Strings

Review-Url: https://codereview.chromium.org/2128053002
Cr-Commit-Position: refs/heads/master@{#405105}

It's always true in practice

BUG=627483

Review-Url: https://codereview.chromium.org/2142083002
Cr-Commit-Position: refs/heads/master@{#405104}

The NTPSnippetsService currently delivers snippets to the UI via the
Android bridge. Change it to additionally serve as a
ContentSuggestionsProvider implementation and deliver
ContentSuggestions for the ARTICLES category. These ContentSuggestions
are currently only delivered to the ContentSuggestionsService and not
served to the UI, yet.

Adjust NTPSnippetsServiceTest, SnippetsBridge and SnippetsInternals
because of a few renamed functions.

Change NTPSnippetsServiceFactory to register the NTPSnippetsService
as a provder with the ContentSuggestionsService.

BUG=619560

Review-Url: https://codereview.chromium.org/2131943002
Cr-Commit-Position: refs/heads/master@{#405103}

Using update-w3c-deps in Chromium 1e9dc390.

BUG=490511, 505364, 612924, 627706
TBR=suzyh@chromium.org, nzolghadr@chromium.org

Review-Url: https://codereview.chromium.org/2143653006
Cr-Commit-Position: refs/heads/master@{#405102}

USE_V4L2_CODEC is needed by GpuVideoEncodeAccelerator.

BUG=541408
TEST=check Media.RTCVideoEncoderInitEncodeSuccess histogram

Review-Url: https://codereview.chromium.org/2146463002
Cr-Commit-Position: refs/heads/master@{#405101}

https://chromium.googlesource.com/chromium/src/+/c35147b9b

BUG=626278
TBR=glebl@chromium.org

Review URL: https://codereview.chromium.org/2149433003 .

Cr-Commit-Position: refs/heads/master@{#405100}

In the top10_mobile page set google.com gets redirected to google.ca. This
sometimes causes problems in telemetry with scrolling. As a short term fix,
replace google.com with google.co.uk in the page set. We cannot change it
to google.ca because memory_top_10_mobile uses the same page set but with
a different wpr that has a recording of google.co.uk. Updated dual_browser
page set to be consistent with top_10_mobile page set.

Also recorded new wprs for memory_top_10_mobile, dual_browser and
top_10_mobile_memory.

BUG=chromium:617914
LOG=N
CQ_INCLUDE_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2138133003
Cr-Commit-Position: refs/heads/master@{#405099}

A compound Knuth-Morris-Pratt failure function is used to match URLs against the
|pattern|.

The |pattern| is split on the '*' wildcard symbol and then a failure function is
built for each subpattern by BuildFailureFunctionFuzzy or BuildFailureFunction
(depending on whether the subpattern contains separator placeholders), and
appended to a vector. Some of the subpatterns can be exempted from being
indexed. E.g., if the |pattern| has a BOUNDARY left anchor, the first subpattern
can be matched by checking if it's a prefix of a URL.

Each subpattern indexed with BuildFailureFunctionFuzzy is prepended with a value
1 (to distinguish them from the subpatterns indexed with BuildFailureFunction,
their failure functions always start with 0).

BUG=609747

Review-Url: https://codereview.chromium.org/2098233002
Cr-Commit-Position: refs/heads/master@{#405098}

The old files in the corpus had the woff signature instead of the woff2
signature and AFL could not discover any paths as a result. The new ones
have the correct signature.

BUG=539572

Review-Url: https://codereview.chromium.org/2145623002
Cr-Commit-Position: refs/heads/master@{#405097}

Merging with interfaces/KeyframeEffect/processing-a-keyframes-argument.html

BUG=623437

Review-Url: https://codereview.chromium.org/2134253004
Cr-Commit-Position: refs/heads/master@{#405096}

BUG=623437

Review-Url: https://codereview.chromium.org/2141823002
Cr-Commit-Position: refs/heads/master@{#405095}

Redundant with animation-model/keyframe-effects/the-effect-value-of-a-keyframe-effect.html

BUG=623437

Review-Url: https://codereview.chromium.org/2139683003
Cr-Commit-Position: refs/heads/master@{#405094}

[Password Generation] Checks the existence of the signin/signup form even if the password was generated

After this CL (https://codereview.chromium.org/1237543002), if the password was generated, there is no check whether the forms still exists. It was introduced to be sure Chrome saves the generated password. The disadvantage of it is that we send a positive vote to the server even if the login was failed (the vote says generation was successful).

This CL (https://codereview.chromium.org/1817483002/) introduced the presaving of generated password (i.e. save generated password right after generation and update it after every user input).

Thus, we are sure that the generated password was saved. No need in the first CL (https://codereview.chromium.org/1237543002). Let remove its code since it distorts votes statistics.

BUG=552420

Review-Url: https://codereview.chromium.org/2141513002
Cr-Commit-Position: refs/heads/master@{#405093}

BUG=615589

Review-Url: https://codereview.chromium.org/2121223002
Cr-Commit-Position: refs/heads/master@{#405092}

BUG=623437

Review-Url: https://codereview.chromium.org/2139153002
Cr-Commit-Position: refs/heads/master@{#405091}

BUG=623437

Review-Url: https://codereview.chromium.org/2137333002
Cr-Commit-Position: refs/heads/master@{#405090}

This CL fixes a couple of style nits pointed out by lint in login_database.*, and also changes
sql::Statement::ColumnBlobAsString to const.

BUG=413020

Review-Url: https://codereview.chromium.org/2133173003
Cr-Commit-Position: refs/heads/master@{#405089}

URLRequest::Delegate::OnBeforeNetworkStart is not used by
anything, despite having a lot of plumping.  It was added to
try experimenting with having the ResourceScheduler delay
requests only once they needed to go over the network, so
responses that could be served out of the cache.

BUG=479994

Committed: https://crrev.com/0af4009f7ce7a5a00091070e85bfd36745bba02c
Review-Url: https://codereview.chromium.org/2123093002
Cr-Original-Commit-Position: refs/heads/master@{#404606}
Cr-Commit-Position: refs/heads/master@{#405088}

Multi-iframe NTP continues to use it, but no longer logs statistics for
load time and number of tiles. This happens only for external NTPs,
where the load time and number of tiles are not fully under our control
anyway.

Single-iframe NTP now uses NTP_ALL_TILES_LOADED. When this is logged, we
emit statistics, ensuring that we log a load time and number of tiles
exactly once per NTP (well, unless the user closes the page or navigates
away without the page having finished loading).

BUG=625990
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2141933002
Cr-Commit-Position: refs/heads/master@{#405087}

This patch adds a heuristic check to see if the font has invalid
avgCharWidth.

The spec is silent about how avgCharWidth is computed for CJK fonts,
and some fonts selected to match to CJK full-width characters.

Since in most fonts, avgCharWidth is close to the width of "0", when
it's too big compared to the width of "0" can be considered as invalid.

BUG=625058

Review-Url: https://codereview.chromium.org/2145903002
Cr-Commit-Position: refs/heads/master@{#405086}

BUG=586161

Review-Url: https://codereview.chromium.org/2124503002
Cr-Commit-Position: refs/heads/master@{#405085}

Now hard-coded the new Blended behaviour, which ranks app list results
by their score, rather than stratifying them into groups.

BUG=487494

Review-Url: https://codereview.chromium.org/1136363003
Cr-Commit-Position: refs/heads/master@{#405084}

Need to call LabelButton::Layout since this requires updated preferred
width of the label and that needs up to date text.

BUG=624612

Review-Url: https://codereview.chromium.org/2143473002
Cr-Commit-Position: refs/heads/master@{#405083}

This test is redundant with existing tests in the W3C web-platform-tests.

BUG=623437

Review-Url: https://codereview.chromium.org/2141723005
Cr-Commit-Position: refs/heads/master@{#405082}

Before, Sandwich was using the patched WPR archive with headers
ensure the resource get cached. But that could lead to non realistic
page load time in theory if multiple requests are issued on uncachable
resources.

This CL fixes this issue by using the original WPR archive when running
the benchmarks for NoState-Prefetch.

BUG=582080

Review-Url: https://codereview.chromium.org/2144633002
Cr-Commit-Position: refs/heads/master@{#405081}

The root property nodes weren't applied because we expect the PaintLayer of
the root LayoutView to apply them before painting. However in debug builds
the GraphicsLayer could paint debug background before we ever reach the
PaintLayer. Also the scrollbar layers (not implemented in SPv2. Upcoming.)
are not backed by PaintLayer.

Review-Url: https://codereview.chromium.org/2140173004
Cr-Commit-Position: refs/heads/master@{#405080}