GitLab

Update both metadata-exporter and linux_chromium_component_updater
builders to NOT be tree closers.

Update metadata-exporter builder to be triggered by commits
(contiuously), as opposed to periodically.

Remove all default notifications from these builders because these
are very specific builders and the people notified by default don't have
the context.

Bug: 1106554
Change-Id: Ib5068ff16b6be2c3f00e354b7c9b2dda6162e8b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303600
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789279}

This enum value is not set anywhere (I believe since r414750) except in
some tests.

Bug: 1100977
Change-Id: Ib643ca350704ba240057b097379b415b299a0afb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274168Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789278}

This CL fixed an issue in download location prompt status metrics, also
adds a metrics for download later prompt status.

Bug: 1106094,1078454
Change-Id: I17af189721e840a5e29ee7fc89e02506b2b9b689
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300806
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789277}

Bug: b/160753530
Test: manual
Change-Id: I4edae4b329f17919ad25aca3800adf79861e6f1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287273Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789276}

Put all config requests into a vector and move them together.
Change the callbacks to handle all displays configured together rather than one display at a time.

BUG=1082882
TEST=no changes enabling and disabling displays, display_unittests.

Change-Id: I36859414e1e31e8411f67bac0c3609696cabeece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237653Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Auto-Submit: Mark Yacoub <markyacoub@google.com>
Cr-Commit-Position: refs/heads/master@{#789275}

The ActiveModalDialogListener outer callback is explicitly called
multiple times, thus requiring conversion to RepeatingCallback. the
inner closure is also stored as a RepeatingClosure by the only place that
creates an ActiveModalDialogListener, so is similarly converted.

This change also converts chrome_browser_main's base::Binds, as the only
consumer of ActiveModalDialogListener.

Bug: 1007635
Change-Id: I49e4a2ba9772919e57c448e08bba57e6c8a32b9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299191
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789274}

iOS14 tests to execute on chromium.tests.ios14.

Bug: 1101531
Change-Id: I8fee379d472ed05c73eeed75b8bf6f50b83a1694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295788Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789273}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ic84fbe38d12071933410a43d4ca63b64d07e02c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303561Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#789272}

This was fixed within ANGLE

Bug: chromium:1099763
Change-Id: I4398cc7178ceaa05e9000668b04c5501daeea55e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302411Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#789271}

Bug: 1104291
Change-Id: If1535212a0a931b0e7477ff91b60d5a3ecbd0efd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303456Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789270}

Refactors the SetAndroidAppInfos method out of ReportGenerator and into
a new delegate class, in preparation for moving ReportGenerator to
components.

Note that the ReportGenerator constructor uses the desktop factory
directly, because the base factory can't be used until ReportGenerator
is moved to components.

#Squeegee

Bug: 1092425
Change-Id: Iff4a273f752cc286ac5654c3520c00cd1c31f14e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296578Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/master@{#789269}

We no longer have separate test-type-handling logic for CTS tests
and instrumentation tests; instead, they emulate and are treated
as gtest-based tests by the infrastructure these days.

This CL updates the //testing/buildbot/README.md documentation
and the generator code accordingly.

Bug: 816629
Change-Id: I56d646cab293dcd9e59209d80d6fa016fd1d5ffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303773
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789268}

R=ikilpatrick@chromium.org

Bug: 1098475
Change-Id: Ibe99426f1737841957b7f6611bcab70228724786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261875
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789267}

UnifiedAutoplaySettingBrowserTest.Block Failed on several bots.

List of failed builders:

Builder: Win10 Tests x64
https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64
First failing build:
https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/b8874594547915853472
--------------------
Builder: Win10 Tests x64
https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64
First failing build:
https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/b8874585376703011824

TBR=sergeyu@chromium.org

Bug: 1106521
Change-Id: I55eaa23c2bd01d4dc03cdfbef6fe4090866d6f49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303457
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789266}

Bug: 1100696
Change-Id: I44136dfd61e8ab7d1fc64020d51854adaad68377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283893Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789265}

Flake Portal:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUAsSBUZsYWtlIkVjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFNTTFVJVGVzdElnbm9yZUNlcnRFcnJvcnMuU3ViZnJhbWVIYXNDZXJ0RXJyb3IM

TBR=estark@chromium.org

Bug: 1106370
Change-Id: Ibee02ba23881f78b28c27e3652ccbf60fa7a6f86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303055Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789264}

Follow up to https://crrev.com/c/2289191.

This callback is only used in tether code as an error callback. This
change moves the callback to TetherDelegate and renames to
StringErrorCallback. Even though this is mostly used in
chromeos/components/tether, it can't be defined there since
chromeos/network can't include code from there.

Bug: 1007660
Change-Id: I882d25857afdcc2b86a9cae4f146032603b6d40f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303871Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789263}

This CL relands "Deflake preservesPitch tests", which was reverted by:
commit f19f3404.

It also attempts to incorporate some of the WPT changes made upstream,
but not yet landed, in:
https://github.com/web-platform-tests/wpt/pull/24599

Specifically, it fixes typos in the Safari prefixes, and explicitly
starts the audio context. However, it is different from the PR, since
it reuses the same Audio element, MediaElementAudioSourceNode and
AudioContext. This is an attempt to cut down on overhead costs and
fix test timeouts. We instead reset the audio.currentTime to 0, and
only create a new analyser node for each test.

Bug: 1105877, 1096238
Change-Id: Ie528ec0b7c38d9df59fcb04696c810e6d1c232f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300929
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789262}

These cases were converted to use PostTask some time ago, but because
the PostTask queue is managed in native (once native is initialized)
this means that uncaught exceptions cause native crashes instead of
being reported as Java exceptions.

Use AwThreadUtils to make it clear that posting directly to the Android
looper is intentional.

Change-Id: If7dcf8b98bb42886d02532a9d27eafcc58bab829
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302945
Auto-Submit: Richard Coles <torne@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789261}

Change "a search engine" to "the search engine " to provide better
consistency (since "a" was only used once).

Change-Id: If001c447bbc9c5d88a841fb8eb1bc69b6053114d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298102Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789260}

https://dawn.googlesource.com/tint.git/+log/919011af0a2a..5f43fedcddba

$ git log 919011af0..5f43fedcd --date=short --no-merges --format='%ad %ae %s'
2020-07-16 dneto [spirv-reader] Handle gl_Position
2020-07-16 rharrison Clean up how deps are defined in BUILD.gn
2020-07-16 dsinclair Remove refs.cfg.
2020-07-16 dsinclair Fixup group list name
2020-07-16 dsinclair [msl-writer] Emitting of program constants.
2020-07-16 dsinclair [msl-writer] Fixup matrix and array constructors.
2020-07-16 dsinclair Differentiate size and stride in array type name.
2020-07-16 dneto [spirv-reader] Support duplicate type definitions
2020-07-15 dsinclair [msl-writer] Add struct offset support.
2020-07-15 dsinclair [msl-writer] Add builtin support
2020-07-15 dsinclair Add helpers for referenced variables.
2020-07-15 dsinclair [msl-writer] Refactor some entry point variable code.
2020-07-15 dsinclair [msl-writer] Generate entry point functions.
2020-07-14 dsinclair [msl-writer] Handle emitting user function calls.
2020-07-14 dsinclair Inherit refererenced globals up the call stack.
2020-07-14 dsinclair [msl-writer] Generate input/output structs
2020-07-14 dsinclair Add determination of entrypoint callees.
2020-07-14 dsinclair Update cube example

Created with:
  roll-dep src/third_party/tint/src

Change-Id: I06b16721427a141dee1b101e23bb36e47c09f836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302926
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789259}

Converts Callbacks used by the *process_singleton* classes to Repeating
Callbacks. Most callbacks are obviously (at least potentially) called
multiple times; however, the ShouldKillRemoteProcessCallback appears to
only be called once, as a result of PreMainMessageLoopRun. Despite this,
this change opts to make it a RepeatingCallback as nothing in its usage
would prevent it from being called multiple times and it appears to only
be a callback (instead of a direct method call), so that the behavior
can be overridden by tests.

Additionally, converts base::Binds used by the *process_singleton*
classes where the consuming API has been updated to take a particular
type.

After this change the *process_singleton* files should be clean of any
base::Bind(, base::Callback<, and base::Closure calls.

Bug: 1007635
Change-Id: Ifbf9fc165e063440f4f6ac3212f0cd403f70dfa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296637Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789258}

https://android.googlesource.com/platform/external/perfetto.git/+log/cab02df7a5c5..c4c3be736312

2020-07-16 dproy@google.com Merge "metrics: Allow chrome metric protos to be compiled in"
2020-07-16 lalitm@google.com amalgamated: use the toolchain script to find clang

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Iec1a128013b1766c204c89bb08f156114af3453a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303122Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#789257}

https://skia.googlesource.com/skia.git/+log/7fe0359130f9..442d424a7287

2020-07-16 reed@google.com Revert "Serialize mipmaps"
2020-07-16 michaelludwig@google.com Fix GrTAllocator tests
2020-07-16 brianosman@google.com Make invokeChild default to fInputColor, rather than half4(1)
2020-07-16 bsalomon@google.com Consolidate sampler->index/key conversion
2020-07-16 herb@google.com reorganize GrAtlasTextOp creation
2020-07-16 adlai@google.com FIx imagemakewithfilter test in OOPRDDL config
2020-07-16 egdaniel@google.com Use staging buffers in d3d for texture uploads.
2020-07-16 herb@google.com simplify GrAtlasTextOp's onPrepare
2020-07-16 reed@google.com Serialize mipmaps
2020-07-16 brianosman@google.com Remove modulation by input color in GrTextureEffect
2020-07-16 elliotevans@google.com Add Puppeteer perf for release and experimental_simd builds of CanvasKit against SKPs
2020-07-16 rmistry@google.com Add canary roll CL link to canary task driver
2020-07-16 mtklein@google.com support 64-bit gather()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC nifong@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: nifong@google.com
Change-Id: I4e0a5326bc6fe8315b75422645d7694fbc8c1905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303610Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#789256}

This CL includes:

- Some gentle style updates.
- Explicit extraction of only one file.
- Use of SetFileInformationByHandle to set the creation time and
  attributes of the output file before closing it rather than use of
  SetFileTime and SetFileAttributes after the fact. This avoids
  potential filesystem races.
- Removal of some dead code.

BUG=None

Change-Id: Iaa27f6951a96fc5cec55fa9b0cd8505f48f2515e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303710
Commit-Queue: Greg Thompson <grt@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789255}

This CL adds functions to download the latest or any given version of
ash-chrome.

Bug: 1104318
Change-Id: I32da0de5d590586a4c47f55c93fc004e00ce70af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302931
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789254}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I9b7d8ae2b062e8f030c01ab8d6b1024c1cd348aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303105
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#789253}

Adds a config for the FullscreenControllerBrowserScoped flag.

Bug: 790886
Change-Id: Ibbb765e6d7affa49bde4afc8effefdce48da94a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299236Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789252}

Screencast: http://dr/file/d/1eBuaixYJ1kbutQBpT4bCTlyjHY66OeLP/view
Screenshots: http://screen/PebTHg6AOTm, http://screen/2SoE6iSFJ3a

Finch param command line test flags:
-enable-features="SharingQRCodeGenerator<MyStudy"
--force-fieldtrials=MyStudy/Group1
--force-fieldtrial-params=MyStudy.Group1:max_url_length/300

Bug: 1105139
Change-Id: I3277f02ac35bcb94d998c8a7c37b1becc26eee79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299462Reviewed-by: Travis Skare <skare@chromium.org>
Reviewed-by: Tanya Gupta <tgupta@chromium.org>
Commit-Queue: Sophey Dong <sophey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789251}

Bug: 995969
Change-Id: Ib89e52839557ee11d92141575e3fa77d68b3ed24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292295Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789250}

This is a part of the work of removing from
DisplayItemClient::VisualRect(). Now we calculate visual rect for
display items during paint.

For most SVG objects, the visual rect is simply
EnclosingIntRect(object.VisualRectInLocalSVGCoordinates()) (not
including outlines).

Bug: 1104064
Change-Id: If72e66238585c17c48fda21a80060c24029b25f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301206Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789249}

When a window is resized, a locationChanged event is not fired on its
descendants (e.g. the maximize button, the web contents). So Switch
Access' locationChanged handler should listen to events on all of the
current node's ancestors as well.

Also adds support for listening to multiple nodes with
RepeatedEventListener.

AX-Relnotes: n/a.
Bug: 1105296
Change-Id: Idba74866ef71fa0adebb1e08647a860404afb43e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300825Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#789248}

Change-Id: I7230bd37e7f9c1c136e1c23b6acdc340eb089121
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303452Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789247}

We are starting up new experiments with Paint Holding and need these
histograms to continue.

Bug: 1104961
Change-Id: I6683260b5459c7b2cbe83a2aa7f6669af1a304ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300933
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789246}

Flake portal:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTgsSBUZsYWtlIkNjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFRhYk1hbmFnZXJUZXN0LkRpc2NhcmRUYWJzV2l0aE9jY2x1ZGVkV2luZG93DA

TBR=fdoray@chromium.org

Bug: 1106485
Change-Id: Iee3f1a06c3819e0bdb29e89d38534913d80761a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303769Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789245}

One of the tests used to disable the ability to proceed to the web page
via an experiment preference (testProceedAlwaysDisabled) wasn't cleaned
up after the test is done. Instead add cleanup and set the preference to
default in setup.

Bug: 1106070
Change-Id: I57d2a378491f84281bbede147089aa88c98ca8ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300823
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Auto-Submit: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789244}

Fixed: 1105085
Change-Id: Id39e2ecdf4f2196c78c84b85bf6c0ab7ff051f0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299345Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789243}

Make sure that an invalidated dialog doesn't call
AppModalDialogQueue::ShowNextDialog() during shutdown. This could
potentially cause issues as it causes ShowNextDialog to be reentrant,
which doesn't seem intentional.

Also remove an unnecessary check: the active dialog is not in the dialog
queue so we don't need to check the queue against the active dialog when
hiding a batch of dialogs.

Bug: 1060986
Change-Id: I962a5cf14c3f5b67d287de61464b604dbe96aaf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295822
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789242}

Currently, the vertical and a11y tab switchers observe the browser
controls even if they aren't visible. This affects the rendering
performance for the tabs.

The fix is to add/remove the observer when the layout shows/hides.

Bug: 1105601
Change-Id: I60fd18fdeebf3d281ab95146a16c99ff8c5acde5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300986Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#789241}

Validate the communication between NetworkDiagnosticsImpl and the
routines.

BUG=chromium:1096551
TEST=unit_tests --gtest_filter=NetworkDiagnosticsImplTest.*

Change-Id: Id0868b88791e4b3fe9ec18b6257b68ef64ed41b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274149
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789240}