- 13 Jun, 2018 40 commits
-
-
sczs@chromium.org authored
When a new Folder is created, the folder cell is created on edit mode. If we try to delete the cell at this point (by swiping the cell to the left) a crash occurs (both on legacy and UIRefresh). This Cl prevent this crash by returning NO on canEditRowAtIndexPath for the editingFolderCell. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iaca9d4d7001d89d795d2ce2c82db46a092086ec9 Reviewed-on: https://chromium-review.googlesource.com/1098230 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#566705}
-
Bence Béky authored
Use CompletionOnceCallback in most places in //net/dns, except for dns_transaction.cc. Bug: 807724 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie2a8ad3ed9e5285761d7321ec337e888b55b9dd9 Reviewed-on: https://chromium-review.googlesource.com/1091596Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#566704}
-
Hirokazu Honda authored
The number of decoded frames should be equal to the number of frames of input video, if no Reset() is invoked before Flush(). Should check this condition in VDA unittest. BUG=chromium:834170 TEST=VDA unittest on eve and kevin TEST=VDA unittest on non-Chrome OS platforms in CQ. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2eda613522b9a1e6259a9d72c4f86b616bc90996 Reviewed-on: https://chromium-review.googlesource.com/1063910 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#566703}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Iac2d8e016f55f31b210e1e737f9f9d4258299480 Reviewed-on: https://chromium-review.googlesource.com/1098206Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#566702}
-
Ryan Sturm authored
This is recorded for pages in OnComplete and it is recorded for all pages that were paused when the page load completed. Bug: 797989 Change-Id: Ia42b917305cf96160134085d7608a25e3f828ae7 Reviewed-on: https://chromium-review.googlesource.com/1093431 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#566701}
-
Noel Gordon authored
The test tests that Quick View closes when users click Quick View when it is in open state. Change the test to use a text file, rather than a PNG image, to remove image decode and rescale costs from the test-time. The test awaits the close using a pending() call, but did not define a |caller|, which is a required argument of pending(). Fix that. Also put all tests steps in a StepRunner group, so that all test steps can be debugged using the step runner browser test flag. Document each of the test steps. Bug: 851888 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I39310b57f9ed09e5d164b95b11b7494dc45adffa Reviewed-on: https://chromium-review.googlesource.com/1097048 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#566700}
-
Noel Gordon authored
The test tests that Quick View opens by the usual method: user presses the space key on a selected file. Change the test to use a text file, rather than a PNG image, to remove image decode and rescale costs from the test-time. Also put all tests steps in a StepRunner group, so that all test steps can be debugged using the step runner browser test flag. Document each of the steps. Bug: 851888 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ief21de93e9496f463506d2ae22ab28db76c087ef Reviewed-on: https://chromium-review.googlesource.com/1097041Reviewed-by:
-
Kai Ninomiya authored
This replaces the GLsync object in WebGLSync with the GL_READBACK_SHADOW_COPIES_UPDATED_CHROMIUM query from the GL_CHROMIUM_nonblocking_readback extension. In order to prevent invalid readback results when using transform feedback, this calls InvalidateReadbackBufferShadowDataCHROMIUM on buffers when they are written by transform feedback. Bug: 828135 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia5662e01fb2485595a1cd46e5c66d4db04efaf92 Reviewed-on: https://chromium-review.googlesource.com/1036403 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#566698}
-
Jun Choi authored
With new update on the Cable spec, the ordering of elements in client/authenticator advertisement packets has changed. Update FidoCableDiscovery accordingly. Bug: 851004 Change-Id: Ib40ec3af1e10490ea80e8934403cd1a381319f83 Reviewed-on: https://chromium-review.googlesource.com/1093256 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#566697}
-
Ben Pastene authored
By default, all FYI tests run at pri 40, while all non-FYI tests run at pri 30. Since some optional CQ bots mirror FYI bots, their tests run at a lower pri than other CQ tests. Consequently, if the pool is in full use, there's a chance that the optional tests will get starved out and expired. This leads to a blocked CQ run if the CL in question is required to pass these optional bots via "Cq-Include-Trybots" commit msg footer. This increases priority of all known CQ-optional FYI bots to match normal CQ tests. Bug: 851115 Change-Id: I9c7625e498f098a6613729777d3782c2b4b6625c Reviewed-on: https://chromium-review.googlesource.com/1097600Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#566696}
-
Jiaquan He authored
This commit: - moves AppListPresenterImpl into //ash/app_list/presenter, and extracts all its accesses to Ash out to ash::AppListPresenterDelegateImpl; - moves AppListPrenseterImplTestApi into AppListPresenterImpl; - moves AppListPresenterImplTest into ash_unittests and reenables all tests in it. With this commit, we'll have the following dependency chain for app list: ash -> presenter -> view -> model An upstream component has access to its downstream components (e.g.from presenter to view, fromash to model). A downstream component can access its upstream components with specific interfaces: model -> *: via AppListModelObserver; view -> *: via AppListViewDelegtate; presenter -> *: via AppListPresenterDelegate; Bug: 733662 Change-Id: Iaa67c44aacdc79ecf7fd27682b6d9f89c2554c70 Reviewed-on: https://chromium-review.googlesource.com/1096549Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Eliot Courtney authored
BUG=b:109773984 BUG=841886 Change-Id: Ib04cd920450f7e63e779220b24a65956f3bc1e1f Reviewed-on: https://chromium-review.googlesource.com/1088342Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#566694}
-
Joel Hockey authored
Currently FileTransferController starts a 2s timer to change to a directory if you drag and then hover over a root. This happens on the dragenter event. The dragleave event will cancel the timer if it has not already fired. For crostini, we want to change to the directory immediately. Test fires dragenter and then dragleave events immediately after each other. Usually this would cause no change if the events are received within 2s of each other. We test for crostini that even if these events are fired right after each other, we still change directory. Bug: 846917 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4f0f463ff1c4bc164328a2764ff235ee399d6e4c Reviewed-on: https://chromium-review.googlesource.com/1096801 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Mathieu Perreault authored
Enables it for Windows and ChromeOS Bug: None Change-Id: Id612d9893cc329dbd9d405c63261a049246e33d5 Reviewed-on: https://chromium-review.googlesource.com/1090408 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#566692}
-
Sam McNally authored
This is a reland of ac0ccdc1 with FileManagerBrowserTestBase::drive_volume_ null-initialized. Original change's description: > Add a FakeDriveFs and change FileManagerBrowserTestBase to use it. > > Bug: 848126 > Change-Id: Icb7b5edf28aa61e133aff0f0bf639f06b32adcfa > Reviewed-on: https://chromium-review.googlesource.com/1088336 > Commit-Queue: Sam McNally <sammc@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Sasha Morrissey <sashab@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566333} Bug: 848126 Change-Id: I583fd6ebe92e5f191de93a3b3167a1c50e595a95 Tbr: noel@chromium.org, sashab@chromium.org, xiyuan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1098395Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#566691}
-
Mike Frysinger authored
There's nothing in this script that really requires being run in the top level of the src.git repo other than the git commit logic. That means we can run this script completely outside of src.git if given a set of paths to operate on. Move the check into the git scenario. Bug: None Test: ran the script outside of src.git on some png files Change-Id: I4d1343f3757a05e8675ac80c618c8b4ec23e1695 Reviewed-on: https://chromium-review.googlesource.com/1097615Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#566690}
-
Victor Costan authored
Release notes: https://www.sqlite.org/releaselog/3_24_0.html This CL removes 0011-Handle-TRUE-and-FALSE-in-DEFAULT-expression-for-ALTE.patch because it is included in the 3.24 code. Bug: 851064 Change-Id: Ieca195ba13822a86c2b57df9c5e019de2a23e09f Reviewed-on: https://chromium-review.googlesource.com/1093300Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#566689}
-
Carlos Knippschild authored
Change-Id: I0b4735b38d3bad5c19ae126486011df8144275e2 Reviewed-on: https://chromium-review.googlesource.com/1098027 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#566688}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9c0e3063ddb1..3e313805e5a2 git log 9c0e3063ddb1..3e313805e5a2 --date=short --no-merges --format='%ad %ae %s' 2018-06-12 lucferron@chromium.org Vulkan: Line loop edge case with ubyte indices Created with: gclient setdep -r src/third_party/angle@3e313805e5a2 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I8961aac6a3c14bf80b6fde65ebb0166df213887f Reviewed-on: https://chromium-review.googlesource.com/1098235Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566687}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a3843c99e7a6..81a3085b250d git log a3843c99e7a6..81a3085b250d --date=short --no-merges --format='%ad %ae %s' 2018-06-12 hnakashima@chromium.org Refactor modification of Contents in CPDF_PageContentGenerator. 2018-06-12 tsepez@chromium.org Comment some more #else // PDF_ENABLE_XFA 2018-06-12 hnakashima@chromium.org Fill m_ContentStream field in CPDF_PageObject. 2018-06-12 tsepez@chromium.org FPDFPage_New(), FPDF_LoadPage(): Fallthru into PDF case if no XFA context. 2018-06-12 tsepez@chromium.org CheckUnSupportError() always called with FPDF_ERR_SUCCESS. Created with: gclient setdep -r src/third_party/pdfium@81a3085b250d The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2d9db1b44dfa99923318dd83b04d23e288f9a4ce Reviewed-on: https://chromium-review.googlesource.com/1098315Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566686}
-
Chris Blume authored
glslang_test is only built in a Vulkan build. Since it doesn't build, it prevents us from having Vulkan as part of the default build. It appears like a file was renamed at some point and the BUILD.gn wasn't updated to reflect this change since it wasn't being tested in the default build. This CL includes the newly renamed file and allows glslang_test to be built and run again. BUG=852196 Change-Id: I11507bd51996caed6280501f36556e17334bb1ba Reviewed-on: https://chromium-review.googlesource.com/1098379Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#566685}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/51345cbe..3f7f40e7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I538008481f9224bf2921dd5f0fcb53db895c6885 Reviewed-on: https://chromium-review.googlesource.com/1098196Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#566684}
-
Jialiu Lin authored
1. Change IDS_SAFE_BROWSING_SCOUT_REPORTING_TITLE and IDS_SAFE_BROWSING_SCOUT_REPORTING_SUMMARY in android_chrome_strings.grd to match unified consent strings 2. Update IDS_FEEDBACK_SERVICE_DIALOG_EXPLANATION_SCOUT to match unified consent string, and move it from google_chrome_strings.grd and chromium_trings.grd to generated_resources.grd. 3. set localized "safeBrowsingEnableExtendedReporting" and "safeBrowsingEnableExtendedReportingDesc" to unified consent strings unconditionally. Bug: 837857 Change-Id: If659d187c5fd3a4a587c090997b2db8db9127e57 Reviewed-on: https://chromium-review.googlesource.com/1097556 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#566683}
-
Bret Sepulveda authored
Some tests would create an instance of OmniboxViewViews, but without a location bar. Refresh tries to access the location bar to set the placeholder text, and this would crash. This patch moves that code into Init and guards it by checking that location_bar_view_ is defined. Bug: 846410 Change-Id: I0a1aec21f515dcc441e52c92c0c1adc58163348f Reviewed-on: https://chromium-review.googlesource.com/1098141Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#566682}
-
Yuki Awano authored
- When window is maximized, Android content is rendered without considering caption bar. We need to adjust accessibility node bounds to consider it. window in maximized state. Confirm that accessibility focus rect is shown in the right place. Bug: 850427 Test: Enable chrome caption bar and spoken feedback. Open any Android Change-Id: I82a6020135623d73f0f5905ef49ce44328470108 Reviewed-on: https://chromium-review.googlesource.com/1090598Reviewed-by: -
Josh Pratt authored
At the startup of the CrostiniRegisteryService (at login), this records the number of Crostini apps in the registry. The histogram uses UMA_HISTOGRAM_COUNTS_1000. Bug: 703927 Change-Id: I12ddd7bebc0b735ce76ad3a1b23a63eab0886103 Reviewed-on: https://chromium-review.googlesource.com/1080429 Commit-Queue: Josh Pratt <jopra@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#566680}
-
Darren Shen authored
Whenever KeyboardController is created/destroyed, observers need to be re-registered. KeyboardObserverRegister was introduced to simplify this process. However, with the new KeyboardController lifetimes, we only create/destroy the KeyboardController once, so we don't need to use KeyboardObserverRegisters anymore; we just need to register once at the beginning and unregister once at the end. We don't need to check whether KeyboardController is enabled when adding an observer, as none of the observer events are raised when the KeyboardController is disabled. Bug: 845780 Change-Id: I2bba7919ad7330649209fe3b6f44f74d26b650e3 Reviewed-on: https://chromium-review.googlesource.com/1075841 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#566679}
-
Ken Rockot authored
Enables the onAuthRequired WebRequest event to fire (and potentially block) as expected when the Network Service is enabled. Bug: 841827 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia8d13bf8465438dee780de36f6b34bcdc681f1a7 Reviewed-on: https://chromium-review.googlesource.com/1081659 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#566678}
-
Charlie Reis authored
Filesystem and blob URLs don't have a chrome-extension:// scheme according to GURL, but do according to url::Origin. BUG=851503, 840857 Change-Id: Ia5e4cf5f9c3d04dff07d4f31da6d774d574af653 Reviewed-on: https://chromium-review.googlesource.com/1093402 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566677}
-
Scott Chen authored
Bug: 828333 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If101939b46697c7da6e9c0a0fc4f7219c83f11c1 Reviewed-on: https://chromium-review.googlesource.com/1095641 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#566676}
-
Parastoo Geranmayeh authored
Multiple address fields may belong to multiple sections on a form, and may not mean different address lines, and thus may not need rationalization. Also, multiple address fields may be hidden/visible pairs, and not different lines. While rationalizing address fields, one should consider the sections identified by the heuristics (DetermineHeuristicTypes). These sections are based on the types predicted by heuristics. This way we are merging the two sources of type predictions. Examples are included in the tests. Bug: 835975 Change-Id: I9f3680e69162b6b7d01203bd89773a99e5ca8af7 Reviewed-on: https://chromium-review.googlesource.com/1093796 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#566675}
-
Xing Liu authored
When download location change feature is disabled, we always use default location, in case the feature is enabled and disabled that the user may stuck at SD card location when the feauture is turned off. Bug: 848136 Change-Id: If4a444a8f9c89734a45aee43c8eb98fec5862d18 Reviewed-on: https://chromium-review.googlesource.com/1095860 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#566674}
-
Xing Liu authored
Currently we check externally removed flag to block opening file. This logic is not mostly used. 1. On primary storage, we delete the db record when the file is externally removed. 2. On SD card storage, this logic will block user to open the file when reinserting the SD card. So we should delete this logic and always try to open the file Bug: 850307 Change-Id: Ibbd2c3e7c8bf0b2f69263a406cfa5b4240bf0097 Reviewed-on: https://chromium-review.googlesource.com/1096660Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8e4d09ae7af1..47fd204aa6c0 git log 8e4d09ae7af1..47fd204aa6c0 --date=short --no-merges --format='%ad %ae %s' 2018-06-12 benjaminwagner@google.com Remove remaining references to G930A. Created with: gclient setdep -r src/third_party/skia@47fd204aa6c0 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I55bc27521d2833cf87c4e2536eb68f95becd36be Reviewed-on: https://chromium-review.googlesource.com/1097878Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566672}
-
Antoine Labour authored
After https://crrev.com/c/1089695, while using ProduceTextureDirect, it is not possible any more for a client to: 1- reassign an existing mailbox to another texture 2- unlink a mailbox from a texture TakeFrontBuffer can technically still do (1), but ReturnFrontBuffer is a good place to unlink the mailbox service-side. This allows some simplification of the MailboxManager implementations, as well as the decoders. Bug: 847674 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I422b7ba8bcb762d1a5aea63f59dc833002f3d6b3 Reviewed-on: https://chromium-review.googlesource.com/1097696 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#566671}
-
Sunny Sachanandani authored
A number of fixes to make underlays work with non root render passes: 1) Transform clip rect to display space so that it works correctly for transformed non-root render passes. 2) Use the RPDQ clip for solid color quad behind the RPDQ. 3) Clip the punch through rect using the video quad's clip rect, and propagate the clipped value up the stack. 4) Do not propagate video quad or RPDQ opacities as that doesn't work correctly. 5) Do not overwrite underlay rect or occlusion if there are multiple underlays in a frame. 6) Lots of comments! Bug: 843814 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib62bd3834e7e7856c02d9f304b2b4e4f594fd9cd Reviewed-on: https://chromium-review.googlesource.com/1087774 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
dpapad authored
Polymer 2 automatically converts <template is="dom-if"> to <dom-if><template>, so the query selector needs to be updated. Also the way to get cached <template> contents is slightly different. Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5625295e4138fa92a6a4b728123a7f58e3e06c0e Reviewed-on: https://chromium-review.googlesource.com/1096476Reviewed-by:
-
Bence Béky authored
Since there can be at most one ping in flight, change member type from integral to Boolean, and change name from plural to singular. This is a follow-up to https://crrev.com/c/1093561. Change-Id: Ie7b6b7a1236ee69d8cab32c0c543f61fba1a1cad Reviewed-on: https://chromium-review.googlesource.com/1097212Reviewed-by:
-
Bence Béky authored
Change return value callback method from CompletionCallback to CompletionOnceCallback in all TestCompletionCallbackBase derived classes except for TestCompletionCallback, and use BindOnce instead of Bind. Remove CompletionCallback private members and bind at method call time instead of construction time. Bug: 807724 Change-Id: I2931d7a0ff5086a8733b8a27a7940d90f95ae683 Reviewed-on: https://chromium-review.googlesource.com/1097200Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#566667}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If4aab3855e1147358506acb85a5ec5458fd9e349 Reviewed-on: https://chromium-review.googlesource.com/1098388Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#566666}
-
