GitLab

> [fsp] Add an option for mounting in R/W mode.
> 
> Files app fetches information whether a volume is read only or R/W from
> file_manager::VolumeManager, which used to always have the isReadOnly option
> set to true for any provided file system.
> 
> However, since R/W operations are now under development, we should be able to
> mark a volume as R/W.
> 
> In order to achieve that, a "writable" option has been added to the File System
> Provider API mount() call. The argument is by default false, so file systems
> are by default read only.
> 
> TEST=unit_test, browser_tests: *FileSystemProvider*Writable*
> BUG=391362
> 
> Review URL: https://codereview.chromium.org/372163006

TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/391613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282900 0039d316-1c4b-4281-b951-d872f2087c98

When expanding the live tiles rect, we want to include border pixels
for all tiles that intersect the live tiles rect. It used to do this
by also including any tiles whose border pixels intersect the live
tiles rect, but that's excessive.

This adds ExpandRectIgnoringBordersToTileBoundsWithBordersEmpty and
uses it to expand the live tiles rect, the unit test
PictureLayerTilingIteratorTest.ResizeOverBorderPixelsDeletesTiles
covers this usage of the method.

The ExpandRectToTileBoundsWithBorders is no longer used, so remove it.

R=enne
BUG=386998

Review URL: https://codereview.chromium.org/385123006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282896 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282893 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Remove media::VideoRenderer::SetPlaybackRate(). (https://codereview.chromium.org/384943002/)

Reason for revert:
Sorry to revert this change. It made the following layout tests flakily fail:
media/track/track-cue-rendering-horizontal.html
media/track/track-cue-rendering-vertical.html

Reverting locally healed the tests.

The image diffs show what appears to be a timestamp change (something like 0:18 to 0:19):
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__dbg_/20779/layout-test-results/results.html

Original issue's description:
> Remove media::VideoRenderer::SetPlaybackRate().
> 
> Video renderers don't need the information as they are already making
> audio/video synchronization decisions based on a media timeline that
> already incorporates the current playback rate via the time callback.
> 
> In particular, VideoRendererImpl only used playback rate to estimate
> a better duration to sleep until the current frame was ready ...
> except that in most cases we'd sleep for kIdleTimeDelta and wait
> until the media timeline had progressed past the current frame's
> timestamp. In other words, there's absolutely no reason to even try
> to estimate the sleep duration based on the playback rate.
> 
> BUG=370634
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282797

TBR=xhwang@chromium.org,scherkus@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=370634

Review URL: https://codereview.chromium.org/390733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282891 0039d316-1c4b-4281-b951-d872f2087c98

Files app fetches information whether a volume is read only or R/W from
file_manager::VolumeManager, which used to always have the isReadOnly option
set to true for any provided file system.

However, since R/W operations are now under development, we should be able to
mark a volume as R/W.

In order to achieve that, a "writable" option has been added to the File System
Provider API mount() call. The argument is by default false, so file systems
are by default read only.

TEST=unit_test, browser_tests: *FileSystemProvider*Writable*
BUG=391362

Review URL: https://codereview.chromium.org/372163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282890 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/367963003/

Fix use-after-free error

BUG=170544, 377538
R=jgraettinger@chromium.org

TEST=SpdySessionTest.PushedStreamShouldNotCountToClientConcurrencyLimit
SpdySessionTest.RejectPushedStreamExceedingConcurrencyLimit
SpdySessionTest.IgnoreReservedRemoteStreamsCount

Review URL: https://codereview.chromium.org/371273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282889 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/387853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282888 0039d316-1c4b-4281-b951-d872f2087c98

TBR=estade@chromium.org
BUG=392949

Review URL: https://codereview.chromium.org/389863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282887 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282886 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178012:178012&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/388123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282885 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282880 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/390713002

Fixes issues from previous failed roll which included

https://codereview.chromium.org/375983002
https://codereview.chromium.org/376873009

R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/387003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282879 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390346

Review URL: https://codereview.chromium.org/376663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282878 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282873 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178010:178011&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/389133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282872 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282871 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178008:178009&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/384173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282870 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282864 0039d316-1c4b-4281-b951-d872f2087c98

GetSystemNSSKeySlot returns the ChromeOS system-wide TPM slot.

ChromeOS has separate slots for each user and linux doesn't have a public/private split, so GetPrivateNSSKeySlot no longer makes sense.

BUG=210525
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/383593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282862 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282861 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282860 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178005:178007&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/389813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282859 0039d316-1c4b-4281-b951-d872f2087c98

Move the code responsible for showing network icons into a common component
so that it can be used from both ash and athena. This also moves the relevant
string and image-resources out of ash into separate ui_chromeos_ targets.

R=mmoss@chromium.org, oshima@chromium.org, sky@chromium.org, stevenjb@chromium.org
TBR=derat@ for third_party/cros_system_api owners
BUG=387199

Previously landed in r282837, and reverted in r282839 because it broke non-chromeos builds.

Review URL: https://codereview.chromium.org/351353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282858 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/383393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282857 0039d316-1c4b-4281-b951-d872f2087c98

This provides an implementation of the mojo surfaces service and a
sample with two mojo applications composing each other via surfaces. The
viewport / display hookup is a bit of a hack in this patch as is the
complete lack of scheduling logic, but it's enough to get started.

Review URL: https://codereview.chromium.org/361123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282856 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282855 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178004:178004&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/384163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282854 0039d316-1c4b-4281-b951-d872f2087c98

Fixes

..\..\win8\metro_driver\winrt_utils.cc(80,1) :  error(clang): pasting formed 'CreateString(', an invalid preprocessing token [-Winvalid-token-paste]
IMPLEMENT_CREATE_PROPERTY(String, HSTRING);
^
..\..\win8\metro_driver\winrt_utils.cc(54,47) :  note(clang): expanded from macro 'IMPLEMENT_CREATE_PROPERTY'
  hr = property_value_statics->Create ## Name ## ( \
                                              ^

BUG=82385
TBR=grt@chromium.org

Review URL: https://codereview.chromium.org/373423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282853 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943

Review URL: https://codereview.chromium.org/385943006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282852 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Four new pages added to tough_scheduling_cases (https://codereview.chromium.org/372243003/)

Reason for revert:
Causes scheduler.tough_scheduling_cases to fail on all android bots. Example:
http://chromegw/i/chromium.perf/builders/Android%20Nexus4%20Perf/builds/1081/steps/scheduler.tough_scheduling_cases/logs/stdio

Original issue's description:
> Four new pages added to tough_scheduling_cases
> 
> BUG=391005
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282740

TBR=jdduke@chromium.org,skyostil@chromium.org,picksi@google.com,miletus@chromium.org,picksi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=391005

Review URL: https://codereview.chromium.org/388053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282847 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282846 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177992:178003&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/390623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282845 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82385
TBR=joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/385373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282844 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282843 0039d316-1c4b-4281-b951-d872f2087c98

Fix the merge conflict and reland http://crrev.com/282726, which was
reverted in http://crrev.com/282732.

TBR=estade@chromium.org,thestig@chromium.org,groby@chromium.org
BUG=389918

Review URL: https://codereview.chromium.org/389733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282842 0039d316-1c4b-4281-b951-d872f2087c98

This is by no means finished. There are plenty of things to do - but I send it out now so that you can have a look at it as it is to see what my plans are.

Note: The activities management functions are not yet called. So there should be no impact on anything running yet. 

Please have a look! If you generally agree I will try to get it in before I go on vacation, otherwise it will have to wait until I get back. I might even work tomorrow instead of taking off as planned if needed.

BUG=388085
TEST=not yet done
TBR=rsesek

Review URL: https://codereview.chromium.org/358003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282841 0039d316-1c4b-4281-b951-d872f2087c98

desired size in DIP pixels and a desired scale.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/331163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282840 0039d316-1c4b-4281-b951-d872f2087c98

> chromeos: Move some network related UI in ui/chromeos/
> 
> Move the code responsible for showing network icons into a common component
> so that it can be used from both ash and athena. This also moves the relevant
> string and image-resources out of ash into separate ui_chromeos_ targets.
> 
> R=mmoss@chromium.org, oshima@chromium.org, sky@chromium.org, stevenjb@chromium.org
> TBR=derat@ for third_party/cros_system_api owners
> BUG=387199
> 
> Review URL: https://codereview.chromium.org/351353004

TBR=sadrul@chromium.org

Review URL: https://codereview.chromium.org/383373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282839 0039d316-1c4b-4281-b951-d872f2087c98

We have switched from fgets to read, but the change did not
modify code which converts CRLF to LF.

https://codereview.chromium.org/133033002

Due to this reason, we were running strlen for the buffer
filled by read, which is not always NULL terminated.

This change simply removes the CRLF-to-LF conversion. This is
safe because we do not have any newlines in the test file.

BUG=392768
TEST=./out/Debug/browser_tests --gtest_filter='*NonSfi*IrtMani*'
TEST=trybots

Review URL: https://codereview.chromium.org/383063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282838 0039d316-1c4b-4281-b951-d872f2087c98

Move the code responsible for showing network icons into a common component
so that it can be used from both ash and athena. This also moves the relevant
string and image-resources out of ash into separate ui_chromeos_ targets.

R=mmoss@chromium.org, oshima@chromium.org, sky@chromium.org, stevenjb@chromium.org
TBR=derat@ for third_party/cros_system_api owners
BUG=387199

Review URL: https://codereview.chromium.org/351353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282837 0039d316-1c4b-4281-b951-d872f2087c98