- 07 Jan, 2021 40 commits
-
-
Dominique Fauteux-Chapleau authored
This adds the basic internal changes to SafeBrowsingPrivateEventRouter needed to report per-profile events. This CL doesn't add new tests, as this is difficult without other per-profile CLs being submitted. Adding such tests is tracked in crbug.com/1159930 Bug: 1159533 Change-Id: I65f626941367fb31ac6005fa230624d01f861718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595833Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#841152}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Idcc33a8fe0e0c1591bc1a9d023ba3a6d2c2fd9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614727Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841151}
-
Toni Barzic authored
App list view state changes are animated whenever app list view bounds change, which includes cases where app list transition starts from position midway between app list view states - for example, after dragging app list view, or if a state transition interrupts another state transition. Reporting animation smoothness for all app list view state transition introduces some noise - this cl reduces the cases where animation smoothness is reported to only cover full app list state changes. I.e. the animation smoothness in now reported only if the initial bounds and transform match values expected for the starting (current) app list state. This requires OnStateTransitionAnimationCompleted() to be moved to the animation observer callback, rather then animation smoothness report callback, as the report callback will now not run for all transitions. With this change, state transition animation completion is reported sooner, before the metrics results are reported. This alone breaks launcher perf tests - the tests wait for the app list view state to get to a target state, and then close the app list view. New transition timing means that app list view state change may happen before the smoothness metric gets reported - the reporter target state gets reset when the app list view state changes, and causes the reporter not to reporting the metric for the just completed state transition. To fix this, the reporter callback creation is updated to return a callback with an argument bound to the current state at the time of callback creation, instead of using the cached app list state at the time the report callback is run. Additionally, not reporting smoothness for transitions that start mid way through previous transition broke reporting for directly showing app list in fullscreen mode. The app list was initially shown in peeking state and then immediately moved to fullscreen state, which meant that transition from closed to fullscreen state was always starting from an interrupted transition to peeking state. To address this, change AppListView::Show() interface to accept preferred initial state. The change exposed an issue where observers were notified of state change before the internal AppListView state was updated (in cases where transition animations were immediate), potentially causing nested state changes - specific case: app list close transition was causing search box to be cleared, which updates the app list view state, and because it happened before app list view state got updated to closed, this started transition to fullscreen state. The CL updates the state change flow to notify observers that the app list view transition finished only after internal state is updated. BUG=1114525 Change-Id: I38193b0101fea8c8fec6badb07a0e08b0776f8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608848Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841150}
-
Mitsuru Oshima authored
Bug: None Change-Id: Ic670b45600d30ec1b4e8a679d9033803c2cea3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608655Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#841149}
-
Dan Harrington authored
This is provided for use by xsurface. It is backed by Chrome's shared ProtoDatabase. Data is automatically wiped on the same events that wipe other feed data. Bug: 1158468 Change-Id: Id215ec00311883acc65c7f3d6b87570c4b255278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590649Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#841148}
-
Nathan Zabriskie authored
Currently when using OneCopyRasterBufferProvider we perform an upload from CPU shared memory to the GPU and then a GPU to GPU copy during raster playback. This CL allows direct upload of CPU shared memory to the output shared image texture through the use of a new hint in RasterDecoder::CopySubTexture that indicates CPU memory should be used directly. This also allows us to unify how the copy is implemented in RasterDecoder to always use Skia. Bug: 984045 Change-Id: I6ac7d238cf3b2f43562481e2e1b36b3c4670a6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517149 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#841147}
-
Sophie Chang authored
Bug: 1154790 Change-Id: I737a56b26abf8cbe56e5f613e73b02dbffbcbc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611649Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#841146}
-
Tanya Gupta authored
LongScreenshotsEntry allows for management of multiple FDT requests and generated bitmaps. EntryManager is responsible for managing all of the entries. Bug: 1153969 Change-Id: I11053f9b0ba0a47282f0e1e6153f37675de3ab1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605600 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#841145}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/5820c040a91a..725a542f7776 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 9f10caf9c4f3 to ebd3ea2ecbac (2 revisions) 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from cc435b55410a to 9f10caf9c4f3 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC ianelliott@google.com,enga@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com,enga@google.com,radial-bots+chrome-roll@google.com Change-Id: Ia2bb761654880fb7a54d1b68ed7e7fface908849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615178Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841144}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609999114-48d6c013bfb0cf3d871ee24efc89ddcdc4d51629.profdata to chrome-win32-master-1610009713-66490881217dda72de1fa905fa3f863deeda7cfb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia0abd260f3999737ba7bf6ded870213e68900e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614566Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841143}
-
Victor Costan authored
The ParameterizedVisibleUnitsSentenceTest test suite does not have any test case. This CL removes it. This problem was discovered by attempting to roll googletest past CL 315255779, which causes test binaries to fail when they include test suites / parametrized tests that are not instantiated, and when they include empty test suites. Bug: 1163396 Change-Id: I95213add5ed04cd08ef1b208141c9903075b686e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615659 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#841142}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ddb981175c35..61704b4db5d7 2021-01-07 jegarc@microsoft.com Styles: Prevent invisible properties to invalidate visible ones 2021-01-07 tvanderlippe@chromium.org Convert UIString.js to TypeScript-authored If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1163314 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I360e91ea928178f07ac6ac8e34a69c65b964f946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615179Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841141}
-
Alison Maher authored
To handle layout of OOF positioned elements inside a nested fragmentation context, we will delay layout of the OOFs until they've reached the outermost context, at which point they will get laid out inside the inner multicol in which their containing block was found. This change stores such inner multicols in the container builder and physical fragment as a means to propagate the associated inner multicols up to the outer context where their OOFs will be laid out. This change also adds logic to halt the propagation of OOF positioned fragmentainer descendants up the tree if we've reached a multicol. In this case, we would know that we are in a nested context, and any OOFs that have reached their containing block should remain in the inner multicol's physical fragment rather than continuing up the tree. See design doc for more details: https://docs.google.com/document/d/13Pn7SSJjzskg9kQ4jErzlJrj2j4zGBfNBFLEeDVENUU/edit?usp=sharing Note: The OOF elements inside a nested context are not yet getting laid out, which will cause related tests to crash. This will be addressed in follow-up changes. Bug: 1079031 Change-Id: I87399a67c6fc5021f3323afe8fae0b15e6e13eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612392 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#841140}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609988385-9c096aa1bc5d021f182b9150cd47fcb15e7461d7.profdata to chrome-win64-master-1610009713-6f95aef060564dd70c8d09ec603d31a9c7b42ed0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If22004de98c832154e26fb81d53f84f3223a0b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614189Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841139}
-
Kyle Horimoto authored
This reverts commit 3ece5c0f. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1163902 Original change's description: > Move crostini section under Advanced in settings. > > Bug: 1163003 > Change-Id: I9b2b439007c80bc0385128da4817ac001ee7eb0c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610407 > Auto-Submit: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840920} TBR=khorimoto@chromium.org,nverne@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I77bde9769710657da5d0992728dd53006a83de2c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1163003, 1163902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615667 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#841138}
-
wutao authored
When ambient mode starts and exits, it will change the video visibility and update the video wake lock. For example, when a video is playing in browser, it will request a video wake lock to prevent screen dim and off. However, when we lock the screen while playing the video in an active tab, the ambient mode will start after several seconds. Ambient widget covers the fullscreen and change the browser visibility to not visible and release the video wake lock. After some time, screen is turned off and ambient mode exits. The browser visibility becomes visible again and acquire the video wake lock again and turn on the screen. The screen on event will start ambient mode in a few seconds again. To fix this bug, we set the opacity of the ambient widget to be translucent, which will not change the browser visibility and therefore the video wake lock. As long as the video wake lock is held, the ambient mode will not exit since there is no dim event. Bug: b/173806284 Test: manual Change-Id: I0bb7f3c8f6fdeb04d9831a85ffe97eeb769f3b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612386 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841137}
-
Gavin Williams authored
Make whole row clickable to match the behavior of the More settings button. Bug: 1059779 Change-Id: Ia1da833b14cb835e090f3f37fb47faeef3c948be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613920Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#841136}
-
Jeffrey Kardatzke authored
BUG=1146646 TEST=Verified UI only shows hostname in dialog Change-Id: I80df7f5f0c5d582649e9cf30c9dfd00f65407d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615298 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#841135}
-
Evan Stade authored
This required adding deps, which in turn created circular includes. To address this, the patch * moves settings_namespace.{cc,} into the //extensions/browser target * passes the task runner from GetExtensionFileTaskRunner() as a parameter into value store code Bug: 1158986 Change-Id: I91ae5c90d82c5cbe5eb1d2a62cd1dd65a003e74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601640Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#841134}
-
rbpotter authored
The only valid use case involved the chrome://devices page, which has been removed. Bug: 1100748, 1162164 Change-Id: Ie1d62eecd00cec5e35fb76e7398c0ab40ea95b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585562Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#841133}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1c3c93911966..e856b6bba826 2021-01-07 gbeaty@chromium.org Enable set_output_commit to be used with RevisionFallbackChain. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1141886,chromium:1159749 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I5f92f9c4030573dc4cf825d76b0277554002152c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615180Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841132}
-
Shane Fitzpatrick authored
calls. Instances found by searching for references to that field Fixed: 1162476 Change-Id: If64e74dd79e7c17859c3a7699e34abc497f9cc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613358 Commit-Queue: Shane Fitzpatrick <shanefitz@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#841131}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be0b3b7363a9..bdc3d3c60fa9 2021-01-07 johnstiles@google.com Simplify map of SPIR-V numeric constants. 2021-01-07 johnstiles@google.com Flatten nested vector constructors when emitting SPIR-V. 2021-01-07 johnstiles@google.com Implement getBVecComponent. 2021-01-07 csmartdalton@google.com Revert "Disable tessellation when we don't have indirect draw support" 2021-01-07 johnstiles@google.com Add getConstantBool as a sibling of getConstant(Int|Float). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1163441 Tbr: johnstiles@google.com Change-Id: I4cbdd09ef396746aa0ff0709b03e8baf93758597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614726Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841130}
-
edchin authored
Bug: 1163074 Change-Id: I126b46a7ed308d6ab000f12206d1f050fd3e92d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615103 Commit-Queue: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#841129}
-
Gavin Williams authored
Currently when a scan completes a PDF is created without checking if the scan was successful. This change checks to see if scan fails before attempting to create the PDF. Also |save_failed_| will be set when the PDF creation fails. Bug: 1059779 Change-Id: I84bf426e33da6840c13cce3195bfaa111ff7c6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612053Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#841128}
-
Emily Stark authored
When a subframe main resource loads in spite of a certificate error (usually because the user has previously bypassed the same certificate error for a main frame load), Chrome downgrades the omnibox security UI to indicate that not all resources on the page are loaded securely. The browser test for this UI downgrade was flaky, which turned out to be because the check for a suframe certificate error occurred in Blink during document loading, and the notification to the browser process occasionally got dropped, presumably because of some race related to unloading the previous document. I didn't figure out the exact cause of the test flake because this logic better belongs in the browser process anyway; it was implemented pre-PlzNavigate, and now it makes more sense to simply check for subframe certificate errors in a navigation throttle, just like we do for mixed content. This CL therefore moves this certificate error check into MixedContentNavigationThrottle. A bit of extra plumbing is needed to ensure that URLLoader reports the SSLInfo on the response when there is a certificate error for a subframe main resource. URLLoader only reports the SSLInfo when needed on the response as an optimization (since SSLInfos can be quite large), and we're now adding a new scenario in which it's needed. But this additional SSLInfo reporting should be rare because it's only relevant when the user has clicked through a certificate error. The test was previously flaking reliably and I verified that it now passes 1000 times locally. Bug: 1106370 Change-Id: I64d323ca99ae0ab8262bbb1c1efce46a04f73eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606194 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#841127}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. Tbr: sky@chromium.org Bug: 1145565 Change-Id: I8a6c5867c2bc5e073245e1ee82aed43d44b47632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611553Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#841126}
-
Xiaohui Chen authored
Bug: None Change-Id: If207621ff75593d95028c02d89cb9a95d5777e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615105 Auto-Submit: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#841125}
-
Jeroen Dhollander authored
The OnDeviceAssistant feature was removed a while ago, but apparently I had forgotten the feature flag itself. I grepped and neither |OnDeviceAssistant| nor |marble| are mentioned in the ChromeOS code anymore, so I think I got it all this time. Bug: b/171307059 Test: compiled Change-Id: Iea7e3dd5a89483ec4f9ec71777b126faddb266d8 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612048 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841124}
-
Rahul Goyal authored
This cl contains the set of changes required to show onboarding in a dialog for JITT. Also this cl shouldn't have any user facing changes. Bug: b/174445633 Change-Id: Ib52d3175e1713f573624c1af735aab93f6be1f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610091Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Rahul Goyal <goyalrahul@google.com> Cr-Commit-Position: refs/heads/master@{#841123}
-
Darin Fisher authored
Fixed: 1128971 Change-Id: Ifcf996108f169337e379f8bbcebc7bac87080539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597144 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#841122}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac4d756a6626..47a632b2ab93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tmartino@google.com,clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1155160 Tbr: tmartino@google.com,clamy@google.com Change-Id: I89d9e5538cf92f5c1aa564a67223cc557681f0ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614771Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841121}
-
Sammie Quon authored
These were put on hold because the accelerators were added while capture mode was still being built. Bug: none Test: added tests Change-Id: I213e483edf450464a26d6c547deeb0f665ab9dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613355Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#841120}
-
cfredric authored
would also have been included due to SameSite rules. Bug: 1143756 Change-Id: I443a042e08ed0c091c65e55138c5ad0547a6f652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611946Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#841119}
-
Wei Li authored
Merge SMALL_SHADOW and BIG_SHADOW types into one STANDARD_SHADOW type as they are essentially same. Rename NO_SHADOW to NO_SHADOW_LEGACY as it is only needed to support bubbles on the legacy Win7 platform. We would remove it when win7 is no longer supported. Thus rename to NO_ASSETS to NO_SHADOW. After this change, bubble border shadow types boil down to just two usable types: STANDARD_SHADOW and NO_SHADOW. They represent standard (MD style) shadow and no shadow cases respectively. Fixed: 940027 Change-Id: Icbd18ca0092175aa1e1f53cd511b6c8a5edbc9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591910Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#841118}
-
Ian Kilpatrick authored
From: https://github.com/w3c/csswg-drafts/issues/5713 Basically these tests stretch an image in one axis, and previously tested that the image should lose its aspect-ratio. When stretching in one axis, and when there is no size constraint in the other axis it should respect the aspect-ratio. Change-Id: Ic1374f50b4d561b3c38b94a4f60724f950e6513e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611567Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#841117}
-
Dale Curtis authored
We've disabled these on Windows and ChromeOS, so it's no surprise that we need to disable them on macOS as well. R=zmo Fixed: 1163111 Change-Id: I406e6ebd1d27da84964e46efb9582ce77f904dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613560Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#841116}
-
Peter Kvitek authored
This is a followup to http://crrev.com/c/2570447 that introduced extra check in OSCrypt::SetRawEncryptionKey() that is now removed. Bug: 1157539 Change-Id: I0d35502068958a93654565301d84ae04e4760272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596873Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#841115}
-
Owen Min authored
Enterprise.MachineLevelUserCloudPolicyEnrollment.* are now expired in June. Enterprise.CloudReporting* are set to expired in 1 year. Enterprise.CloudExtensionRequestUpdated expire date is bumped to Oct. Bug: 1160729, 1160730 Change-Id: I2c245f4a68e5c05a99a4255685eccb1e7ca253bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613464Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841114}
-
cfredric authored
These metrics are only updated for excluded cookies, and their values are whether or not SameParty was the only reason for excluding the cookie. Bug: 1143756 Change-Id: Icc35c59d47269e89f8f37515a7a86d6dc33d0591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611046Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#841113}
-