- 14 Jan, 2021 40 commits
-
-
adamta authored
Calls the OmniboxCommand to show the omnibox when tapping the fake omnibox in the refactored NTP. Fixes condition by correctly setting the parent view controller's "isScrolledToTop" property. Bug: 1114792 Change-Id: Iaef7b870c35648ab519380aaa94369e74fc20c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628111 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#843337}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610560659-4ba340836b4bfcb3a336687b253f7e1b1055ef00.profdata to chrome-win32-master-1610571527-a7cc65d6e4dfa3bc4bfeaca916fdc0c69afa5118.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iafa46d084387d0dcb4ae163d96c183655647eaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628320Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843336}
-
Alan Cutter authored
This CL enables parsing and storing the capture_links field in web app manifests while the kWebAppEnableLinkCapturing feature flag is enabled. This CL is implementing the parsing side of this spec: https://github.com/WICG/sw-launch/blob/master/declarative_link_capturing.md#proposal including the following pending pull request to that spec: https://github.com/WICG/sw-launch/pull/26 This CL does not implement the link capturing behaviours, that will come in follow up CLs. Bug: 1163398 Change-Id: I803ad87ea219ebceed35a547695a517020918c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623453Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#843335}
-
James Cook authored
The code under test was renamed a while ago. Update the test names to match. Bug: none Test: unit_tests Change-Id: I1a9ccd59b66ea20855edcfc89cf73690e28f98df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625964 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#843334}
-
Tsuyoshi Horo authored
This field will be used for BlockInsecurePrivateNetworkRequests to calculate the frame's SecurityState. Currently this field is not set. So the test sxg-subresource-header-integrity-mismatch.tentative.html fails when BlockInsecurePrivateNetworkRequests is enabled. Bug: 1166050 Change-Id: Icf722e4ea06819daaf3f3c5be91408564871bc81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626673Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#843333}
-
Esmael El-Moslimany authored
Bug: 1076506 Change-Id: Ifb53f33b23356cc614e2d551007e36bc50b08c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628450 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#843332}
-
Reilly Grant authored
This change hides the help button in the serial port chooser dialog since the help center page it would automatically navigate to is not yet available. Bug: 1085149 Change-Id: I00e2d6523e2a64a28e78675186327afe990fc7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619001 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#843331}
-
Anthony Vallee-Dubois authored
Bug: 1166369 Change-Id: I32459ec22d8a4a6bd57d8ae0a17a3850a365fc57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625914 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#843330}
-
Regan Hsu authored
* Deprecate PhoneHub.InitialConnecting as it is no longer needed, but was not corrected when moving metrics from ash to phonehub * Fix PhoneHub.NotificationOptIn -> PhoneHub.NotificationOptInEvents * Fix PhoneHub.Screen.OnSettingsButtonClicked -> honeHub.Screen.ScreenOnSettingsButtonClicked Note that following metrics currently emit properly on ToT (manually visible from chrome://histograms): PhoneHub.InterstitialScreenEvent.BluetoothOrWifiDisabled PhoneHub.InterstitialScreenEvent.Onboarding.ExistingMultideviceUser PhoneHub.InterstitialScreenEvent.OnboardingDismissPrompt Fixed: 1164584 Bug: 1106937 Change-Id: I977a3e454c9ed0add6e0efc669a45dc6349c5110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625277 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#843329}
-
Austin Orion authored
We've received reports from enterprise customers using the browser on a virtual machine that screen sharing (via Teams, Google Meet, etc.) will unexpectedly end. The issue was traced back to the browser receiving a WTS_SESSION_LOCK event, it looked as if the user had locked their screen. In response to this event the browser ends any active screen sharing sessions. The issue is that those lock events were coming from other VMs hosted on the same server. We are not interested in the events caused by other sessions, so we should only register for changes to the current session. The affected customer has verified that this fix has resolved the issue. content::VideoCaptureManager is the only class that observes these events, so there should be no other side effects to this change. Bug: 1163572 Change-Id: Icfa5629eb17298f7150dedfd650b77cb34887cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598389 Commit-Queue: Austin Orion <auorion@microsoft.com> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#843328}
-
Caitlin Fischer authored
Bug: 1144792 Change-Id: I9563b56493a68dc6f7598c2b08248612575f552a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623195Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843327}
-
Christoph Schwering authored
The experiment is not active. Bug: 1007974, 949783 Change-Id: I0ccebe9f54ae927bab0d7a0ca6c53d1e7467bfb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623287Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#843326}
-
Dominic Mazzoni authored
Background images are normally hidden in forced-colors mode, but the Google logo should still be visible. It'd be worth considering making it an <img> instead, but in the meantime, forced-color-adjust: none is a simpler, safer, targeted fix. Bug: 1166383 Change-Id: Ie29b351020c652a6fe381bcdce6ef4a9a1e03d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627966 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
Adam Langley authored
Fixed: 1166254 Change-Id: I4bfd0c178757d7b24959180b9db083d545607b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628046 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#843324}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.150. R=rmhasan@google.com Bug: 1041619 Change-Id: I66c0e53f43b30a8da9fa94755081e91bdbcf9b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627999 Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#843323}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3549479dc4cc..c4a1bd4553ff 2021-01-13 amaiorano@google.com Implement VK_EXT_headless_surface 2021-01-13 natsu@google.com Update AHB default YUV dataspace to YCBCR_601 2021-01-13 capn@google.com VulkanBenchmarks: refactor into Image class 2021-01-13 capn@google.com Fix back-face culling for vertices near w=0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I38c6d95c313d6374711f804af228977cd6a7a57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627814Reviewed-by:
-
David Grogan authored
Because we shouldn't create a fragment with a -1 block size. Change-Id: I787c09024d3dbdc478a6fe0b8a201ea5596390d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611570Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843321}
-
Caitlin Fischer authored
Bug: 776416, 1126640 Change-Id: Icea9823e21112a79dbd2b93469a77df5c2820fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627713Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843320}
-
Austin Sullivan authored
Currently takes a raw ptr. The reasoning for such is not strong: "This doesn't take std::unique_ptr<> just to save extra base::WrapUnique" Bug: N/A Change-Id: I5144706466787d7ee23210d61c2f855065e391ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627132Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#843319}
-
Brian Sheedy authored
Adds a script to find cases where the tags known to the tests and the tags generated when tests are run on the bots are different. This is a necessary tool for making the generation of unknown tags fatal in the future, as we need to know what tags we need to ignore or otherwise address before turning on that functionality. Also updates a couple of ignored tags that were pointed out by the script. Bug: 1011107 Change-Id: I9022fc779de718b53ea3469d6048dd0fcd7b8c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628043 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#843318}
-
Dan Harrington authored
Without internal src, there's no way to render the content. So just don't request the content if there's no renderer. Change-Id: I76304b3de576b9bf9662ecbbbe7317f91aa28580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627981 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#843317}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610560659-e96e8917fec116ef2a139db8416bd66f9188db27.profdata to chrome-win64-master-1610571527-cb84a3d10a676e72fe097e5f2fde0ba90e629978.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia8fb00004a7591a0bdb41b98bc3b2afbd6288a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628341Reviewed-by:
-
Joel Riley authored
AX-Relnotes: Select-to-speed reading speed selector now will multiple the default rate rather than override, so if default rate is 2.0x and 2.0x is selected in STS, then effective rate is 4x. Bug: 1166252 Change-Id: I9004b1af56cad3374cadeb5c4ae2ce00892b8c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627937 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#843315}
-
Sophie Chang authored
Reland "Reenable PredictionManager and HintsFetcher browser tests that were disabled on desktop platforms" This is a reland of 3bd04812 No changes since this one was reverted incorrectly Original change's description: > Reenable PredictionManager and HintsFetcher browser tests that were > disabled on desktop platforms > > Change-Id: I173ac1025760f908042e64c7c8839fb90e41fc78 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626918 > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843180} Change-Id: I2bc3449abe44516f018c828c0d91a51101186439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625959 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#843314}
-
Solomon Kinard authored
This should make it easier to for casual readers to see which wildcards are allowed. Reference: https://developer.chrome.com/docs/extensions/mv2/match_patterns/ Bug: 1133624 Change-Id: Ifd5b26e7b052f07c62dc0846cff4dfe922d52134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613512 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843313}
-
Cammie Smith Barnes authored
Removes '^chrome/test/chromedriver/server/http_handler.cc' from the _NOT_CONVERTED_TO_MODERN_BIND_AND_CALLBACK list in src/PRESUBMIT.py, as the chrome/test directory has now been fully converted. Bug: 1007643 Change-Id: Ib57bcb674ac8c26c7ad5553267194cecd590591d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626176Reviewed-by:
-
Yao Xiao authored
Explainer: https://github.com/WICG/floc#opting-out-of-computation This feature controls the access to the interest cohort (https://github.com/WICG/floc) as well as the eligibility for the navigation history entry to be included in the interest cohort computation. Let the feature availability be controlled by a chrome feature to allow some flexibility while finalizing on the decision. In reality, we will probably want to enable the chrome feature before it goes to OT. Use browsertest for testing as opposed to using webtest, as the functions rely on the chrome layer. Bug: 1158851 Change-Id: I2a81f9547c9180bf3c6ac65974eb0b1666a41812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593688 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#843311}
-
Michael Montvelishsky authored
Bug: none Test: none Change-Id: I19e2731087799e7f58dfd43c66d65d0ff5e5cfb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627873 Auto-Submit: Michael Montvelishsky <mont@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#843310}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9b5dd7ab8a98..64d94deaa6a4 2021-01-14 ehmaldonado@google.com presubmit: Use new API to check for owners approval If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Id46502da345918835c0e3df5ee1643a7f5156cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628346Reviewed-by:
-
Trevor Perrier authored
This CL moves the expiry on the detailed-language-settings flag from M89 to M91. Bug: 1127531 Change-Id: I23d2df7e3a2b87a45bc8c87baafb45589dee4b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626977Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#843308}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/20d3823787dd..3f6d4980860b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com,mpearson@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1164243 Tbr: yutak@google.com,mpearson@google.com Change-Id: I98b55b506d69b9fe546f2a6ee06c706bec917775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628342Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843307}
-
Austin Sullivan authored
Refactor content/public/browser and chrome/browser All changes are find-and-replace unless called out in a comment. Bug: 1110509 Change-Id: Ib46ed353865321413e49a56477a4a07b47034e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602222 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#843306}
-
Yuta Hijikata authored
The patch removes is_lacros, is_ash, IS_LACROS and IS_ASH which were aliases for is_chromeos_lacros, is_chromeos_ash, IS_CHROMEOS_ASH and IS_CHROMEOS_LACROS. The names were changed to make it clearer that the variables are related to CrOS. Bug: 1052397 Change-Id: Id5b9b1b2ca3d34a9773ae73e4cc9408b9633e0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627529Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#843305}
-
Xianzhu Wang authored
It will be called to map a cull rect from parent space to local space in cull rect update during PrePaint. The purpose is to mark PaintLayers needing repaint on cull rect changes before paint, instead of checking interest rect / cull rect changes during paint, to avoid setting PaintLayer needing repaint unnecessarily, especially for CAP during composited scrolling. Besides the original features of CullRect::ApplyTransforms() which is used in cull rect mapping for CompositeAfterPaint, it also implements the following features to be on par with CompositedLayerMapping:: ReComputeInterestRect(): - Considering clips in additional to scroll clips, - Clipping expanded cull rect by scrolling contents rect for composited scroll translations, - Clamping extreme geometry values, - Adaptive expansion distance for composited transforms. The next steps are: 1. Add CullRectUpdater which updates cull rects during PrePaint when runtime feature CullRectUpdate is enabled. 2. Use the updated cull rect to replace interest rect in pre-CAP and cull rect in CAP and pre-CAP, still behind the runtime feature. 3. Enable CullRectUpdate for CAP 4. Enable CullRectUpdate for pre-CAP. 5. Remove old interest rect / cull rect code. Bug: 1046544 Change-Id: I6e7e9f85bc0b4640e67de1732744e647b6f7e230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620090Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843304}
-
Max Curran authored
Initial implementation of the background task to measure how often user are offline and what they do while offline. Full Design Doc: https://docs.google.com/document/d/1Vv6fdaRWjLpxeuVR89C6y5cGcAiCu6f4YBRwMjpN_T0/edit?usp=sharing Bug: 1131600 Change-Id: I89f67a6bbdaf71b550518b40c06788e3dfaccf11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459946 Commit-Queue: Max Curran <curranmax@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#843303}
-
Azeem Arshad authored
This CL changes eid_popup component so that it fetches eid qr code image data from mojo service and renders it on a canvas. Screenshot: http://screen/bVoRYtfvfMMyMb4.png Bug: 1093185 Change-Id: Iae2f248c5524495aa13e85b25ea6add02c382d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613945 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
-
Joel Riley authored
When navigation controls are not present, STS was not going into inactive state after TTS completed. This CL fixes this issue, as calling updatePauseStatusFromTtsEvent_ was setting STS back into SPEAKING state. Also, if STS is activated without nodes, do not show panel. AX-Relnotes: Bug fix when activating STS without navigation controls, STS did not go back into inactive state. Bug: 1165847 Change-Id: I88b44e84de525d2dbc190b97fa02b691394cb294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625268 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
-
John Delaney authored
What: Replace usage of ShellAddedObserver + TestNavigationObserver with TestNavigationObserver::StartWatchingNewWebContents(). Why: Tests are flaking from calls to TestNavigationObserver::Wait() hanging. The existing solution assumes that the test will setup the TestNavigationObserver before the newly opened WebContents starts the navigation. However this isn't necessarily true, as we aren't registering the TestNavigationObserver in the same callstack in which the web contents is created. Bug: 1166341 Change-Id: Id2b5f36158f86377b3881e54d793c27af718cb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627757Reviewed-by:
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: Ic81197c9b576e8f6045365196ec0f3637509c0c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628109Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843299}
-
Eric Willigers authored
In guest mode, shared files in the .WebShare/ directory are deleted when the user logs off (if they are not deleted earlier). In incognito mode, we continue to prevent file sharing. Bug: 1161373 Change-Id: I0542d4ba92381c7ab2f07bbab896242bcc643057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626991 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#843298}
-
