GitLab

Currently all 1x art files are repacked into chrome.pak files.

This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale.

As a first step this CL does the following:
 - add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome.
 - stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak
 - update the Mac and Windows installer code to package the extra pak files.

Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation.

BUG=114311
TEST=Ran on Windows, and Mac and Linux.

Review URL: http://codereview.chromium.org/10024050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132517 0039d316-1c4b-4281-b951-d872f2087c98

R=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9956157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132516 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10105013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132515 0039d316-1c4b-4281-b951-d872f2087c98

rather than at the model level. This gives us automatic nocompile of all
properties; previously not all were supported.


TEST=tools/json_schema_compiler/json_schema_test.py, unit_tests --gtest_filter=JsonSchemaCompiler*

Review URL: http://codereview.chromium.org/10108005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132514 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:16557
TEST=chromeos_unittests --gtest_filter="FlimflamProfileClientTest.*"

Review URL: https://chromiumcodereview.appspot.com/10038011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132513 0039d316-1c4b-4281-b951-d872f2087c98

- Changed the data structure being passed around in the socket API from a string to an array of longs. This is a stepping stone to get us to ArrayBuffers.

- Changed "message" key to "data" for consistency.

BUG=120567
TEST=no new ones, but existing, as updated, still pass.

Review URL: http://codereview.chromium.org/10095020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132512 0039d316-1c4b-4281-b951-d872f2087c98

Fix a crash when trying to input phone number in the autofill settings page while running as guest mode.

BUG=123346
TEST=Login as guest mode, open chrome://setting/autofillEditAddress, input some number in the Phone input field, hit tab, check that didn't cause a crash.


Review URL: http://codereview.chromium.org/10081023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10107006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132510 0039d316-1c4b-4281-b951-d872f2087c98

The memory widget was removed in crrev.com/131801 as part of the uber-tray status area update.  This removes the obsolete about:flags switch that used to turn it on.

BUG=123700
TEST=none


Review URL: http://codereview.chromium.org/10103013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132508 0039d316-1c4b-4281-b951-d872f2087c98

Currently behind a flag "-Xclang -plugin-arg-find-bad-constructs -Xclang skip-virtuals-in-implementations"

BUG=115047
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10076002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132507 0039d316-1c4b-4281-b951-d872f2087c98

Added a new PyAuto method WaitForDomNode() which allows tests to block until a specified node exists in the DOM.


BUG=None
TEST=functional/apptest.py


Review URL: http://codereview.chromium.org/10095018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132506 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=ran the browser test.

Review URL: https://chromiumcodereview.appspot.com/10080002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132505 0039d316-1c4b-4281-b951-d872f2087c98

- delete old in_process_webkit sources (hooray)
- rename the new sources to no longer have the _new suffix
- fix up the includes
- remove the ENABLE_NEW_DOM_STORAGE_BACKEND flag since old stuff is now gone
Review URL: https://chromiumcodereview.appspot.com/10086018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132504 0039d316-1c4b-4281-b951-d872f2087c98

Fixed bug where the ExecuteJavascript() family of PyAuto hooks ignored the automation id of messages from DomAutomationController.

This had the effect of hooks returning on the next message from
DomAutomationController regardless of whether that message actually
indicated completion of the injected javascript.

BUG=120769
TEST=functional/execute_javascript.py


Review URL: http://codereview.chromium.org/9950098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132503 0039d316-1c4b-4281-b951-d872f2087c98

Change FlimflamProfileClient's interface to deal with multiple profile objects
Change FlimflamProfileClient's interface to send an entry's path as a string, not an ObjectPath
Add non-Libcros implementations of CrosDeleteServiceFromProfile, CrosRequestNetworkProfileProperties and CrosRequestNetworkProfileEntryProperties
Add EnableNonLibcrosNetworkFunctions
Add --enable-non-libcros-network-functions commandline option
Rename existing CrosNetworkFunctionsTest to CrosNetworkFunctionsLibcrosTest
Add new CrosNetworkFunctionsTest which tests the non Libcros implementation

BUG=chromium-os:16557
TEST=unit_tests --gtest_filter="CrosNetworkFunctions*"

Review URL: https://chromiumcodereview.appspot.com/9958045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132502 0039d316-1c4b-4281-b951-d872f2087c98

I'll send out a separate mail about the shmat() situation -- for now, a
shipping seccomp filter sandbox is better than no filtering.
Review URL: https://chromiumcodereview.appspot.com/10105009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132501 0039d316-1c4b-4281-b951-d872f2087c98

Check and warn if public destructors are found on types that derive from base::RefCounted or base::RefCountedThreadSafe.

Having public destructors is dangerous, as it allows the ref-counted object to be stack allocated and have references that attempt to outlive the stack, or to allow callers to explicitly delete it while references are still held. Both patterns result in use-after-free, hence their prohibition.

In doing so, update the Chromium plugin to be able to scan both headers and implementation files, and enable the public destructor check for both types with an optional flag ( -Xclang -plugin-arg-find-bad-constructs -Xclang skip-refcounted-dtors )

BUG=123295
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10005022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132500 0039d316-1c4b-4281-b951-d872f2087c98

Some notification clients expect URLs while others expect URLRows but in some cases the URLRows were not being provided. Eliminated the duplication of data structures by removing the set of URLs and relying only on the vector of URLRows.

NOTE: This CL is identical to previously reviewed 10031028 except that a leak was fixed in in_memory_url_index_unittest.cc.

tim@ for OWNERS review of sync/...

BUG=122740
TEST=Added unit test.
TBR=tim@chromium.org

Previously reviewed as: https://chromiumcodereview.appspot.com/10031028
Review URL: https://chromiumcodereview.appspot.com/10096015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132499 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123530
TEST=none


Review URL: http://codereview.chromium.org/10103012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132498 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116077
TEST=ctrl+drag will allow resizing window with exact positioning, drag resizing will still snap to grid.


Review URL: http://codereview.chromium.org/10008084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132497 0039d316-1c4b-4281-b951-d872f2087c98

Pass BrokerDuplicateHandle() to the NaCl loader process in
nacl_listener.cc.

Pass BrokerDuplicateHandle() to the NaCl trusted plugin.  We need to
add this to PPB_NaCl_Private in order to pass it through.

Remove the use of the "init_handle_passing" SRPC call.  Otherwise the
NaCl process will attempt to do an imc_connect() to the renderer,
which involves sending a handle to it, which fails.

Add a wrapper for AddTargetPeer() to 'content' so that
nacl_process_host.cc can use it.

Change the renderer's handle-passing policy to allow sending handles
other than Sections.  The NaCl trusted plugin sends other handle types
to the NaCl loader process.

This change will allow the sandbox to be tightened up, in the future,
so that the NaCl loader process and the renderer process do not have
handles to each other.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2719
TEST=nacl_integration etc.

Review URL: https://chromiumcodereview.appspot.com/10039001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132496 0039d316-1c4b-4281-b951-d872f2087c98

BUG=119242
TEST=install Chrome, uninstall Chrome, make sure delegate execute stuff goes away.


Review URL: http://codereview.chromium.org/9969186

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132495 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123018

Review URL: https://chromiumcodereview.appspot.com/10080010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132494 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10069020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132493 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81758
TEST=no

Review URL: https://chromiumcodereview.appspot.com/10066024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132492 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122139
TEST=Unittest


Review URL: http://codereview.chromium.org/10091008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132491 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112615
TEST=none
TBR=sail@chromium.org
TBR=estade@chromium.org

Review URL: http://codereview.chromium.org/9959130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132490 0039d316-1c4b-4281-b951-d872f2087c98

This continues refactoring started in http://codereview.chromium.org/9958006/

BUG=None
TEST=Refactor; covered by existing tests


Review URL: http://codereview.chromium.org/10097004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132489 0039d316-1c4b-4281-b951-d872f2087c98

Revert 132479 - Transmit a X-Chrome-UMA-Enabled bit to Google domains from clients that have UMA enabled.

BUG=123609
TEST=With UMA enabled (not Chromium), visit www.google.com and ensure that the request header includes X-Chrome-UMA-Enabled with value "1". Also, ensure that unit_tests GoogleUtilTests all pass.

Review URL: http://codereview.chromium.org/10054029

TBR=stevet@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10107009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132488 0039d316-1c4b-4281-b951-d872f2087c98

Also fixed a bug that pnels remain visible with full screen apps on Snow Leopard.
The fix is to also call orderBack/orderFront when full-screen is detected. This is because the full-sreen window is still in normal level and our panel windows stay in the top of z-order when its level is changed to normal.

BUG=123058
TEST=Manual test by launching panels and make an app full-screen


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132144

Review URL: http://codereview.chromium.org/10051020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132487 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132485 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96459
TEST=enabled safe_browsing_tests locally and verified it still passes.


Review URL: http://codereview.chromium.org/10103007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132484 0039d316-1c4b-4281-b951-d872f2087c98

BUG=120936
TEST=Regression test.


Review URL: http://codereview.chromium.org/9999041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132482 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122878
TEST=Verify 122878


Review URL: http://codereview.chromium.org/10048009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132481 0039d316-1c4b-4281-b951-d872f2087c98

Break down the single unrecoverable error into 4 cases.

BUG=121587
TEST=none


Review URL: http://codereview.chromium.org/10105006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132480 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123609
TEST=With UMA enabled (not Chromium), visit www.google.com and ensure that the request header includes X-Chrome-UMA-Enabled with value "1". Also, ensure that unit_tests GoogleUtilTests all pass.

Review URL: http://codereview.chromium.org/10054029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132479 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62364, 92244
TEST=ClientSocketPoolBaseTest.\*CloseIdleSocket\*


Review URL: http://codereview.chromium.org/9999030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132478 0039d316-1c4b-4281-b951-d872f2087c98

TBR=brettw
BUG=117627
BUG=119150
TEST=sbox_validation_tests
Review URL: https://chromiumcodereview.appspot.com/9716027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132477 0039d316-1c4b-4281-b951-d872f2087c98

This change causes the syncer to exit from its download then commit
function if the download fails.  This helps prevent the creation of
server-side conflicts, which would be more likely to happen if a
download failed but the following commit succeeded.

The main changes are as follows:
- Rather than proceed to the next step when a download updates failure
  is detected, the syncer will exit.  This should cause the
SyncScheduler to schedule a retry at a later time.  
- The definition of a download updates failure is now based on the
  return code of the download attempt, rather than checking the contents
of the (possible non-existent) returned protobuf.  This makes the error
detection logic used here more closely match the logic used to decide
whether or not to schedule retries.

This implementation has a side-effect on configure sync cycles.  The old
behaviour was to handle failures by applying whatever updates we had
downloaded at that point.  The new behaviour will leave updates
unapplied if any error occurs.  This better matches a nearby comment's
assertion which states that we should not attempt to apply updates until
we have downloaded all of them.  I believe the author of that comment
would approve of this change.

This change moves around some of the ExtensionActivityMonitor logic.
It's important that we not take the data from the extensions acitivity
monitor at the start of the cycle.  Restoring that data is handled in
the commit building and response code, which might not be executed if we
need to break out early.  This also fixes issue 123270.

Most of the diffs for this change are concentrated in the unit tests:
- Expose more of the SyncScheduler to the SyncerTest test harness.
- Add functions to SyncerTest for testing specific types of sync jobs.
- Add some functions that allow us to better control failures in
MockConnectionManager.
- Added tests for configure job success and failure.
- Added tests for update then commit job success and failure.
- Removed some redundant tests.

BUG=122033,123270
TEST=sync_unit_tests, specifically:
SyncerTest.UpdateThenCommit,
SyncerTest.UpdateFailsThenDontCommit,
SyncerTest.ConfigureDownloadsTwoBatchesSuccess,
SyncerTest.ConfigureFailsDontApplyUpdates

Review URL: http://codereview.chromium.org/10006046

TBR=rlarocque@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10107004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132476 0039d316-1c4b-4281-b951-d872f2087c98

Create a power management assertion when a remote session starts. The power
assertion will wake the display if it's asleep and will keep it awake while the
remote session is in progress.

BUG=120429
TEST=manual


Review URL: http://codereview.chromium.org/10082032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132475 0039d316-1c4b-4281-b951-d872f2087c98