- 11 Dec, 2018 40 commits
-
-
Sara Kato authored
This boundsForRange should return null in Non-arc, non-text nodes. Otherwise, since bounds for these nodes exist (eg - on images), highlighting for these would occur unexpectedly on select-to-speak side. Test: Manual Bug: 908509 Change-Id: I344a050a9033d7d839cb242b1fc56196ec28bcce Reviewed-on: https://chromium-review.googlesource.com/c/1358105 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#615444}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2bcd17a0. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts eroman@chromium.org, rsleevi@chromium.org: external/wpt/WebCryptoAPI foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure ksakamoto@chromium.org: external/wpt/resource-timing panicker@chromium.org: external/wpt/user-timing rmcilroy@chromium.org: external/wpt/requestidlecallback tdresser@chromium.org: external/wpt/hr-time external/wpt/navigation-timing yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3a940f1891ee1fab3deac0ed104cc1c7a66bd1ca Reviewed-on: https://chromium-review.googlesource.com/c/1371217Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615443}
-
Xianzhu Wang authored
For now ViewportProperties contains the page scale node only, and Settings contains prefer_compositing_to_lcd_text only. In the future they will contain more properties/settings. Change-Id: I760b79191aa25a8fc489aa9c4d9ab1dc1e6204fc Reviewed-on: https://chromium-review.googlesource.com/c/1370278Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615442}
-
Giovanni Ortuño Urquidi authored
Some interfaces depend on many other interfaces. Before this patch users would have to manually add externs for every interface used. This CL introduces a new target that js_libraries can use to include all the necessary externs to use an interface. Bug: 849993 Change-Id: I97acb7bbbd604e7ebeb1cb5fe814e4afecefe2d6 Reviewed-on: https://chromium-review.googlesource.com/c/1369485Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#615441}
-
Matt Falkenhagen authored
Remove the following tests: - fetch-canvas-tainting.html - fetch-cors-xhr.html - fetch-csp.html These are redundant with corresponding WPT tests. They previously could not be removed without losing test coverage because the WPT tests were being skipped due to time outs, see https://codereview.chromium.org/2805313003/. But those WPT tests are now passing. A small exception is the WPT fetch-canvas-tainting* tests flakily timeout, but they are still enabled and mostly passing so we won't lose test coverage. These tests were originally written at r179595 and upstreamed to WPT at https://github.com/web-platform-tests/wpt/commit/b2e3ab765e26436850208dbdcf747c3be75b1999. Bug: 688116, 373120 Change-Id: Ic2dc2ddc322aae89b1e06e5a16b1ed8c30265d00 Reviewed-on: https://chromium-review.googlesource.com/c/1370236Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#615440}
-
John Z Wu authored
ios webview uses butter sync which does not need overall sync consent because it will never be enabled. Bug: 873790 Change-Id: Id6f6dfd6ebd424f2d3c385a85f425171d03ef1d9 Reviewed-on: https://chromium-review.googlesource.com/c/1371203 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#615439}
-
John Z Wu authored
A new flag was added recently that prevented server cards from being offered as autofill suggestions. We simply enable to restore the intended behavior. Change-Id: I537ae79a6bf6acfef081f9002654e4d4fc202fe5 Reviewed-on: https://chromium-review.googlesource.com/c/1371202 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
-
Sam McNally authored
MetadataBoxController uses the availability of externalFileUrl in file metadata to decide whether to obtain metadata via ExternalMetadataProvider or by reading the file. With DriveFS, externalFileUrl is not set but ExternalMetadataProvider should be used for fetching metadata. Also use alternateUrl (which is only set for Drive files) to detect files where this metadata provider should be used. Also skip FSP metadata requests when none of the metadata fields are available via the FSP API. Bug: 913738, 587231 Change-Id: I95636e6bcf1d21cea3366d17363ab6300b1d59f8 Reviewed-on: https://chromium-review.googlesource.com/c/1370154 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#615437}
-
Yusuke Sato authored
This allows the job to use userdata.qcow in the user's /home. BUG=b:118408409 TEST=sign in, confirm the job is running Change-Id: I1bcb5ff1cfcae06a7ce404b17ffd2c329419736e Reviewed-on: https://chromium-review.googlesource.com/c/1367085Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#615436}
-
Fergal Daly authored
The test was testing that the element ended up green (starting red) however, if the browser has no support at all for ::part then the element actually starts green and stays green. Bug: 805271 Change-Id: Ida40c7963aa3a00c3d197b1309ddaea49e4f3b92 Reviewed-on: https://chromium-review.googlesource.com/c/1369500Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#615435}
-
Adithya Srinivasan authored
Bug: 582328 Change-Id: I733060f119871b3de35c147e6d3eb1d6c83663f1 Reviewed-on: https://chromium-review.googlesource.com/c/1366299Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#615434}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/40bd76027f8e..ae0d860ba31b git log 40bd76027f8e..ae0d860ba31b --date=short --no-merges --format='%ad %ae %s' 2018-12-11 reed@google.com move intercepts call to textblob 2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 153e0224da45..f5c88e7e1c1a (2 commits) Created with: gclient setdep -r src/third_party/skia@ae0d860ba31b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Id3ef54967dde692a364dcf9a2815c56e53de3c8a Reviewed-on: https://chromium-review.googlesource.com/c/1371248Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615433}
-
Hiroki Nakagawa authored
Before this CL, SharedWorkerRepositoryClient is created in RenderFrameImpl::Initialize() and owned by WebLocalFrameImpl[*]. This needed unnecessary plumbing between blink/renderer and content/renderer. This CL removes the path, and instead makes Document own SharedWorkerRepositoryClient as Supplement<Document>. This changes the ownership model of SharedWorkerRepositoryClient from per-Frame to per-Document, but it shouldn't affect behavior. Also, this removes the mechanism to manage multiple Documents from SharedWorkerRepositoryClient (see ClientMap/Set in the class). As mentioned above, the client is a per-Frame (per-Document) object, and the mechanism doesn't make sense. [*] This was necessary for communicating with renderer's embedder but the path was removed by recent refactorings (Onion Soup). Bug: 911415 Change-Id: If9ae00b0fbdde99d8a0256dc7381fab5c72ff317 Reviewed-on: https://chromium-review.googlesource.com/c/1370224 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#615432}
-
rbpotter authored
Previously, the height of the custom margins error message was fixed at 2 lines of text. However, this resulted in the message being cut off for some languages/font sizes. Allowing a variable height error message broke the logic setting the custom radio button's position, so this CL updates the positioning logic so that the radio button stays centered on the cr-input regardless of the height of the error message. Bug: 911958 Change-Id: If9e1655e0d2bb87de46ac3c1749b5b07cd831bd7 Reviewed-on: https://chromium-review.googlesource.com/c/1369027Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#615431}
-
Matt Falkenhagen authored
The 'generated response' test used to fail. Fixed by r615063. Bug: 840881 Change-Id: Ia5773ee28ac4d9b2195f98f8dedd731fa166502e TBR: npm No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1370159Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/69540f44196e..8f66ddbae325 git log 69540f44196e..8f66ddbae325 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 steveanton@webrtc.org Move is_unified_plan flag to a member variable 2018-12-10 steveanton@webrtc.org [Unified Plan] Fix issues with recycling m= sections 2018-12-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a1b00bf1..aec72e9e (615131:615246) 2018-12-10 terelius@webrtc.org Remove support for having multiple SSRCs in an RtcEventVideoSendStreamConfig. 2018-12-10 benwright@webrtc.org New statistic added to VideoReceiveStream to determine latency to first decode. 2018-12-10 terelius@webrtc.org Fix header extension mapping bug in RTC event log analyzer. 2018-12-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d6dec397..a1b00bf1 (614285:615131) 2018-12-10 srte@webrtc.org Adds trial to fall back to probe rate if ack rate is missing. 2018-12-10 srte@webrtc.org Using more accurate receive time calculation in scenario tests. Created with: gclient setdep -r src/third_party/webrtc@8f66ddbae325 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:899680,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iadd4ec06946097473111d30398341877f8149812 Reviewed-on: https://chromium-review.googlesource.com/c/1370653Reviewed-by:
-
Sam McNally authored
With the old Drive integration, all files were accessed via externalfile: URLs. Those for hosted docs redirected to the actual URL for accessing that doc. With DriveFS, real file: URLs are used so no externalfile: URLs exist. The drag and drop code populates the File and, if available, the externalfile: URL in the DataTransfer. For hosted docs under DriveFS, this is insufficient as the files are not openable. However, the alternateUrl is the URL needed to access the hosted doc so substitute it for the externalfile: URL for hosted docs. Bug: 913725 Change-Id: Ib9456042e1e864b378b71db404e1ea406959b1fe Reviewed-on: https://chromium-review.googlesource.com/c/1370152Reviewed-by:
-
Cecilia Ni authored
This CL makes the app list show 4 apps by default with the rest in an expandable list. Bug: 1369498 Change-Id: I7e559d806dc85c64a6f01661e5ba2e0e89604c38 Reviewed-on: https://chromium-review.googlesource.com/c/1369498 Commit-Queue: Cecilia Ni <ceciliani@google.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#615427}
-
Richard Li authored
The typemapping between content::BackgroundFetchRegistration and blink.mojom.BackgroundFetchRegistration causes the dependence for //third_party/blink/public:blink_headers. The dependence is a block for moving background_fetch.mojom into blink/public/mojom/. In this CL, content::BackgroundFetchRegistration is removed. In the future, background_fetch_types.typemap will be removed, and then background_fetch.mojom is able to move to new place. Change-Id: I913f64dd4e2ed47deacdfeda1e77781fcda3373a Reviewed-on: https://chromium-review.googlesource.com/c/1365079 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Change util.getEntryLabel to special case Downloads folder to translate. Change DirectoryTree and FileList to use util.getEntryLabel for translating the entry labels and util.compareLabel for sorting the entries. Change FileList related types to carry volume manager to be able to pass LocationInfo to be able to use getEntryLabel for displaying and sorting entries on File List, as follows: - Add VolumeManager to FileListContext constructor, since this type is constructed only once. - Change DirectoryContents constructor to forward VolumeManager from FileListContext to FileListModel. - FileListModel uses VolumeManager to get LocationInfo to sort entries by labels. Add Closure markup for DirectoryContents attributes related to this change to add clarity for developers and stronger type in Closure. As part of this changed DirectoryContents.fileList_ to be always FileListModel instead of switching to a empty ArrayDataModel from |setFileList|. Test will come in follow up CL. :-) Bug: 873539 Change-Id: I46dd1879c14cbf046f5da5d96c29b34f13d404a1 Reviewed-on: https://chromium-review.googlesource.com/c/1370151 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#615425}
-
Sadrul Habib Chowdhury authored
Create a small content/renderer/compositor component to contain the code needed to manage the compositor (i.e. LayerTreeView and related code). This code should not have any dependencies on the rest of the code in content. Enforce this by way of explicit DEPS rules. This would make it easier to relocate the compositor out of content when desired (see earlier discussions in crbug.com/838693, crrev.com/c/1126490). Move up the rest of the code under content/renderer/gpu into content/renderer/. Bug: none Change-Id: I5b0c043c6577f1d6aa5f12f6243713c9e8c35d32 Reviewed-on: https://chromium-review.googlesource.com/c/1360430 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615424}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f98851124b4..ea2cff61234c Created with: gclient setdep -r src-internal@ea2cff61234c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic6e4b986b5510e43911e5dd53cc11d5517ccff5f Reviewed-on: https://chromium-review.googlesource.com/c/1370652Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615423}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I3a2c55aac4b8ed8000550c8093cc96139918deab Reviewed-on: https://chromium-review.googlesource.com/c/1371127Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#615422}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/09253406..f88410f8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I49f831d7e7f0cdbfa407f6b98655a4808aabbdc8 Reviewed-on: https://chromium-review.googlesource.com/c/1371198Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615421}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a10494c302e6..40bd76027f8e git log a10494c302e6..40bd76027f8e --date=short --no-merges --format='%ad %ae %s' 2018-12-11 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@40bd76027f8e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I4d5d48fcdeaa0385ad99f9f0f30aa61a2f17d139 Reviewed-on: https://chromium-review.googlesource.com/c/1371246Reviewed-by:
-
Kent Tamura authored
When Chrome opens a URL with a fragment id, it decodes %xx for UTF-8, and decodes it for isomorphic-decode [1] if it is invalid for UTF-8. Then tries to find an element with the decoding result as an ID. No other browsers do isomorphic-decode, and it's not defined by the standard. This CL removes this non-standard behavior. This CL doesn't apply Blink's intent process. This is a very small behavior change, and affects only 0.0016% of page views. * Implementation - Add a flag to disable isomorphic-decode to url::DecodeURLEscapeSequences(), and apply the new behavior only to blink::LocalFrameView::ProcessUrlFragment(). - Remove unnecessary UseCounters. chromestatus: https://www.chromestatus.com/feature/4885685374812160 [1] https://infra.spec.whatwg.org/#isomorphic-decode Change-Id: I17788e3697484701db66dbfef53bd1cae4598c51 Bug: 845824 Reviewed-on: https://chromium-review.googlesource.com/c/1333178Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#615419}
-
Casey Piper authored
Whenever a request is received by cryptotoken, and that request is then proxied to WebAuthn, log this instance to the background console. Change-Id: I180f6fbbd3b512dab9f4549742b52f97a36542f1 Reviewed-on: https://chromium-review.googlesource.com/c/1371084Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Casey Piper <piperc@chromium.org> Cr-Commit-Position: refs/heads/master@{#615418}
-
Hiroki Nakagawa authored
For cleanup, this CL moves SharedWorkerRepositoryClientImpl from core/exported/ to core/workers/, and merge it to SharedWorkerRepositoryClient. Change-Id: I694198b596ef572f064fa0638e82251e53decc0f Bug: 911415 Reviewed-on: https://chromium-review.googlesource.com/c/1369757Reviewed-by:
-
Joel Einbinder authored
Change-Id: I4821b09569a302f8a3039a864f2dddac445bfcf3 Reviewed-on: https://chromium-review.googlesource.com/c/1370887Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#615416}
-
Kent Tamura authored
Also, update symbols and comments around them. This CL has no behavior changes. Bug: 843412 Change-Id: Ic1c2381e5d431fdedf5978d510cc9018e101d70d Reviewed-on: https://chromium-review.googlesource.com/c/1370157Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#615415}
-
Yue Cen authored
Bug: 912321 Change-Id: Ibfddb6628b06fe5111f873cf7716a210d47deb36 Reviewed-on: https://chromium-review.googlesource.com/c/1370369Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#615414}
-
Alex Moshchuk authored
This is a followup to https://crrev.com/c/1365982, which introduced a new filter file for Site Isolation Android content_browsertests, but forgot to add it to BUILD.gn. Change-Id: I33d9626562886bd5b5b7eec051a40bc9169ed627 Reviewed-on: https://chromium-review.googlesource.com/c/1371197Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#615413}
-
Dan Beam authored
This reverts commit 14d25fb9. This is a roll-forward with a fix to the URL of an iconset to load (see the diff between patchsets 1 and 2). NOPRESUBMIT=true # existing issue in destination.js Bug: 855259, 912678 Change-Id: I3aeb26263de682ecb2f0596e336ec20ab5c19807 Reviewed-on: https://chromium-review.googlesource.com/c/1371079 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Erik Luo authored
Screenshot: https://imgur.com/a/33LFGai Bug: 894341 Change-Id: I90abb517bb08358fa932335648be15ca0e9cab2b Reviewed-on: https://chromium-review.googlesource.com/c/1367108Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#615411}
-
Pavel Feldman authored
Bug: 649657 Change-Id: I76bae556b1196336b9da03cf924e31d97a1e238f Reviewed-on: https://chromium-review.googlesource.com/c/1371210 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
-
Sungguk Lim authored
When new value is updated by StorageArea.set(), chrome.storage.onChanged callback and newly added StorageArea.onChanged callback would be called at the same time. Bug: 863277 Change-Id: I9076fdf1c55f5c2d5e913e3c671aab6630cee304 Reviewed-on: https://chromium-review.googlesource.com/c/1329802Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Sungguk Lim <limasdf@gmail.com> Cr-Commit-Position: refs/heads/master@{#615409}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/762a25693faf..fed2cb39c320 git log 762a25693faf..fed2cb39c320 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 brucedawson@chromium.org Fix ucrt source path when packaging the Windows toolchain Created with: gclient setdep -r src/third_party/depot_tools@fed2cb39c320 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I89fe17d53ed093db892056b008df969759be0f85 Reviewed-on: https://chromium-review.googlesource.com/c/1370651Reviewed-by:
-
Xianzhu Wang authored
When an object has multiple fragments, the original method in BoxPainter::BackgroundIsKnownToBeOpaque() didn't work because the object's VisualRect is the bounding box of all fragments' visual rects, which is likely to cover areas that are not covered by painted background. Now Let BoxPainter::BackgroundIsKnownToBeOpaque() return false if there are multiple fragments. BTW, rebaseline multicol tests containing composited contents. The old baselines expect single fragment for the composited contents which is a SPv1 quirk. CompositeAfterPaint can correctly fragment composited contents. Change-Id: Icdabe2a0eabdf2e1541481f5c09b796c33a9370a Reviewed-on: https://chromium-review.googlesource.com/c/1370276Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6d522d4fe25f..768c73895b2f git log 6d522d4fe25f..768c73895b2f --date=short --no-merges --format='%ad %ae %s' 2018-12-11 zhuohao@chromium.org rammus: add mapping for factory-rammus-11289.B 2018-12-11 lamontjones@chromium.org cros_build_lib: Return a list from GetImageDiskPartitionInfo Created with: gclient setdep -r src/third_party/chromite@768c73895b2f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5be6b9a157429c7b29b50992592c793a7b94b50f Reviewed-on: https://chromium-review.googlesource.com/c/1371194Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/15640698497a..a10494c302e6 git log 15640698497a..a10494c302e6 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 caryclark@skia.org remove legacy switch Created with: gclient setdep -r src/third_party/skia@a10494c302e6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:843966 TBR=ethannicholas@chromium.org Change-Id: I317bbc0e19278427b380be8160c6e46d1f9c302c Reviewed-on: https://chromium-review.googlesource.com/c/1370650Reviewed-by:
-
