- 05 Dec, 2016 31 commits
-
-
rune authored
- Need to re-collect active stylesheets when inserting already cached import documents. - Missing markDocumentDirty() when inserting import documents. - Added test for missing coverage of the need for marking for re- collection from HTMLImportChild::ownerInserted(). The fact that we need to recollect sheets in the document scope and recalculate style for the whole document is not a perf regression, this is how it used to be before considering the async stylesheet update with ruleset invalidations, but ideally we would like to do better. It's unlikely a common use case as html imports are typically loaded in head as script and rendering blocking. R=meade@chromium.org BUG=567021 Review-Url: https://codereview.chromium.org/2551473002 Cr-Commit-Position: refs/heads/master@{#436238}
-
minggang.wang authored
ignored. So we need to remove this in order to take the required scale factor into account. BUG=668023 Review-Url: https://codereview.chromium.org/2535463002 Cr-Commit-Position: refs/heads/master@{#436237}
-
yamaguchi authored
BUG=669745 TEST=manual test as noted in the bug. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2538413002 Cr-Commit-Position: refs/heads/master@{#436236}
-
alancutter authored
This change enables CSS and Web animations to apply animated effects on CSS custom properties. This change involves a restructure of style resolving detailed in the design doc: https://docs.google.com/a/chromium.org/document/d/1V27q30H-pQZVbzHCJjdFThBSeuvxkGLdGmb1hLWBAiY This is a reland of https://codereview.chromium.org/2309963002 with fixes for when the baseComputedStyle optimisation is active. The revert was due to crbug.com/669790 where behaviour differs depending on whether asserts are enabled, thus none of the try bots picked up on the bug. BUG=644148 Review-Url: https://codereview.chromium.org/2532953008 Cr-Commit-Position: refs/heads/master@{#436235}
-
djd authored
This contains luci/luci-go@47c9792. R=tansell@chromium.org BUG=666047 Review-Url: https://codereview.chromium.org/2553493002 Cr-Commit-Position: refs/heads/master@{#436234}
-
sashab authored
Changed Order to an enum class and gave it an unsigned underlying type. Also renamed it from Order to EOrder to match the other ComputedStyle enums, and renamed its members to match its keywords from CSSValueKeywords.in. Also removed the '= 0' value setter for Logical and the one callsite where this was used (implicit int conversion is not allowed for enum classes anyway). Changing it to an enum class enforces better namespacing and code practices. Adding the unsigned underlying type is pre-work for when the class is eventually stored as an enum bitfield (it would be done in this patch, except a presubmit warning already exists that prevents that. The presubmit warning needs to be updated before that change can occur.) This is also pre-work to move EOrder to be generated in ComputedStyleBase. BUG=628043 Review-Url: https://codereview.chromium.org/2546333002 Cr-Commit-Position: refs/heads/master@{#436233}
-
napper authored
Changed EPointerEvents to an enum class and gave it an unsigned underlying type. Changing it to an enum class enforces better namespacing and code practices. Adding the unsigned underlying type is pre-work for when the class is eventually stored as an enum bitfield (it would be done in this patch, except a presubmit warning already exists that prevents that. The presubmit warning needs to be updated before that change can occur.) This is also pre-work to move EPointerEvents to be generated in ComputedStyleBase. BUG=628043 Review-Url: https://codereview.chromium.org/2542843002 Cr-Commit-Position: refs/heads/master@{#436232}
-
hashimoto authored
Chrome OS needs to use values like neon-vfpv4 or crypto-neon-fp-armv8. BUG=670541 Review-Url: https://codereview.chromium.org/2546033002 Cr-Commit-Position: refs/heads/master@{#436231}
-
satorux authored
Previously, the user image was always saved in JPEG format at /home/chronos/<email-address>.jpg even if the user chose a PNG file with transparent/translucent pixels. Since JPEG format does not support transparent/translucent pixels, these pixels were replaced with black ones. This patch solves the problem by storing the user image in PNG format at /home/chronos/<email-address>.png, when transparent/translucent pixels are present. BUG=587289 TEST=transparent pixels are honored in the login and lock screens, as well as the settings page Review-Url: https://codereview.chromium.org/2537713002 Cr-Commit-Position: refs/heads/master@{#436230}
-
chrome-cron authored
Cr-Commit-Position: refs/heads/master@{#436229} -
thakis authored
Ran `tools/clang/scripts/upload_revision.py 288545`. This brings in a regression for linux lld (bug 670397), but nobody uses that yet. In return, it speeds up CFI blacklist processing, makes it possible to turn on blink PCH use on Windows (would crash previously), and makes win/asan work in component builds again. BUG=670392 TBR=hans Review-Url: https://codereview.chromium.org/2551603004 Cr-Commit-Position: refs/heads/master@{#436228}
-
keishi authored
BUG=544756 Review-Url: https://codereview.chromium.org/2547853002 Cr-Commit-Position: refs/heads/master@{#436227}
-
yosin authored
This patch converts "format-block-converts-false.html" to utilize w3c test harness with |assert_selection()| to simplify test case for improving code health. This patch is as preparation of http://crrev.com/2532373002 BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2550633002 Cr-Commit-Position: refs/heads/master@{#436226}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/77dd2d44c88d5 BUG=667128 TBR=robhogan@gmail.com Review URL: https://codereview.chromium.org/2551753003 . Cr-Commit-Position: refs/heads/master@{#436225}
-
xiaochengh authored
This patch converts the layout test with assert_selection to improve code health and also increase the usage of w3c testharness. Note: Chrome's current behavior is incorrect. It will be fixed by https://codereview.chromium.org/2541163003 BUG=n/a Review-Url: https://codereview.chromium.org/2534423003 Cr-Commit-Position: refs/heads/master@{#436224}
-
xiaochengh authored
This patch converts the layout test with assert_selection to improve code health and also increase the usage of w3c testharness. It also moves the test file to editing/selection/modify_extend for better organization. Note: Chrome's current behavior is incorrect. It will be fixed by https://codereview.chromium.org/2541163003 BUG=n/a Review-Url: https://codereview.chromium.org/2535173009 Cr-Commit-Position: refs/heads/master@{#436223}
-
yurak authored
Planning on adding a new interface for form association code called FormAssociated.h so I'm renaming this to avoid confusion. Review-Url: https://codereview.chromium.org/2546063002 Cr-Commit-Position: refs/heads/master@{#436222}
-
aleksandar.stojiljkovic authored
If using canvas.getImageData or GL textures of UNSIGNED_BYTE type, 16-bit depth stream data is available only through 8-bit* API, so there is a precision loss. Here, we add no-precision-loss** JavaScript access through WebGL float texture. RGBA32F usage here enables lossless access to 16-bit depth information via WebGL1. In related work, the same code path is used to upload 16-bit data to other WebGL2 supported formats; e.g. with GL_R16UI there is no conversion needed in SkCanvasVideoRenderer::TexImageImpl. * 8-bit access refers to JS ImageData and WebGL UNSIGNED_BYTE where 16-bit depth data is now available as luminance (all 3 color channels contains upper 8 bits of 16bit value). ** Float is used for no-precision-loss access to 16-bit data normalized to [0-1.0] range using formula value_float = value_16bit/65535.0. This patch also adds UNSIGNED_BYTE WebGL test which was earlier tested through testVideoToImageBitmap since UNSIGNED_BYTE and canvas rendering still share the same path through SkCanvasVideoRenderer::Paint. BUG=369849, 624436 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2476693002 Cr-Commit-Position: refs/heads/master@{#436221}
-
dpranke authored
Most if not all of this information is out of date, as incremental linking is now handled more-or-less automatically by the build and you probably shouldn't mess with the settings. R=brucedawson@chromium.org BUG=670518 Review-Url: https://codereview.chromium.org/2549443004 Cr-Commit-Position: refs/heads/master@{#436220}
-
qyearsley authored
Reason: There is no owner for this directory currently. NOEXPORT=true Review-Url: https://codereview.chromium.org/2553473002 Cr-Commit-Position: refs/heads/master@{#436219}
-
changwan authored
As a follow-up to https://codereview.chromium.org/2543893002/, we make the code easy to read and remove unnecessary findbug suppression. BUG=668692 Review-Url: https://codereview.chromium.org/2544163003 Cr-Commit-Position: refs/heads/master@{#436218}
-
brucedawson authored
build_config.h *looks* like a list of all of the OS_* macros, but it is missing OS_CHROMEOS. This can lead to confusion. Documenting OS_CHROMEOS here makes build_config.h the source of truth that developers already assume that it is. Review-Url: https://codereview.chromium.org/2130543002 Cr-Commit-Position: refs/heads/master@{#436217}
-
robhogan authored
Account for leading space when selecting our offset for the visible text. BUG=667128 Review-Url: https://codereview.chromium.org/2529243002 Cr-Commit-Position: refs/heads/master@{#436216}
-
kotenkov authored
BUG=669983 Review-Url: https://codereview.chromium.org/2537773008 Cr-Commit-Position: refs/heads/master@{#436215}
-
kbr authored
BUG=662644 TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2549003002 Cr-Commit-Position: refs/heads/master@{#436214}
-
skeksk91 authored
BUG=644626 Review-Url: https://codereview.chromium.org/2547333002 Cr-Commit-Position: refs/heads/master@{#436213}
-
bashi authored
This is a follow-up CL of crrev.com/2536533002. BUG=670814 Review-Url: https://codereview.chromium.org/2552603002 Cr-Commit-Position: refs/heads/master@{#436212}
-
mgiuca authored
BUG=542537 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2532483003 Cr-Commit-Position: refs/heads/master@{#436211}
-
alexis.lagoutte authored
Hanshake => Handshake occured => occurred BUG= Review-Url: https://codereview.chromium.org/2475933002 Cr-Commit-Position: refs/heads/master@{#436210}
-
ortuno authored
When acceptAllDevices is true the chooser will show all devices in range. BUG=654918 Review-Url: https://codereview.chromium.org/2510323002 Cr-Commit-Position: refs/heads/master@{#436209}
-
alancutter authored
This patch refactors generate_perf_json.py to avoid using cwd logic. File paths are now relative to src which is derived relative to the script location. BUG=667435 Review-Url: https://codereview.chromium.org/2542073003 Cr-Commit-Position: refs/heads/master@{#436208}
-
- 04 Dec, 2016 9 commits
-
-
kbr authored
It's failing on most try jobs, causing retries and slowing down the CQ. BUG=671048 TBR=dpranke@chromium.org, zakerinasab@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2551753002 Cr-Commit-Position: refs/heads/master@{#436207}
-
kbr authored
BUG=662644 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org Review-Url: https://codereview.chromium.org/2550983002 Cr-Commit-Position: refs/heads/master@{#436206}
-
lshang authored
According to the mocks(go/fns-ui-spec), there should be a seperator between http warning message and other autofill entries. BUG=662298, 662297 Review-Url: https://codereview.chromium.org/2542593003 Cr-Commit-Position: refs/heads/master@{#436205}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/d87fbee77524..8b4b56ac2927 $ git log d87fbee77..8b4b56ac2 --date=short --no-merges --format='%ad %ae %s' 2016-12-04 msarett Fix max/min error Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=herb@google.com Review-Url: https://codereview.chromium.org/2553483002 Cr-Commit-Position: refs/heads/master@{#436204}
-
xiaoyin.l authored
In the "Get the code" section, shouldn't it be "fetch chromium"? As it is unlikely that people who build Chromium on Windows want to target iOS. Also this is my first patch submission, so I think I also need to add my name to the AUTHORS file. BUG= Review-Url: https://codereview.chromium.org/2545313002 Cr-Commit-Position: refs/heads/master@{#436203}
-
robhogan authored
BUG=670325 Review-Url: https://codereview.chromium.org/2547933003 Cr-Commit-Position: refs/heads/master@{#436202}
-
yzshen authored
- InterfacePtrInfo - InterfaceRequest - InterfacePtr - Binding BUG=579646 Review-Url: https://codereview.chromium.org/2549683002 Cr-Commit-Position: refs/heads/master@{#436201}
-
bnc authored
- Use wire values in SpdySettingsIds, - remove SPDY/3.1-only setting values from SpdySettingsIds, - rename ParseSettingId() to ParseSettingsId(), - merge IsValidSettingId() into ParseSettingsId(), - remove SerializeSettingId(), - factor out SettingsIdToString(); remove default case to make sure every enum value is handled. These values are not persisted to disk (that was a SPDY/3.1 feature), so the only downside to the value change is Chrome net-log incompatibility. This lands server side change 140592266 by bnc. BUG=622737, 488484 Review-Url: https://codereview.chromium.org/2544343003 Cr-Commit-Position: refs/heads/master@{#436200}
-
mcasas authored
Because they are missing as [1] mentions. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=665150#c10 BUG=665150 Review-Url: https://codereview.chromium.org/2546293002 Cr-Commit-Position: refs/heads/master@{#436199}
-