- 22 Mar, 2018 40 commits
-
-
Matthew Jones authored
This patch adds the concept of priority to content that can be shown in the bottom sheet. Currently only two priorities are supported: HIGH and LOW. BUG=821568 Change-Id: Id2473a48618b5095ab9b1cca20831c7547c4d36d Reviewed-on: https://chromium-review.googlesource.com/969063 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#545193}
-
Kurt Horimoto authored
This CL adds the ability to specify constraints for a NamedGuide using frames and autoresizing masks. This will be used to support laying out the NamedGuide corresponding with the voice search button when voice search is being triggered by the keyboard accessory view, as this view is in a separate window from the rest of the application's hierarchy. Bug: 805123 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icf6207f38629de2f5eac381b4f489f7213ecacd1 Reviewed-on: https://chromium-review.googlesource.com/952779Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#545192}
-
Chandan Padhi authored
Media devices mojo bindings are not generated for targets that depend on blink_headers causing compilation failures. This CL adds missing dependency for blink_headers. blink_headers --> generate_mojo_bindings --> media_devices_mojo_bindings Bug: 764680 Change-Id: Idaa73dc237b93d16b3d11038e5a7ebdbb101bfdd Reviewed-on: https://chromium-review.googlesource.com/954805 Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#545191}
-
Matt Wolenetz authored
Mark as flaky. TBR=dgozman@chromium.org BUG=824904,823003 NO-TRY=true Change-Id: Ic7f72855a70e3bece90537808595140ffe7334ea Reviewed-on: https://chromium-review.googlesource.com/976380Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545190}
-
Jiaquan He authored
When update an AppListItem from a SyncItem, the AppListItem's position we have can be invalid. In this case we should force it to use the SyncItem's position if it's valid. Credit the patch to nya@chromium.org. Bug: 733662 Bug: 824630 Change-Id: Ie2d60fe21eed647bb26c5c7e3cb1bfc3684446d2 Reviewed-on: https://chromium-review.googlesource.com/976096 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#545189}
-
Lei Tian authored
Browser Actons crashes on preLMR1 devices when showing the share dialog. This is because on preLMR1, share dialog is a Android dialog. When dialog is shown, its attached activity is destroy. To fix it, BrowserActionActivity would not be closed if share option is selected on preLMR1 devices. The activity would be closed when an item is selected form the dialog. Bug: 821631 Change-Id: Ie40120e9aab2b7b45cc84dc532888c02611e5ec6 Reviewed-on: https://chromium-review.googlesource.com/969715 Commit-Queue: Lei Tian <ltian@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#545188}
-
Tommy C. Li authored
- Hooks Omnibox up to the top-chrome-md=material-refresh flag. - Also adds the MATERIAL_REFRESH item in material_design_controller to correspond to the new command line flag. - Also adds some values to the layout constants using the Touchable UI as a basis for the Material Refresh constants. Bug: 823535 Change-Id: I2f8e88bf3f65ebdc89eaa056200a12e176571110 Reviewed-on: https://chromium-review.googlesource.com/969962Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#545187}
-
Moe Ahmadi authored
This reverts commit 99341850. Reason for revert: Causing compilation failure https://ci.chromium.org/buildbot/chromium/Mac/39586 Original change's description: > Remove redundant code from RWHVCocoa, move some code to RWHVNSViewBridge > > Remove suppressNextEscapeKeyUp_ because its functionality is made > redundant by keyDownCodes_. The escape-key-specific version was > introduced in crrev.com/165615 while the generic version was introduced > in crrev.com/304728. > > While in the -[NSView keyEvent:] method, replace repeated method calls > with local variables in preparation for moving most of the funciton > across an IPC boundary, and fold shouldAutohideCursorForEvent into > the function (since it's called nowhere else). > > Move SetBackgroundColor and Show/Hide/IsHidden functionality into > the RWHVNSViewBridge. > > Bug: 821651 > Change-Id: I31382a46b330fedbd3c4a6593ffafdb4a0b83be1 > Reviewed-on: https://chromium-review.googlesource.com/974887 > Commit-Queue: ccameron <ccameron@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545160} TBR=tapted@chromium.org,ccameron@chromium.org Change-Id: Idff422824e86d1413026526c61334ac6ead4c3c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821651 Reviewed-on: https://chromium-review.googlesource.com/976441Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545186}
-
Elly Fong-Jones authored
It compares the Views accelerator table to the keyboard shortcut table, which only makes sense to do in Views browsers. TBR=pkasting@chromium.org Bug: 810479 Change-Id: I4bde07a0cc9a80894772e9e6aa0b275e30d04671 Reviewed-on: https://chromium-review.googlesource.com/976372Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#545185}
-
Tommy C. Li authored
Bug: 781703 Change-Id: Ic1ef30cb77140a54f847f8fc619c95dd0b4515d0 Reviewed-on: https://chromium-review.googlesource.com/973759 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Jochen Eisinger authored
This reverts commit 23d03126. Reason for revert: Heuristic is too simplistic Original change's description: > Ignore the target attribute if the download attribute is present > > BUG=823050 > R=mkwst@chromium.org > > Change-Id: I50a6d1efb605c8eff538a0f157203812d0ba5f1b > Reviewed-on: https://chromium-review.googlesource.com/970701 > Reviewed-by: Mike West <mkwst@chromium.org> > Commit-Queue: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544449} TBR=jochen@chromium.org,mkwst@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 823050 Change-Id: Ib36b4a191b0501de80341be991e55f20c4bd9fb1 Reviewed-on: https://chromium-review.googlesource.com/975553Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545183}
-
Theresa authored
Adds a ToolbarCoordinator, ToolbarView, and ToolbarModelChangeProcessor to display and manage the contextual suggestions toolbar. Also introduces a PropertyObservable base class in the modelutil package. BUG=822943 Change-Id: I252e1c48afc8f053a5271cefa9f4a7142d816e32 Reviewed-on: https://chromium-review.googlesource.com/974289 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#545182}
-
Patrick Monette authored
Bug: 808542 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idc4a489a8854dd0af7b282f7f89304c6dd17456d Reviewed-on: https://chromium-review.googlesource.com/973549Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#545181}
-
Paul Jensen authored
This constructor is deprecated but apparently called by many Cronet embedders. Proguard should remove this in production code. R=mef@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I1e5d76a8c60980f06896c4e7531ba6a702f5942f Reviewed-on: https://chromium-review.googlesource.com/976261Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545180}
-
Marc Treib authored
plus a few other small cleanups/modernizations. Bug: none Change-Id: I518e95e9008bd5dae3989fb99feb5e676eadc020 Reviewed-on: https://chromium-review.googlesource.com/975608Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#545179}
-
Michael Thiessen authored
This CL adds support for the S8/S9 running O, which no longer change resolution when entering VR. However, the user can still change resolution manually and Chrome could end up in the wrong resolution when launched from Daydream, so we handle this case by just killing the process and returning to Daydream, so that when Chrome is re-launched it's launched into the correct density. It turned out to be way too difficult to properly support Activity recreation while avoiding showing 2D UI to users. Bug: 817987, 822292 Change-Id: Ia8fa7bca41831810c2fa9f17088ba3049c6253f3 Reviewed-on: https://chromium-review.googlesource.com/971942Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#545178}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: Idcb3266ee3077817254290fb827fadb2a9d820a7 Reviewed-on: https://chromium-review.googlesource.com/975322Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545177}
-
Matt Wolenetz authored
Mark as flaky on Win and Linux TBR=dom-dev@chromium.org,qyearsley@chromium.org BUG=824848,823003 NO-TRY=True Change-Id: I99541729761173fae58d781462464b2a4cd6fd7f Reviewed-on: https://chromium-review.googlesource.com/976369Reviewed-by:
-
Harald Alvestrand authored
This adds internal slots "LastOffer" and "LastAnswer", and uses those to check that SetLocalDescription uses an unchanged SDP offer/answer. Because modification of SDP is suspected to be used in a number of places, this change only rejects SDP with modified fingerprints (which would fail anyway), but merely counts the usage for other modifications. Bug: chromium:823036 Change-Id: I0c978d5ff3e63b0afab3ec02334c57a5aaa94cdd Reviewed-on: https://chromium-review.googlesource.com/966441 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545175}
-
Bailey Forrest authored
- This process is broken into stages to make review easier - Stage 1 does nothing but move files. - Stage 1 does not build without depending on internal code. BUG=internal b/76121501 TEST=Build and run. cast_bluetooth_unittests. Change-Id: I7b1d48c3cac61934970e86b45cc804918ac97f63 Reviewed-on: https://chromium-review.googlesource.com/976221Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#545174}
-
rbpotter authored
Update PrintJob::pdf_page_mapping_ so that PDF pages not in the user's selection are ignored instead of causing the print job to be cancelled. Also remove some comments that are significantly outdated, and caused confusion while investigating the bug. Bug: 823876 Change-Id: Id6c1c3acb67c4d460cffa937f7a9b87eda402a88 Reviewed-on: https://chromium-review.googlesource.com/974042Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#545173}
-
Peter Boström authored
Uses this + STYLE_SECONDARY for the SettingsResetPromptDialog to match the desired secondary style. Without STYLE_EMPHASIZED_SECONDARY the emphasized text would be bold black which sticks out way too much against the secondary gray. Bug: chromium:698785 Change-Id: I3f9d1d3423ff3e990cc67f131f33ff0c7ddf55ff Reviewed-on: https://chromium-review.googlesource.com/974065Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#545172}
-
Yuanyao Zhong authored
[Chromecast] Touch enable/disable handling in cast_content_window_aura for newly added function EnableTouchInput. 2. Tested CreateWindowForWebContents with touch and enable, and changed to disable. Enable->Disable, Enable->Enable, Disable->Enable, Disable->Disable all four cases. Bug: b/73285025 Test: 1. Build, flash s905x and touch around Change-Id: I3ca7148326fe6670a5ad2b68d20826fdb9c543a1 Reviewed-on: https://chromium-review.googlesource.com/971623 Commit-Queue: Yuanyao Zhong <yyzhong@chromium.org> Reviewed-by:Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#545171}
-
mark a. foltz authored
Media Router has launched in-browser discovery of DIAL devices in M63, and removed usage of chrome.dial from the Media Router component extension. This removes the API from Chrome as there are no more users. Bug: 769348 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9bde034fb42ffb05aef1a8d3666775d83cbd1337 Reviewed-on: https://chromium-review.googlesource.com/964800 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Adam Parker <amp@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#545170}
-
Ivan Sandrk authored
This is a private API that can only be used by whitelisted extensions hence taking it off the public documentation. Change-Id: Ieb0b31ae371ded18e39e285d445857a0c0d891ae Reviewed-on: https://chromium-review.googlesource.com/975962 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545169}
-
Emircan Uysaler authored
- Posts GpuMemoryBufferVideoFramePool::Abort() calls on the correct thread. - Avoids unnecessary Abort calls when there isn't an active task. - Renames FrameReady() to EnqueueFrame(). Bug: 653200 Change-Id: Iaa98be89f34cf4d76855c51b6121b877bf44a6c5 Reviewed-on: https://chromium-review.googlesource.com/974308Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#545168}
-
Charlie Harrison authored
This patch adds the ability for main frame throttles to receive potentially multiple calls to notify of page-level activation. In these cases, there is some logic at the end of the navigation to "normalize" the computed ActivationState to apply to the most recent page-level ActivationState given. This patch should have no observable effects to subresource_filter logic, with or without ad frame. Bug: 809504 Change-Id: Icb85e36c737fd092db4b7a134aabd03a1382b875 Reviewed-on: https://chromium-review.googlesource.com/961534Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#545167}
-
Danyao Wang authored
Navigation entries restored from a previously saved session are inserted as restore_session.html?targetUrl=<target> URLs. The onload handler redirects the page to the target URL when loaded. It turns out that WKWebView does not fire onload handler in back/forward navigation from an about:blank URL redirected from restore_session.html to another restore_session.html. Most likely it's because WkWebView consiters this a same-page navigation. This causes forward navigationt from a restored app-specific URL to not load the web content. This CL fixes it by forcing a reload in the WKWebView in this case. Bug: 814790 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie6e7ada39388cedd7357a582308f0edc1397ef63 Reviewed-on: https://chromium-review.googlesource.com/974365Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#545166}
-
Alexander Timin authored
Use thread type passed to the scheduler from WebThreadCreationParams instead of having to call SetThreadType manually. R=kinuko@chromium.org Change-Id: I28ea429917191d3f561774be7d2b54ac29322517 Reviewed-on: https://chromium-review.googlesource.com/973366Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545165}
-
Joy Ming authored
WebVrTransitionTest#testWindowRafStopsFiringWhilePresenting Bug: 824835 Change-Id: Id2079235b1329f3c3b9ba00960450ff9959eac5b Reviewed-on: https://chromium-review.googlesource.com/975988Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#545164}
-
Yash Malik authored
Bug: 815215 Change-Id: I98a3665e0663ced8c00ea3a03fa1dbb8ac3d164d Reviewed-on: https://chromium-review.googlesource.com/956692 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#545163}
-
Tommy Steimel authored
This CL modifies the modern media controls on videos with preload=none to show disabled fullscreen and mute buttons instead of hiding them completely. Bug: 823401 Change-Id: I853ec4bd216e5c63018750d03b81ea96e74e3fc6 Reviewed-on: https://chromium-review.googlesource.com/969952 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#545162}
-
Eugene But authored
This crash does not have steps to reproduce and can occur if Download Task in coordinator is null or invalid. This change gracefully handles the case when task became null after coordinator was stopped. Setting view controller delegate to nil will prevent callbacks from view controller which is being dismissed. Bug: 824758 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I44099adf5604dba25e937670312f7fff5af2f56d Reviewed-on: https://chromium-review.googlesource.com/975666Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#545161}
-
Christopher Cameron authored
Remove suppressNextEscapeKeyUp_ because its functionality is made redundant by keyDownCodes_. The escape-key-specific version was introduced in crrev.com/165615 while the generic version was introduced in crrev.com/304728. While in the -[NSView keyEvent:] method, replace repeated method calls with local variables in preparation for moving most of the funciton across an IPC boundary, and fold shouldAutohideCursorForEvent into the function (since it's called nowhere else). Move SetBackgroundColor and Show/Hide/IsHidden functionality into the RWHVNSViewBridge. Bug: 821651 Change-Id: I31382a46b330fedbd3c4a6593ffafdb4a0b83be1 Reviewed-on: https://chromium-review.googlesource.com/974887 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
SaveLayerAlphaOp is smaller than SaveLayerOp because the former stores the alpha value instead of the whole PaintFlags structure. It also corresponds to a fast path in Skia. This also makes the behavior of opacity layer more similar to that of SPv1. Perf result: slight reduction of op_memory_usage (-0.3%) and raterize_time (-0.75%). https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180321190807/html/index.html Bug: 824415 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7f85aa84f7435686270aac59e782b09bb6a0b7cf Reviewed-on: https://chromium-review.googlesource.com/973808 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#545159}
-
Patrick Monette authored
This is a reland of fdf8f25c Original change's description: > [3p-Conflicts] Fix whitelisting of modules with matching cert's subject > > A previous CL was meant to whitelist modules whose cert's subject > matches the cert's subject of the executable, but the code was added in > the wrong file. > > Move the check from ModuleListFilter where it doesn't belong and move it > to the ProblematicProgramsUpdater class. > > Also added a unit test to make sure the issue is really fixed. > > Bug: 819793 > Change-Id: Ibd6a3c599d6b5ec2bf0a50c5ae0536159bb30fc6 > Reviewed-on: https://chromium-review.googlesource.com/969601 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545128} Tbr: grt@chromium.org Bug: 819793 Change-Id: I67ba5cc75c7d7a0822c79d8e84dfec6cd69b919b Reviewed-on: https://chromium-review.googlesource.com/976181Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#545158}
-
Felix Ekblom authored
Change-Id: I48de0f566cb3434ab22b8b450b8120dd8ff7346c Reviewed-on: https://chromium-review.googlesource.com/974265 Commit-Queue: Felix Ekblom <felixe@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#545157}
-
Fyodor Gayokho authored
By spec, if a member (OptionalStorage) has potentially-throwing move constructor (when T is not trivially move constructible), the implicit move constructor is also potentially-throwing (OptionalBase and Optional). However, if T is nothrow move constructible, noexcept is explicitly specified to the Optional's move constructor. This hits the following statement in the spec (11.4.2 [dcl.fct.def.default]) If a function that is explicitly defaulted has an explicit exception-specification that is not compatible (18.4 [except.spec]) with the exception-specification on the implicit declaration, then - if the function is explicitly defaulted on its first declaration, it is defined as deleted; So, move constructor would be deleted. Note that, practically, with -fno-exceptions as we build Chrome, clang outputs is_nothrow_move_constructible<Optional<T>>::value will be false, although move ctor itself looks generated. This is the fix for that case. Also note that, without -fno-exceptions, clang would report "error: exception specification of explicitly defaulted move constructor does not match the calculated one". This is a clang bug (https://bugs.llvm.org/show_bug.cgi?id=22325). Change-Id: I7c5775084e2c75157b337c97b04a84e9d2879e11 Reviewed-on: https://chromium-review.googlesource.com/964961Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#545156}
-
Allen Vicencio authored
This CL adds a bool success field to FindHostCallback to indicate if the HostLocator was successful in querying for hosts. Bug: chromium:757625 Change-Id: Ie1a2c4ee0c8392157234cc1f1eefdb0d3bc4d88f Reviewed-on: https://chromium-review.googlesource.com/963757 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#545155}
-
Michael Lippautz authored
The DCHECKs were use to verify that promptly freed objects are not present in callback lists. This is only a problem with non-atomic marking. This can be ensured in another way: - Assuming promptly freeing immediately writes a FreeListEntry - Assuming callback list presence implies the header is marked - Exception: Weak tables Then, - We should never promptly free a marked object (check already in place) - Exception: We should also not promptly free weak tables (check already in place) - We should never mark a FreeListEntry Bug: chromium:757440 Change-Id: Ie80dc3197679e3e5f4482a8f7e3dae22b4ea97b4 Reviewed-on: https://chromium-review.googlesource.com/975601Reviewed-by:
-
